[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #36 from Michal Ambroz --- https://github.com/radare/radare2/issues/10300 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/AY3UCPL756XQUZHS6YWEGCAUYQ3BNMN6/
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #35 from Michal Ambroz --- Both capstone and librz have been fixed on the way to current git snapshot. But linking of radare2 is failing right now ... seems that the third option "--with-sysmagic" to use the system installed magic library is causing some issues as well. gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/include -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/include -MD -fPIC -g -Wall -D__UNIX__=1 -pie -I/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//libr/include radare2.o -L.. -o radare2 -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z,relro -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -ldl -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/core -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/parse -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/search -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/cons -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/config -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/bin -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/debug -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/anal -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/reg -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/bp -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/io -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/fs -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/lang -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/asm -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/syscall -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/hash -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/magic -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/socket -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/flag -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/egg -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/crypto -L/home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/util -lr_core -lr_parse -lr_search -lr_cons -lr_config -lr_bin -lr_debug -lr_anal -lr_reg -lr_bp -lr_io -lr_fs -lr_lang -lr_asm -lr_syscall -lr_hash -lr_magic -lr_socket -lr_flag -lr_egg -lr_crypto -lr_util -fPIC -lz -lzip -lz -lzip /home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//shlr/gdb/lib/libgdbr.a /home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//shlr/java/libr_java.a /home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//shlr/bochs/lib/libbochs.a /home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//shlr/qnx/lib/libqnxr.a /home/mambroz/rpmbuild/BUILD/radare2-555e88a1a4017a91ffb8bc0c4f68f998c8905291/libr/..//shlr/ar/libr_ar.a -lpthread -lutil -lutil radare2.o:(.data+0xe8): undefined reference to `r_magic_version' collect2: error: ld returned 1 exit status Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/22JVVS6WX4NSEGXCB4L6M6INXM62CPA6/
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #34 from Michal Ambroz --- Hello Anton, I have just tried to re-package version 2.6.0 and actually there are some 2 new issues. Compilations ends with: make[2]: Entering directory '/home/mambroz/rpmbuild/BUILD/radare2-2.6.0/libr' gcc -fvisibility=hidden -shared -dynamiclib -o libr.so \ .libr/*.o \ ../shlr/gdb/lib/libgdbr.a ../shlr/java/libr_java.a \ ../shlr/zip/librz.a \ ../shlr/libr_shlr.a ../shlr/ar/libr_ar.a ../shlr/grub/libgrubfs.a ../shlr/windbg/libr_windbg.a ../shlr/qnx/lib/libqnxr.a ../shlr/bochs/lib/libbochs.a\ ../shlr/capstone/libcapstone.a gcc: error: ../shlr/zip/librz.a: No such file or directory gcc: error: ../shlr/capstone/libcapstone.a: No such file or directory 1) Seems that the build script partially ignore the "--with-syscapstone" and during the build of libr are trying to link some locally compiled libcapstone. 2) ../shlr/zip/librz.a is missing as well ... quite possibly some partial ignoring of the option --with-syszip I will raise issues for that on github. Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PQ74TRAI7QUCEZAJY6QKXMXDQLATFBGC/
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855 Michal Ambroz changed: What|Removed |Added Flags|needinfo? | --- Comment #33 from Michal Ambroz --- Hello Anton, thanks for the offer. The situation seems indeed bit more difficult for me as packager to solve alone. Most of the patchable changes I was already able to push upstream to you guys. What remains are probably things which work well for you and are not politically correct for Fedora. You as Radare authors want it to make it as simple as possible for the users to download and compile from github ... which means some things are already bundled in to make it easy. I do not blame you for that. The paradigm of Fedora is to have everything as modular as possible - so if there is library for regular expressions, it should be in the system only once as a library package and all other application should be only dynamically linking to it. As long as the API is the same, it should be possible to independently patch and update single library. Here are notes from the spec file on what has been already removed: Removed from the final package because of the presence of minified JS and absence of the source JS - this should be packaged with radare2-webui shlr/www/m - Apache-2.0 shlr/www/enyo/vendors/jquery-ui.min.js - GPL + MIT shlr/www/enyo/vendors/jquery.layout-latest.min.js - GPL + MIT shlr/www/enyo/vendors/jquery.scrollTo.min.js - MIT shlr/www/enyo/vendors/lodash.min.js - lodash license shlr/www/enyo/vendors/joint.* - Mozilla MPL 2.0 shlr/www/enyo/vendors/jquery.min.js - Aplache License version 2.0 shlr/www/p/vendors/jquery* - GPL + MIT shlr/www/p/vendors/dagre*|graphlib* - 3 clause BSD shlr/www/p/vendors/jquery.onoff.min.js - MIT Some embedded libraries I was able to identify sofar: shlr/grub/grubfs.c - LGPL shlr/java - Apache 2.0 shlr/sdb/src - MIT shlr/spp - MIT shlr/squashfs/src - GPLv2+ shlr/tcc - LGPLv2+ shlr/udis86 - 2 clause BSD shlr/wind - LGPL v3+ shlr/spp - MIT shlr/zip/zlib - 3 clause BSD (system installed sared zlib is used instead) regular expressions library from BSD js0n library lz4 binutils vavrdisasm Sometimes it is not really clear how the library got to radare and what are the modifications to its code comparing to the upstream. For some of these it would be possible to use some dynamic library - like for the regular expressions or json. Personally I do not think there is much of things which shuold stand in a way to radare2 to be accepted as a package for Fedora, but of course I am probably biased as someone who already spent so much time with packaging and maintaining it for Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SGZOE4TMLFFXXBHS7GZOGDEXCX33NZIT/
[Bug 1586367] Review Request: R-hunspell - High-Performance Stemmer, Tokenizer, and Spell Checker
https://bugzilla.redhat.com/show_bug.cgi?id=1586367
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS
- Package requires R-core.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MPL (v1.1) GPL (v2 or later) or LGPL (v2.1 or later)", "MPL
(v1.1) BSD (2 clause) GPL (v2 or later) or LGPL (v2.1 or later)",
"LGPL (v2.1)", "Unknown or generated". 38 files have unknown license.
Detailed output of licensecheck in
/home/bob/packaging/review/R-hunspell/review-R-hunspell/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
= SHOULD items =
Generic:
[-]: If
[Bug 1586344] Review Request: R-timeSeries - Rmetrics - Financial Time Series Objects
https://bugzilla.redhat.com/show_bug.cgi?id=1586344 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- - Fix the line encodengs: R-timeSeries.noarch: W: wrong-file-end-of-line-encoding /usr/share/R/library/timeSeries/doc/timeSeriesPlot.R R-timeSeries.noarch: W: wrong-file-end-of-line-encoding /usr/share/R/library/timeSeries/doc/timeSeriesPlot.Rnw - Patch the old FSF address: R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.NA.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.Omit.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.TimeSeriesClass.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.TimeSeriesCoercion.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.TimeSeriesData.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.TimeSeriesPositions.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.aggregate.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.align.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.apply.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.as.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.attach.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.bind.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.colCum.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.colStats.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.cor.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.cumulated.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.daily.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.dim.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.drawdowns.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.durations.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.lag.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.mathOps.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.merge.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.methods-plot.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.methods-print.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.methods-summary.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.model.frame.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.monthly.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.na.contiguous.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.order.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.periodical.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.rank.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.returns.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.rowCum.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.signalCounts.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.spreads.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.subset.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.time.R R-timeSeries.noarch: E: incorrect-fsf-address /usr/share/R/library/timeSeries/unitTests/runit.timeSeries.R Package otherwise approved, fix the aforementioned issue before import. Package Review ==
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 --- Comment #11 from Fedora Update System --- R-sysfonts-0.7.2-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d189b403b3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QOMNDZVIPSJYAMNQ6T4NTRKRBTPRIAK3/
[Bug 1585868] Review Request: R-showtext - Using Fonts More Easily in R Graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1585868 --- Comment #9 from Fedora Update System --- R-showtext-0.5.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-62997f71d4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3SOSSZNRVKNFF6P4J3LJ6O2K4D75JJWC/
[Bug 1585390] Review Request: R-data.table - Extension of `data.frame`
https://bugzilla.redhat.com/show_bug.cgi?id=1585390 --- Comment #9 from Fedora Update System --- R-data.table-1.11.4-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-17b82b7aa7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FTML6UD73SWFMMECWDHHPBDZUA2P6JI4/
[Bug 1586320] Review Request: R-pillar - Coloured Formatting for Columns
https://bugzilla.redhat.com/show_bug.cgi?id=1586320
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package have the default element marked as %%doc :DESCRIPTION
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 369 files have unknown license.
Detailed output of licensecheck in
/home/bob/packaging/review/R-pillar/review-R-pillar/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
[x]: Package requires R-core.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin,
[Bug 1584973] Review Request: golang-github-git-lfs-go-netrc - A Golang package for reading and writing netrc files
https://bugzilla.redhat.com/show_bug.cgi?id=1584973 --- Comment #4 from Robert-André Mauchin --- I don't know actually, you should ask nim or jchaloup at https://github.com/gofed/go-macros/issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3PDEEP5L43ZIYII2PIRVJKYIDVBBLZEH/
[Bug 1585868] Review Request: R-showtext - Using Fonts More Easily in R Graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1585868 --- Comment #8 from Fedora Update System --- R-showtext-0.5.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cf9fc2fada -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IBDHJD4KAR2ERGUWGDTU26NZADDUSOFZ/
[Bug 1585868] Review Request: R-showtext - Using Fonts More Easily in R Graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1585868 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3HXOOMBV4JTSODHT7EJ27JRRB56RPYVY/
[Bug 1585390] Review Request: R-data.table - Extension of `data.frame`
https://bugzilla.redhat.com/show_bug.cgi?id=1585390 --- Comment #8 from Fedora Update System --- R-data.table-1.11.4-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-090081b480 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7KOXKCBK4MXDCM7YFAXLBQJL5QV2UA35/
[Bug 1585390] Review Request: R-data.table - Extension of `data.frame`
https://bugzilla.redhat.com/show_bug.cgi?id=1585390 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5LKF4LYTKA6JEOAOJZCWET2AALEI7V3T/
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 --- Comment #10 from Fedora Update System --- R-sysfonts-0.7.2-3.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-73f3657160 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5TGCVTKFGJUWIY3LB7IS3F6G3HUYVUGB/
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BTZOMQUG5UQ3Y7OPA43KFYWBWEG7DCXV/
[Bug 1586318] Review Request: R-formatR - Format R Code Automatically
https://bugzilla.redhat.com/show_bug.cgi?id=1586318
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
- Not good:
License: GPL
It should be GPLv2+
Package approved but please fix the license issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 30 files have unknown license. Detailed
output of licensecheck in
/home/bob/packaging/review/R-formatR/review-R-formatR/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.
[x]: Package requires R-core.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package
[Bug 1577543] Review Request: R-tufte - Tufte' s Styles for R Markdown Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1577543 --- Comment #9 from Fedora Update System --- R-tufte-0.3-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CLXYYZTAXQU7BWR5WEZFAAMYB2OAHMGC/
[Bug 1574362] Review Request: python-black - Uncompromising Python code formatter
https://bugzilla.redhat.com/show_bug.cgi?id=1574362 --- Comment #15 from Fedora Update System --- python-black-18.5b1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CAR7ABT4IYVW5D2TD22FQTIJU24OGKAS/
[Bug 1512217] Tracking: Pantheon Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1512217 Fabio Valentini changed: What|Removed |Added Depends On||1589386 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1589386 [Bug 1589386] Review Request: elementary-shortcut-overlay - Native, OS-wide shortcut overlay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NZPBP4WSL6ZQYIMAVEBPVEEKPNINDGBG/
[Bug 1589386] Review Request: elementary-shortcut-overlay - Native, OS-wide shortcut overlay
https://bugzilla.redhat.com/show_bug.cgi?id=1589386 Fabio Valentini changed: What|Removed |Added Blocks||1512217 ||(PantheonDesktopPackageRevi ||ews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1512217 [Bug 1512217] Tracking: Pantheon Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VYW2EEE7SO5MJ6CJN4YGG3GR4NXQZO6O/
[Bug 1589386] New: Review Request: elementary-shortcut-overlay - Native, OS-wide shortcut overlay
https://bugzilla.redhat.com/show_bug.cgi?id=1589386 Bug ID: 1589386 Summary: Review Request: elementary-shortcut-overlay - Native, OS-wide shortcut overlay Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://decathorpe.fedorapeople.org/packages/elementary-shortcut-overlay.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/elementary-shortcut-overlay-1.0-1.fc28.src.rpm Description: This GTK+ applet reads window manager and OS keyboard shortcuts from dconf and exposes them to the user when launched. Inspired by the similar feature of Ubuntu Unity introduced in Ubuntu 12.04. The shortcut window opens centered on the primary display. The gear in the titlebar opens the system keyboard settings. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=27494946 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/T7VO3INCU4TZU2TJTZGLLKNKXHNYXGGT/
[Bug 1578101] Review Request: python-h2 - HTTP/ 2 State-Machine based protocol implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1578101 --- Comment #15 from Fedora Update System --- python-h2-3.0.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c45ca6a4ba -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CWWU64MDNJHXSGLTHYCPWDO7NFMJNMS6/
[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1578103 --- Comment #11 from Fedora Update System --- python-hyperlink-18.0.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5ad25743b1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LF527IJCVNNZWQV4MWD5Y6BXQNWS4LZU/
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- R-sysfonts-0.7.2-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-73f3657160 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ODJVBY2ZTKQJL2KPX3XNLHFUJV5VBYGQ/
[Bug 1585502] Review Request: chrome-gnome-shell - 10.1 for EPEL7
https://bugzilla.redhat.com/show_bug.cgi?id=1585502 Jason Tibbitts changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NSJTEA7F3AOTPZRHKP76EV33ACX3A762/
[Bug 1512217] Tracking: Pantheon Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1512217 Fabio Valentini changed: What|Removed |Added Depends On||1589330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1589330 [Bug 1589330] Review Request: switchboard-plug-sound - Switchboard Sound Plug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7GCRDAGJQRJSCGCOVJZSKKWDWM5JOWMS/
[Bug 1589330] Review Request: switchboard-plug-sound - Switchboard Sound Plug
https://bugzilla.redhat.com/show_bug.cgi?id=1589330 Fabio Valentini changed: What|Removed |Added Blocks||1512217 ||(PantheonDesktopPackageRevi ||ews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1512217 [Bug 1512217] Tracking: Pantheon Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7NICBGI5HQOALTGVCF65Y6VR5EMVHHV2/
[Bug 1589330] New: Review Request: switchboard-plug-sound - Switchboard Sound Plug
https://bugzilla.redhat.com/show_bug.cgi?id=1589330 Bug ID: 1589330 Summary: Review Request: switchboard-plug-sound - Switchboard Sound Plug Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://decathorpe.fedorapeople.org/packages/switchboard-plug-sound.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/switchboard-plug-sound-0.1-1.fc28.src.rpm Description: A sound plug for Switchboard. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=27492023 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VH2P7DI3WA2WF3AD3JQO4F6XDUFJFRPV/
[Bug 1583798] Review Request: termy-qt - TermySequence terminal multiplexer client
https://bugzilla.redhat.com/show_bug.cgi?id=1583798 Rex Dieter changed: What|Removed |Added CC||rdie...@gmail.com Blocks||928937 (qt-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5EYK2EFQUDFRAE6DY4RGCNPOKYJNEOVY/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FDP22FMKRUQRYWW3HOSMGIHH6ORBIWYX/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 --- Comment #4 from Fedora Update System --- python-neotime-1.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-d97647d730 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OP7CWYMN6NSYXQ5PD3TBG7PDXXT2UQND/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 --- Comment #6 from Fedora Update System --- python-neotime-1.0.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-87ef985548 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/EKUMF5AYLAY6KZBS3KPPH7VUT7HHLL47/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 --- Comment #5 from Fedora Update System --- python-neotime-1.0.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcb1c3e927 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OJFNNQOGOEGH24TK23N2EG526NE3OBHZ/
[Bug 1586295] Review Request: rubygem-bootsnap - Boot large ruby/ rails apps faster
https://bugzilla.redhat.com/show_bug.cgi?id=1586295 --- Comment #7 from Pavel Valena --- > I am fine to skip the test failure this time for armv7hl. I'll file a bug when the component is created. In the meantime I'll exclude the armv7hl arch, as it does not work at all. > You can move CODE_OF_CONDUCT.md to %files doc? Sure, I somehow overlooked it... > Other things look okay! I do not think wee need to do anything with the `call-to-mktemp` - see below. Reading the code: * On C level [1] - expects atomic access to a file (used for caching only, reasonable hashing method is used); and * On Ruby level [2] - Mutex is used for synchronizing the Threads Furthermore, reading CAPEC[3], as suggested by rpmlint, none of the Attack Prerequisites are not met AFAICT. This gem is also heavily used and developed at Shopify (and now enabled by default in any Rails app). Concluding that any security concerns one might have have been very probably already investigated. [1] https://github.com/Shopify/bootsnap/blob/684acfd9b8c1298a026dd6b9c2ffeb173d11e949/ext/bootsnap/bootsnap.c#L466 [2] https://github.com/Shopify/bootsnap/blob/684acfd9b8c1298a026dd6b9c2ffeb173d11e949/lib/bootsnap/load_path_cache/cache.rb#L11 [3] http://capec.mitre.org/data/definitions/29.html Additionally, I've commented out any $CFLAGS modification in `extconf.rb` file to use the default Fedora ones. I've updated the links again, Scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27490538 Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/E4GUMXFHL4SGC3MXAOBYVU2WUTJOJBTN/
[Bug 1589283] New: Review Request: mmg - Surface and volume remeshers
https://bugzilla.redhat.com/show_bug.cgi?id=1589283 Bug ID: 1589283 Summary: Review Request: mmg - Surface and volume remeshers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: manisan...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://smani.fedorapeople.org/review/mmg.spec SRPM URL: https://smani.fedorapeople.org/review/mmg-5.3.10-1.fc29.src.rpm Description: Surface and volume remeshers Fedora Account System Username: smani -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UPVSD7BYAQBWX2FOA3WU4JX6PXJJF7C5/
[Bug 1576413] Review Request: boom-boot - boot manager
https://bugzilla.redhat.com/show_bug.cgi?id=1576413 --- Comment #21 from Marian Csontos --- Hi Neal, I updated the spec file, made a scratch build, and uploaded rpm and srpm to below locations: Spec URL: https://raw.githubusercontent.com/csonto/fedpkg-boom-boot/master/boom-boot.spec SRPM URL: https://mcsontos.fedorapeople.org/boom-boot/boom-boot-0.8.5-6.2.fc29.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=27490751 - wouldbe fedpkg git repo is here: https://github.com/csonto/fedpkg-boom-boot - the fresh srpm and rpm results: https://mcsontos.fedorapeople.org/boom-boot complete rpmlint output: python3-boom.noarch: W: spelling-error %description -l en_US systemd -> systems, system, system d python3-boom.noarch: W: spelling-error %description -l en_US bls -> lbs, bl, ls python3-boom.noarch: W: non-etc-or-var-file-marked-as-conffile /boot/boom/boom.conf python3-boom.noarch: E: non-standard-dir-perm /boot/boom/profiles 700 python3-boom.noarch: E: non-standard-dir-perm /boot/loader/entries 700 1 packages and 0 specfiles checked; 2 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/I2WPHNH25STBHWI6L72ZJEDLNH2BK4GI/
[Bug 1576413] Review Request: boom-boot - boot manager
https://bugzilla.redhat.com/show_bug.cgi?id=1576413 --- Comment #20 from Neal Gompa --- I'm okay with the changes proposed so far, so please get up an updated spec and SRPM so I can review it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/S53JUCRPR5FKSIAXSKFGAW53NYQDYRZL/
[Bug 1576413] Review Request: boom-boot - boot manager
https://bugzilla.redhat.com/show_bug.cgi?id=1576413 --- Comment #19 from Neal Gompa --- For what it's worth, I'm okay with boom.conf being shipped in /boot for now. We already do this in GRUB 2, and everyone here knows that both GRUB 2 and Boom will eventually need to be fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/U3C4PL6N2LRSUJNIRZZDAIJWWP5FWMWZ/
[Bug 1585502] Review Request: chrome-gnome-shell - 10.1 for EPEL7
https://bugzilla.redhat.com/show_bug.cgi?id=1585502 --- Comment #2 from geant.4.ro...@gmail.com --- But I install the package in epel7,it don't currently working. Can I upgrade it? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/C2XWMY6C7OHZUIXHX7MO57N4Y3DRJZAK/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-neotime -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GZMIEOVC6QMUJ5Z4VG63IM7G3LSPB6FJ/
[Bug 1586199] Review Request: rubygem-mini_magick - Manipulate images with minimal use of memory via ImageMagick
https://bugzilla.redhat.com/show_bug.cgi?id=1586199 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-mini_magick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/F32MOUU3B7A3UGF7FDXNZAC2QAPL73GE/
[Bug 1541516] Review Request: compat-giflib - Compatibility packaging providing libgif.so.4
https://bugzilla.redhat.com/show_bug.cgi?id=1541516 Sandro Mani changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-06-08 10:17:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VZKJRYB2C5VMR3HMYJSZADY66S65FE72/
[Bug 1586199] Review Request: rubygem-mini_magick - Manipulate images with minimal use of memory via ImageMagick
https://bugzilla.redhat.com/show_bug.cgi?id=1586199 --- Comment #7 from Jun Aruga --- Oh thanks for that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2A27ZKTVMNYM3RHB2LPZ7RAFJOOJOJV4/
[Bug 1586199] Review Request: rubygem-mini_magick - Manipulate images with minimal use of memory via ImageMagick
https://bugzilla.redhat.com/show_bug.cgi?id=1586199 Pavel Valena changed: What|Removed |Added Docs Contact|jar...@redhat.com | Assignee|nob...@fedoraproject.org|jar...@redhat.com --- Comment #6 from Pavel Valena --- Fixing assignee. https://pagure.io/releng/fedora-scm-requests/issue/6946 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JVTHZP6HWYBFFIO7M44AVQ6HQW4I3CGX/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797
Ralph Bean changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Ralph Bean ---
Please remove the shebang from all python files in
/usr/lib/python3.6/site-packages/neotime in the
%prep section to make rpmlint happy. A "find" call with "sed" should do it.
Also, please file an issue with upstream asking them to include the full text
of the license in
their next tarball release (include it in MANIFEST.in, usually).
Neither of these are blocking concerns. +1 to the review. These can be fixed
after import to dist-git.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Apache (v2.0)", "Unknown or
generated", "*No copyright* Apache (v2.0)". 7 files have unknown
license. Detailed output of licensecheck in /home/threebean/1588797
-python-neotime/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Binary eggs must be removed in %prep
Note: Cannot find any build in BUILD directory (--prebuilt option?)
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream
[Bug 1586295] Review Request: rubygem-bootsnap - Boot large ruby/ rails apps faster
https://bugzilla.redhat.com/show_bug.cgi?id=1586295 --- Comment #6 from Jun Aruga --- You can move CODE_OF_CONDUCT.md to %files doc? Other things look okay! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YM4LXO72SU4D7T2ZZDPYB6ENMAHDXXPF/
[Bug 1588797] Review Request: python-neotime - Nanosecond resolution temporal types
https://bugzilla.redhat.com/show_bug.cgi?id=1588797 Ralph Bean changed: What|Removed |Added Status|NEW |ASSIGNED CC||rb...@redhat.com Assignee|nob...@fedoraproject.org|rb...@redhat.com Flags||fedora-review? --- Comment #1 from Ralph Bean --- I'll take it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LGE6XIC5GZMAJJYE6QO7ZURODVC7VM4H/
[Bug 1577543] Review Request: R-tufte - Tufte' s Styles for R Markdown Documents
https://bugzilla.redhat.com/show_bug.cgi?id=1577543 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-06-08 09:11:32 --- Comment #8 from Fedora Update System --- R-tufte-0.3-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/C5Y2CZC5OC4GBVBP2QLGDJAK6YPB4W3O/
[Bug 1582520] Review Request: python-collectd_cvmfs - Collectd module for CvmFS clients
https://bugzilla.redhat.com/show_bug.cgi?id=1582520 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-06-08 09:10:41 --- Comment #10 from Fedora Update System --- python-collectd_cvmfs-1.0.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LRSIVJOICILM3OP3QWD57BNKNDWATHOQ/
[Bug 1558789] Review Request: R-orcutt - Estimate Procedure in Case of First Order Autocorrelation
https://bugzilla.redhat.com/show_bug.cgi?id=1558789 --- Comment #12 from Fedora Update System --- R-orcutt-2.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/WC7HVFL4NBRONXO7IJ4UHM6MH3UEISYI/
[Bug 1574362] Review Request: python-black - Uncompromising Python code formatter
https://bugzilla.redhat.com/show_bug.cgi?id=1574362 Fedora Update System changed: What|Removed |Added Resolution|CURRENTRELEASE |ERRATA --- Comment #14 from Fedora Update System --- python-black-18.5b1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CQJ2UXNCKCWLTEFGPB47F2RL5PPLTMFU/
[Bug 1586295] Review Request: rubygem-bootsnap - Boot large ruby/ rails apps faster
https://bugzilla.redhat.com/show_bug.cgi?id=1586295 --- Comment #5 from Jun Aruga --- You need source contribution to the upstream to change the logic, don't you? ``` $ rpmlint -i ./*.spec /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ... rubygem-bootsnap.x86_64: E: call-to-mktemp /usr/lib64/gems/ruby/bootsnap-1.3.0/bootsnap/bootsnap.so This executable calls mktemp. As advised by the manpage (mktemp(3)), this function should be avoided. Some implementations are deeply insecure, and there is a race condition between the time of check and time of use (TOCTOU). See http://capec.mitre.org/data/definitions/29.html for details, and contact upstream to have this issue fixed. ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GLS6AWKBO27YPSSGVASJ23QDVFK347OF/
[Bug 1578101] Review Request: python-h2 - HTTP/ 2 State-Machine based protocol implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1578101 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python-h2-3.0.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-806cce8b0c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GTQZJ2ITNRHKNJLOSMMEYQVH7PCSHWJO/
[Bug 1578103] Review Request: python-hyperlink - A featureful, immutable, and correct URL for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1578103 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-hyperlink-18.0.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-5251a80496 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VLP5OIQCMPVSPTGA3IINWWOML4PQPETU/
[Bug 1586295] Review Request: rubygem-bootsnap - Boot large ruby/ rails apps faster
https://bugzilla.redhat.com/show_bug.cgi?id=1586295 --- Comment #4 from Jun Aruga --- I am fine to skip the test failure this time for armv7hl. ``` %ifarch armv7hl ... ruby -Ilib:test:ext -e 'Dir.glob "./test/**/*_test.rb", (:require)' ... %endif ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5TTQZ3Q4CWE4TSICYCUEP7TK6H27A3ER/
[Bug 1582469] Review Request: plasma-browser-integration - components necessary to integrate browsers into the Plasma Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1582469 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-browser-integration -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JUWZ6LA4RKIRYL3ZTXFCUWME7TACADPI/
[Bug 1586199] Review Request: rubygem-mini_magick - Manipulate images with minimal use of memory via ImageMagick
https://bugzilla.redhat.com/show_bug.cgi?id=1586199 Jun Aruga changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Jun Aruga --- okay, I reviewed it again. It looks good. I would ACCEPT it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZAPSNLWEU4I55SXEDRMVMCJGENUFKWR4/
[Bug 1512217] Tracking: Pantheon Desktop related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1512217 Fabio Valentini changed: What|Removed |Added Depends On||1589066 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1589066 [Bug 1589066] Review Request: wingpanel-indicator-nightlight - Night Light Indicator for wingpanel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JHZLZQBNXO7VNFAP2AQBESUX2JV62ACF/
[Bug 1589066] Review Request: wingpanel-indicator-nightlight - Night Light Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1589066 Fabio Valentini changed: What|Removed |Added Blocks||1512217 ||(PantheonDesktopPackageRevi ||ews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1512217 [Bug 1512217] Tracking: Pantheon Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TMKJAESCQSAHGMPRG56CYFUBJORJHMJM/
[Bug 1589066] New: Review Request: wingpanel-indicator-nightlight - Night Light Indicator for wingpanel
https://bugzilla.redhat.com/show_bug.cgi?id=1589066 Bug ID: 1589066 Summary: Review Request: wingpanel-indicator-nightlight - Night Light Indicator for wingpanel Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: decatho...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://decathorpe.fedorapeople.org/packages/wingpanel-indicator-nightlight.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/wingpanel-indicator-nightlight-2.0-1.fc28.src.rpm Description: A wingpanel indicator for Night Light. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=27485847 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XIGYKSTSRGST7WVLFIVJEQURVWE7KFKO/
[Bug 1416705] Review Request: python-kivy - Kivy - Multimedia / Multitouch framework in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1416705 --- Comment #9 from MartinKG --- (In reply to Tom "spot" Callaway from comment #8) > Please remove them from the source tarball. It is not sufficient to simply > delete these files during the package build process, because the SRPM will > have the "No Commercial" restriction, which has an impact on any > distribution of Fedora's SRPM tree. > > You can ask upstream to remove these non-free files, but they may not be > concerned about that. Thanks for your information done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-kivy.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/python-kivy-1.10.0-2.fc28.src.rpm %changelog * Fri Jun 08 2018 Martin Gansser - 1.10.0-2 - remove files with non acceptable CC BY-NC licence from tar archive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GOZMAZORMXD5GDYOLI3WXKD3QT5MD3IK/
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 --- Comment #8 from Fedora Update System --- R-sysfonts-0.7.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-73f3657160 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FKS2FE6C3GZTXYC7YR46CAOUCWCZE274/
[Bug 1585024] Review Request: R-sysfonts - Loading Fonts into R
https://bugzilla.redhat.com/show_bug.cgi?id=1585024 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5BICYGBT46QU7MZWN3J5SR53OCUXMMSW/
