[Bug 1597417] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1597417 --- Comment #2 from W. Michael Petullo --- Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-3.12.0-1.fc28.src.rpm Description: Pwntools is a CTF framework and exploit development library. Written in Python, it is designed for rapid prototyping and development, and intended to make exploit writing as simple as possible. Fedora Account System Username: mikep Addressed comment #1. Statements to build documentation are present, but I commented them out because pwntools does not yet seem compatible with sphinx 1.7 as shipped by Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/M7I6K7FLT4VJCBAO4WDXSRGX372T6SUO/
[Bug 1597417] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1597417 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2MGKPBTCKOBBENEN5XLS5ITCPF27HSLV/
[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #13 from Neal Gompa --- > %ldconfig_scriptlets This needs to be `%ldconfig_scriptlets libs` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/77YCT3IFF3EMOXNJXSKF6XZJCYDCOASV/
[Bug 1597036] Review Request: -
https://bugzilla.redhat.com/show_bug.cgi?id=1597036 --- Comment #3 from Brian Crockett --- That's a little disappointing that I spent my sunday going thru the effort of fixing this, only for it to go unused.. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/URLBX2ZPL7C3C4ZGBD6N2JFWNIBY5YIA/
[Bug 1596964] Review Request: rust-rand_core - Core random number generator traits
https://bugzilla.redhat.com/show_bug.cgi?id=1596964 Josh Stone changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-07-03 14:37:33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4HVPOP55KVCHCYLQ6XGZKV7FG6WOH5LV/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397 --- Comment #5 from Fedora Update System --- python-django-crispy-forms-1.7.2-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d9d8ed9aa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/BGKH3KSOPCRXB57ZBSELLVOWIPX7IQX7/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/QJ2AM5BDPXKSOHGYM4ZOHK66X4TJS3BQ/
[Bug 1597862] New: Review Request: gr-hpsdr - GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1597862 Bug ID: 1597862 Summary: Review Request: gr-hpsdr - GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jskar...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr.spec SRPM URL: https://jskarvad.fedorapeople.org/gr-hpsdr/gr-hpsdr-1.2-1.fc28.src.rpm Description: GNU Radio modules for OpenHPSDR Hermes / Metis and Red Pitaya using the OpenHpsdr protocol. Fedora Account System Username: jskarvad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OHUX2G4ORFA3BSJJOR7ZRWJQ45GMOFQV/
[Bug 1520922] Review Request: extractpdfmark - Extract page mode and named destinations as PDFmark from PDF
https://bugzilla.redhat.com/show_bug.cgi?id=1520922 Federico Bruni changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Flags|needinfo?(f...@inventati.or | |g) | Last Closed||2018-07-03 13:55:36 --- Comment #26 from Federico Bruni --- I think I got it. Let me know if there's anything wrong. https://koji.fedoraproject.org/koji/taskinfo?taskID=28004064 https://koji.fedoraproject.org/koji/packageinfo?packageID=26442 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZIYX53EMVLFQZ2WXOBIR7JHY6FVQ4XRG/
[Bug 1590988] Review Request: freight-container - rpm/ systemd based container utility
https://bugzilla.redhat.com/show_bug.cgi?id=1590988 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- freight-container-0-0.3.20180613gitd1d03af.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-29e781cb92 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3INK3ZCLTUOD4F2UOGX35R6Z6I3VSKX5/
[Bug 1596922] Review Request: python-pipdeptree - Command line utility to show dependency tree of package
https://bugzilla.redhat.com/show_bug.cgi?id=1596922 --- Comment #6 from Dhanesh B. Sabane --- (In reply to Miro Hrončok from comment #4) > What do you need? I'm fairly confident you don't need tox, you also probably > can run the test without coverage reports. We also have pytest 3.6 (it might > work) and pluggy 0.6.0 (as requested). The tox.ini file in the GitHub repo suggests having tox==3.0.0 and pytest==3.5.0 (the only pending requirements). Matthias (FAS ID: mrunge) replied to my email and has bumped up the spec for python-tox. I think he still needs to push an update to Bodhi. For pytest, I wasn't able to locate the 3.6.0 version on Fedora repos. Can you guide me on how I can get that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CP2VDG6XYSBO7TJWQCKNSYJDK7RR4HOZ/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-django-crispy-forms -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NZE3HQCUTIR7VRIOG7U7W73G3FBUSKY6/
[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1536780 --- Comment #64 from Tom Stellard --- This looks better now. Just a few more things that the fedora-review tool caught: - Drop BuildRequires: which -+ Filter Provdes for liblldb* https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering - Any shared objects that are run-time dependencies of applications compiled by swift, but not run-time dependencies of the swift compiler should be split out into a -runtime subpackage. swift-lang should Require: the -runtime subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZE74ZD2H3MHXNJWPHH6GQ6QL26VGXI47/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SOX5TUOV2JSYDWFSFH7R5N5B776HXHYC/
[Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1380826 Bug 1380826 depends on bug 1550692, which changed state. Bug 1550692 Summary: new version of babel 2.5.3 https://bugzilla.redhat.com/show_bug.cgi?id=1550692 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/F7RAV36IHL75EQ5GF7ZKQHYSMDV2GENZ/
[Bug 1595099] Review Request: vulkan-loader - Vulkan loader
https://bugzilla.redhat.com/show_bug.cgi?id=1595099 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-07-03 12:52:09 --- Comment #7 from Fedora Update System --- mesa-18.0.5-2.fc28, vulkan-headers-1.1.77.0-1.fc28, vulkan-loader-1.1.77.0-4.fc28, vulkan-tools-1.1.77.0-1.fc28, vulkan-validation-layers-1.1.77.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OZ2TKMVUYRTTFA4XICCKYUWFYGK2NFAA/
[Bug 1595305] Review Request: vulkan-validation-layers - Vulkan validation layers
https://bugzilla.redhat.com/show_bug.cgi?id=1595305 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-07-03 12:52:15 --- Comment #8 from Fedora Update System --- mesa-18.0.5-2.fc28, vulkan-headers-1.1.77.0-1.fc28, vulkan-loader-1.1.77.0-4.fc28, vulkan-tools-1.1.77.0-1.fc28, vulkan-validation-layers-1.1.77.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/X5N6LHPIQOILQPLUQU7D7TYUDN4E7ZJG/
[Bug 1594134] Review Request: vulkan-headers - Vulkan Header files and API registry
https://bugzilla.redhat.com/show_bug.cgi?id=1594134 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-07-03 12:52:05 --- Comment #7 from Fedora Update System --- mesa-18.0.5-2.fc28, vulkan-headers-1.1.77.0-1.fc28, vulkan-loader-1.1.77.0-4.fc28, vulkan-tools-1.1.77.0-1.fc28, vulkan-validation-layers-1.1.77.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OZDZV5S3B7DQBQ2CRDLXJKXRXK2PBZ6Y/
[Bug 1595308] Review Request: vulkan-tools - Vulkan tools
https://bugzilla.redhat.com/show_bug.cgi?id=1595308 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-07-03 12:52:12 --- Comment #7 from Fedora Update System --- mesa-18.0.5-2.fc28, vulkan-headers-1.1.77.0-1.fc28, vulkan-loader-1.1.77.0-4.fc28, vulkan-tools-1.1.77.0-1.fc28, vulkan-validation-layers-1.1.77.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7NYYIJXUAOYW4DWNI7L7UL4KGZFZ44TU/
[Bug 1590921] Review Request: restic - restic is a backup program that is fast, efficient and secure.
https://bugzilla.redhat.com/show_bug.cgi?id=1590921 Bug 1590921 depends on bug 1592074, which changed state. Bug 1592074 Summary: Review Request: golang-github-minio - Minio Client SDK for Go https://bugzilla.redhat.com/show_bug.cgi?id=1592074 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4MQXHX3AGWKXA7GY7ULNMLUY2STAWHO2/
[Bug 1592074] Review Request: golang-github-minio - Minio Client SDK for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1592074 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-07-03 12:50:43 --- Comment #7 from Fedora Update System --- golang-github-minio-6.0.2-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DWFBADCTH42E7HTO4UH44CHVUIQNEBGS/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397 --- Comment #2 from Luis Bazan --- Hi Robert New SRPMS https://lbazan.fedorapeople.org/python-django-crispy-forms-1.7.2-2.fc28.src.rpm New SPEC: https://lbazan.fedorapeople.org/python-django-crispy-forms.spec Best! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4J5IK7HJSO4URNNXWXVEGZFV54UYLMYY/
[Bug 1597417] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1597417
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Could you add a comment before the patch to explain what it does.
- There's no tests provided so you can remove %check
- Another issue is that you're using python2-tox which has been removed from
Fedora. This is not really needed to use the library so you can safely remove
it.
- Install the docs:
BuildRequires: python2-sphinx
%package doc
Summary:pwntools documentation
%description doc
Documentation for pwntools
%build
%py2_build
# generate html docs
PYTHONPATH=${PWD} sphinx-build-2 docs/source html
# remove the sphinx-build leftovers
rm -rf html/.{doctrees,buildinfo}
%files doc
%doc html
%license LICENSE-pwntools.txt
(might need other BR)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZYIVPEQDXLE75V634PLPEL2YEV3M3CUG/
[Bug 1597417] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1597417 Bug 1597417 depends on bug 1594431, which changed state. Bug 1594431 Summary: Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework https://bugzilla.redhat.com/show_bug.cgi?id=1594431 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/SIAK5KHPL6DEGWMPZGNLD77QXX3PAVRH/
[Bug 1594431] Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework
https://bugzilla.redhat.com/show_bug.cgi?id=1594431 W. Michael Petullo changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2018-07-03 11:18:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y42KSFKXDBZE3PIFH6CKZUVUXU2KAETB/
[Bug 1597417] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1597417 Bug 1597417 depends on bug 1594430, which changed state. Bug 1594430 Summary: Review Request: python-ROPGadget - A tool to find ROP gadgets in program files https://bugzilla.redhat.com/show_bug.cgi?id=1594430 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GNJRX74CQKMH6KC7NVO7IJSYPJE6ZAUI/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 W. Michael Petullo changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2018-07-03 11:18:35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZCZHB5YDOSBNKVC5UOK5WE4ACQDQC6S3/
[Bug 1594431] Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework
https://bugzilla.redhat.com/show_bug.cgi?id=1594431 --- Comment #20 from W. Michael Petullo --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/DCWK5X5CLXTVSD2PAPQ6B37FFZTKL26C/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 --- Comment #8 from W. Michael Petullo --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/AI5VRLT2ZEPP4LYJ6CNOUUTUHIBK2DLT/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/G46A5USPNZLPFQK7M5E4XA5CYINMFCLV/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 --- Comment #7 from Fedora Update System --- python-ROPGadget-5.4-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-82d60cb6db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KBQXSCG3RLAGJF6JV2EPGVEEOZPZQJS2/
[Bug 1594431] Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework
https://bugzilla.redhat.com/show_bug.cgi?id=1594431 --- Comment #19 from Fedora Update System --- unicorn-1.0.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-bf9f4ac284 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/3YCD6SZH7UWPWN55V6IDF66J3KMS5RYS/
[Bug 1594431] Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework
https://bugzilla.redhat.com/show_bug.cgi?id=1594431 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/B2QSIB6CRGAKTIBO53DHO5KAM73BUKVK/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ROPGadget -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/OEVLIYAVUHXNDRUHP7AZEIPMHIKPM65K/
[Bug 1550595] Review Request: tpm2-abrmd-selinux - SELinux policies for tpm2-abrmd
https://bugzilla.redhat.com/show_bug.cgi?id=1550595 --- Comment #34 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tpm2-abrmd-selinux -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HV3COM6XYN5JCXYFUASOBM4QX27ATAKS/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #28 from Miro Hrončok --- Does /usr/lib64/python3.7/site-packages/sassc.py actually need the shebang and executable bit? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5GIJDRJIS7FYAM67HJKN55VA3PBWZT43/
[Bug 1597391] Review Request: mediawiki-backtick-code - mediawiki extension - allows inline code snippets
https://bugzilla.redhat.com/show_bug.cgi?id=1597391
--- Comment #3 from zachvatw...@gmail.com ---
Thanks for the review! I am working on these items.
(In reply to Robert-André Mauchin from comment #2)
> - Not needed
>
> BuildRoot:%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>
> rm -rf %{buildroot}
>
> - The archive seems corrupted. I don't manage to open it. Same with the
> SRPM. I think the correct Source0 should be:
>
> https://pagure.io/mediawiki-backtick-code-extension/raw/master/f/mediawiki-
> backtick-code-0.0.2.tar.gz
>
> - You should own this directory:
>
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners:
> /usr/share/mediawiki/extensions/BacktickCode
>
> %dir %{_datadir}/mediawiki/extensions/BacktickCode
>
> - The changelog entry must contain your name, email and the Version-Release
> info:
> [x]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/share/mediawiki/extensions/BacktickCode
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners:
> /usr/share/mediawiki/extensions/BacktickCode
> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> Note: rm -rf %{buildroot} present but not required
> = SHOULD items =
>
> Generic:
> [!]: Buildroot is not present
> Note: Buildroot: present but not needed
> [?]: Package functions as described.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XXX6LSRLXIT3VGYNBAWBPSD3IQDD5F6T/
[Bug 1597397] Review Request: python-django-crispy-forms - The best way to have Django DRY forms.
https://bugzilla.redhat.com/show_bug.cgi?id=1597397
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Don't forget the python provide macro:
%package -n python3-%{pypi_name}
Summary: %{summary} - Python 3 version
%{?python_provide:%python_provide python3-%{pypi_name}}
- Be more specific in %files:
%files -n python3-%{pypi_name}
%doc LICENSE.txt README.rst
%{python3_sitelib}/crispy_forms/
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
- Source0 needs https:
Source0:
https://pypi.python.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
- No idea what you're trying to do here:
rm -rf %{py3dir}
cp -a . %{py3dir}
find %{py3dir} -name '*.py' | xargs sed -i '1s|^#!python|#!%{__python3}|'
%{py3dir} is not used for the build. And there's no file with a python shebang
either. So you can remove this entire section.
- LICENSE.txt must be installed with %license, not %doc:
%files -n python3-%{pypi_name}
%license LICENSE.txt
%doc README.rst
- Remove the tab in this line:
Summary: %{summary} - Python 3 version
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE.txt is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 318 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-django-crispy-forms/review-python-
django-crispy-forms/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.7/site-
packages, /usr/lib/python3.7
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #27 from Marcel Plch --- Spec and SRPM updated. Shebang is fixed to /usr/bin/python3 and the package no longer requires python2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HQMSNCADFB3IGOWGRPM5COTBIYL7446D/
[Bug 1594430] Review Request: python-ROPGadget - A tool to find ROP gadgets in program files
https://bugzilla.redhat.com/show_bug.cgi?id=1594430 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Seems good, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KJO2J43YHFLRARKEPDYI5453OJUJL3F3/
[Bug 1597391] Review Request: mediawiki-backtick-code - mediawiki extension - allows inline code snippets
https://bugzilla.redhat.com/show_bug.cgi?id=1597391
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Blocks||177841 (FE-NEEDSPONSOR)
--- Comment #2 from Robert-André Mauchin ---
- Not needed
BuildRoot:%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
rm -rf %{buildroot}
- The archive seems corrupted. I don't manage to open it. Same with the SRPM.
I think the correct Source0 should be:
https://pagure.io/mediawiki-backtick-code-extension/raw/master/f/mediawiki-backtick-code-0.0.2.tar.gz
- You should own this directory:
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/mediawiki/extensions/BacktickCode
%dir %{_datadir}/mediawiki/extensions/BacktickCode
- The changelog entry must contain your name, email and the Version-Release
info:
* Fri Jun 29 2018 Zach Villers - 0.0.2-1
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /home/bob/packaging/review/mediawiki-
backtick-code/review-mediawiki-backtick-code/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/mediawiki/extensions/BacktickCode
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/mediawiki/extensions/BacktickCode
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]:
[Bug 1594431] Review Request: unicorn - A lightweight multi-platform, multi-architecture CPU emulator framework
https://bugzilla.redhat.com/show_bug.cgi?id=1594431 --- Comment #18 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/unicorn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/JCAPO5LVIZTRFIN7F3CLZNWIPKNR2HVV/
[Bug 1596964] Review Request: rust-rand_core - Core random number generator traits
https://bugzilla.redhat.com/show_bug.cgi?id=1596964 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rand_core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VWOJ6OLKFPUGGIDA7R75VUMLE3L42MLI/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #26 from Miro Hrončok --- + /usr/lib/rpm/redhat/brp-mangle-shebangs *** WARNING: mangling shebang in /usr/lib64/python3.7/site-packages/sassc.py from #!/usr/bin/env python to #!/usr/bin/python2. This will become an ERROR, fix it manually! $ rpm -qp --requires python3-libsass-0.14.5-1.fc29.x86_64.rpm /usr/bin/python2 ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MFK23VVPI75ZJNDS76K4M5HYDNPKREIT/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #25 from Marcel Plch --- Done. You may now launch a rebuild. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/J6U7GV2AQW7LQVDUHYTN3EM4MIIGRCEN/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #24 from Miro Hrončok --- Have you also updated the SRPM? I'd like to rebuild it in Koji. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YCRHZN3UD5L6IQLJYOOVWG7WAGYOIZOX/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #23 from Marcel Plch --- I have updated the spec and dropped the python2 package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YRO5FE2GDTKRBUOTSKRGWG7IX7BM2PRM/
[Bug 1594313] Review Request: java-11-openjdk - next LTS OpenJDK for Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1594313 --- Comment #36 from Severin Gehwolf --- (In reply to Severin Gehwolf from comment #18) > Package Review > == > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > === [...] > - Some licenses in sources are not listed in "License" field. Please apply patch https://bugzilla.redhat.com/attachment.cgi?id=1455380 to fix this. [...] > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [!]: License field in the package spec file matches the actual license. > Note: licensecheck output file attached. [...] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/W2Q66G362QAQHCZCED7OZ6F3WUQUNPHB/
[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #12 from Jonathan Dieter --- Ok, in this updated spec, the only bundled code is buzhash from the urlblock project. It's used to figure out when to automatically end a chunk. There's a new dependency on openssl, and I think I've finished the rest of the list of smaller items, including the change on the License tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YIKJI2ILUV2APT3TP663T4ZKEZGETP23/
[Bug 1597287] Review Request: zchunk - A compressed file format that allows easy deltas
https://bugzilla.redhat.com/show_bug.cgi?id=1597287 --- Comment #11 from Jonathan Dieter --- Updated spec: Spec URL: https://www.jdieter.net/downloads/zchunk/zchunk.spec SRPM URL: https://www.jdieter.net/downloads/zchunk/zchunk-0.7.5-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4BAVNWLQX4J5KO6UH7DCWR6KWBNOR7UJ/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #22 from Miro Hrončok --- + /usr/lib/rpm/redhat/brp-mangle-shebangs *** WARNING: mangling shebang in /usr/lib64/python3.7/site-packages/sassc.py from #!/usr/bin/env python to #!/usr/bin/python2. This will become an ERROR, fix it manually! *** WARNING: mangling shebang in /usr/lib64/python2.7/site-packages/sassc.py from #!/usr/bin/env python to #!/usr/bin/python2. This will become an ERROR, fix it manually! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/5BE4WGRGZYKEYJ3UZWDIS6HUBMCEZCCO/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281
--- Comment #21 from Miro Hrončok ---
BuildRequires: python2-devel python2-six python2-pytest python-werkzeug
BuildRequires: python3-devel python3-six python3-pytest python3-werkzeug
1) as a matter of style, i recommend putting each BR on new line. it's better
with diffs, commits, etc.
2) python-werkzeug -> python2-werkzeug
PLATFORM=...
why si this needed? maybe add a comment
-
py.test-%{python2_version} -> py.test-2
py.test-%{python3_version} -> py.test-3
-
%exclude %{_bindir}/sassc
%exclude %{_bindir}/sassc.py
add a comment?
-
Also, consider not doing the python2 package at all.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IVW5Y7QUTSXFHA3MFG3S5NQ3L7VS65GK/
[Bug 1491281] Review Request: python-libsass - python bindings for libsass
https://bugzilla.redhat.com/show_bug.cgi?id=1491281 --- Comment #20 from Marcel Plch --- A new, updated, and fixed version of the bindings is prepared. Spec URL:https://raw.githubusercontent.com/Traceur759/python-libsass/master/python-libsass.spec SRPM URL: https://github.com/Traceur759/python-libsass/raw/master/python-libsass-0.14.5-1.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/VFDFGKKXLQHFSVTYN4R4TWPBEE44NHZS/
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #39 from Anton Kochkov --- 2.6.9 was released as an intermediate release, can you please check how it plays out with packaging? So we will be able to fix issues if any before the 2.7.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/A5EJU6IEZUG6XDV7YHN4CLLPCE3LRFEB/
[Bug 1594313] Review Request: java-11-openjdk - next LTS OpenJDK for Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1594313 --- Comment #35 from Severin Gehwolf --- (In reply to jiri vanek from comment #10) > (In reply to Severin Gehwolf from comment #1) > > This: > > > > %global _privatelibs > > libjsoundalsa[.]so.*|libsplashscreen[.]so.*|libawt_xawt[.]so.*|libjawt[.]so. > > *|libjli[.]so.*|libattach[.]so.*|libawt[.]so.*|libextnet[.]so.*|libjsig[.]so. > > *|libawt_headless[.]so.*|libdt_socket[.]so.*|libfontmanager[.]so. > > *|libinstrument[.]so.*|libj2gss[.]so.*|libj2pcsc[.]so.*|libj2pkcs11[.]so. > > *|libjaas_unix[.]so.*|libjava[.]so.*|libjavajpeg[.]so.*|libjdwp[.]so. > > *|libjimage[.]so.*|libjsound[.]so.*|liblcms[.]so.*|libmanagement[.]so. > > *|libmanagement_agent[.]so.*|libmanagement_ext[.]so.*|libmlib_image[.]so. > > *|libnet[.]so.*|libnio[.]so.*|libprefs[.]so.*|librmi[.]so.*|libsaproc[.]so. > > *|libsctp[.]so.*|libsunec[.]so.*|libunpack[.]so.*|libverify[.]so.*|libzip[. > > ]so.*|lib[.]so\\(SUNWprivate_.* > > > > Should be this: > > > > %global _privatelibs > > libsplashscreen[.]so.*|libawt_xawt[.]so.*|libjawt[.]so.*|libjli[.]so. > > *|libattach[.]so.*|libawt[.]so.*|libextnet[.]so.*|libjsig[.]so. > > *|libawt_headless[.]so.*|libdt_socket[.]so.*|libfontmanager[.]so. > > *|libinstrument[.]so.*|libj2gss[.]so.*|libj2pcsc[.]so.*|libj2pkcs11[.]so. > > *|libjaas[.]so.*|libjava[.]so.*|libjavajpeg[.]so.*|libjdwp[.]so.*|libjimage[. > > ]so.*|libjsound[.]so.*|liblcms[.]so.*|libmanagement[.]so. > > *|libmanagement_agent[.]so.*|libmanagement_ext[.]so.*|libmlib_image[.]so. > > *|libnet[.]so.*|libnio[.]so.*|libprefs[.]so.*|librmi[.]so.*|libsaproc[.]so. > > *|libsctp[.]so.*|libsunec[.]so.*|libunpack[.]so.*|libverify[.]so.*|libzip[. > > ]so.* > > > > lib.so provides isn't generated for JDK 10+, libjaas_unix.so is no longer in > > JDK 11, etc. > > Fixed. You have some sript to generate this befor buid? Or from build itslef? > Used. According to: https://bugzilla.redhat.com/show_bug.cgi?id=1590796#c14 this needs to change to the following in order to not break dependencies for other packages: libsplashscreen[.]so.*|libawt_xawt[.]so.*|libjli[.]so.*|libattach[.]so.*|libawt[.]so.*|libextnet[.]so.*|libawt_headless[.]so.*|libdt_socket[.]so.*|libfontmanager[.]so.*|libinstrument[.]so.*|libj2gss[.]so.*|libj2pcsc[.]so.*|libj2pkcs11[.]so.*|libjaas[.]so.*|libjavajpeg[.]so.*|libjdwp[.]so.*|libjimage[.]so.*|libjsound[.]so.*|liblcms[.]so.*|libmanagement[.]so.*|libmanagement_agent[.]so.*|libmanagement_ext[.]so.*|libmlib_image[.]so.*|libnet[.]so.*|libnio[.]so.*|libprefs[.]so.*|librmi[.]so.*|libsaproc[.]so.*|libsctp[.]so.*|libsunec[.]so.*|libunpack[.]so.*|libzip[.]so.* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/MMMSVPREMYGWCHNYXKY5NLAAY7EVKBI6/
