[Bug 1583798] Review Request: termy-qt - TermySequence terminal multiplexer client
https://bugzilla.redhat.com/show_bug.cgi?id=1583798 --- Comment #11 from Fedora Update System --- termy-qt-1.1.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-e6fc2fe6c7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631996] Review Request: R-fs - Cross-Platform File System Operations Based on 'libuv'
https://bugzilla.redhat.com/show_bug.cgi?id=1631996 --- Comment #1 from Elliott Sales de Andrade --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=29820572 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631996] New: Review Request: R-fs - Cross-Platform File System Operations Based on 'libuv'
https://bugzilla.redhat.com/show_bug.cgi?id=1631996 Bug ID: 1631996 Summary: Review Request: R-fs - Cross-Platform File System Operations Based on 'libuv' Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: quantum.anal...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://qulogic.fedorapeople.org//R-fs.spec SRPM URL: https://qulogic.fedorapeople.org//R-fs-1.2.6-1.fc28.src.rpm Description: A cross-platform interface to file system operations, built on top of the 'libuv' C library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1583798] Review Request: termy-qt - TermySequence terminal multiplexer client
https://bugzilla.redhat.com/show_bug.cgi?id=1583798 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #10 from Fedora Update System --- termy-qt-1.1.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-41064bd1fa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631988] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=1631988
--- Comment #3 from Julio Gonzalez Gil ---
Thanks!
I'll take care of everything tomorrow. Most of the stuff is just inherited from
the original SPEC submitted at 725292, so I think I can just change most of the
stuff as required.
About:
> Release:%{_release_simple}%{?dist}
I just changed it so I could use
> Source1:
> https://github.com/juliogonzalez/s3fs-fuse-rpm/blob/%{version}-%{_release_simple}/SOURCES/passwd-s3fs
because otherwise copr would refuse to build the package when using:
> Source1: passwd-s3fs
But now I see https://docs.pagure.org/copr.copr/user_documentation.html#scm, I
think I misunderstood the use of 'Subdirectory' :-)
So most probably the _release_simple variable will go away as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631988] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=1631988
--- Comment #2 from Neal Gompa ---
Spec review:
> Release:%{_release_simple}%{?dist}
You should just put the number in. That is, it should be "2%{?dist}".
Strictly speaking, it's not required to change this, and if you have particular
automation centered around that, you should document it.
Cf. https://fedoraproject.org/wiki/Packaging:DistTag
> License:GPLv2
A quick glance at the source files for the project indicate that this is
actually GPLv2+. Please adjust accordingly.
> Source1:
> https://github.com/juliogonzalez/s3fs-fuse-rpm/blob/%{version}-%{_release_simple}/SOURCES/passwd-s3fs
It's better to change this to a plain source reference. When the package is
imported into Dist-Git, the file will exist in the Dist-Git repository anyway.
> Requires: fuse >= 2.8.4
> Requires: fuse-libs >= 2.8.4
Is there a reason for this? Can't we just depend on the autodeps here? Or do we
also need the fuse CLI tools, too?
> Requires: curl >= 7.0
> Requires: libxml2 >= 2.6
> Requires: openssl >= 0.9
Why do these need to be explicitly requested?
> BuildRequires: curl-devel, fuse-devel, libxml2-devel, openssl-devel
> BuildRequires:automake, gcc-c++, make
Please lay these out with one BR per line, as it makes it easier for diffing.
Since the software build code uses pkgconfig modules, please use `pkgconfig()`
deps for these where possible.
> Conflicts: fuse-s3fs
Please put a comment in the spec about why there's a conflict here.
> Obsoletes:s3fs
Unversioned Obsoletes are not generally allowed in Fedora, and I don't believe
we have an "s3fs" to replace.
Cf.
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages
> %description
> s3fs is a FUSE file system that allows you to mount an Amazon S3 bucket as a
> local file system. It stores files natively and transparently in S3 (i.e.,
> you can use other programs to access the same files). Maximum file size=64GB
> (limited by s3fs, not Amazon).
> .
> s3fs is stable and is being used in number of production environments, e.g.,
> rsync backup to s3.
Please drop the line with only a ".", as that is not required for newline
separation in spec files.
> %global debug_package %{nil}
Please drop this, as there's no reason that debuginfo cannot be produced for
this package.
> %setup -q
"%autosetup" is preferable to "%setup -q". If you're concerned about it not
working for EPEL builds, that's not a problem, as %autosetup has been
backported to all supported EPEL targets.
Cf. http://rpm.org/user_doc/autosetup.html
> make %{?_smp_mflags}
"%make_build" is preferred over "make %{?_smp_mflags}". Like "%autosetup", this
has been backported to all supported EPEL targets.
> make install DESTDIR=%{buildroot}
Please use "%make_install".
> cp -p %{SOURCE1} passwd-s3fs
This belongs in the prep section.
> %doc AUTHORS README.md ChangeLog COPYING passwd-s3fs
"%license" must be used for COPYING in the file list. Again, this works on all
targets.
Cf. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981 --- Comment #4 from Susi Lehtola --- Thanks for a quick turnback time. Sorry for not checking if it built in mock, it looked too simple to have build requirements. I couldn't see any documentation, there is no doc(s) directory. Everything else is fixed. https://jussilehtola.fedorapeople.org/gau2grid.spec https://jussilehtola.fedorapeople.org/gau2grid-1.2.0-2.fc28.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631988] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=1631988 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review? --- Comment #1 from Neal Gompa --- Taking this review. In addition, I will sponsor you. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981
--- Comment #3 from Robert-André Mauchin ---
- Add %make_build after %cmake
%build
mkdir objdir
cd objdir
%cmake .. -DCARTESIAN_ORDER=row -DSPHERICAL_ORDER=gaussian
-DCMAKE_INSTALL_LIBDIR=%{_lib}
%make_build
- make -C objdir install DESTDIR=%{buildroot} → %make_install -C objdir
- Build fails:
[ 14%] Generating gau2grid.h, gau2grid_phi.c, gau2grid_deriv1.c,
gau2grid_deriv2.c, gau2grid_spherical.c, gau2grid_helper.c
/usr/bin/python3.7 -c "import sys;
sys.path.append('/builddir/build/BUILD/gau2grid-1.2.0');
import gau2grid as gg;
gg.c_gen.generate_c_gau2grid(8,
path='/builddir/build/BUILD/gau2grid-1.2.0/objdir', cartesian_order='row',
spherical_order='gaussian')"
make[2]: Leaving directory '/builddir/build/BUILD/gau2grid-1.2.0/objdir'
BUILDSTDERR: Traceback (most recent call last):
BUILDSTDERR: File "", line 1, in
BUILDSTDERR: File
"/builddir/build/BUILD/gau2grid-1.2.0/gau2grid/__init__.py", line 5, in
BUILDSTDERR: from . import RSH
BUILDSTDERR: File "/builddir/build/BUILD/gau2grid-1.2.0/gau2grid/RSH.py",
line 7, in
BUILDSTDERR: import numpy as np
BUILDSTDERR: ModuleNotFoundError: No module named 'numpy'
Add:
BuildRequires: python3-numpy
- I've proposed a PR to add library versioning:
https://github.com/dgasmith/gau2grid/pull/23
Patch0:
https://github.com/dgasmith/gau2grid/pull/23.patch#/0001-Add-SONAME-version-to-the-library.patch
And:
%files
%license LICENSE
%doc README.md
%{_libdir}/libgg.so.1*
%files devel
%{_includedir}/gau2grid/
%{_datadir}/cmake/gau2grid/
%{_libdir}/libgg.so
- ***In the next release***, you should not forget to build the docs with
sphinx and install them in the devel package:
BuildRequires: python3-sphinx
BuildRequires: python3-sphinx_rtd_theme
And in %build:
make -C docs html
rm -rf docs/build/html/.{doctrees,buildinfo}
Then
%files devel
%doc docs/build/html
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981 Susi Lehtola changed: What|Removed |Added Alias||gau2grid -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981 --- Comment #2 from Susi Lehtola --- (In reply to Robert-André Mauchin from comment #1) > https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_. > so_name_versioning > > In cases where upstream ships unversioned .so library (so this is not needed > for plugins, drivers, etc.), the packager MUST try to convince upstream to > start versioning it. https://github.com/dgasmith/gau2grid/issues/24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 725292] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=725292 Julio Gonzalez Gil changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co ||m) --- Comment #37 from Julio Gonzalez Gil --- New submission is now ready at https://bugzilla.redhat.com/show_bug.cgi?id=1631988, so I think this review can be closed (adding "needinfo" from nhor...@redhat.com as former assignee, in case he can close it) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631988] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=1631988 Julio Gonzalez Gil changed: What|Removed |Added Summary|Review Request: s3-fuse - |Review Request: s3fs-fuse - |FUSE-based file system |FUSE-based file system |backed by Amazon S3 |backed by Amazon S3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631988] New: Review Request: s3-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=1631988 Bug ID: 1631988 Summary: Review Request: s3-fuse - FUSE-based file system backed by Amazon S3 Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: ju...@juliogonzalez.es QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/juliogonzalez/s3fs-fuse-rpm/blob/1.84-2/SPECS/s3fs-fuse.spec (also at https://copr-be.cloud.fedoraproject.org/results/juliogonzalez/s3fs-fuse/fedora-rawhide-x86_64/00801688-s3fs-fuse/s3fs-fuse.spec) SRPM URL: https://copr-be.cloud.fedoraproject.org/results/juliogonzalez/s3fs-fuse/fedora-rawhide-x86_64/00801688-s3fs-fuse/s3fs-fuse-1.84-2.fc30.src.rpm Description: s3fs is a FUSE filesystem that allows you to mount an Amazon S3 bucket as a local filesystem. It stores files natively and transparently in S3 (i.e., you can use other programs to access the same files). Maximum file size=64GB (limited by s3fs, not Amazon). s3fs is stable and is being used in number of production environments, e.g., rsync backup to s3. Fedora Account System Username: juliogonzalez Koji: Results are at https://koji.fedoraproject.org/koji/taskinfo?taskID=29814931 Additional info: I am a new packager, so I will need a sponsor (I will present my self at devel list in a few minutes) s3fs-fuse is pending review at https://bugzilla.redhat.com/show_bug.cgi?id=725292 since seven years ago. Some years ago I started using the SPEC from https://github.com/cfg/s3fs (based on that request) to maintain the SPEC and a set of scripts to build s3fs-fuse at https://github.com/juliogonzalez/s3fs-fuse-rpm We tried to get feedback from the original submitter (Jorge A. Gallegos) but did not succeed, so I am opening a new review request as discussed at https://bugzilla.redhat.com/show_bug.cgi?id=725292#c30 This package conflicts with an existing package already in fedora: fuse-s3fs (this is stated in the spec file). This submission was requested by upstream, so they are aware and are fine with using s3fs-fuse as package name (despite at other distributions the name is s3fs). See https://github.com/s3fs-fuse/s3fs-fuse/issues/785 and https://bugzilla.redhat.com/show_bug.cgi?id=725292#c35 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 Susi Lehtola changed: What|Removed |Added Alias||python-deepdiff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] New: Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 Bug ID: 1631987 Summary: Review Request: python-deepdiff - Deep Difference and search of any Python object/data Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: susi.leht...@iki.fi QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jussilehtola.fedorapeople.org/python-deepdiff.spec SRPM URL: https://jussilehtola.fedorapeople.org/python-deepdiff-3.3.0-1.fc28.src.rpm Fedora Account System Username: jussilehtola Description: Deep Difference of dictionaries, iterables, strings and other objects. It will recursively look for all the changes. This package is required for updating psi4 to the 1.2 series. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning In cases where upstream ships unversioned .so library (so this is not needed for plugins, drivers, etc.), the packager MUST try to convince upstream to start versioning it. If that fails due to unwilling or unresposive upstream, the packager may start versioning downstream but this must be done with caution and ideally only in rare cases. We don't want to create a library that could conflict with upstream if they later start providing versioned shared libraries. Under no circumstances should the unversioned library be shipped in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1609598] Review Request: fuse-overlayfs - FUSE overlay+shiftfs implementation for rootless containers
https://bugzilla.redhat.com/show_bug.cgi?id=1609598 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-09-22 16:50:07 --- Comment #12 from Fedora Update System --- fuse-overlayfs-0.1-4.dev.git79c70fd.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631981] New: Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid
https://bugzilla.redhat.com/show_bug.cgi?id=1631981 Bug ID: 1631981 Summary: Review Request: gau2grid - Fast computation of a gaussian function and its derivative on a grid Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: susi.leht...@iki.fi QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jussilehtola.fedorapeople.org/gau2grid.spec SRPM URL: https://jussilehtola.fedorapeople.org/gau2grid-1.2.0-1.fc28.src.rpm Fedora Account System Username: jussilehtola Description: A collocation code for computing gaussians on a grid of the form: out_Lp = x^l y^m z^n \sum_i coeff_i e^(exponent_i * (|center - p|)^2) This version has been built with -DCARTESIAN_ORDER=row -DSPHERICAL_ORDER=gaussian for compatibility with psi4. This package is necessary for updating psi4 to the 1.2 release series. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631416] Review Request: python-trio - An async/await-native I/ O library for humans and snake people
https://bugzilla.redhat.com/show_bug.cgi?id=1631416 --- Comment #5 from Fedora Update System --- python-trio-0.7.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-6dcc2a540f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631551] Review Request: nodejs-image-size - A Node module to get dimensions of any image file
https://bugzilla.redhat.com/show_bug.cgi?id=1631551 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- nodejs-image-size-0.6.3-1.fc29, nodejs-less-3.8.1-1.fc29, nodejs-less-plugin-clean-css-1.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-139407d656 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631547] Review Request: nodejs-less-plugin-clean-css - Compresses the css output from less using clean-css
https://bugzilla.redhat.com/show_bug.cgi?id=1631547 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- nodejs-image-size-0.6.3-1.fc29, nodejs-less-3.8.1-1.fc29, nodejs-less-plugin-clean-css-1.5.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-139407d656 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628367] Review Request: python-h11 - A pure-Python, bring-your-own-I /O implementation of HTTP/1.1
https://bugzilla.redhat.com/show_bug.cgi?id=1628367 --- Comment #11 from Fedora Update System --- python-h11-0.8.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1627729] Review Request: mate-user-admin - User management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1627729 --- Comment #12 from Fedora Update System --- mate-user-admin-1.1.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1628300] Review Request: python-outcome - Capture the outcome of Python function calls
https://bugzilla.redhat.com/show_bug.cgi?id=1628300 --- Comment #12 from Fedora Update System --- python-outcome-1.0.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441843] Review Request: linchpin - Ansible based multicloud orchestrator
https://bugzilla.redhat.com/show_bug.cgi?id=1441843 Jonathan Dieter changed: What|Removed |Added CC||greg.helli...@gmail.com Flags||needinfo?(greg.hellings@gma ||il.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441843] Review Request: linchpin - Ansible based multicloud orchestrator
https://bugzilla.redhat.com/show_bug.cgi?id=1441843 --- Comment #23 from Jonathan Dieter --- (In reply to Jonathan Dieter from comment #22) > (In reply to Jonathan Dieter from comment #21) > > Great, thanks. > > > > rpmlint is complaining about a number of empty hidden files in the RPM. Do > > you know why they're there? If they're actually there for a reason, then > > we'll ignore rpmlint, but if they're something left over from the build > > process, there's no reason to have them. > > Any news on this? Ping -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1583798] Review Request: termy-qt - TermySequence terminal multiplexer client
https://bugzilla.redhat.com/show_bug.cgi?id=1583798 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/termy-qt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1591910] Review Request: blis - BLAS-like Library Instantiation Software
https://bugzilla.redhat.com/show_bug.cgi?id=1591910
--- Comment #7 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- libblas* libraries are not hardened:
$ checksec --file libblas.so.3
RELRO STACK CANARY NXPIE RPATH
RUNPATHFORTIFYFortified Fortifiable FILE
Partial RELRO No canary found NX enabledDSO No RPATH No
RUNPATH No00libblas.so.3
- These packages provide same blas* libraries:
$ repoquery --whatprovides libblas.so.*
Last metadata expiration check: 2:17:11 ago on sab 22 set 2018 12:57:31 CEST.
blas-0:3.8.0-8.fc28.i686
blas-0:3.8.0-8.fc28.x86_64
blas-0:3.8.0-9.fc28.i686
blas-0:3.8.0-9.fc28.x86_64
Must be filtered, i guess.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 330
files have unknown license. Detailed output of licensecheck in
/home/sagitter/1591910-blis/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in blis-
serial64 ,
