[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 --- Comment #12 from Fedora Update System --- python-visionegg-quest-1.1-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2488fa18c6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1639186] Review Request: libcerf - a library that provides complex error functions
https://bugzilla.redhat.com/show_bug.cgi?id=1639186 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- libcerf-1.9-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-59933f9560 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613574] Review Request: DCD - The D Completion Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1613574 Bug 1613574 depends on bug 1613572, which changed state. Bug 1613572 Summary: Review Request: libdparse - Library for lexing and parsing D source code https://bugzilla.redhat.com/show_bug.cgi?id=1613572 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613574] Review Request: DCD - The D Completion Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1613574 Bug 1613574 depends on bug 1613573, which changed state. Bug 1613573 Summary: Review Request: dsymbol - Symbol lookup support for libdparse https://bugzilla.redhat.com/show_bug.cgi?id=1613573 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613573] Review Request: dsymbol - Symbol lookup support for libdparse
https://bugzilla.redhat.com/show_bug.cgi?id=1613573 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-04 01:50:16 --- Comment #9 from Fedora Update System --- dsymbol-20181014gitec28618-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613573] Review Request: dsymbol - Symbol lookup support for libdparse
https://bugzilla.redhat.com/show_bug.cgi?id=1613573 Bug 1613573 depends on bug 1613572, which changed state. Bug 1613572 Summary: Review Request: libdparse - Library for lexing and parsing D source code https://bugzilla.redhat.com/show_bug.cgi?id=1613572 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613574] Review Request: DCD - The D Completion Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1613574 Bug 1613574 depends on bug 1613570, which changed state. Bug 1613570 Summary: Review Request: msgpack-d - A pure D implementation of MessagePack https://bugzilla.redhat.com/show_bug.cgi?id=1613570 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613570] Review Request: msgpack-d - A pure D implementation of MessagePack
https://bugzilla.redhat.com/show_bug.cgi?id=1613570 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-04 01:50:12 --- Comment #8 from Fedora Update System --- msgpack-d-1.0.0-0.1.beta.7.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613574] Review Request: DCD - The D Completion Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1613574 Bug 1613574 depends on bug 1613571, which changed state. Bug 1613571 Summary: Review Request: containers - Efficient library to use collection in D https://bugzilla.redhat.com/show_bug.cgi?id=1613571 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613572] Review Request: libdparse - Library for lexing and parsing D source code
https://bugzilla.redhat.com/show_bug.cgi?id=1613572 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-04 01:50:07 --- Comment #7 from Fedora Update System --- libdparse-0.9.9-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613573] Review Request: dsymbol - Symbol lookup support for libdparse
https://bugzilla.redhat.com/show_bug.cgi?id=1613573 Bug 1613573 depends on bug 1613571, which changed state. Bug 1613571 Summary: Review Request: containers - Efficient library to use collection in D https://bugzilla.redhat.com/show_bug.cgi?id=1613571 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1613571] Review Request: containers - Efficient library to use collection in D
https://bugzilla.redhat.com/show_bug.cgi?id=1613571 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-04 01:49:59 --- Comment #11 from Fedora Update System --- containers-0.8.0-3.alpha.9.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1612092] Review Request: mailman3 - The GNU mailing list manager
https://bugzilla.redhat.com/show_bug.cgi?id=1612092 --- Comment #15 from Neal Gompa --- Review notes: [x]: Package is named according to package naming guidelines [x]: Package complies with Fedora Packaging Guidelines [x]: Package complies with Fedora Python Packaging Guidelines [!]: Package builds and installs correctly fedora-review and Mock are choking on installing the package. I suspect this has to do with the SELinux scriptlets, though. [!]: Package includes documentation and license content per guidelines "%license COPYING" is missing for the package file list. Could you please address the license file issue and post updated spec and SRPM links? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643691] Review Request: python-repomd - Library for reading dnf/ yum repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1643691
--- Comment #3 from Neal Gompa ---
Some additional advice, if you want to simplify this a bit further, you can
remove runtime requires from the spec if you add the following to the top of
your spec:
%{?python_enable_dependency_generator}
You can see an example of its use in the kiwi and pagure packages. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643691] Review Request: python-repomd - Library for reading dnf/ yum repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1643691 Neal Gompa changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Neal Gompa --- Review notes: [x]: Package is named according to package naming guidelines [x]: Package complies with Fedora Packaging Guidelines [x]: Package complies with Fedora Python Packaging Guidelines [x]: Package builds and installs correctly [x]: Package includes documentation and license content per guidelines PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1641203] Review Request: freecell-solver - a library for solving some solitaire variants
https://bugzilla.redhat.com/show_bug.cgi?id=1641203
--- Comment #17 from Neal Gompa ---
(In reply to Neal Gompa from comment #16)
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>
>
> = MUST items =
>
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [!]: Rpath absent or only used for internal libs.
> Note: See rpmlint output
Rpath usage is generally forbidden in Fedora.
Cf. https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath
> [x]: Package does not contain any libtool archives (.la)
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [!]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
The license files "COPYING.*" should be installed with the library package and
the main binaries.
Cf. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "MIT/X11 (BSD like)", "ISC", "LGPL (v3 or later)", "Unknown or
> generated", "BSD (2 clause)". 461 files have unknown license. Detailed
> output of licensecheck in /home/makerpm/1641203-freecell-
> solver/licensecheck.txt
> [!]: License file installed when any subpackage combination is installed.
The license files "COPYING.*" should be installed with the library package and
the main binaries.
Cf. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/include/freecell-solver
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/include/freecell-solver
This directory needs to be owned by the devel subpackage.
> [x]: Package does not own files or directories owned by other packages.
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [!]: Changelog in prescribed format.
The version referenced in the changelog entry is wrong, but easily fixable.
> [x]: Sources contain only permissible code or content.
> [-]: Package contains desktop file if it is a GUI application.
> [x]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [x]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 10240 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
>
> Python:
> [x]: Python eggs must not download any dependencies during the build
> process.
> [x]: A package which is used b
[Bug 1641203] Review Request: freecell-solver - a library for solving some solitaire variants
https://bugzilla.redhat.com/show_bug.cgi?id=1641203
--- Comment #16 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: Package does not contain any libtool archives (.la)
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "ISC", "LGPL (v3 or later)", "Unknown or
generated", "BSD (2 clause)". 461 files have unknown license. Detailed
output of licensecheck in /home/makerpm/1641203-freecell-
solver/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/include/freecell-solver
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/include/freecell-solver
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
a
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- python-visionegg-quest-1.1-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f5a8ffb9aa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645811] Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1645811 --- Comment #1 from Andrew Bauer --- Updated specfile and source rpm: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/fcgiwrap.spec https://kojipkgs.fedoraproject.org//work/tasks/1763/30651763/fcgiwrap-1.1.0-6.20150530git99c942c.fc30.src.rpm Had to put back the --with-systemd configure flag, even though we are supplying our own systemd service files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645811] New: Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1645811 Bug ID: 1645811 Summary: Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: zonexpertconsult...@outlook.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Fedora Account System Username: kni Spec URL: https://raw.githubusercontent.com/knight-of-ni/specfiles/master/fcgiwrap.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9163/30649163/fcgiwrap-1.1.0-6.20150530git99c942c.fc30.src.rpm Description: - This package provides a simple FastCGI wrapper for CGI scripts with/ following features: - very lightweight (84KB of private memory per instance) - fixes broken CR/LF in headers - handles environment in a sane way (CGI scripts get HTTP-related environment vars from FastCGI parameters and inherit all the others from environment of fcgiwrap ) - no configuration, so you can run several sites off the same fcgiwrap pool - passes CGI std error output to std error stream of cgiwrap or FastCGI - support systemd socket activation, launcher program like spawn-fcgi is no longer required on systemd-enabled distributions RPMLINT: $ rpmlint fcgiwrap-1.1.0-6.20150530git99c942c.fc28.src.rpm fcgiwrap.src: W: spelling-error %description -l en_US cgiwrap -> wrapping fcgiwrap.src: W: spelling-error %description -l en_US systemd -> systems, system, system d fcgiwrap.src: W: spelling-error %description -l en_US fcgi -> GIF 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint fcgiwrap-1.1.0-6.20150530git99c942c.fc28.x86_64.rpm fcgiwrap.x86_64: W: spelling-error %description -l en_US cgiwrap -> wrapping fcgiwrap.x86_64: W: spelling-error %description -l en_US fcgi -> GIF 1 packages and 0 specfiles checked; 0 errors, 2 warnings. NOTES: -- The package in this review is based on the package with the same name by jorti, found here: https://copr.fedorainfracloud.org/coprs/jorti/fcgiwrap/ The systemd unit files have been modified to read from an environment file. The environment file allows one to set daemon parameters w/o editing the service file. Unfortunately, I have not found a way to handle the user & group names in the same manner so if the user is using a web server other than nginx, the service file must still be edited. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1075806] Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1075806 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |EOL Assignee|i...@cicku.me |nob...@fedoraproject.org Flags|fedora-review? | Last Closed||2018-11-03 19:24:53 --- Comment #20 from Neal Gompa --- Go for it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1075806] Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1075806 Andrew Bauer changed: What|Removed |Added CC||zonexpertconsulting@outlook ||.com --- Comment #19 from Andrew Bauer --- Well this is interesting. I was about to create a review request for an fcgiwrap package I put together, when I found this request from 2014. Since the activity in this review appears to have died out, is anyone opposed to closing this request and allowing me to create a new review request? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code
https://bugzilla.redhat.com/show_bug.cgi?id=1258542 --- Comment #41 from Shawn Starr --- Yes, this is where we are at and why I've not been able to move on this... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645768] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645768 --- Comment #2 from Robert-André Mauchin --- *** Bug 1645767 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645767] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645767 Robert-André Mauchin changed: What|Removed |Added Status|NEW |CLOSED CC||zebo...@gmail.com Resolution|--- |DUPLICATE Last Closed||2018-11-03 13:52:24 --- Comment #1 from Robert-André Mauchin --- *** This bug has been marked as a duplicate of bug 1645768 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1509679 --- Comment #4 from Till Hofmann --- Hi Jan, a review swap sounds good, I can have a look at both your packages! I'm a bit busy and currently travelling, but if you can wait a couple days, I'll review them. I'd also be interested in your sway spec (and possibly COPR?) Also note the NotReady flag on this review request, it needs an update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1509679 Jan Pokorný changed: What|Removed |Added CC||jpoko...@redhat.com --- Comment #3 from Jan Pokorný --- Hello Till, since you currently maintain sway, I have something for an attractive review swap if you are interested since these are going to replace + extend swaygrab experience (unless there's something else that works equally well) since sway 1.0: - grim [bug 1645764] - slurp [bug 1645765] Vice-versa, I am interested in this dmenu replacement. How does this sound to you? (FWIW. also have tweaked sway spec to work with the current sway beta that I used for my private build -- since upstream asks not to package that explicitly -- if it would save you some time; also have adopted wlroots package and updated it to released 0.1 version in Rawhide in an anticipation of this new sway.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1644268] Review Request: mythes-eo - Esperanto thesaurus
https://bugzilla.redhat.com/show_bug.cgi?id=1644268
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #4 from Artur Iwicki ---
>pushd $RPM_BUILD_ROOT/%{_datadir}/hyphen/
>pushd $RPM_BUILD_ROOT/%{_datadir}/mythes/
Not needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1643764] Review Request: intelhex - A python library for manipulating Intel HEX file format
https://bugzilla.redhat.com/show_bug.cgi?id=1643764
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #2 from Artur Iwicki ---
>Source0:
>https://github.com/bialix/intelhex/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
You can use "%{URL}/archive/%{version}/%{name}-%{version}.tar.gz" instead.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645367] Review Request: rcm - management suite for dotfiles
https://bugzilla.redhat.com/show_bug.cgi?id=1645367
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>%{_mandir}/man1/*.gz
>%{_mandir}/man5/*.gz
>%{_mandir}/man7/*.gz
Spec files should not assume the compression method for man pages.
>%{_datadir}/rcm/*
This makes the package own the files inside the directory, but not the
directory itself - it remains unowned. Get rid of the asterisk.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645764] Review Request: grim - Grab images from a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645764 --- Comment #2 from Jan Pokorný --- Fix build problems with i686 and armv7hl. Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30637684 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645768] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645768 --- Comment #1 from Ankur Sinha (FranciscoD) --- Forgot the spec/srpm links: https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit.spec https://ankursinha.fedorapeople.org/python-duecredit/python-duecredit-0.6.4-1.fc29.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645768] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645768 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-duecredit Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1280480] Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1280480 Ankur Sinha (FranciscoD) changed: What|Removed |Added Alias|python-duecredit| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645768] New: Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645768 Bug ID: 1645768 Summary: Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: SRPM URL: Description: duecredit is being conceived to address the problem of inadequate citation of scientific software and methods, and limited visibility of donation requests for open-source software. It provides a simple framework (at the moment for Python only) to embed publication or other references in the original code so they are automatically collected and reported to the user at the necessary level of reference detail, i.e. only references for actually used functionality will be presented back if software provides multiple citeable implementations. Fedora Account System Username: ankursinha F30 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635402 F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635483 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645767] New: Review Request: python-duecredit - Automated collection and reporting of citations for used software /methods/datasets
https://bugzilla.redhat.com/show_bug.cgi?id=1645767 Bug ID: 1645767 Summary: Review Request: python-duecredit - Automated collection and reporting of citations for used software/methods/datasets Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: SRPM URL: Description: duecredit is being conceived to address the problem of inadequate citation of scientific software and methods, and limited visibility of donation requests for open-source software. It provides a simple framework (at the moment for Python only) to embed publication or other references in the original code so they are automatically collected and reported to the user at the necessary level of reference detail, i.e. only references for actually used functionality will be presented back if software provides multiple citeable implementations. Fedora Account System Username: ankursinha F30 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635402 F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30635483 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441843] Review Request: linchpin - Ansible based multicloud orchestrator
https://bugzilla.redhat.com/show_bug.cgi?id=1441843
--- Comment #29 from Jonathan Dieter ---
Nicely done, but the requires for the -docs is wrong. linchpin is noarch, so
it should be Requires: %{name} = %{version}-%{release}. As it is, I'm unable
to actually install linchpin-docs.
Also, not a blocker, but the guidelines recommend that documentation be under a
-doc subpackage, not a -docs subpackage.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645766] New: Review Request: python-azure-devtools - Devtools for Azure SDK and CLI for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1645766 Bug ID: 1645766 Summary: Review Request: python-azure-devtools - Devtools for Azure SDK and CLI for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pikachu.2...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://melmorabity.fedorapeople.org/packages/python-azure-devtools/python-azure-devtools.spec SRPM URL: https://melmorabity.fedorapeople.org/packages/python-azure-devtools/python-azure-devtools-1.0.0-1.fc30.src.rpm Description: This package contains tools to aid in developing Python-based Azure code. Fedora Account System Username: melmorabity Notes: * COPR builds for F29, rawhide and EPEL7: https://copr.fedorainfracloud.org/coprs/melmorabity/python-azure/build/818711/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645764] Review Request: grim - Grab images from a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645764 Jan Pokorný changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1645765 --- Comment #1 from Jan Pokorný --- Note that this can be combined with slurp [bug 1645765] and uses the very same style of packaging (reviewer would ideally tackle both at once). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645765] Review Request: slurp - Select a region in a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645765 Jan Pokorný changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1645764 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645765] New: Review Request: slurp - Select a region in a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645765 Bug ID: 1645765 Summary: Review Request: slurp - Select a region in a Wayland compositor Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jpoko...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/~jpokorny/pkgs/slurp/slurp.spec SRPM URL: https://fedorapeople.org/~jpokorny/pkgs/slurp/slurp-0.0.1-1.20181024git0dbd039.fc30.src.rpm Fedora Account System Username: jpokorny Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30634998 Note that this is mostly helpful in combination with grim [bug 1645764] and uses the very same style of packaging (reviewer would ideally tackle both at once). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645764] New: Review Request: grim - Grab images from a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645764 Bug ID: 1645764 Summary: Review Request: grim - Grab images from a Wayland compositor Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jpoko...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fedorapeople.org/~jpokorny/pkgs/grim/grim.spec SRPM URL: https://fedorapeople.org/~jpokorny/pkgs/grim/grim-0.0.1-1.20181024git61df6f0.fc30.src.rpm Fedora Account System Username: jpokorny Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30634882 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 --- Comment #10 from Fedora Update System --- python-visionegg-quest-1.1-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c43103b9f7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 --- Comment #9 from Fedora Update System --- python-visionegg-quest-1.1-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f5a8ffb9aa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- python-visionegg-quest-1.1-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2488fa18c6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|CLOSED |POST Resolution|WONTFIX |--- Keywords||Reopened --- Comment #7 from Ankur Sinha (FranciscoD) --- Imported, being built now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141 Bug 1280141 depends on bug 1290995, which changed state. Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm for finding threshold https://bugzilla.redhat.com/show_bug.cgi?id=1290995 What|Removed |Added Status|CLOSED |POST Resolution|WONTFIX |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1641822] Review Request: golang-github-goftp-server - A FTP server framework written in Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1641822
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Ankur Sinha (FranciscoD) ---
Looks good. One or two tiny issues that you should fix before the import.
Since this is using the golang macros heavily, maybe a note should be made of
the wiki page explaining it---just so that it is easy for anyone looking at the
spec to figure out what they do?
XXX APPROVED XXX
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* Expat License", "Unknown or generated", "Expat
License". 17 files have unknown license. Detailed output of
licensecheck in /home/asinha/1641822-golang-github-goftp-
server/licensecheck.txt
This is OK. It is the Expat license which is identical to the MIT license.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com(golang)
Please check both of these issues.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
golang-github-goftp-server-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/goftp/server/.goipath
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please remove this file if it is unneeded (I'm not sure).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]:
[Bug 1639186] Review Request: libcerf - a library that provides complex error functions
https://bugzilla.redhat.com/show_bug.cgi?id=1639186 --- Comment #9 from Fedora Update System --- libcerf-1.9-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f578cbef6f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1639186] Review Request: libcerf - a library that provides complex error functions
https://bugzilla.redhat.com/show_bug.cgi?id=1639186 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #8 from Fedora Update System --- libcerf-1.9-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-59933f9560 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1515053] Review Request: asv - Airspeed Velocity: A simple Python history benchmarking tool
https://bugzilla.redhat.com/show_bug.cgi?id=1515053 --- Comment #10 from Ankur Sinha (FranciscoD) --- (In reply to Elliott Sales de Andrade from comment #9) > (In reply to Ankur Sinha (FranciscoD) from comment #8) > > > There are a few bundling issues here: > > > > - I'm not sure whether the various JS libraries that you're including can be > > bundled. The guidelines here say they must be packaged separately too: > > > > https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft > > Unfortunately, the JS ecosystem never really seemed to have taken off as far > as packages go... As you can see that guideline has been a draft for 10 > years. Yes, I understand that, but it still is bundling. Maybe it'll be worth quickly checking up on the devel list to see how this should be handled? > > > - extern/asizeof is part of Pympler which is in Fedora. So that should be > > used > > instead of the bundled copy: > > https://src.fedoraproject.org/rpms/python-Pympler > > It's a bundled library in pympler too. Ugh. This shouldn't be, but I reckon it's too tiny a module to call it "bundling", even though it is. > > > - extern/json-minify is bundled too. I expect this needs to be packaged > > separately also as I've not been able to find it in the repos: > > https://pypi.org/project/JSON_minify/ > > I think the package never existed before, so I will see if I can unbundle it > upstream. +1 Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645723] Review Request: slack-cleaner - Bulk delete messages/ files on Slack
https://bugzilla.redhat.com/show_bug.cgi?id=1645723 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
