[Bug 1515053] Review Request: asv - Airspeed Velocity: A simple Python history benchmarking tool
https://bugzilla.redhat.com/show_bug.cgi?id=1515053 --- Comment #11 from Elliott Sales de Andrade --- (In reply to Ankur Sinha (FranciscoD) from comment #10) > (In reply to Elliott Sales de Andrade from comment #9) > > (In reply to Ankur Sinha (FranciscoD) from comment #8) > > > - extern/asizeof is part of Pympler which is in Fedora. So that should be > > > used > > > instead of the bundled copy: > > > https://src.fedoraproject.org/rpms/python-Pympler > > > > It's a bundled library in pympler too. > > Ugh. This shouldn't be, but I reckon it's too tiny a module to call it > "bundling", even though it is. > I don't see why; there's no upstream library. It's basically copied off a cookbook site and I'd consider it at most a copylib. Now with unbundled JSON-minify, jQuery, and flot: Spec URL: https://qulogic.fedorapeople.org/asv.spec SRPM URL: https://qulogic.fedorapeople.org/asv-0.3.1-2.fc28.src.rpm koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30820122 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645329] Review Request: python-fslpy - The FSL Python library
https://bugzilla.redhat.com/show_bug.cgi?id=1645329 --- Comment #12 from Fedora Update System --- python-fsleyes-widgets-0.7.0-3.fc28, python-fslpy-1.12.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645661] Review Request: python-fsleyes-widgets - A collection of custom wx widgets and utilities used by FSLeyes
https://bugzilla.redhat.com/show_bug.cgi?id=1645661 --- Comment #11 from Fedora Update System --- python-fsleyes-widgets-0.7.0-3.fc28, python-fslpy-1.12.0-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 --- Comment #15 from Fedora Update System --- python-visionegg-quest-1.1-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 --- Comment #14 from Fedora Update System --- python-deepdiff-3.3.0-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ecea94ef5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- python-deepdiff-3.3.0-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a892d5f0c8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645661] Review Request: python-fsleyes-widgets - A collection of custom wx widgets and utilities used by FSLeyes
https://bugzilla.redhat.com/show_bug.cgi?id=1645661 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-11 21:14:29 --- Comment #10 from Fedora Update System --- python-fsleyes-widgets-0.7.0-3.fc29, python-fslpy-1.12.0-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645329] Review Request: python-fslpy - The FSL Python library
https://bugzilla.redhat.com/show_bug.cgi?id=1645329 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-11-11 21:14:34 --- Comment #11 from Fedora Update System --- python-fsleyes-widgets-0.7.0-3.fc29, python-fslpy-1.12.0-3.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141 Bug 1280141 depends on bug 1290995, which changed state. Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm for finding threshold https://bugzilla.redhat.com/show_bug.cgi?id=1290995 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for finding threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2018-08-22 03:29:46 |2018-11-11 21:13:41 --- Comment #14 from Fedora Update System --- python-visionegg-quest-1.1-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645172] Review Request: firejail - Linux namespaces sandbox program
https://bugzilla.redhat.com/show_bug.cgi?id=1645172
--- Comment #7 from Jaroslav Škarvada ---
(In reply to Ondrej Dubaj from comment #4)
> Bugs in spec file fixed, but must use %attr. Without it I cannot build rpm
> package.
It works for me without %attr by just using:
chmod 0755 %{buildroot}%{_bindir}/%{name}
in the %install phase.
But AFAIK firejail is SUID program, so if you remove SUID bit (either with the
attr or chmod), it will not work. What build error you encountered? I built it
OK, then:
$ rpmls ./firejail-0.9.56-2.fc27.x86_64.rpm | grep /usr/bin/firejail
-rwsr-xr-x /usr/bin/firejail
Note the 's' bit, it's for SUID.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645172] Review Request: firejail - Linux namespaces sandbox program
https://bugzilla.redhat.com/show_bug.cgi?id=1645172
--- Comment #6 from Jaroslav Škarvada ---
Please just use:
%make_build
not '%make_build %{?_smp_mflags -j3}'
You can check what the macros finally expand to by using the 'rpm --eval
MACRO', e.g. on my system:
$ rpm --eval %make_build
/usr/bin/make -O -j3
The %make_build is defined as '%{__make} %{_make_output_sync} %{?_smp_mflags}'
which dynamically expands according to available cores.
With the '%{?_smp_mflags -j3}' the last -j3 (everything after the space) is
IMHO ignored.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645172] Review Request: firejail - Linux namespaces sandbox program
https://bugzilla.redhat.com/show_bug.cgi?id=1645172 --- Comment #5 from Jaroslav Škarvada --- (In reply to Ondrej Dubaj from comment #4) > Bugs in spec file fixed, but must use %attr. Without it I cannot build rpm > package. > > Spec URL: https://github.com/odubaj/firejail/blob/master/firejail.spec > SRPM URL: > https://github.com/odubaj/firejail/blob/master/firejail-0.9.56-2.fc28.src.rpm > Description: Firejail is a SUID sandbox program that reduces the risk of > security > breaches by restricting the running environment of untrusted applications > using Linux namespaces. It includes a sandbox profile for Mozilla Firefox. > Fedora Account System Username: odubaj Next time please use link to raw, i.e.: https://raw.githubusercontent.com/odubaj/firejail/master/firejail.spec for the spec and similarlry for the srpm. The command: wget 'https://raw.githubusercontent.com/odubaj/firejail/master/firejail.spec' should return the file not HTML page as it do with the links you provided. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648728] Review Request: python-progressbar2 - A Progressbar library to provide visual progress to long running operations
https://bugzilla.redhat.com/show_bug.cgi?id=1648728 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-progressbar2 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648728] New: Review Request: python-progressbar2 - A Progressbar library to provide visual progress to long running operations
https://bugzilla.redhat.com/show_bug.cgi?id=1648728 Bug ID: 1648728 Summary: Review Request: python-progressbar2 - A Progressbar library to provide visual progress to long running operations Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ankursinha.fedorapeople.org/python-progressbar2/python-progressbar2.spec SRPM URL: https://ankursinha.fedorapeople.org/python-progressbar2/python-progressbar2-3.38.0-1.fc29.src.rpm Description: A text progress bar is typically used to display the progress of a long running operation, providing a visual cue that processing is underway. The ProgressBar class manages the current progress, and the format of the line is given by a number of widgets. A widget is an object that may display differently depending on the state of the progress bar. There are many types of widgets: - AbsoluteETA - AdaptiveETA - AdaptiveTransferSpeed - AnimatedMarker - Bar - BouncingBar - Counter - CurrentTime - DataSize - DynamicMessage - ETA - FileTransferSpeed - FormatCustomText - FormatLabel - Percentage - ReverseBar - RotatingMarker - SimpleProgress - Timer The progressbar module is very easy to use, yet very powerful. It will also automatically enable features like auto-resizing when the system supports it.} Fedora Account System Username: ankursinha Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30812638 F29 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30812833 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1646795] Review Request: linux-system-roles - Set of interfaces for unified system management
https://bugzilla.redhat.com/show_bug.cgi?id=1646795 --- Comment #5 from Michael DePaulo --- I thought that %doc & %license only copy files when you specify relative paths. But these are absolute paths, it doesn't copy them, correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648709] Review Request: python-indexed_gzip - Fast random access of gzip files in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1648709 Ankur Sinha (FranciscoD) changed: What|Removed |Added Blocks||1276941 (fedora-neuro) Alias||python-indexed_gzip Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1276941 [Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648709] New: Review Request: python-indexed_gzip - Fast random access of gzip files in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1648709 Bug ID: 1648709 Summary: Review Request: python-indexed_gzip - Fast random access of gzip files in Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sanjay.an...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ankursinha.fedorapeople.org/python-indexed_gzip/python-indexed_gzip.spec SRPM URL: https://ankursinha.fedorapeople.org/python-indexed_gzip/python-indexed_gzip-0.8.7-1.fc29.src.rpm Description: The indexed_gzip project is a Python extension which aims to provide a drop-in replacement for the built-in Python gzip.GzipFile class, the IndexedGzipFile. indexed_gzip was written to allow fast random access of compressed NIFTI image files (for which GZIP is the de-facto compression standard), but will work with any GZIP file. indexed_gzip is easy to use with nibabel. The standard gzip.GzipFile class exposes a random access-like interface (via its seek and read methods), but every time you seek to a new point in the uncompressed data stream, the GzipFile instance has to start decompressing from the beginning of the file, until it reaches the requested location. An IndexedGzipFile instance gets around this performance limitation by building an index, which contains *seek points*, mappings between corresponding locations in the compressed and uncompressed data streams. Each seek point is accompanied by a chunk (32KB) of uncompressed data which is used to initialise the decompression algorithm, allowing us to start reading from any seek point. If the index is built with a seek point spacing of 1MB, we only have to decompress (on average) 512KB of data to read from any location in the file. Fedora Account System Username: ankursinha Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=30810729 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #14 from Ankur Sinha (FranciscoD) --- (In reply to Marcel Plch from comment #3) > Note that I am not a packager yet and this is an informal review. > - Thanks for you review too, Marcel. If I can help you become a package maintainer (assuming that's why you did the informal review), please do let me know. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #13 from Ankur Sinha (FranciscoD) --- Thank you for the review, Athmane. SCM requested: https://pagure.io/releng/fedora-scm-requests/issue/8802 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1646795] Review Request: linux-system-roles - Set of interfaces for unified system management
https://bugzilla.redhat.com/show_bug.cgi?id=1646795
--- Comment #4 from Robert-André Mauchin ---
%doc copies file to /usr/share/doc/%{name}, %license to
/usr/share/licenses/%{name}
If you %doc or %license different files with the same name, they'll be copied
to /usr/share/doc/%{name} or /usr/share/licenses/%{name} but each new files
will overwrite the previous one since they have the same name.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 --- Comment #11 from Fedora Update System --- python-deepdiff-3.3.0-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a892d5f0c8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 --- Comment #12 from Fedora Update System --- python-deepdiff-3.3.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ecea94ef5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1646795] Review Request: linux-system-roles - Set of interfaces for unified system management
https://bugzilla.redhat.com/show_bug.cgi?id=1646795
--- Comment #3 from Michael DePaulo ---
WRT the entire command by Robert-André Mauchin:
Overwriting them? I do not think we are. Are you saying that RPM installs them
twice? `rpm -qlp` & `rpm -ql` list them once.
I am open to the idea of symlinking them, but I am under the impression that we
need to keep the entire per-role file/folder structure intact under
{_datadir}/ansible/roles/ to conform to Ansible standards, including the
licenses and docs. I would think the link would be under %{_pkgdocdir} and
would point to the path under %{_datadir} .
Granted, we are getting warnings like:
warning: File listed twice:
/usr/share/ansible/roles/linux-system-roles.kdump/COPYING
I asked on #fedora-devel and was told this is the best approach given the
circumstances. These occur because we include the entire directories like:
%{_datadir}/ansible/roles/%{roleprefix}kdump
I am OK with doing the work to specify the files individually, but I thought it
would be better to include the entire dir though. Since the dir belongs to the
package really.
Thank you for reviewing,
-Mike
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 Athmane Madjoudj changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #12 from Athmane Madjoudj --- (In reply to Marcel Plch from comment #3) <...snip...> > = SHOULD items = > > Generic: > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. Looks good, license included in the tarball. <...snip...> > [!]: Latest version is packaged. Looks good <...snip...> > [!]: %check is present and all tests pass. It's there and passes. ( check https://kojipkgs.fedoraproject.org//work/tasks/8868/30808868/build.log) <...snip...> Build OK: https://koji.fedoraproject.org/koji/taskinfo?taskID=30808867 === Result: PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 --- Comment #10 from Fedora Update System --- python-deepdiff-3.3.0-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a892d5f0c8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1631987] Review Request: python-deepdiff - Deep Difference and search of any Python object/data
https://bugzilla.redhat.com/show_bug.cgi?id=1631987 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- python-deepdiff-3.3.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ecea94ef5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1648595 --- Comment #4 from Manas Mangaonkar (Pac23) --- (In reply to Robert-André Mauchin from comment #3) > You're supposed to fill the [ ] of fedora-review. > > I don't understand what's wrong with the current description. Noted! Maybe a link to the upstream repo doc that goes in more detail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648584] Review Request: golang-github-dgryski-bitstream - Read and write bits from io.Reader and io.Writer streams
https://bugzilla.redhat.com/show_bug.cgi?id=1648584 --- Comment #3 from Manas Mangaonkar (Pac23) --- (In reply to Robert-André Mauchin from comment #2) > There's no typo, it should be golang-github-dgryski-bitstream, not > golang-github-dgryski-go-bitstream yes that's what i meant by the typo. the go shouldn't be there.My bad on the wording and sentence construction. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648584] Review Request: golang-github-dgryski-bitstream - Read and write bits from io.Reader and io.Writer streams
https://bugzilla.redhat.com/show_bug.cgi?id=1648584 --- Comment #2 from Robert-André Mauchin --- There's no typo, it should be golang-github-dgryski-bitstream, not golang-github-dgryski-go-bitstream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1648595 --- Comment #3 from Robert-André Mauchin --- You're supposed to fill the [ ] of fedora-review. I don't understand what's wrong with the current description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645764] Review Request: grim - Grab images from a Wayland compositor
https://bugzilla.redhat.com/show_bug.cgi?id=1645764 --- Comment #5 from Till Hofmann --- > Issues: > === > - Upstream files are not properly licensed, most (if not all) files are > missing > license headers. This should at least be reported to upstream. Have you contacted upstream about the license? Even though they intend to distribute with the MIT license, their files are not properly licensed. This should be fixed upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1509679 --- Comment #20 from Till Hofmann --- Thank you again for your detailed comments! As you suggested, I removed *.md5 and *.map files and I ditched the shebang scriptlet -- I thought the mangler would eventually fail instead of fixing shebangs, but I think I confused that with unversioned python shebangs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1645913] Review Request: luxcorerender - LuxCore Renderer, an unbiased rendering system
https://bugzilla.redhat.com/show_bug.cgi?id=1645913 --- Comment #6 from Mukundan Ragavan --- Rest of the review. = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock /fedora-rawhide-x86_64/root/builddir/build/BUILD/LuxCore- luxcorerender_v2.1beta1' returned non-zero exit status -15 ---> License is correct. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build-id/81(brlapi, linux-atm, libxml2, glibc, sudo, qt5-qtquickcontrols, vlc-core, NetworkManager-vpnc, python3-libs, octave, redland, ruby-libs, gimp), /usr/lib/.build-id/55(xfce4-session, iproute, libxcb, ilmbase, python2-lxml, libreoffice-core, gimp, open-vm-tools-desktop, glibc, gcc-gfortran, python3-qt5-base, gstreamer1-plugins-ugly-free, strongswan, libkate, ruby-libs, iptables, pciutils-libs, vlc-core, GraphicsMagick, libcom_err, NetworkManager, util-linux, ocl-icd, grilo, ghostscript, minicom, python3-scipy), /usr/lib/.build-id(qemu- ui-gtk, cups-client, efivar-libs, rsyslog, qemu-block-gluster, rpm- plugin-selinux, python3-qt5-webkit, libimagequant, giflib, libreoffice-graphicfilter, trousers, libdb-utils, xorg-x11-font-utils, OpenEXR-libs, libcom_err, libseccomp, p11-kit, libabw, gtkspell, libvirt-daemon-driver-storage-iscsi, libmodman, parted, libdvdread, perl-version, zstd, bluez-libs, libwebp, libxslt, system-config- printer-udev, perl-Encode, libverto-libev, python2-cryptography, libevdev, libgpg-error, lvm2-libs, perl-Digest-SHA, perl-Params- Classify, libsodium, python3-unbound, libzstd, gtk-murrine-engine, lua-lpeg, symlinks, python3-simplejson, libcdr, e2fsprogs-libs, pulseaudio-libs, lcms2, python3-Bottleneck, qemu-guest-agent, annobin, ntfs-3g, libxcb, libyubikey, python3-pycurl, openconnect, xcb-util- keysyms, m4, libgphoto2, xcb-util, libwmf-lite, xfce4-pulseaudio- plugin, pulseaudio-utils, perl-Sub-Identify, llvm5.0-libs, perl- PerlIO-utf8_strict, libeot, ImageMagick-c++, systemd-bootchart, uniconvertor, u2f-hidraw-policy, perl-JSON-XS, texlive-pdftex, perl- Ref-Util-XS, perl-Time-Piece, dbusmenu-qt, ncurses-libs, libidn2, ldns, thunar-volman, xorg-x11-xkb-utils, NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, sane-backends-drivers-cameras, python3-hawkey, libwpd, libdc1394, libvirt-daemon-driver-qemu, qemu- block-ssh, libwps, gssdp, libacl, pulseaudio-libs-glib2, policycoreutils, mcelog, libgdiplus, pptp, sane-backends-drivers- scanners, libXxf86misc, foomatic, texlive-dvips, python3-reportlab, libpath_utils, rpm-build, libvirt-daemon-driver-storage-sheepdog, libglvnd-gles, python3-audit, redhat-lsb-core, libmicrodns, freeglut, gstreamer1, python3-statsmodels, gmime30, dbus-libs, libreoffice-gtk3, libreoffice-gtk2, cairo-gobject, python3-matplotlib-tk, libclastfm, gutenprint, openal-soft, usermode, xarchiver, qpdf-libs, linux-atm- libs, libedit, openssh, openssl, python3-cairo, python2-libdnf, accountsservice, isl, ImageMagick, gssproxy, mesa-libGLU, libatomic_ops, clang6.0-libs, libmpcdec, rubygem-io-console, geany, libyui-ncurses, libvirt-daemon-driver-interface, NetworkManager, libkate, liblangtag, python3-gmpy2, NetworkManager-l2tp-gnome, libdatrie, setuptool, guile, gl2ps, pcre-utf16, tree, pipewire, glusterfs-libs, gnupg, libnsl2, xfsprogs, authselect, libcroco, texlive-bibtex, xfce4-dict, qt5-qtsensors, NetworkManager-iodine, spice-server, NetworkManager-fortisslvpn-gnome, plymouth-plugin-label, colord-libs, aalib-libs, libcddb, totem-pl-parser, gpgmepp, gvnc, hypervfcopyd, cronie, libexttextcat, qt5-qtquickcontrols, gsl, nettle, libcacard, elfutils, colord, libpipeline, pkcs11-helper, gtk-sharp2, network-scripts, findutils, popt, python2-xpyb, qt5-qtx11extras, libraw1394, lm_sensors, gcc-c++, python3-dbus, iproute-tc, libupnp, spice-glib, woff2, python2-numpy, patch, sqlite-libs, lttng-ust, enchant, libXxf86dga, python2-smartcols, xdg-user-dirs-gtk, libwayland-client, pinentry-gnome3, libipt, mdadm, xl2tpd, device- mapper, libXtst, irqbalance, GeoIP, perl-Class-XSAccessor, GraphicsMagick, portaudio, libXrandr, newt, liba52, hplip, crda,
[Bug 1645913] Review Request: luxcorerender - LuxCore Renderer, an unbiased rendering system
https://bugzilla.redhat.com/show_bug.cgi?id=1645913 --- Comment #5 from Mukundan Ragavan --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ---> Some provides are missing. $ dnf install luxcorerender-2.1-0.1.beta1.fc30.x86_64.rpm luxcorerender-core-2.1-0.1.beta1.fc30.x86_64.rpm luxcorerender-libs-2.1-0.1.beta1.fc30.x86_64.rpm Last metadata expiration check: 0:01:08 ago on Sun 11 Nov 2018 07:23:36 AM EST. Error: Problem 1: conflicting requests - nothing provides luxcorerender-lib(x86-64) = 2.1-0.1.beta1.fc30 needed by luxcorerender-core-2.1-0.1.beta1.fc30.x86_64 Problem 2: package luxcorerender-2.1-0.1.beta1.fc30.x86_64 requires luxcorerender-core = 2.1-0.1.beta1.fc30, but none of the providers can be installed - conflicting requests - nothing provides luxcorerender-lib(x86-64) = 2.1-0.1.beta1.fc30 needed by luxcorerender-core-2.1-0.1.beta1.fc30.x86_64 Please correct this. - Header files in -devel subpackage, if present. Note: luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/CovarianceMatrix.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/DeepImage.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/Denoiser.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/DenoisingUnit.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/IDenoiser.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/MultiscaleDenoiser.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/SamplesAccumulator.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/bcd-1.1/include/bcd/core/SpikeRemovalFilter.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Cholesky/LDLT.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Cholesky/LLT.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/Assign.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/AssignEvaluator.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/Block.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/BooleanRedux.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/CommaInitializer.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/CoreEvaluators.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/CwiseBinaryOp.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/CwiseNullaryOp.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/CwiseUnaryOp.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/DenseBase.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/DenseCoeffsBase.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/DenseStorage.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/Diagonal.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/DiagonalMatrix.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/Dot.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/EigenBase.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/Fuzzy.h luxcorerender-debugsource : /usr/src/debug/luxcorerender-2.1-0.1.beta1.fc30.x86_64/deps/eigen-3.3.4/Eigen/src/Core/GeneralProduct.h luxcorerender-debugsource :
[Bug 1648584] Review Request: golang-github-dgryski-bitstream - Read and write bits from io.Reader and io.Writer streams
https://bugzilla.redhat.com/show_bug.cgi?id=1648584 Manas Mangaonkar (Pac23) changed: What|Removed |Added CC||manasmangaon...@gmail.com --- Comment #1 from Manas Mangaonkar (Pac23) --- Not a official Packager yet,working towards it.Total Noob Specfile has a typo in its name,preventing a proper review by the fedora-review tool(states no spec file found).I think this is the reason. instead of golang-github-dgryski-bitsrteam.spec it is golang-github-dgryski-go-bitstream.spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #11 from Ankur Sinha (FranciscoD) --- Great. Please post when you've done a full review (and make a note of it so that we can show it to the sponsors). In the meantime, please check new packages against rawhide, not a stable release---it is not neccessary to make new packages available to stable releases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #10 from Manas Mangaonkar (Pac23) --- (In reply to Ankur Sinha (FranciscoD) from comment #8) > (In reply to Manas Mangaonkar (Pac23) from comment #7) > > I am not a official Packager yet,this is a unofficial review. > > --- > > > > > > Mock build failed on two different machines,config error stating fc28 > > > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > > Config(fedora-28-x86_64) > > Manas, I'm afraid that's not sufficient to be called a review. You must at > least investigate the build logs and point out what the error is. > > > In this case, I can guess what it is. it is that duecredit and grabbit are > in testing and therefore not present in the stable repos. So, the package > will build correctly in rawhide but will need build root overrides for the > stable releases. > Please check the build log to confirm if this is the case :) > > More information here: > https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter- > dependent_packages Yes packages(grabbit & duecredit) Are missing. Will be detailed in my next review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #9 from Manas Mangaonkar (Pac23) --- (In reply to Ankur Sinha (FranciscoD) from comment #8) > (In reply to Manas Mangaonkar (Pac23) from comment #7) > > I am not a official Packager yet,this is a unofficial review. > > --- > > > > > > Mock build failed on two different machines,config error stating fc28 > > > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > > Config(fedora-28-x86_64) > > Manas, I'm afraid that's not sufficient to be called a review. You must at > least investigate the build logs and point out what the error is. > > > In this case, I can guess what it is. it is that duecredit and grabbit are > in testing and therefore not present in the stable repos. So, the package > will build correctly in rawhide but will need build root overrides for the > stable releases. > Please check the build log to confirm if this is the case :) > > More information here: > https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter- > dependent_packages Yes packages(grabbit & duecredit) Are missing. Will be detailed in my next review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1509679 --- Comment #19 from Jan Pokorný --- Hmm, just dropping *.md5 and *.map will save some 8 MB in -doc-devel without any change in usability. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1509679] Review Request: rofi - A window switcher, application launcher and dmenu replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1509679
--- Comment #18 from Jan Pokorný ---
> For the sake of completeness, I'd suggest:
>
> s#/usr/bin/${interpreter}#%{_bindir}/${interpreter}#
>
> but is not a blocker here (note that possibly python* dealing in the same
> location in the spec file is merely an overapproximation, so no crossing
> into Python specific guidelines takes place, I'd suggest dropping those
> mentions, actually).
Actually, ditching that handling altogether will make the implicit
rpm scripts do the Right Thing:
> + /usr/lib/rpm/redhat/brp-mangle-shebangs
> mangling shebang in /usr/bin/rofi-sensible-terminal from /usr/bin/env bash to
> #!/usr/bin/bash
> mangling shebang in /usr/bin/rofi-theme-selector from /usr/bin/env bash to
> #!/usr/bin/bash
so best to just rely on that.
* * *
Also have noticed that there's likely no good reason to ship *.md5 files
in -devel-doc (my understanding is that it tells doxygen which source
got updated, and that's not needed here, since that documentation is not
to be regenerated directly at one's machines at that system location).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1546459] Review Request: svgo-inkscape - Extension to optimize SVG files for Inkscape
https://bugzilla.redhat.com/show_bug.cgi?id=1546459 Luya Tshimbalanga changed: What|Removed |Added Depends On||1648629 --- Comment #8 from Luya Tshimbalanga --- Bug filed. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1648629 [Bug 1648629] Unable to install svgo-inkscape due to conflict -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1647803] Review Request: vdr-osd2web - VDR skin interface for the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1647803 MartinKG changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2018-11-11 03:40:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1648595 --- Comment #2 from Manas Mangaonkar (Pac23) --- > Package builds fine,Please add a description in the readme or add a link to > some sort of in detailed readme/man. * in the spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648595] Review Request: golang-github-pkg-term - Manages POSIX terminals
https://bugzilla.redhat.com/show_bug.cgi?id=1648595 Manas Mangaonkar (Pac23) changed: What|Removed |Added CC||manasmangaon...@gmail.com --- Comment #1 from Manas Mangaonkar (Pac23) --- Not a official Packager yet ! This is a unofficial review Package builds fine,Please add a description in the readme or add a link to some sort of in detailed readme/man. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 2-clause "Simplified" License", "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /root /golang-gb/golang-github-pkg-term/licensecheck.txt [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gocode/src, /usr/share/gocode [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src/github.com/pkg(golang-github-pkg-profile-devel, golang-github-pkg-errors-devel, golang-github-pkg-sftp-devel, golang- github-pkg-xattr-devel), /usr/share/gocode/src/github.com(golang- github-peterbourgon-diskv-devel, golang-github-aead-chacha20-devel, golang-github-DataDog-datadog-go-devel, golang-github-git-lfs-netrc- devel, golang-github-shurcool-httpfs-devel, golang-github-ncw-swift- devel, golang-github-karlseguin-expect-devel, golang-github-pquerna- cachecontrol-devel, golang-github-nwaples-rardecode-devel, golang- github-akrennmair-gopcap-devel, golang-github-marstr-randname-devel, golang-github-dvsekhvalnov-jose2go-devel, golang-github-coreos-go- oidc-devel, golang-github-prometheus-procfs-devel, golang-github- dustin-go-humanize-devel, golang-github-pelletier-go-buffruneio-devel, golang-github-thejerf-suture-devel, golang-github-gdamore-encoding- devel, golang-github-zyedidia-pty-devel, golang-github-gregjones- httpcache-devel, golang-github-SAP-go-hdb-devel, golang-github-chzyer- logex-devel, golang-github-bmizerany-perks-devel, golang-github-aws- aws-sdk-go-devel, golang-github-gorilla-websocket-devel, golang- github-yuin-gopher-lua-devel, golang-github-shurcool-home-devel, golang-github-pkg-xattr-devel, golang-github-gliderlabs-ssh-devel, glide-devel, golang-github-pengsrc-shared-devel, golang-github-petar- GoLLRB-devel, golang-github-lucasb-eyer-colorful-devel, golang-github- vividcortex-ewma-devel, golang-github-hashicorp-memberlist-devel, golang-github-mattn-go-runewidth-devel, golang-github-docker-go-devel, golang-github-miekg-pkcs11-devel, golang-github-fatih-color-devel, golang-github-mitchellh-reflectwalk-devel, golang-github-go-ldap-ldap- devel, golang-github-zyedidia-poller-devel, golang-github-bradfitz- gomemcache-devel, golang-github-shurcool-issues-devel, golang-github- cheggaaa-pb-devel, golang-github-mdlayher-wifi-devel, golang-github- nwidger-jsoncolor-devel, golang-github-shopspring-decimal-devel, golang-github-circonus-labs-circonusllhist-devel, golang-github-calmh- du-devel, golang-github-ncw-dropbox-sdk-unofficial-devel, golang- github-coreos-go-iptables-devel, golang-github-shurcool-reactions- devel, golang-github-facebookgo-atomicfile-devel, golang-github- gorilla-context-devel, golang-github-data-dog-txdb-devel, golang- github-jinzhu-gorm-devel, golang-github-git-lfs-devel, golang-github- coreos-go-log-devel, golang-github-sevlyar-daemon-devel, golang- github-google-cmp-devel, golang-github-coreos-pkg-devel, golang- github-azure-autorest-devel, golang-github-xlab-handysort-devel, golang-github-kylelemons-godebug-devel, golang-github-emicklei-go- restful-devel, golang-github-xanzy-ssh-agent-devel, golang-github- mreiferson-go-httpclient-devel, golang-github-shurcool-highlight- devel, golang-github-jedisct1-dnsstamps-devel, golang-github-shirou- gopsutil-devel, golang-github-hashicorp-go-immutable-radix-devel, golang-github-klauspost-compress-devel, golang-github-AdRoll-goamz- devel, golang-github-docker-libtrust-devel, golang-github-jessevdk-go- flags-devel, golang-github-beevik-ntp-devel, golang-github-tarm- serial-devel, golang-github-docker-spdystream-devel, golang-github- hashicorp-scada-client-devel,
[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS
https://bugzilla.redhat.com/show_bug.cgi?id=1534067 --- Comment #8 from Ankur Sinha (FranciscoD) --- (In reply to Manas Mangaonkar (Pac23) from comment #7) > I am not a official Packager yet,this is a unofficial review. > --- > > > Mock build failed on two different machines,config error stating fc28 > > ERROR: Exception(/root/python-pybids-0.6.5-1.gite35ced6.fc29.src.rpm) > Config(fedora-28-x86_64) Manas, I'm afraid that's not sufficient to be called a review. You must at least investigate the build logs and point out what the error is. In this case, I can guess what it is. it is that duecredit and grabbit are in testing and therefore not present in the stable repos. So, the package will build correctly in rawhide but will need build root overrides for the stable releases. Please check the build log to confirm if this is the case :) More information here: https://fedoraproject.org/wiki/Package_update_HOWTO#Updating_inter-dependent_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
