[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1655421 --- Comment #38 from Fedora Update System --- hw-probe-1.4-11.el6, hwinfo-21.47-6.el6, libx86emu-1.11-7.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-353038099d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1655421 --- Comment #37 from Fedora Update System --- hw-probe-1.4-11.el7, hwinfo-21.47-6.el7, libx86emu-1.11-7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-762de57dfe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1657965] Review Request: python-kadmin - Python module for kerberos admin (kadm5)
https://bugzilla.redhat.com/show_bug.cgi?id=1657965 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-12-21 05:52:42 --- Comment #10 from Fedora Update System --- python-kadmin-0.1.2-1.20181207git94e50ed.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1656628] Review Request: python-readme-renderer - Safely render long_description/README files in Warehouse
https://bugzilla.redhat.com/show_bug.cgi?id=1656628 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- python-readme-renderer-24.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f547b44c30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1655421 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #36 from Fedora Update System --- hw-probe-1.4-11.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-55896bafb9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1333529] Review Request: opa-fm - OPA Fabric Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1333529 Honggang LI changed: What|Removed |Added Assignee|mschm...@redhat.com |ho...@redhat.com --- Comment #15 from Honggang LI --- I'm taking over this review request. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/Carla -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #11 from MartinKG --- Many thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Antonio Trande --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #9 from MartinKG --- This time, I transfer the data without bumping up the version. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/Carla.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/Carla-2.0.0-0.4.20181212git51f2073.fc29.src.rpm %changelog * Thu Dec 20 2018 Martin Gansser - 2.0.0-0.4.20181212git51f2073 - Add lv2-carla subpkg - Take ownership of lv2/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #8 from Antonio Trande --- 'lv2-carla', not 'carla-lv2'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814 --- Comment #7 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/Carla.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/Carla-2.0.0-0.4.20181212git51f2073.fc29.src.rpm %changelog * Thu Dec 20 2018 Martin Gansser - 2.0.0-0.4.20181212git51f2073 - Add lv2 subpkg - Take ownership of lv2/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1255973] Review Request: libndn-cxx - C++ library, implementing Named Data Networking (NDN) primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1255973 Antonio Trande changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NOTABUG Last Closed||2018-12-20 19:50:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1419547] Review Request: xcrysden - a crystalline and molecular structure render program,
https://bugzilla.redhat.com/show_bug.cgi?id=1419547 Antonio Trande changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2018-12-20 19:48:37 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660814] Review Request: Carla - Audio plugin host
https://bugzilla.redhat.com/show_bug.cgi?id=1660814
--- Comment #6 from Antonio Trande ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
== Issues==
- As i said before, to own all files and directories inside a "directory" is
sufficient using this form
%{_libdir}/directory/
so for the 'vst' sub-package is
%{_libdir}/vst/
- I have just seen that '%{_libdir}/lv2' is a directory owned by the 'lv2-*'
packages. In this case, '%{_libdir}/lv2' can be co-owned in this way:
%dir %{_libdir}/lv2
%{_libdir}/lv2/carla.lv2/
Following the name used for packaging the "lv2" files, i suggest you to create
a "lv2-carla" sub-package.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "zlib/libpng license", "GPL (v2 or later)", "GNU Lesser General
Public License", "Unknown or generated", "GNU Lesser General Public
License (v2 or later)", "GNU Lesser General Public License (v2.1 or
later)", "ISC License", "*No copyright* Public domain", "BSL (v1.0)",
"Expat License", "*No copyright* GNU Lesser General Public License
(v2.1 or later)", "*No copyright* GPL (v2 or later)", "GPL (v2)", "BSD
2-clause "Simplified" License", "*No copyright* BSD 3-clause "New" or
"Revised" License", "*No copyright* GPL (v2)". 771 files have unknown
license. Detailed output of licensecheck in
/home/sagitter/FedoraReview/1660814-Carla/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib64/vst
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/vst
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/lv2(lv2)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use
[Bug 1360277] Review Request: qt-installer-framework - The Qt Installer Framework
https://bugzilla.redhat.com/show_bug.cgi?id=1360277 sensor@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sensor@gmail.com --- Comment #10 from sensor@gmail.com --- I'm coming. Reached. ~~ SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00839080-qt-installer-framework/qt-installer-framework.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-rawhide-x86_64/00839080-qt-installer-framework/qt-installer-framework-3.0.6-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API
https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #8 from j...@redhat.com --- Daniel, thank you. Just gave it a quick check and mereged it. Updated Links: Spec URL: https://raw.githubusercontent.com/johnkim76/rpmbuild_files/master/SPECS/python-openshift.spec SRPM URL: https://github.com/johnkim76/rpmbuild_files/raw/master/SRPMS/python-openshift-0.8.1-2.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1653209] Review Request: deepin-clone - Disk and partition backup/restore tool
https://bugzilla.redhat.com/show_bug.cgi?id=1653209 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-clone -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1661211] Review Request: json11 - A tiny JSON library for C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1661211 Vitaly Zaitsev changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-12-20 15:56:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1655421 --- Comment #35 from Fedora Update System --- hw-probe-1.4-11.el6 hwinfo-21.47-6.el6 libx86emu-1.11-7.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-353038099d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1655421] Review Request: hw-probe - A tool to check operability of computer hardware
https://bugzilla.redhat.com/show_bug.cgi?id=1655421 --- Comment #34 from Fedora Update System --- hw-probe-1.4-11.el7 hwinfo-21.47-6.el7 libx86emu-1.11-7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-762de57dfe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API
https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #7 from Daniel Mellado --- I've created PR addressing the changes besides the ones from Fabian at https://github.com/johnkim76/rpmbuild_files/pull/3 Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1648728] Review Request: python-progressbar2 - A Progressbar library to provide visual progress to long running operations
https://bugzilla.redhat.com/show_bug.cgi?id=1648728 --- Comment #32 from Petr Viktorin --- I removed the old python-progressbar's Python 3 package on Rawhide. Note: I will have limited access to e-mail until the new year. But if something breaks in Rawhide, hopefully it can wait until January 2. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API
https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #6 from Alfredo Moralejo --- ok, i think we can live with it until it's fixed upstream, could you update the spec with the rest of fixes so that i can re-run fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1083962] Review Request: maxscale - A database-centric proxy that works with MariaDB and MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1083962 Oden Eriksson changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened --- Comment #38 from Oden Eriksson --- Revisiting this after some years and fought a bit with cmake. It doesn't seem to be possible to build it against system pcre2 anymore. They also added mariadb-connector-c, jansson, libmicrohttpd that also builds statically. Quite ugly. It will build on latest fedora though but I would prefer to unbundle pcre2, added mariadb-connector-c, jansson and libmicrohttpd somehow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1659833] Review Request: python-notify2 - Python interface to DBus notifications
https://bugzilla.redhat.com/show_bug.cgi?id=1659833
--- Comment #4 from Fabio Valentini ---
(In reply to Neal Gompa from comment #3)
> (In reply to Fabio Valentini from comment #2)
> > 1) You can use %{pypi_source} for the value of the Source0: tag.
> >
>
> I'm not a fan of those types of URL pre-fillers, so I avoided it.
I usually agree, but the pypi source tag is really nice.
But it's your decision if you want to use it or not.
> > 2) Please fix the description - right now, it's a truncated, ill-formatted,
> > plain-text version of the rST README file.
> >
>
> Working on it.
Thanks!
> > 3) LICENSE and docs/license.rst contain the same text, you can drop the
> > second one from the %files section.
> >
> > 4) Have you opened a bug against python-dbus regarding the missing provides?
> >
>
> I may file a pull request to fix it, since dbus-python is built properly in
> Mageia.
+1
> > 5) There's a small test suite shipped with the package, did you try running
> > it?
> >
>
> I did not because I don't know what satisfies "from gi.repository import
> GdkPixbuf" used in the tests. It didn't work when I tried it in mock...
It's provided by python3-gobject-base, but I assume you'd also need to have
gtk3 installed for it to actually work.
$ sudo dnf provides
/usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py
(...)
python3-gobject-base-3.30.4-1.fc29.x86_64 : Python 3 bindings for GObject
: Introspection base package
Repo: updates
Matched from:
Filename: /usr/lib64/python3.7/site-packages/gi/overrides/GdkPixbuf.py
(...)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1661211] Review Request: json11 - A tiny JSON library for C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1661211 --- Comment #2 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/json11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1661211] Review Request: json11 - A tiny JSON library for C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1661211
Vasiliy Glazov changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Vasiliy Glazov ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 5 files have unknown
license. Detailed output of licensecheck in
/home/vascom/1661211-json11/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
json11-debuginfo , json11-debugsource
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to
[Bug 1661211] Review Request: json11 - A tiny JSON library for C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1661211 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED CC||vasc...@gmail.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1661211] New: Review Request: json11 - A tiny JSON library for C++11
https://bugzilla.redhat.com/show_bug.cgi?id=1661211 Bug ID: 1661211 Summary: Review Request: json11 - A tiny JSON library for C++11 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: vit...@easycoding.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://github.com/EasyCoding/json11/raw/master/json11.spec SRPM URL: https://xvitaly.fedorapeople.org/for-review/json11-1.0.0-1.fc29.src.rpm Description: Json11 is a tiny JSON library for C++11, providing JSON parsing and serialization. Fedora Account System Username: xvitaly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660054] Review Request: reportd - D-Bus interop layer for libreport
https://bugzilla.redhat.com/show_bug.cgi?id=1660054 --- Comment #7 from Ernestas Kulik --- Updated: Spec URL: https://raw.githubusercontent.com/ernestask/rpms/reportd/reportd.spec SRPM URL: https://github.com/ernestask/rpms/raw/reportd/reportd-0.2.1-1.fc29.src.rpm https://koji.fedoraproject.org/koji/taskinfo?taskID=31544378 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1659833] Review Request: python-notify2 - Python interface to DBus notifications
https://bugzilla.redhat.com/show_bug.cgi?id=1659833
--- Comment #3 from Neal Gompa ---
(In reply to Fabio Valentini from comment #2)
> 1) You can use %{pypi_source} for the value of the Source0: tag.
>
I'm not a fan of those types of URL pre-fillers, so I avoided it.
> 2) Please fix the description - right now, it's a truncated, ill-formatted,
> plain-text version of the rST README file.
>
Working on it.
> 3) LICENSE and docs/license.rst contain the same text, you can drop the
> second one from the %files section.
>
> 4) Have you opened a bug against python-dbus regarding the missing provides?
>
I may file a pull request to fix it, since dbus-python is built properly in
Mageia.
> 5) There's a small test suite shipped with the package, did you try running
> it?
>
I did not because I don't know what satisfies "from gi.repository import
GdkPixbuf" used in the tests. It didn't work when I tried it in mock...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1641203] Review Request: freecell-solver - a library for solving some solitaire variants
https://bugzilla.redhat.com/show_bug.cgi?id=1641203 Neal Gompa changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2018-12-20 10:08:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660054] Review Request: reportd - D-Bus interop layer for libreport
https://bugzilla.redhat.com/show_bug.cgi?id=1660054 --- Comment #6 from Ernestas Kulik --- (In reply to Miroslav Suchý from comment #5) > - Header files in -devel subpackage, if present. > Note: reportd-debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/dbus > /report-dbus-generated.h reportd-debugsource : > /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report-daemon.h reportd- > debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report- > service.h reportd-debugsource : > /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report-task.h Those are debugsource packages. Shouldn’t come up after https://pagure.io/FedoraReview/c/d59ddf63c24e9d282029f0c8c352e42284f1fdff. > AutoTools: Obsoleted m4s found > -- > AC_PROG_LIBTOOL found in: reportd-0.2/configure.ac:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1660054] Review Request: reportd - D-Bus interop layer for libreport
https://bugzilla.redhat.com/show_bug.cgi?id=1660054 --- Comment #5 from Miroslav Suchý --- - Header files in -devel subpackage, if present. Note: reportd-debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/dbus /report-dbus-generated.h reportd-debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report-daemon.h reportd- debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report- service.h reportd-debugsource : /usr/src/debug/reportd-0.2-2.fc28.x86_64/service/report-task.h AutoTools: Obsoleted m4s found -- AC_PROG_LIBTOOL found in: reportd-0.2/configure.ac:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1654833] Review Request: python-kubernetes - add python-kuberenetes to EPEL 7
https://bugzilla.redhat.com/show_bug.cgi?id=1654833 Daniel Mellado changed: What|Removed |Added Assignee|dmell...@redhat.com |hgue...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
