[Bug 1643906] Review Request: golang-github-rican7-retry - A simple, stateless, functional mechanism to perform actions repetitively

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1643906

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Elliott Sales de Andrade  ---
APPROVED

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Expat License", "Unknown or generated". 12 files have unknown
 license. Detailed output of licensecheck in
1643906-golang-github-rican7-retry/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com(golang-github-inconshreveable-
 mousetrap-devel, golang-github-davecgh-go-spew-devel, golang, golang-
 github-pelletier-go-toml-devel, golang-github-hashicorp-hcl-devel,
 golang-github-magiconair-properties-devel, golang-github-stretchr-
 testify-devel, golang-github-BurntSushi-toml-devel, golang-gopkg-yaml-
 devel-v2, golang-github-spf13-pflag-devel, golang-github-urfave-cli-
 devel, golang-github-mitchellh-go-homedir-devel, golang-github-kr-fs-
 devel, golang-github-kr-pretty-devel, golang-github-kr-pty-devel,
 golang-github-spf13-cobra-devel, golang-github-peterh-liner-devel,
 golang-github-mattn-go-runewidth-devel, golang-github-pmezard-go-
 difflib-devel, golang-github-spf13-cast-devel, golang-github-kr-text-
 devel, golang-github-pkg-errors-devel, golang-github-blang-semver-
 devel, golang-github-pelletier-go-buffruneio-devel, golang-github-
 spf13-viper-devel, golang-github-olekukonko-ts-devel, golang-github-
 cpuguy83-go-md2man-devel, golang-github-mitchellh-mapstructure-devel,
 golang-github-cheggaaa-pb-devel, golang-github-pkg-sftp-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that 

[Bug 1534567] Review Request: golang-github-spacemonkeygo-openssl - OpenSSL bindings for Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1534567

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||quantum.anal...@gmail.com
   Fixed In Version||golang-github-spacemonkeygo
   ||-openssl-0-0.3.20171219gite
   ||863d83.fc28
 Resolution|--- |CURRENTRELEASE
Last Closed||2019-01-16 07:20:15



--- Comment #6 from Elliott Sales de Andrade  ---
This was built some time ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1512702] Review Request: golang-github-prometheus-node_exporter - Prometheus exporter for hardware and OS metrics exposed by *NIX kernels

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1512702
Bug 1512702 depends on bug 1578564, which changed state.

Bug 1578564 Summary: Review Request: golang-github-mdlayher-wifi - Provides 
access to IEEE 802.11 WiFi device actions and statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1578564

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1578564] Review Request: golang-github-mdlayher-wifi - Provides access to IEEE 802.11 WiFi device actions and statistics

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1578564

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||quantum.anal...@gmail.com
   Fixed In Version||golang-github-mdlayher-wifi
   ||-0-0.1.20180522git17fb838.f
   ||c29
 Resolution|--- |CURRENTRELEASE
Last Closed||2019-01-16 06:52:29



--- Comment #8 from Elliott Sales de Andrade  ---
This is built; please close review requests when they're complete.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1663586] Review Request: python-kaitaistruct - A new way to develop parsers for binary structures

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1663586

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666299] Review Request: python-tomlkit - Style preserving TOML library

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666299

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Elliott Sales de Andrade  ---
APPROVED

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "Expat License". 16 files have unknown
 license. Detailed output of licensecheck in
1666299-python-tomlkit/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve 

[Bug 1666291] Review Request: python-cachy - Simple yet effective caching library

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666291

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Elliott Sales de Andrade  ---
I only have two comments, but this would otherwise be fine, I think:

- You should ask upstream to include the license in their tarball. (It's
  required by the license.)
- There are some optional dependencies that you may want to add; it seems
  that it doesn't get picked up by the dependency generator.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 29 files have unknown license. Detailed
 output of licensecheck in 1666291-python-cachy/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary 

[Bug 1661657] Review Request: helm - A free polyphonic synth with lots of modulation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661657

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #2 from Elliott Sales de Andrade  ---
I think you'll need to unbundle some of these things. For example, the fonts
don't need to be shipped again in this package. And many of the things in the
'other licenses' comment should perhaps also be removed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1663586] Review Request: python-kaitaistruct - A new way to develop parsers for binary structures

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1663586

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
This is probably mostly okay, but the spec and srpm do not match.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295



--- Comment #8 from Fedora Update System  ---
perl-Data-Binary-0.01-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
perl-Data-Binary-0.01-1.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1540833] Review Request: racket - General-purpose programming language

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||quantum.anal...@gmail.com
   Fixed In Version||racket-7.0-2.fc28
   ||racket-7.0-2.fc29
   ||racket-7.0-2.fc30
 Resolution|--- |ERRATA
Last Closed|2018-02-12 13:25:34 |2019-01-16 02:48:32



--- Comment #22 from Elliott Sales de Andrade  ---
This seems to have been built for Fedora 28.

David, please remember to tag your package updates with the relevant bug
reports so that they are closed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662544] Review Request: python-tvb-gdist - Cython interface to geodesic

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662544



--- Comment #15 from Fedora Update System  ---
python-tvb-gdist-1.5.6-3.fc29 has been pushed to the Fedora 29 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1654881] Review Request: golang-rsc-pdf - PDF Reader for Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1654881

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||depar...@redhat.com,
   ||quantum.anal...@gmail.com
  Flags||needinfo?(deparker@redhat.c
   ||om)



--- Comment #6 from Elliott Sales de Andrade  ---
The current golang-x-arch package cannot be installed because this package has
not been built. Are you planning to finish building this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573



--- Comment #6 from Raphael Groner  ---
Maybe fedora-review insists to find any %license entry. We'd have to ask at
packaging committee.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573



--- Comment #5 from Raphael Groner  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: python-aiorpcx.spec should be python-aiorpcX.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name


= MUST items =

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
=> licensecheck.txt is empty?!

[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
=> OK, no license file provided but setup.py mentions MIT.
   https://github.com/kyuupichan/aiorpcX/blob/master/setup.py#L28

[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
=> OK

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
=> See above.

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[?]: Binary eggs must be removed in %prep
 Note: Cannot find any build in BUILD directory (--prebuilt option?)
=> Maybe a bug in f-r?

[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
=> OK, see above

[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that 

[Bug 1662544] Review Request: python-tvb-gdist - Cython interface to geodesic

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662544

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2019-01-16 01:42:33



--- Comment #14 from Fedora Update System  ---
python-tvb-gdist-1.5.6-3.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1130098] Review Request: python-ejson - Extensible json serializer/deserializer library

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1130098

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||quantum.anal...@gmail.com
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2019-01-16 01:32:30



--- Comment #4 from Elliott Sales de Andrade  ---
I think it's time to close this.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1130103] Review Request: blink - Real-time communications client using SIP protocol

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1130103
Bug 1130103 depends on bug 1130098, which changed state.

Bug 1130098 Summary: Review Request: python-ejson - Extensible json 
serializer/deserializer library
https://bugzilla.redhat.com/show_bug.cgi?id=1130098

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1663090] Review Request: direvent - GNU directory event monitoring daemon

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1663090

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #5 from Elliott Sales de Andrade  ---
You should not use a wildcard, but %find_lang:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_handling_locale_files

(Also, the guidelines have moved from the wiki to the above URL.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1636111



--- Comment #33 from Mukundan Ragavan  ---
Matias, one last issue and then I can sponsor you. I apologize for yet another
delay.



[!]: Package should compile and build into binary rpms on all supported
 architectures.

---> https://koji.fedoraproject.org/koji/taskinfo?taskID=32052225


Package does not build ppc and arm. Looking at the build log, checks fail.
please take a look.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1636111



--- Comment #32 from Mukundan Ragavan  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/blacklist.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/cache.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/cache_intern.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/core.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/glyr.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/common/amazon.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/common/google.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/common/mbid_lookup.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/common/musicbrainz.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/common/picsearch.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/intern/generic.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/jsmn/jsmn.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/misc.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/register_plugins.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/stringlib.h
  glyr-debugsource :
  /usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/lib/types.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/src/glyrc/autohelp.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/src/glyrc/colorprint.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/src/glyrc/escape.h
  glyr-debugsource :
 
/usr/src/debug/glyr-1.0.10-10.20180824git618c418e.fc30.x86_64/src/glyrc/update.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in glyr-libs
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

---> all these have been addressed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GNU Lesser General Public License (v3 or later)", "*No
 copyright* GNU Lesser General Public License (v3)", "Expat License",
 "Unknown or generated". 37 files have unknown license. Detailed output
 of licensecheck in

/home/mukundan/nextcloud/open_source_contrib/pkg_reviews/glyr/1636111-glyr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(qemu-ui-
 gtk, cups-client, efivar-libs, rsyslog, lz4-libs, qemu-block-gluster,
 rpm-plugin-selinux, python3-qt5-webkit, libimagequant, giflib,
 libreoffice-graphicfilter, trousers, libdb-utils, xorg-x11-font-utils,
 OpenEXR-libs, libcom_err, libseccomp, p11-kit, libabw, gtkspell,
 libvirt-daemon-driver-storage-iscsi, libmodman, parted, libdvdread,
 zstd, bluez-libs, libwebp, libxslt, system-config-printer-udev, perl-
 Encode, libverto-libev, python2-cryptography, libevdev, libgpg-error,
 lvm2-libs, perl-Digest-SHA, perl-Params-Classify, libsodium,
 python3-unbound, libzstd, gtk-murrine-engine, lua-lpeg, symlinks,
 python3-simplejson, libcdr, e2fsprogs-libs, pulseaudio-libs, lcms2,
 python3-Bottleneck, qemu-guest-agent, annobin, ntfs-3g, libxcb,
 libyubikey, python3-pycurl, openconnect, xcb-util-keysyms, m4,
 libgphoto2, xcb-util, 

[Bug 1666545] New: Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Bug ID: 1666545
   Summary: Review Request: python-qdarkstyle - A dark stylesheet
for Qt applications
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: heg...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora




Spec URL: http://jonny.fedorapeople.org//python-qdarkstyle.spec
SRPM URL: http://jonny.fedorapeople.org//python-qdarkstyle-2.6.5-1.fc29.src.rpm

Description:
A dark stylesheet for Qt applications.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666545

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks||1666513




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666513
[Bug 1666513] nothing provides python3.6dist(qdarkstyle) < 3.0 needed by
electrum-3.2.4-1.fc28.noarch
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666545] Review Request: python-qdarkstyle - A dark stylesheet for Qt applications

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666545



--- Comment #1 from Jonny Heggheim  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=32052203

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666493] New: Review Request: OpenLiberty - Server runtime for Java Developers

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666493

Bug ID: 1666493
   Summary: Review Request: OpenLiberty - Server runtime for Java
Developers
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: michael.zh...@ibm.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://app.box.com/s/9pd6nx4cxsu29r5i41kn3g33x5278nsy
SRPM URL: https://app.box.com/s/hg2zdfcf83j2vlvhrkhes8jsy6y06oag
Description: Open Liberty provides developers with proven Java EE 8 technology
and the latest Eclipse MicroProfile™ capabilities for building microservices.
Fedora Account System Username: zhangm13 - michael.zh...@ibm.com

This will be my first package on Fedora. I am currently looking for a sponsor
to help me package this in the next month.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1663642] Review Request: python-asynctest - Enhance the standard unittest package with features for testing asyncio libraries

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1663642



--- Comment #6 from Carl George  ---
> Why? SPEC must only be UTF-8 encoded, I don't recall any rules against using
> proper quoting characters.

> Why? The changelog entries are not sentences.

I thought these things were in the guidelines somewhere, but I can't find it
now so I must have been mistaken.  My personal preferences aside, keep the
fancy quotes and lowercase if you like.

> My reading of the above is that it's not necessary if subpackage is named
> python3-%{pypi_name}.

"In order to make the switch from Python 2 to Python 3 automatic, all packages
that provide python3-%{srcname} (for any %{srcname}) SHOULD use the
%python_provide macro with the package name" [0]

It currently evaluates to an empty string with a python3-* argument, but in the
future the macro definition will change so that python3-asynctest provides
python-asynctest.  As you can see it is a SHOULD item, so it's not strictly a
blocker, but if you leave it out you are adding to the manual work that must
eventually be done when unversioned python becomes python3 distribution-wide.

> No. All current Fedora releases and EPEL7 have setuptools newer than 30.3.0.
> Also, python3-setuptools is pulled in by python3-devel.

"MUST: All build dependencies must be listed in BuildRequires" [1]

Just because something happens to get installed in the build root doesn't mean
you don't need to list it.  The project's setup.py file imports setuptools, so
it's a build requirement.  You don't have to include the minimum version, but
there is no reason not to since upstream has been courteous enough to mention
it.

Thanks for taking care of the test suite stuff, I'm able to run fedora-review
now.  Please take care of this rpmlint error [2]:

python3-asynctest.noarch: E: summary-too-long C Enhance the standard unittest
package with features for testing asyncio libraries

[0]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_python_provide_macro
[1]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/
[2]:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573



--- Comment #4 from Raphael Groner  ---
Wrong bug referenced, see bug #1659777 instead for the review swap. Sorry for
confusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from Raphael Groner  ---
Thanks. I'll look into your request ASAP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1645294] Review Request: delve - Debugger for Go programming language

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1645294

Derek Parker  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1645294] Review Request: delve - Debugger for Go programming language

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1645294



--- Comment #16 from Derek Parker  ---
I've updated the package with some patches that enable the Delve test suite to
run with all of the symlinkage. These patches will be removed on the next
update once we release Delve 1.2.0.

SPEC:
https://raw.githubusercontent.com/derekparker/delve-fedpkg/v1.1.0-1/delve.spec
SRPM:
https://github.com/derekparker/delve-fedpkg/releases/download/v1.1.0-1/delve-1.1.0-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1652036] Review Request: cockpit-session-recording - Package provides session recording playback in Cockpit

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1652036



--- Comment #2 from Kirill Gliebov  ---
URL:https://github.com/Scribery/cockpit-session-recording
Spec URL: https://sabbaka.fedorapeople.org/cockpit-session-recording.spec
SRPM URL:
https://github.com/Scribery/cockpit-session-recording/releases/download/v1/cockpit-session-recording-1-1.fc28.src.rpm
Source0:
https://github.com/Scribery/cockpit-session-recording/archive/v1.tar.gz
Description: Provides Session Recording module for Cockpit. Provides list of
recorded by tlog terminal sessions from Journal. Allows to play them in a
player with various controls. Shows correlated logs which happened during
session.
Fedora Account System Username: sabbaka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573



--- Comment #2 from Igor Gnatenko  ---
(In reply to Raphael Groner from comment #1)
> Are you interested in a review swap? Maybe you could look into bug #1662573.

reviewed it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #86 from Sergio Monteiro Basto  ---
BTW please review
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/010-linux-4.16-mount-fixes.patch
https://src.fedoraproject.org/rpms/virtualbox-guest-additions/blob/master/f/0001-VBoxServiceAutoMount-Change-Linux-mount-code-to-use-.patch
this last patch, I needed rebase to fit on vbox 6.0

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1659777] Review Request: python-vconnector - VMware vSphere Connector Module for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1659777



--- Comment #3 from Igor Gnatenko  ---
Apart from that, looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1659777] Review Request: python-vconnector - VMware vSphere Connector Module for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1659777

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1659777] Review Request: python-vconnector - VMware vSphere Connector Module for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1659777

Igor Gnatenko  changed:

   What|Removed |Added

 CC||i.gnatenko.br...@gmail.com



--- Comment #2 from Igor Gnatenko  ---
> %?python_enable_dependency_generator
%{?python_enable_dependency_generator}, please.

> %if 0%{?rhel} || 0%{?fedora} < 30
%if %{undefined __pythondist_requires}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1662573] Review Request: python-aiorpcx - Generic async RPC implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1662573

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Are you interested in a review swap? Maybe you could look into bug #1662573.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1665504] Review Request: qt5-qtnetworkauth - Qt5 - NetworkAuth component

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1665504

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Maybe you could look into bug #1563831 for a review swap?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1469767] Review Request: systemd-swap - Creating hybrid swap space from zram swaps, swap files and swap partitions

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1469767



--- Comment #11 from Raphael Groner  ---
Well, as far as I can understand there's nothing to block an official approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1469767] Review Request: systemd-swap - Creating hybrid swap space from zram swaps, swap files and swap partitions

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1469767

Raphael Groner  changed:

   What|Removed |Added

  Flags|needinfo?(pa...@hubbitus.in |
   |fo) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1469767] Review Request: systemd-swap - Creating hybrid swap space from zram swaps, swap files and swap partitions

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1469767

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(bunnyapocalypse@p
   ||rotonmail.com)



--- Comment #10 from Raphael Groner  ---
> I am not yet sponsored as a package maintainer so this is an unofficial 
> review.

FAS says you managed to get sponsored. Maybe you could continue with this
review when I fixed the points mentioned in comment #9?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1481628] Review Request: Qt-SESAM - Super Easy & Secure Authentication Management

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1481628

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2019-01-15 16:30:56



--- Comment #9 from Raphael Groner  ---
Unfortunately, upstream is obviously not interested into packaging (except some
special distributions).
I've to close here then and finally, please feel free to use my work for
another possible request if you think this package is useful in Fedora.
https://github.com/ola-ct/Qt-SESAM/issues/19


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response
should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666293] Review Request: python-pastel - Bring colors to your terminal

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666293

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Are you interested in a review swap? Maybe you could look into bug #1659777.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1665749



--- Comment #2 from Raphael Groner  ---
Are you interested in a review swap? Maybe you could look into bug #1659777.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1665749] Review Request: python-pipreqs - Generate requirements.txt file for any project based on imports

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1665749

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Are you interested in a review swap? Maybe you could look into büg #1659777.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #4 from Fedora Update System  ---
perl-Data-Binary-0.01-1.fc29 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-eb5fbe3e83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295



--- Comment #5 from Fedora Update System  ---
perl-Data-Binary-0.01-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-9bfda02b8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295



--- Comment #6 from Fedora Update System  ---
perl-Data-Binary-0.01-1.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-711319d914

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1645723] Review Request: slack-cleaner - Bulk delete messages/files on Slack

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1645723



--- Comment #5 from Raphael Groner  ---
SPEC: https://raphgro.fedorapeople.org/review/slack/slack-cleaner.spec
SRPM:
https://raphgro.fedorapeople.org/review/slack/slack-cleaner-0.5.0-1.fc29.src.rpm

%changelog
* Tue Jan 15 2019 Raphael Groner <> - 0.5.0-1
- switch to fork from sgratzl
- use rectified summary for description
- split subpackage for python3 modules

Sorry for the delay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1612092] Review Request: mailman3 - The GNU mailing list manager

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1612092



--- Comment #21 from Neal Gompa  ---
Yes, in this circumstance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1612092] Review Request: mailman3 - The GNU mailing list manager

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1612092

Derek Atkins  changed:

   What|Removed |Added

 CC||warl...@mit.edu



--- Comment #20 from Derek Atkins  ---
So for future reference, "next release" here means F30, not F29?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1658707] Review Request: python-confluent-kafka - Confluent's Apache Kafka client for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1658707



--- Comment #12 from Javier Peña  ---
Oh, now I remember why unit tests are disabled. They're absent from the tarball
distribution, I opened
https://github.com/confluentinc/confluent-kafka-python/issues/508 to get it
fixed.

So I can't fix it now, but I'll update it when a new release is available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Data-Binary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295



--- Comment #2 from Paul Howarth  ---
Thanks Jitka, copy and paste error there, will fix on import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1658707] Review Request: python-confluent-kafka - Confluent's Apache Kafka client for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1658707



--- Comment #11 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-confluent-kafka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1659833] Review Request: python-notify2 - Python interface to DBus notifications

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1659833



--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-notify2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661865] Review Request: smc-rachana-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661865



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/smc-rachana-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661869] Review Request: smc-anjalioldlipi-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661869



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/smc-anjalioldlipi-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661866] Review Request: smc-meera-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661866



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/smc-meera-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok

FIX: URL is wrong. It is link to Data-UUID. Please replace it with
https://metacpan.org/release/Data-Binary

Source0 is ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c
  1 perl(base)
  1 perl(Encode)
  1 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.28.1)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Data-Binary-0.01-1.fc30.noarch.rpm | sort | uniq -c
  1 perl(Data::Binary) = 0.01
  1 perl-Data-Binary = 0.01-1.fc30 
Binary provides are Ok.

$ rpmlint ./perl-Data-Binary*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661868] Review Request: smc-dyuthi-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661868



--- Comment #4 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/smc-dyuthi-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661862] Review Request: smc-suruma-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661862



--- Comment #5 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/smc-suruma-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1658707] Review Request: python-confluent-kafka - Confluent's Apache Kafka client for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1658707



--- Comment #10 from Javier Peña  ---
(In reply to Raphael Groner from comment #9)
> APPROVED
> 
> Please reactivate %check. Why did you comment?

I think it was due to the librdkafka version. I'll re-enable before importing.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and testable CLIs

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666306

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1666311




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666311
[Bug 1666311] Review Request: python-cleo - Create beautiful and testable
command-line interfaces
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666311] Review Request: python-cleo - Create beautiful and testable command-line interfaces

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666311

Fabio Valentini  changed:

   What|Removed |Added

 Depends On||1666306, 1666293, 1666294




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666293
[Bug 1666293] Review Request: python-pastel - Bring colors to your terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1666294
[Bug 1666294] Review Request: python-pylev - Liberally licensed, pure Python
Levenshtein implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1666306
[Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and
testable CLIs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666294] Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666294

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1666311




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666311
[Bug 1666311] Review Request: python-cleo - Create beautiful and testable
command-line interfaces
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666293] Review Request: python-pastel - Bring colors to your terminal

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666293

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1666311




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666311
[Bug 1666311] Review Request: python-cleo - Create beautiful and testable
command-line interfaces
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666311] New: Review Request: python-cleo - Create beautiful and testable command-line interfaces

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666311

Bug ID: 1666311
   Summary: Review Request: python-cleo - Create beautiful and
testable command-line interfaces
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-cleo.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-cleo-0.6.8-1.fc29.src.rpm

Description:
Create beautiful and testable command-line interfaces.

Cleo is mostly a higher level wrapper for CliKit, so a lot of the
components and utilities comes from it. Refer to its documentation for
more information.


Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043595


This package depends on python-clikit, python-pastel, and python-pylev, which
I've submitted for review, too.

NOTE: I've packaged version 0.6.8 instead of 0.7.2 *on purpose*, because stable
releases of poetry aren't compatible with cleo >= 0.7 yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666294] Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666294

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1666306




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666306
[Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and
testable CLIs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666293] Review Request: python-pastel - Bring colors to your terminal

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666293

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1666306




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666306
[Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and
testable CLIs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and testable CLIs

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666306

Fabio Valentini  changed:

   What|Removed |Added

 Depends On||1666293, 1666294




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666293
[Bug 1666293] Review Request: python-pastel - Bring colors to your terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1666294
[Bug 1666294] Review Request: python-pylev - Liberally licensed, pure Python
Levenshtein implementation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666306] New: Review Request: python-clikit - Utilities to build beautiful and testable CLIs

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666306

Bug ID: 1666306
   Summary: Review Request: python-clikit - Utilities to build
beautiful and testable CLIs
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-clikit.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-clikit-0.2.3-1.fc29.src.rpm

Description:
CliKit is a group of utilities to build beautiful and testable command
line interfaces. This is at the core of Cleo.


Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043558


This package depends on python-pastel and python-pylev at install-time and
runtime. I've submitted them for review too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666299] New: Review Request: python-tomlkit - Style preserving TOML library

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666299

Bug ID: 1666299
   Summary: Review Request: python-tomlkit - Style preserving TOML
library
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-tomlkit.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-tomlkit-0.5.3-1.fc29.src.rpm

Description:
TOML Kit is a 0.5.0-compliant TOML library.

It includes a parser that preserves all comments, indentations,
whitespace and internal element ordering, and makes them accessible and
editable via an intuitive API.

You can also create new TOML documents from scratch using the provided
helpers.

Part of the implementation as been adapted, improved and fixed from
Molten.


Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043371

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Paul Howarth  changed:

   What|Removed |Added

 Blocks||1666227




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1666227
[Bug 1666227] Upgrade perl-Module-CPANTS-Analyse to 0.99
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666295] New: Review Request: perl-Data-Binary - Simple detection of binary versus text in strings

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666295

Bug ID: 1666295
   Summary: Review Request: perl-Data-Binary - Simple detection of
binary versus text in strings
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: p...@city-fan.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Data-Binary/branches/fedora/perl-Data-Binary.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Data-Binary/perl-Data-Binary-0.01-1.fc30.src.rpm

Description:
This simple module provides string equivalents to the -T / -B operators. Since
these only work on file names and file handles, this module provides the same
functions but on strings.

Note that the actual implementation is currently different, basically because
the -T / -B functions are in C/XS, and this module is written in pure Perl. For
now, anyway.

Fedora Account System Username: pghmcfc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666294] New: Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666294

Bug ID: 1666294
   Summary: Review Request: python-pylev - Liberally licensed,
pure Python Levenshtein implementation
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-pylev.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-pylev-1.3.0-1.fc29.src.rpm

Description:
A pure Python Levenshtein implementation that’s not freaking GPL’d.

Based off the Wikipedia code samples at
https://en.wikipedia.org/wiki/Levenshtein_distance.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043369

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666293] New: Review Request: python-pastel - Bring colors to your terminal

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666293

Bug ID: 1666293
   Summary: Review Request: python-pastel - Bring colors to your
terminal
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-pastel.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-pastel-0.1.0-1.fc29.src.rpm

Description:
Pastel is a simple library to help you colorize strings in your
terminal.

It comes bundled with predefined styles:

- info: green
- comment: yellow
- question: black on cyan
- error: white on red

Features:

- Use predefined styles or add you own.
- Disable colors all together by calling with_colors(False).
- Automatically disables colors if the output is not a TTY.
- Used in cleo.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043345

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666291] New: Review Request: python-cachy - Simple yet effective caching library

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666291

Bug ID: 1666291
   Summary: Review Request: python-cachy - Simple yet effective
caching library
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://decathorpe.fedorapeople.org/packages/python-cachy.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/python-cachy-0.2.0-1.fc29.src.rpm

Description:
Cachy provides a simple yet effective caching library.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32043233

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1659833] Review Request: python-notify2 - Python interface to DBus notifications

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1659833

Fabio Valentini  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Fabio Valentini  ---
Well, I think we can move this forward, since executing (GUI) tests isn't a
priority right now.

Every other issue has been resolved AFAICT, so: package approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666285] Review Request: golang-github-mitchellh-hashstructure - Get hash values for arbitrary values in Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666285

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1567909




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1567909
[Bug 1567909] hugo-0.53 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666221] Review Request: golang-github-burntsushi-locker - Simple package for conveniently using named read/write locks

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666221

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1567909




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1567909
[Bug 1567909] hugo-0.53 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666285] Review Request: golang-github-mitchellh-hashstructure - Get hash values for arbitrary values in Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666285



--- Comment #1 from Elliott Sales de Andrade  ---
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32042958

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666285] New: Review Request: golang-github-mitchellh-hashstructure - Get hash values for arbitrary values in Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666285

Bug ID: 1666285
   Summary: Review Request: golang-github-mitchellh-hashstructure
- Get hash values for arbitrary values in Go
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora




Spec URL:
http://qulogic.fedorapeople.org//golang-github-mitchellh-hashstructure.spec
SRPM URL:
http://qulogic.fedorapeople.org//golang-github-mitchellh-hashstructure-1.0.0-1.fc29.src.rpm

Description:
The hashstructure Go library is for creating a unique hash value for arbitrary
values in Go.

This can be used to key values in a hash (for use in a map, set, etc.) that are
complex. The most common use case is comparing two values without sending data
across the network, caching values locally (de-dup), and so on.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1643960] Review Request: golang-github-datadog-zstd - Zstd wrapper for Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1643960

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #1 from Elliott Sales de Andrade  ---
Are you unable to unvendor zstd?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1156492] Review Request: golang-github-cpuguy83-go-md2man - Process markdown into manpages

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1156492

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 CC||quantum.anal...@gmail.com
 Resolution|--- |ERRATA
Last Closed|2014-11-19 16:00:37 |2019-01-15 09:33:32



--- Comment #25 from Elliott Sales de Andrade  ---
Why tag new updates to this Review Request? This bug should have been closed
ages ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1246500] Review Request: golang-googlecode-freetype-go - The Freetype font engine in Go

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1246500

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||jchal...@redhat.com,
   ||quantum.anal...@gmail.com
  Flags||needinfo?(jchaloup@redhat.c
   ||om)



--- Comment #1 from Elliott Sales de Andrade  ---
Since Google Code is dead, should this be moved to some other hosting or just
closed?

Is https://github.com/BurntSushi/freetype-go (already packaged) a suitable
replacement?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1246498] Review Request: golang-googlecode-xsrftoken - Generating and validating secure XSRF tokens

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1246498

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||jchal...@redhat.com,
   ||quantum.anal...@gmail.com
  Flags||needinfo?(jchaloup@redhat.c
   ||om)



--- Comment #1 from Elliott Sales de Andrade  ---
Since Google Code is dead, should this be moved to some other hosting or just
closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1246493] Review Request: golang-googlecode-rsc - Random source code

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1246493

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||jchal...@redhat.com,
   ||quantum.anal...@gmail.com
  Flags||needinfo?(jchaloup@redhat.c
   ||om)



--- Comment #1 from Elliott Sales de Andrade  ---
Since Google Code is dead, should this be moved to some other hosting or just
closed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1661863] Review Request: smc-raghumalayalamsans-fonts - Open Type Fonts for Malayalam script

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1661863



--- Comment #3 from vishalvvr  ---
SPEC URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/smc-fonts/fedora-29-x86_64/00846765-smc-raghumalayalamsans-fonts/smc-raghumalayalamsans-fonts.spec

SRPM URL :
https://copr-be.cloud.fedoraproject.org/results/vishalvvr/smc-fonts/fedora-29-x86_64/00846765-smc-raghumalayalamsans-fonts/smc-raghumalayalamsans-fonts-2.1.2-2.fc29.src.rpm

Fixed above issues

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666221] Review Request: golang-github-burntsushi-locker - Simple package for conveniently using named read/write locks

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666221



--- Comment #1 from Elliott Sales de Andrade  ---
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=32040257

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1666221] New: Review Request: golang-github-burntsushi-locker - Simple package for conveniently using named read/write locks

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1666221

Bug ID: 1666221
   Summary: Review Request: golang-github-burntsushi-locker -
Simple package for conveniently using named read/write
locks
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: quantum.anal...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora




Spec URL: http://qulogic.fedorapeople.org//golang-github-burntsushi-locker.spec
SRPM URL:
http://qulogic.fedorapeople.org//golang-github-burntsushi-locker-0-0.1.20190115gita6e239e.fc29.src.rpm

Description:
Simple package for conveniently using named read/write locks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1658707] Review Request: python-confluent-kafka - Confluent's Apache Kafka client for Python

2019-01-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1658707

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Raphael Groner  ---
APPROVED

Please reactivate %check. Why did you comment?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org