[Bug 1723045] Review Request: zola - Fast static site generator with everything built-in
https://bugzilla.redhat.com/show_bug.cgi?id=1723045 --- Comment #6 from Fedora Update System --- FEDORA-MODULAR-2019-d5aed96dc1 has been submitted as an update to Fedora 30 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-d5aed96dc1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723045] Review Request: zola - Fast static site generator with everything built-in
https://bugzilla.redhat.com/show_bug.cgi?id=1723045 --- Comment #5 from Fedora Update System --- FEDORA-MODULAR-2019-64cb9e802e has been submitted as an update to Fedora 29 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2019-64cb9e802e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1668010] Review Request: hip - Tool for porting CUDA to Portable C++ Code
https://bugzilla.redhat.com/show_bug.cgi?id=1668010 --- Comment #15 from Tom Stellard --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00944399-hip/hip.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00944399-hip/hip-1.5.18494-1.rocm2.0.0.fc31.src.rpm I decided to add back the static library in its own sub-package. I don't want to remove the -use-staticlib option, because it seems like it might cause us problems in the future if fedora is missing on option supported by upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720757] Review Request: pew - Tool to manage multiple virtualenvs written in pure Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720757 --- Comment #13 from Fedora Update System --- pew-1.2.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8dc336f073 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1721770] Review Request: glava - OpenGL audio spectrum visualizer
https://bugzilla.redhat.com/show_bug.cgi?id=1721770 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-25 01:26:03 --- Comment #9 from Fedora Update System --- glava-1.6.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711896] Review Request: ghc-microlens-mtl - Microlens support for Reader/Writer/State from mtl
https://bugzilla.redhat.com/show_bug.cgi?id=1711896 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-25 01:25:36 --- Comment #9 from Fedora Update System --- ghc-microlens-mtl-0.1.11.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720757] Review Request: pew - Tool to manage multiple virtualenvs written in pure Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720757 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- pew-1.2.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9b1d2a41db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com --- Comment #1 from Elliott Sales de Andrade --- New Python packages must receive an exception to contain Python 2 version, or just not bother with it. Please fill out the Summary and Description in the spec to something more substantial than just repeating the name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1668010] Review Request: hip - Tool for porting CUDA to Portable C++ Code
https://bugzilla.redhat.com/show_bug.cgi?id=1668010 --- Comment #14 from Felix Schwarz --- One more thing: If you delete the static library you also need to fix /usr/lib64/cmake/hip/hip-targets.cmake which contains references to "libhip_hcc_static.a". I noticed that while trying to build rocblas with your hip package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Dylan Stephano-Shachter changed: What|Removed |Added Depends On||1723572 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Dylan Stephano-Shachter changed: What|Removed |Added Depends On|1723572 |1723570 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723570 [Bug 1723570] Review Request: python-filecache - Save return values to files https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 Dylan Stephano-Shachter changed: What|Removed |Added Blocks||1723575 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723575 [Bug 1723575] Review Request: python-insights-core - data collection and processing framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Dylan Stephano-Shachter changed: What|Removed |Added Depends On||1723572 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723572 [Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 Dylan Stephano-Shachter changed: What|Removed |Added Blocks|1723575 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723575 [Bug 1723575] Review Request: python-insights-core - data collection and processing framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723570] Review Request: python-filecache - Save return values to files
https://bugzilla.redhat.com/show_bug.cgi?id=1723570 Dylan Stephano-Shachter changed: What|Removed |Added Blocks||1723575 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723575 [Bug 1723575] Review Request: python-insights-core - data collection and processing framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 Dylan Stephano-Shachter changed: What|Removed |Added Blocks||1723575 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723575 [Bug 1723575] Review Request: python-insights-core - data collection and processing framework -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] New: Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 Bug ID: 1723575 Summary: Review Request: python-insights-core - data collection and processing framework Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: dylan@theone.ninja QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944257-insights-core/python-insights-core.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944257-insights-core/insights-core-3.0.100.974-1.fc30.src.rpm Description: Insights Core is a data collection and analysis framework that is built for extensibility and rapid development. Included are a set of reusable components for gathering data in myriad ways and providing a reliable object model for commonly useful unstructured and semi-structured data. https://github.com/RedHatInsights/insights-core ps: This is my first batch of Review requests and I am seeking a packaging sponsor. Fedora Account System Username: dstathis -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723570] Review Request: python-filecache - Save return values to files
https://bugzilla.redhat.com/show_bug.cgi?id=1723570 --- Comment #1 from Dylan Stephano-Shachter --- The upstream homepage is here https://github.com/ubershmekel/filecache -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723572] New: Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 Bug ID: 1723572 Summary: Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: dylan@theone.ninja QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944256-cachecontrol/python-cachecontrol.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944256-cachecontrol/cachecontrol-0.12.5-1.fc30.src.rpm Description: The httplib2 caching algorithms packaged up for use with requests. https://github.com/ionrock/cachecontrol This is a dependency for insights-core ps: This is my first batch of Review requests and I am seeking a packaging sponsor. Fedora Account System Username: dstathis -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723570] New: Review Request: python-filecache - Save return values to files
https://bugzilla.redhat.com/show_bug.cgi?id=1723570 Bug ID: 1723570 Summary: Review Request: python-filecache - Save return values to files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: dylan@theone.ninja QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944254-filecache/python-filecache.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00944254-filecache/filecache-0.77-1.fc30.src.rpm Description: This is a python library that automatically writes the return values of functions to a file. It is a dependency of insights-core ps: This is my first batch of Review requests and I am seeking a packaging sponsor. Fedora Account System Username: dstathis -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1703381] Review Request: libdrm-armada - DRM driver for Marvell Armada displays
https://bugzilla.redhat.com/show_bug.cgi?id=1703381
--- Comment #2 from Lubomir Rintel ---
Thanks for the review:
(In reply to Robert-André Mauchin from comment #1)
> - Just rm the *.la in install instead of:
>
> %exclude %{_libdir}/libdrm_armada.la
>
> find %{buildroot} -name '*.la' -print -delete
Why? It just seems more complex for no apparent benefit.
> - Group: is not used in Fedora
Will fix.
> - 20180720: should be the date you *took* the snapshot, not the date of the
> commit
Why? It doesn't make much sense to me and the guidelines don't seem to suggest
anything like that:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots
> - How do you know the version is 2.0.0? Seems to be 2.0.3 from the Debian
> changelog.
That's what the configure.ac (and thus "make dist") uses. I guess you're right
and the debian/changelog is more relevant.
However, this would probably be a post-2.0.2 & pre-2.0.3 shapshot, since
entries get added to 2.0.3 entry.
> - Remove the dot at the end of summary:
>
> libdrm-armada-devel.x86_64: W: summary-ended-with-dot C Development files
> for libdrm-armada.
Will fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709481] Review Request: vim-ctrlp - Full path fuzzy file, buffer, mru, tag, ... finder for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1709481 --- Comment #8 from Ondrej Soukup --- So as soon as I wrote down all these despair here things finally moved forward! I used commit-based approach as suggested by Robert-André - thank you - which works like a charm. I just had to first find out an unrelated typo of mine which made me think it does not work so straightforward... Here are the changes https://github.com/osoukup/ctrlp.vim/commit/2afc0feca05dbf86d4fc233b34951056b42b1163 and here are the new builds https://copr.fedorainfracloud.org/coprs/osoukup/ctrlp.vim/build/944205/ https://koji.fedoraproject.org/koji/taskinfo?taskID=35793933 Thank you both once again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1249211] Review Request: cndoom - Conservative Doom engine for speedrunning competition
https://bugzilla.redhat.com/show_bug.cgi?id=1249211 Adam Williamson changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2019-06-24 17:01:03 --- Comment #8 from Adam Williamson --- Quick further update - what I got back from the dev was this: "I didn't abandon it just wanted to start new when choco v3 gets out, tho I dint'd make any progress but it is on my todo list :) I made terrible choices in my last cndoom release and decided to start from scratch hehe. If you want source it is still available from doom.com.hr: http://www.doom.com.hr/cndoom/cndoom-2.0.3.2.tar.gz; It doesn't seem like much has happened since then, and it seems that speedrunners aren't really using cndoom these days, they mostly use Chocolate or Crispy I believe. So we can probably give up on this for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Nvm, I see the review is not approved yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720217] Review Request: python-dukpy - JavaScript runtime environment
https://bugzilla.redhat.com/show_bug.cgi?id=1720217 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-dukpy-0.3-1.fc31 Resolution|--- |RAWHIDE Last Closed||2019-06-24 16:47:33 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- Built in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720843] Review Request: python-pysnooper - Poor man's debugger for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720843 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-pysnooper-0.2.2-1.fc ||31 Resolution|--- |RAWHIDE Last Closed||2019-06-24 16:43:33 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- Build in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Still waiting for the FESCo ticket to be resolved. I'll ask for the repo to be created, but I won't import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719008] Review Request: python-soupsieve - CSS selector library
https://bugzilla.redhat.com/show_bug.cgi?id=1719008 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1690046
--- Comment #19 from Orion Poplawski ---
(In reply to jogas from comment #18)
> > I don't know what the _libexecdir definition is here, but it should be
> > removed.
>
> The libexecdir macro expands to /usr/lib instead of /usr/libexec on SUSE.
> The _libexecdir macro was defined to avoid a SUSE conditional. Is there a
> better solution I am missing?
If SUSE expands _libexecdir to /usr/lib, perhaps they really want you to put
your "libexec" files there? If you want to keep this, put a comment explaining
why it is being defined, and a preferable definition would be:
%{!?_libexecdir:%define _libexecdir %{_exec_prefix}/libexec}
unless SUSE does not define %{_exec_prefix}.
> Re. Documentation:
>
> To recap: the primary issue is that we cannot build the documentation without
> sphinx-build version 1.4.9 or greater. AFAICT, only Fedora29, Fedora30, and
> Rawhide can satisfy this dependency. Epel provides version 1.1.3.
>
> Originally, on epel, your spec file forced the documentation to build by
> ignoring warnings via:
>
> $ make -C doc-src -k || :
>
> I initially thought this method built the html files with broken tables.
> However, upon closer inspection I've learned that the html files are skipped
> entirely. At this point, I am convinced this the best way to proceed. We
> build
> the documentation and on epel, in place of the html files, we can add a
> readme
> that directs them to online html documentation. In short we'd have:
>
> Fedora flavors: man pages and html docs
> epel: man pages and readme with a link to online html docs
>
> I'd like your blessing before moving forward. If Orion has any thoughts or
> advice regarding this situation it would be warmly received.
That's fine by me. Another option is to capture a build of the docs from
Fedora and install that on EPEL.
FYI - I've sponsored Jordan, and will be leaving tomorrow for an extended
vacation.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1709481] Review Request: vim-ctrlp - Full path fuzzy file, buffer, mru, tag, ... finder for Vim
https://bugzilla.redhat.com/show_bug.cgi?id=1709481 --- Comment #7 from Ondrej Soukup --- (In reply to Igor Gnatenko from comment #6) > Hey Ondrej, > > I sponsored you to the packagers group. > > Let me know if you need any assistance with review made by eclipseo. Thank you very much Igor! I am also thankful to Robert-André for his reviews. After his last comment I tried to incorporate his suggestions in various ways but I am still just struggling with it without any success. I at least understood some of my previous mistakes like building from my own modified archive instead of the upstream one. I was first trying to stick with version-directed approach which I was using previously. The farthest I got was to various LICENSE install errors and got stuck with it. I am not sure how to install it. I was not able to find some example or documentation which would work for me. Now I am investigating the second suggested commit-oriented approach. Simple copy-pasting ended up with invalid spec file so now I am learning it and trying to solve what is the correct working way of using it. I am doing this my little packaging adventure in my free time and cannot find more than couple of hours for it every week so I am proceeding quite slowly. Moreover, I feel most of my last tries ended up as a waste of time investigating blind ways. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720843] Review Request: python-pysnooper - Poor man's debugger for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720843 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Lumír: I kept the Source line as it was, but if you want to change it later, feel free. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720843] Review Request: python-pysnooper - Poor man's debugger for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720843 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pysnooper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720843] Review Request: python-pysnooper - Poor man's debugger for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720843 --- Comment #5 from Lumír Balhar --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > Robert-André: thank you for the review. I fixed the issues you found > locally, and I'll push the fixed version when importing. > > Lumír: thanks, I'll update to the latest version when importing. But I don't > think pypi is better > than github. github at least has 2FA and content-addressed storage. When I was working on the package I had a chat with the upstream developer and I gave him two options to make our work simpler: 1) Include tests in PyPI tarball so we can run them during a build of RPM or 2) tag releases on Github so we can easily use it as a source. I would prefer to use PyPI as a source to omit commit hash but it's just a nitpick and nothing serious. > > Lumír: if you don't mind, I'll add you as comaintainer when setting up the > repo. That would be great! Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1690046] Review Request: Charliecloud - unprivileged container runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1690046
--- Comment #18 from jo...@lanl.gov ---
> The Release tag says 1, but the %changelog says 2.
Oops. Fixed locally.
> I don't know what the _libexecdir definition is here, but it should be
> removed.
The libexecdir macro expands to /usr/lib instead of /usr/libexec on SUSE.
The _libexecdir macro was defined to avoid a SUSE conditional. Is there a
better solution I am missing?
> build_cflags and build_ldflags are always defined now, so the
> conditionals for those can be removed.
Great!
> It might be better to change this to use mv and avoid the %exclude in
> %files:
>
> cp -r %{buildroot}/%{_libexecdir}/%{name}
> %{buildroot}/%{_libexecdir}/%{name}-%{version}
Good point, resolved locally.
Re. Documentation:
To recap: the primary issue is that we cannot build the documentation without
sphinx-build version 1.4.9 or greater. AFAICT, only Fedora29, Fedora30, and
Rawhide can satisfy this dependency. Epel provides version 1.1.3.
Originally, on epel, your spec file forced the documentation to build by
ignoring warnings via:
$ make -C doc-src -k || :
I initially thought this method built the html files with broken tables.
However, upon closer inspection I've learned that the html files are skipped
entirely. At this point, I am convinced this the best way to proceed. We build
the documentation and on epel, in place of the html files, we can add a readme
that directs them to online html documentation. In short we'd have:
Fedora flavors: man pages and html docs
epel: man pages and readme with a link to online html docs
I'd like your blessing before moving forward. If Orion has any thoughts or
advice regarding this situation it would be warmly received.
> I haven't yet figured out how to run the tests from the installed
> package. I think that deserves a README. [...]
The test suite location and its usage is unclear. We are addressing this
upstream by adding a ch-test wrapper to bin
(https://github.com/hpc/charliecloud/pull/447).
For now, I will add a readme.
As always, I appreciate your time and effort. Thanks Dave.
Best,
Jordan
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720843] Review Request: python-pysnooper - Poor man's debugger for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720843 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- Robert-André: thank you for the review. I fixed the issues you found locally, and I'll push the fixed version when importing. Lumír: thanks, I'll update to the latest version when importing. But I don't think pypi is better than github. github at least has 2FA and content-addressed storage. Lumír: if you don't mind, I'll add you as comaintainer when setting up the repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1704522] Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(dominik@greysecto |
|r.net) |
--- Comment #5 from Dominik 'Rathann' Mierzejewski ---
1. The manpage is dungeon(6) while the binary is called "zork". This makes the
manpage not discoverable easily. Please rename or at least add a link:
%install
...
echo ".so dungeon.6" > %{buildroot}%{_mandir}/man6/zork.6
%files
...
%{_mandir}/man6/zork.6*
2. There are tons of warnings from gcc in the build log. Some of them look
serious:
https://copr-be.cloud.fedoraproject.org/results/jflory7/zork/fedora-rawhide-x86_64/00898454-zork/build.log.gz
...
BUILDSTDERR: np.c:176:5: warning: array subscript -1 is outside array bounds of
'integer[40]' {aka 'int[40]'} [-Warray-bounds]
BUILDSTDERR: 176 | --outbuf;
BUILDSTDERR: | ^~~~
Please work with upstream to fix these.
3. The 'history' file could also be included as %doc. I missed that last time.
Apart from that, it looks good packaging-wise and is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1718684] Review Request: cc65 - A free C compiler for 6502 based systems
https://bugzilla.redhat.com/show_bug.cgi?id=1718684 --- Comment #45 from Fedora Update System --- cc65-2.18-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720757] Review Request: pew - Tool to manage multiple virtualenvs written in pure Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720757 --- Comment #11 from Fedora Update System --- FEDORA-2019-9b1d2a41db has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9b1d2a41db -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720757] Review Request: pew - Tool to manage multiple virtualenvs written in pure Python
https://bugzilla.redhat.com/show_bug.cgi?id=1720757 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2019-8dc336f073 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8dc336f073 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1719633] Review Request: python-epel-rpm-macros - The EPEL Python RPM macros
https://bugzilla.redhat.com/show_bug.cgi?id=1719633 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|tors...@redhat.com --- Comment #3 from Miro Hrončok --- https://pagure.io/releng/fedora-scm-requests/issue/13178 "The Bugzilla bug provided is not assigned to anyone" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
