[Bug 1720768] Review Request: python-neurosynth - Neurosynth is a Python package for large-scale synthesis of functional neuroimaging data.
https://bugzilla.redhat.com/show_bug.cgi?id=1720768 --- Comment #9 from Fedora Update System --- python-neurosynth-0.3.7-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-392e82a303 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720768] Review Request: python-neurosynth - Neurosynth is a Python package for large-scale synthesis of functional neuroimaging data.
https://bugzilla.redhat.com/show_bug.cgi?id=1720768 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- python-neurosynth-0.3.7-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-58536e73b0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1721338] Review Request: R-rcmdcheck - Run 'R CMD check' from 'R' and Capture Results
https://bugzilla.redhat.com/show_bug.cgi?id=1721338 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-27 00:55:02 --- Comment #7 from Fedora Update System --- R-rcmdcheck-1.3.3-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1720575] Review Request: python-glad - Multi-Language GL/GLES/EGL/GLX/WGL Loader-Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1720575 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-27 00:55:03 --- Comment #8 from Fedora Update System --- python-glad-0.1.30-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1714350] Review Request: repmgr - Replication Manager for PostgreSQL Clusters
https://bugzilla.redhat.com/show_bug.cgi?id=1714350 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-27 00:54:57 --- Comment #10 from Fedora Update System --- repmgr-4.3.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1721292] Review Request: R-sessioninfo - R Session Information
https://bugzilla.redhat.com/show_bug.cgi?id=1721292 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-27 00:54:58 --- Comment #8 from Fedora Update System --- R-sessioninfo-1.1.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1710215] Review Request: R-xopen - Open System Files, 'URLs', Anything
https://bugzilla.redhat.com/show_bug.cgi?id=1710215 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2019-06-04 06:48:43 |2019-06-27 00:54:59 --- Comment #8 from Fedora Update System --- R-xopen-1.0.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1707960] Review Request: php-brumann-polyfill-unserialize - Backports unserialize options introduced in PHP 7.0
https://bugzilla.redhat.com/show_bug.cgi?id=1707960 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-06-27 00:54:28 --- Comment #12 from Fedora Update System --- php-brumann-polyfill-unserialize-1.0.3-1.fc30, php-typo3-phar-stream-wrapper2-2.1.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1721338] Review Request: R-rcmdcheck - Run 'R CMD check' from 'R' and Capture Results
https://bugzilla.redhat.com/show_bug.cgi?id=1721338 Bug 1721338 depends on bug 1721292, which changed state. Bug 1721292 Summary: Review Request: R-sessioninfo - R Session Information https://bugzilla.redhat.com/show_bug.cgi?id=1721292 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1364678] Review Request: nodejs-read-json-sync - Read and parse a JSON file synchronously
https://bugzilla.redhat.com/show_bug.cgi?id=1364678 Bug 1364678 depends on bug 1333603, which changed state. Bug 1333603 Summary: nodejs-graceful-fs-4.2.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1333603 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724367] New: Review Request: python-confuse - A Python module for handling YAML configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1724367
Bug ID: 1724367
Summary: Review Request: python-confuse - A Python module for
handling YAML configuration files
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-confuse.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-confuse-1.0.0-1.fc30.src.rpm
Project URL: https://github.com/beetbox/confuse
Description:
Confuse is a configuration library for Python that uses YAML. It takes
care of defaults, overrides, type checking, command-line integration, human-
readable errors, and standard OS-specific locations.
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=35849650
rpmlint output:
$ rpmlint python-confuse-1.0.0-1.fc30.src.rpm
python-confuse.src:42: W: macro-in-comment %check
python-confuse.src:43: W: macro-in-comment %{python3_version_nodots}
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint python3-confuse-1.0.0-1.fc30.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Fedora Account System Username: fab
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 --- Comment #4 from Dylan Stephano-Shachter --- New spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948290-insights-core/python-insights-core.spec New srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948290-insights-core/insights-core-3.0.100.974-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723570] Review Request: python-filecache - Save return values to files
https://bugzilla.redhat.com/show_bug.cgi?id=1723570 --- Comment #2 from Dylan Stephano-Shachter --- New spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948276-filecache/python-filecache.spec New srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948276-filecache/filecache-0.77-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723572] Review Request: python-cachecontrol - The httplib2 caching algorithms packaged up for use with requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1723572 --- Comment #1 from Dylan Stephano-Shachter --- New spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948274-cachecontrol/python-cachecontrol.spec New srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948274-cachecontrol/cachecontrol-0.12.5-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 --- Comment #3 from Dylan Stephano-Shachter --- Sorry that one is for cachecontrol. I'll get the ones for insights-core up momentarily. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723575] Review Request: python-insights-core - data collection and processing framework
https://bugzilla.redhat.com/show_bug.cgi?id=1723575 --- Comment #2 from Dylan Stephano-Shachter --- I've fixed both of the mentioned issues. How does this look? Here is the new spec: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948274-cachecontrol/python-cachecontrol.spec Here is the new srpm: https://copr-be.cloud.fedoraproject.org/results/dstathis/insights-core/fedora-30-x86_64/00948274-cachecontrol/cachecontrol-0.12.5-1.fc30.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1702720] Review Request: frr - routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1702720
--- Comment #9 from Martin Osvald ---
There are still some issues reported by fedora-review which should get fixed
(my notes inside '---' parts):
~~~
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
~~~
relates to:
~~~
ERROR: Command failed:
# /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
--releasever 31 --setopt=deltarpm=False --disableplugin=local
--disableplugin=spacewalk install
/home/mosvald/review-frr/results/frr-debuginfo-7.1-1.fc31.x86_64.rpm
/home/mosvald/review-frr/results/frr-debugsource-7.1-1.fc31.x86_64.rpm
/home/mosvald/review-frr/results/frr-7.1-1.fc31.x86_64.rpm
~~~
dnf output:
~~~
Running transaction
Preparing:
1/1
Running scriptlet: frr-7.1-1.fc31.x86_64
1/1
useradd: group frr exists - if you want to add this user to that group, use -g.
usermod: group '%{vty_group}' does not exist
error: %prein(frr-7.1-1.fc31.x86_64) scriptlet failed, exit status 6
Error in PREIN scriptlet in rpm package frr
Verifying: frr-7.1-1.fc31.x86_64
1/1
Failed:
frr-7.1-1.fc31.x86_64
Error: Transaction failed
#
~~~
related specfile code:
~~~
108 %pre
109 getent group frrvty >/dev/null 2>&1 || groupadd -r frrvty >/dev/null 2>&1
|| :
110 getent group frr >/dev/null 2>&1 || groupadd frr >/dev/null 2>&1 || :
111 getent passwd frr >/dev/null 2>&1 || useradd -M -r -s /sbin/nologin \
112 -c "FRRouting routing suite" -d %{_localstatedir}/run/frr frr || :
113 usermod -aG %{vty_group} frr
~~~
notes:
- frr is not system group (-r) even it owns files under /{etc,run,var/log}/frr,
frr chowned:
~~~
Rpmlint
---
...
frr.x86_64: W: non-standard-uid /etc/frr frr
frr.x86_64: W: non-standard-gid /etc/frr frr
frr.x86_64: W: non-standard-uid /run/frr frr
frr.x86_64: W: non-standard-gid /run/frr frr
frr.x86_64: W: non-standard-uid /var/log/frr frr
frr.x86_64: W: non-standard-gid /var/log/frr frr
~~~
- missing '-g frr' in useradd
- %{vty_group} doesn't get substituted
- exit 0 could be added at the end of %pre after solving all the above
~~~
Issues:
===
...
- Texinfo files are installed using install-info in %post and %preun if
package has .info files.
Note: Texinfo .info file(s) in frr
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_texinfo
...
~~~
It happens because install-info command isn't mentioned in %preun, but %postun
instead.
Related code:
/usr/share/fedora-review/plugins/generic.py:
~~~
42 def in_list(what, list_):
43 """ test if 'what' is in each item in list_. """
44 for item in list_:
45 if not item:
46 return False
47 if what not in item:
48 return False
49 return True
...
1918 class CheckInfoInstall(GenericCheckBase):
1919 """ Check that info files are properly installed. """
1920
1921 def __init__(self, base):
1922 GenericCheckBase.__init__(self, base)
1923 self.url = (
1924 "https://docs.fedoraproject.org/en-US;
1925 "/packaging-guidelines/Scriptlets/#_texinfo"
1926 )
1927 self.text = (
1928 "Texinfo files are installed using install-info"
1929 " in %post and %preun if package has .info files."
1930 )
1931 self.automatic = True
1932 self.type = "MUST"
1933
1934 def run(self):
1935 using = []
1936 failed = False
1937 for pkg in self.spec.packages:
1938 if self.rpms.find("/usr/share/info/*", pkg):
1939 using.append(pkg)
1940 rpm_pkg = self.rpms.get(pkg)
1941 if not in_list("install-info", [rpm_pkg.post,
rpm_pkg.preun]):
1942 failed = True
1943 if not using:
1944 self.set_passed(self.NA)
1945 return
1946 text = "Texinfo .info file(s) in " + ", ".join(using)
1947 self.set_passed(self.FAIL if failed else self.PENDING, text)
~~~
I added extra DBG statements into in_list():
~~~
42 def in_list(what, list_):
43 """ test if 'what' is in each item in list_. """
44
[Bug 1720768] Review Request: python-neurosynth - Neurosynth is a Python package for large-scale synthesis of functional neuroimaging data.
https://bugzilla.redhat.com/show_bug.cgi?id=1720768 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2019-58536e73b0 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-58536e73b0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724281] New: Review Request: kafs-client - Basic startup and utilities for in-kernel AFS filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=1724281 Bug ID: 1724281 Summary: Review Request: kafs-client - Basic startup and utilities for in-kernel AFS filesystem Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dhowe...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.infradead.org/~dhowells/kafs/kafs-client.spec SRPM URL: https://www.infradead.org/~dhowells/kafs/kafs-client-0.2-1.fc29.local.src.rpm Description: I would like to propose the kafs-client package for inclusion in Rawhide. It contains: (1) systemd scripts to configure the AFS client that's in the Linux kernel (kafs) and now enabled in Fedora (bug 1616016); and to mount the AFS dynamic root on /afs (in the filesystem-afs package now, bug 1720232). (2) A simple aklog program to convert Kerberos tickets into rxrpc keys for AFS to use. (3) A request-key upcall program to handle DNS lookups on behalf of the kernel for kafs. This is more capable than the one in keyutils, which it overrides for kafs lookups. (4) A utility to check/test/dump the cell database configuration. (5) Various manual pages for the concepts and programs involved. Note that I haven't included manpages for the library - yet - as the functions there are still in flux whilst I work on the kafs-utils package. This does not, however, prevent the AFS filesystem from being used as a basic network filesystem. Fedora Account System Username: dhowells -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724278] New: Review Request: python-beniget - Extract semantic information about static Python code
https://bugzilla.redhat.com/show_bug.cgi?id=1724278 Bug ID: 1724278 Summary: Review Request: python-beniget - Extract semantic information about static Python code Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-beniget.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-beniget-0.1.0-1.fc30.src.rpm Description: A static analyzer for Python2 and Python3 code.Beniget provides a static over- approximation of the global and local definitions inside Python Module/Class/Function. It can also compute def-use chains from each definition. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724278] Review Request: python-beniget - Extract semantic information about static Python code
https://bugzilla.redhat.com/show_bug.cgi?id=1724278 Miro Hrončok changed: What|Removed |Added Whiteboard||Trivial -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724271] New: Review Request: libmodulemd2 - Module metadata manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1724271 Bug ID: 1724271 Summary: Review Request: libmodulemd2 - Module metadata manipulation library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sgall...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://sgallagh.fedorapeople.org/packagereview/libmodulemd2/libmodulemd2.spec SRPM URL: https://sgallagh.fedorapeople.org/packagereview/libmodulemd2/libmodulemd2-2.5.0-2.el7.src.rpm Description: C Library for manipulating module metadata files. See https://github.com/fedora-modularity/libmodulemd/blob/master/README.md for more details. Fedora Account System Username: sgallagh Note: this is intended only for EPEL 7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version
https://bugzilla.redhat.com/show_bug.cgi?id=1667680 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-06-26 15:26:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||python-astunparse-1.6.2-1.f ||c31 Resolution|--- |RAWHIDE Last Closed||2019-06-26 15:12:50 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version
https://bugzilla.redhat.com/show_bug.cgi?id=1667680 Bug 1667680 depends on bug 1667661, which changed state. Bug 1667661 Summary: Review Request: python-astunparse - An AST unparser for Python https://bugzilla.redhat.com/show_bug.cgi?id=1667661 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version
https://bugzilla.redhat.com/show_bug.cgi?id=1667680 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-gast -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723104] Review Request: golang-github-jacobsa-ogletest - A Go unit testing framework like Google Test for C++ and JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723104 --- Comment #2 from Brian (bex) Exelbierd --- Bootstrap of oglemock is built: https://koji.fedoraproject.org/koji/buildinfo?buildID=1298657 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1668010] Review Request: hip - Tool for porting CUDA to Portable C++ Code
https://bugzilla.redhat.com/show_bug.cgi?id=1668010 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #18 from Robert-André Mauchin --- LGTM, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723104] Review Request: golang-github-jacobsa-ogletest - A Go unit testing framework like Google Test for C++ and JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723104 Bug 1723104 depends on bug 1723105, which changed state. Bug 1723105 Summary: Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test https://bugzilla.redhat.com/show_bug.cgi?id=1723105 What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105 Brian (bex) Exelbierd changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-06-26 14:51:45 --- Comment #5 from Brian (bex) Exelbierd --- Bootstrap built. Closing, with the belief that it will be reopened if needed. https://koji.fedoraproject.org/koji/buildinfo?buildID=1298657 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version
https://bugzilla.redhat.com/show_bug.cgi?id=1667680 Patrik Kopkan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Patrik Kopkan --- refreshing approval -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667680] Review Request: python-gast - Python AST that abstracts the underlying Python version
https://bugzilla.redhat.com/show_bug.cgi?id=1667680 Patrik Kopkan changed: What|Removed |Added Assignee|zebo...@gmail.com |pkop...@redhat.com Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661 --- Comment #14 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-astunparse -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661 Patrik Kopkan changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1667661] Review Request: python-astunparse - An AST unparser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1667661
--- Comment #13 from Patrik Kopkan ---
I think package is in good state to be in Fedora also I am sry that I get to it
so late.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Python Software Foundation License
version 2 BSD 3-clause "New" or "Revised" License", "*No copyright*
BSD (unspecified)". 21 files have unknown license. Detailed output of
licensecheck in /home/pkopkan/Documents/review/1667661-python-
astunparse/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1693913] Review Request: coin-or-Data-miplib3 - COIN-OR mixed integer library
https://bugzilla.redhat.com/show_bug.cgi?id=1693913 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/coin-or-Data-miplib3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693514] Review Request: coin-or-Data-Netlib - COIN-OR Netlib models
https://bugzilla.redhat.com/show_bug.cgi?id=1693514 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/coin-or-Data-Netlib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1724202 Miro Hrončok changed: What|Removed |Added Blocks||1714369 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1714369 [Bug 1714369] python-pluggy-0.12.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-jacobsa-oglemock -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1724202 Miro Hrončok changed: What|Removed |Added Whiteboard||Trivial -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724196] Review Request: python-zipp - Backport of pathlib-compatible object wrapper for zip files
https://bugzilla.redhat.com/show_bug.cgi?id=1724196 Miro Hrončok changed: What|Removed |Added Whiteboard||Trivial -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Miro Hrončok changed: What|Removed |Added Depends On||1724202 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1724202 [Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724196] Review Request: python-zipp - Backport of pathlib-compatible object wrapper for zip files
https://bugzilla.redhat.com/show_bug.cgi?id=1724196 Miro Hrončok changed: What|Removed |Added Blocks||1724202 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1724202 [Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724202] Review Request: python-importlib-metadata - Read metadata from Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1724202 Miro Hrončok changed: What|Removed |Added Blocks||1699032, 1694366 Depends On||1724196 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1694366 [Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks https://bugzilla.redhat.com/show_bug.cgi?id=1699032 [Bug 1699032] python-tox-3.13.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1724196 [Bug 1724196] Review Request: python-zipp - Backport of pathlib-compatible object wrapper for zip files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724202] New: Review Request: python-importlib-metadata - Read metadata from Python packages
https://bugzilla.redhat.com/show_bug.cgi?id=1724202 Bug ID: 1724202 Summary: Review Request: python-importlib-metadata - Read metadata from Python packages Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-importlib-metadata.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-importlib-metadata-0.18-1.fc30.src.rpm Description: importlib_metadata is a library which provides an API for accessing an installed package’s metadata, such as its entry points or its top-level name. This functionality intends to replace most uses of pkg_resources entry point API and metadata API. Along with importlib.resources in Python 3.7 and newer (backported as importlib_resources for older versions of Python), this can eliminate the need to use the older and less efficient pkg_resources package. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724196] New: Review Request: python-zipp - Backport of pathlib-compatible object wrapper for zip files
https://bugzilla.redhat.com/show_bug.cgi?id=1724196 Bug ID: 1724196 Summary: Review Request: python-zipp - Backport of pathlib-compatible object wrapper for zip files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-zipp.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-zipp-0.5.1-1.fc30.src.rpm Description: A pathlib-compatible Zipfile object wrapper. A backport of the Path object. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724111] Review Request lsp-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1724111
--- Comment #4 from Vitaly Zaitsev ---
1. License: LGPLv3+ and zlib.
2. Unversioned so-files in %_libdir: /usr/lib64/lsp-plugins-jack-core-1.1.9.so.
You need to set it's SONAME and SOVERSION like lsp-plugins-jack-core.so.1.1.9
or move it outside of %_libdir root.
3. Plugins-doc subpackage should be noarch.
4. Directories in packages are owned also by: /usr/lib64/lv2(lv2-carla, lv2),
/usr/lib64/vst(Carla-vst), /usr/lib64/ladspa(ladspa). Please fix this by adding
this packages as Requires and globing removal.
5. Do not use hardcoded paths. Replace PREFIX=/usr as PREFIX=%{_prefix}.
6. You must patch makefile to respect Fedora build flags.
7. Enable verbose makefile output.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694366] Review Request: python-pre-commit - Framework for managing and maintaining multi-language pre-commit hooks
https://bugzilla.redhat.com/show_bug.cgi?id=1694366 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- JFYI I'm packaging importlib-metadata for new tox. Also, this should be called just pre-commit, not python-pre-commit and python3-pre-commit, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724111] Review Request lsp-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1724111
--- Comment #3 from Vitaly Zaitsev ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file licensing.html is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "zlib/libpng license". 1329 files have
unknown license.
[x]: License file installed when any subpackage combination is installed.
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/lv2(lv2-carla,
lv2), /usr/lib64/vst(Carla-vst), /usr/lib64/ladspa(ladspa)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 256000 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lsp-
plugins , lsp-plugins-ladspa , lsp-plugins-lv2 , lsp-plugins-vst ,
lsp-plugins-jack
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include
[Bug 1693514] Review Request: coin-or-Data-Netlib - COIN-OR Netlib models
https://bugzilla.redhat.com/show_bug.cgi?id=1693514 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Robert-André Mauchin --- Reapproved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693513] Review Request: gap-pkg-jupyterviz - Jupyter notebook visualization tools for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1693513 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Reapproved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693512] Review Request: gap-pkg-francy - Framework for interactive discrete mathematics
https://bugzilla.redhat.com/show_bug.cgi?id=1693512 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Robert-André Mauchin --- Reapproved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693513] Review Request: gap-pkg-jupyterviz - Jupyter notebook visualization tools for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1693513 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693913] Review Request: coin-or-Data-miplib3 - COIN-OR mixed integer library
https://bugzilla.redhat.com/show_bug.cgi?id=1693913 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Robert-André Mauchin --- Reapproved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693514] Review Request: coin-or-Data-Netlib - COIN-OR Netlib models
https://bugzilla.redhat.com/show_bug.cgi?id=1693514 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693512] Review Request: gap-pkg-francy - Framework for interactive discrete mathematics
https://bugzilla.redhat.com/show_bug.cgi?id=1693512 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1693913] Review Request: coin-or-Data-miplib3 - COIN-OR mixed integer library
https://bugzilla.redhat.com/show_bug.cgi?id=1693913 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review+ |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724111] Review Request lsp-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1724111 Vitaly Zaitsev changed: What|Removed |Added Status|NEW |ASSIGNED CC||vit...@easycoding.org Assignee|nob...@fedoraproject.org|vit...@easycoding.org Flags||fedora-review? --- Comment #2 from Vitaly Zaitsev --- I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105 --- Comment #3 from Brian (bex) Exelbierd --- Re-reading this with more coffee, I think "Please fix on import" means "fix these things and then create your package in rawhide." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724111] Review Request lsp-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1724111 --- Comment #1 from Vasiliy Glazov --- Spec URL: https://raw.githubusercontent.com/Vascom/lsp-plugins/master/lsp-plugins.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6746/35836746/lsp-plugins-1.1.9-1.fc31.src.rpm Removed rpath from binaries. Disabled building VST for ppc64le and x390x arches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105 --- Comment #2 from Brian (bex) Exelbierd --- Thank you for the comments and the golang context explanation. I've updated the spec and srpm. I do not understand this comment: "Please fix on import." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1724111] New: Review Request lsp-plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1724111 Bug ID: 1724111 Summary: Review Request lsp-plugins Product: Fedora Version: 30 Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: vasc...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/Vascom/lsp-plugins/master/lsp-plugins.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3887/35833887/lsp-plugins-1.1.9-1.fc31.src.rpm Description: LSP (Linux Studio Plugins) is a collection of open-source plugins currently compatible with follwing formats: LADSPA - set of plugins for Linux Audio Developer's Simple Plugin API LV2 - set of plugins and UIs for Linux Audio Developer's Simple Plugin API (LADSPA) version 2 LinuxVST - set of plugins and UIs for Steinberg's VST 2.4 format ported on GNU/Linux Platform JACK - Standalone versions for JACK Audio connection Kit with UI -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723158] Review Request: golang-github-rfjakob-gocryptfs - Encrypted overlay filesystem written in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1723158 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Depends On||1723110 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723110 [Bug 1723110] Review Request: golang-github-jacobsa-crypto - Some Go cryptography routines that are not included in the Go standard library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723110] Review Request: golang-github-jacobsa-crypto - Some Go cryptography routines that are not included in the Go standard library
https://bugzilla.redhat.com/show_bug.cgi?id=1723110 Elliott Sales de Andrade changed: What|Removed |Added Depends On||1723104 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723104 [Bug 1723104] Review Request: golang-github-jacobsa-ogletest - A Go unit testing framework like Google Test for C++ and JS Test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723110] Review Request: golang-github-jacobsa-crypto - Some Go cryptography routines that are not included in the Go standard library
https://bugzilla.redhat.com/show_bug.cgi?id=1723110 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1723158 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723158 [Bug 1723158] Review Request: golang-github-rfjakob-gocryptfs - Encrypted overlay filesystem written in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723104] Review Request: golang-github-jacobsa-ogletest - A Go unit testing framework like Google Test for C++ and JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723104 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com Blocks||1723110 Depends On||1723105 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723105 [Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test https://bugzilla.redhat.com/show_bug.cgi?id=1723110 [Bug 1723110] Review Request: golang-github-jacobsa-crypto - Some Go cryptography routines that are not included in the Go standard library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105 Elliott Sales de Andrade changed: What|Removed |Added Blocks||1723104 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1723104 [Bug 1723104] Review Request: golang-github-jacobsa-ogletest - A Go unit testing framework like Google Test for C++ and JS Test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1723105] Review Request: golang-github-jacobsa-oglemock - A mocking framework for Go inspired by Google Mock for C++ and Google JS Test
https://bugzilla.redhat.com/show_bug.cgi?id=1723105
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
CC||quantum.anal...@gmail.com
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #1 from Elliott Sales de Andrade ---
The golang.org/x/net/context -> context is not exactly about un-vendoring, but
rather that context was subsumed in the Go standard library in Go 1.7 (yes,
this package is old.)
Remove "A " from Summary. It's also a bit long.
Please fix on import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "*No
copyright* Apache License (v2.0)", "Apache License (v2.0)". 17 files
have unknown license. Detailed output of licensecheck in
1723105-golang-github-jacobsa-oglemock/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: golang-github-jacobsa-oglemock (description)
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages,
