[Bug 1750103] Review Request: dl-fedora - Fedora image download tool
https://bugzilla.redhat.com/show_bug.cgi?id=1750103 --- Comment #8 from Jens Petersen --- Spec: http://petersen.fedorapeople.org/reviews/dl-fedora/dl-fedora.spec SRPM: http://petersen.fedorapeople.org/reviews/dl-fedora/dl-fedora-0.7-1.fc31.src.rpm # 0.7 (2019-09-12) - rework algorithms - check local filesize earlier: don't even check mirror if already downloaded - for partial local file output percentage already downloaded, otherwise show filesize - add --checksum to always do checksum when possible - add --run to run image in qemu-kvm if available - show dir for symlink: so one knows location - drop the branched 'devel' target (use release version number instead) - handle old dangling symlink too (after deleting iso) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752210] Review Request: json-table - Command-line tool to transform nested JSON into tabular data
https://bugzilla.redhat.com/show_bug.cgi?id=1752210 Raphael Groner changed: What|Removed |Added Fixed In Version||json-table-4.3.3-1.fc32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1732985] Review Request: ocproxy - OpenConnect Proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1732985 --- Comment #18 from Fedora Update System --- ocproxy-1.60-1.20190728gitc98f06d.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-bccc8d10dc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #16 from Fedora Update System --- shc-4.0.3-1.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-600078c9b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #15 from Fedora Update System --- smcalc-1.0.1-2.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ce121e2285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748012] Review Request: mkrdns - Automatic reverse DNS zone generator
https://bugzilla.redhat.com/show_bug.cgi?id=1748012 --- Comment #14 from Fedora Update System --- mkrdns-3.3-1.20190902git6b3f3a4.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-fa3fec14e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753084] New: Review Request: libdivide - Optimized integer division
https://bugzilla.redhat.com/show_bug.cgi?id=1753084 Bug ID: 1753084 Summary: Review Request: libdivide - Optimized integer division Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jjames.fedorapeople.org/libdivide/libdivide.spec SRPM URL: https://jjames.fedorapeople.org/libdivide/libdivide-2.0-1.fc32.src.rpm Fedora Account System Username: jjames Description: This package contains a header-only C/C++ library for optimizing integer division. Integer division is one of the slowest instructions on most CPUs, e.g. on current x64 CPUs a 64-bit integer division has a latency of up to 90 clock cycles whereas a multiplication has a latency of only 3 clock cycles. libdivide allows you to replace expensive integer division instructions by a sequence of shift, add and multiply instructions that will calculate the integer division much faster. On current CPUs you can get a speedup of up to 10x for 64-bit integer division and a speedup of up to to 5x for 32-bit integer division when using libdivide. libdivide also supports SSE2, AVX2 and AVX512 vector division which provides an even larger speedup. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744388] Review Request: golang-gocloud - Library and tools for open cloud development in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1744388
Elliott Sales de Andrade changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com
Flags||fedora-review+
--- Comment #7 from Elliott Sales de Andrade ---
Latest version is 0.17.0; I think this should include the Go 1.13 patches.
Please add a comment about why tests are skipped.
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated", "*No
copyright* Apache License (v2.0)", "Apache License (v2.0)". 755 files
have unknown license. Detailed output of licensecheck in
1744388-golang-gocloud/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #14 from Fedora Update System --- smcalc-1.0.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3d4de77c4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748012] Review Request: mkrdns - Automatic reverse DNS zone generator
https://bugzilla.redhat.com/show_bug.cgi?id=1748012 --- Comment #13 from Fedora Update System --- mkrdns-3.3-1.20190902git6b3f3a4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-a336bc3b34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #15 from Fedora Update System --- shc-4.0.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d722558857 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750263] Review Request: eralchemy - Entity Relation Diagrams generation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1750263 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Elliott Sales de Andrade --- OK approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752139] Review Request: ucblogo - logo programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1752139 --- Comment #7 from Josh Cogliati --- The license is in the source package in the file gpl. I added a %license with that to the ucblogo.spec I do plan on working on the warnings and submitting them to upstream. Upstream is between releases, so I need to adapt the patches to that source code repository version first, and then I can work on the warnings and other problems. Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752139] Review Request: ucblogo - logo programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1752139 --- Comment #6 from J. Scheurich --- [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v2)". 600 files have unknown license. Detailed output of licensecheck in /home/mufti/review-ucblogo/licensecheck.txt [!]: License file installed when any subpackage combination is installed. Package do not contain a licence file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #13 from Fedora Update System --- smcalc-1.0.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a5a520810c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744287] Review Request: golang-mongodb-mongo-driver - Go driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1744287 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- golang-mongodb-mongo-driver-1.1.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-655c175cd4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #14 from Fedora Update System --- shc-4.0.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3fa0e4ea24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743801] Review Request: golang-contrib-opencensus-exporter-aws - OpenCensus Go exporters for AWS
https://bugzilla.redhat.com/show_bug.cgi?id=1743801 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- golang-contrib-opencensus-exporter-aws-0-0.1.20190917gitc50fb1b.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5b284291f1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- golang-github-gobuffalo-packr-2.6.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743781] Review Request: golang-github-alecthomas-kong-hcl - Kong configuration loader for HCL
https://bugzilla.redhat.com/show_bug.cgi?id=1743781 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- golang-github-alecthomas-kong-hcl-0.2.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-36f5925433 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743806] Review Request: golang-contrib-opencensus-integrations-ocsql - OpenCensus SQL database driver wrapper for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1743806 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- golang-contrib-opencensus-integrations-ocsql-0.1.4-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-42c82e2138 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748012] Review Request: mkrdns - Automatic reverse DNS zone generator
https://bugzilla.redhat.com/show_bug.cgi?id=1748012 --- Comment #12 from Fedora Update System --- mkrdns-3.3-1.20190902git6b3f3a4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fe99c88ed2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744238] Review Request: golang-github-frankban-quicktest - Quick helpers for testing Go applications
https://bugzilla.redhat.com/show_bug.cgi?id=1744238 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- golang-github-frankban-quicktest-1.4.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b42d0adfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752139] Review Request: ucblogo - logo programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1752139
--- Comment #5 from J. Scheurich ---
This is a informal review, i am not in the packager group 8-(
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 1658880 bytes in 27 files.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_documentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2 or later) (with incorrect FSF
address)", "*No copyright* GPL (v2 or later) (with incorrect FSF
address)", "GPL (v2)". 600 files have unknown license. Detailed output
of licensecheck in /home/mufti/review-ucblogo/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/emacs,
/usr/share/emacs/site-lisp, /usr/share/icons/hicolor/256x256,
/usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/man/man1(kxstitch,
filesystem, sysreporter), /usr/share/emacs/site-lisp/site-
start.d(emacs-slime, emacs-irsim-mode, autoconf, emacs-filesystem,
emacs-common, lilypond, gforth, emacs-spice-mode, maxima, asymptote)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[!]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
package has .info files.
Note: Texinfo .info file(s) in ucblogo
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
Note: %makeinstall used in %install section
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv,
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #12 from Fedora Update System --- smcalc-1.0.1-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a8b8916907 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #13 from Fedora Update System --- shc-4.0.3-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-516a85f60b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- shc-4.0.3-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7f939ebcb6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- smcalc-1.0.1-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e90080f6dd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748012] Review Request: mkrdns - Automatic reverse DNS zone generator
https://bugzilla.redhat.com/show_bug.cgi?id=1748012 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- mkrdns-3.3-1.20190902git6b3f3a4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-75352e4f4a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752139] Review Request: ucblogo - logo programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1752139
--- Comment #4 from J. Scheurich ---
BTW, there are warnings while using
$ rpmbuild -ba ucblogo.spec
...
n make-comint:
comint-logo.el:642:26:Warning: Use `with-current-buffer' rather than
save-excursion+set-buffer
In comint-exec:
comint-logo.el:659:51:Warning: Use `with-current-buffer' rather than
save-excursion+set-buffer
...
...
dvipdf usermanual.dvi
for d akehelp.c:9:1: warning: return type defaults to 'int' [-Wimplicit-int]
9 | main() {
| ^~~~
makehelp.c: In function 'main':
makehelp.c:20:2: warning: implicit declaration of function 'exit'
[-Wimplicit-function-declaration]
20 | exit(1);
| ^~~~
makehelp.c:20:2: warning: incompatible implicit declaration of built-in
function 'exit'
makehelp.c:3:1: note: include '' or provide a declaration of 'exit'
2 | #include
+++ |+#include
3 |
...
in html; do [ -d $d ] || mkdir -p $d || exit 1; done
texi2html --expand tex --split chapter --no-iftex usermanual.texi
Unescaped left brace in regex is deprecated here (and will be fatal in Perl
5.32), passed through in regex; marked by <-- HERE in m/^\s+@([^\s\{\}\@]+)({
<-- HERE })?\s*/ at /usr/bin/texi2html line 33105.
usermanual.texi:9: Unknown command `vsize'
usermanual.texi:10: Unknown command `parskip'
usermanual.texi:11: Unknown command `parindent'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554050] Review Request: gli - OpenGL Image (GLI)
https://bugzilla.redhat.com/show_bug.cgi?id=1554050 --- Comment #9 from Ian Hattendorf --- I'm not sure. Unfortunately I don't have time anymore to maintain this package. Is there an orphaned status for packages that aren't yet approved, or should I close it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #19 from Fedora Update System --- pdfarranger-1.3.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1753052] New: Review Request: radsecproxy - Generic RADIUS proxy with RadSec support
https://bugzilla.redhat.com/show_bug.cgi?id=1753052 Bug ID: 1753052 Summary: Review Request: radsecproxy - Generic RADIUS proxy with RadSec support Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: redhat-bugzi...@linuxnetz.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://labs.linuxnetz.de/bugzilla/radsecproxy.spec SRPM URL: https://labs.linuxnetz.de/bugzilla/radsecproxy-1.8.0-1.src.rpm Description: radsecproxy is a generic RADIUS proxy that in addition to usual RADIUS UDP transport, also supports TLS (RadSec), as well as RADIUS over TCP and DTLS. The aim is for the proxy to have sufficient features to be flexible, while at the same time to be small, efficient and easy to configure. Fedora Account System Username: robert -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1715821] Review Request: conmon - OCI container runtime monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1715821 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-18 00:03:29 --- Comment #15 from Fedora Update System --- conmon-2.0.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750983] Review Request: oomd - Userspace Out-Of-Memory (OOM) killer
https://bugzilla.redhat.com/show_bug.cgi?id=1750983 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #14 from Fedora Update System --- oomd-0.2.0-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1708161] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests
https://bugzilla.redhat.com/show_bug.cgi?id=1708161 Bug 1708161 depends on bug 1722656, which changed state. Bug 1722656 Summary: Review Request: python-sybil - Automated testing for the examples in your documentation https://bugzilla.redhat.com/show_bug.cgi?id=1722656 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1751535] Review Request: python-fsspec - File-system specification
https://bugzilla.redhat.com/show_bug.cgi?id=1751535 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-18 00:03:10 --- Comment #6 from Fedora Update System --- python-fsspec-0.4.4-1.fc31~bootstrap has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1722656] Review Request: python-sybil - Automated testing for the examples in your documentation
https://bugzilla.redhat.com/show_bug.cgi?id=1722656 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-18 00:03:07 --- Comment #10 from Fedora Update System --- python-sybil-1.2.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1727348] Review Request: patat - Terminal-based presentations using Pandoc
https://bugzilla.redhat.com/show_bug.cgi?id=1727348 --- Comment #12 from Fedora Update System --- patat-0.8.2.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747574] Review Request: cocotb - Coroutine Co-simulation Test Bench
https://bugzilla.redhat.com/show_bug.cgi?id=1747574
Miro Hrončok changed:
What|Removed |Added
CC||mhron...@redhat.com
--- Comment #3 from Miro Hrončok ---
This will break with Python 3.10:
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2019-ce121e2285 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ce121e2285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #9 from Fedora Update System --- FEDORA-EPEL-2019-3d4de77c4e has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-3d4de77c4e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #8 from Fedora Update System --- FEDORA-2019-a8b8916907 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a8b8916907 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 --- Comment #7 from Fedora Update System --- FEDORA-2019-e90080f6dd has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e90080f6dd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1441427] Review Request: smcalc - Matrix Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1441427 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-a5a520810c has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a5a520810c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2019-600078c9b8 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-600078c9b8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2019-d722558857 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-d722558857 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #9 from Fedora Update System --- FEDORA-2019-516a85f60b has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-516a85f60b -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 --- Comment #8 from Fedora Update System --- FEDORA-2019-7f939ebcb6 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7f939ebcb6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1440687] Review Request: shc - Shell script compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1440687 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2019-3fa0e4ea24 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3fa0e4ea24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744287] Review Request: golang-mongodb-mongo-driver - Go driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1744287 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2019-655c175cd4 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-655c175cd4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744388] Review Request: golang-gocloud - Library and tools for open cloud development in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1744388 --- Comment #6 from Robert-André Mauchin --- I've imported all the deps, could you take a look at it again Elliott? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747574] Review Request: cocotb - Coroutine Co-simulation Test Bench
https://bugzilla.redhat.com/show_bug.cgi?id=1747574
--- Comment #2 from Jerry James ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- About the name of the package, you have asserted that this is not a standard
python library. Yet I look at the tests and the examples, and I see
"import cocotb". I look at the final RPM, and I see a python module plus one
binary, /usr/bin/cocotb-config, which certainly does not sound like the name
of an application. This sure looks like a Python module. I think it should
have the "python-" prefix.
- The "noarch" tag simply means that the exact same files are installed on
every architecture, so that is the right thing to do for now. If upstream
does decide to ship prebuilt libraries, then you'll have to change that.
Even then, though, I would argue for making the main package contain only
the arch-specific bits, and have a noarch subpackage that contains the noarch
bits.
- This line is unnecessary:
Requires: python3dist(setuptools)
If you run "rpm -q --requires" on the binary rpm, you will see something like
this among the results (this is for a Rawhide build):
python3.8dist(setuptools)
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
- These lines in %prep confuse me:
# Remove bundled egg-info
rm -rf %{pypi_name}.egg-info
There is no such directory in the upstream tarball. Even if there were, it
would be egg metadata, not an egg package, so not necesssary to remove. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Eggs/#_upstream_egg_packages
- For the change to the shebang in bin/combine_results.py, in addition to
changing from unversioned python to python3, also get rid of /usr/bin/env,
perhaps like this:
sed 's/env python/python3/g' -i bin/combine_results.py
- You might want to tell upstream about python 3.8 incompatibilities (seen in
the build log):
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_closedown/test_closedown.py:44:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while test_count is not 5:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:296:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while count is not 100:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:397:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while count is not 50:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:406:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while count is not 50:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:545:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 1:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:550:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 0:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:555:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 1:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:560:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 0:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:565:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 1:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_cocotb/test_cocotb.py:570:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if dut.clk.value.integer is not 0:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_discovery/test_discovery.py:178:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if length is not 1:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_discovery/test_discovery.py:355:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if length is not 1:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_external/test_external.py:57:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while test_count is not 5:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_external/test_external.py:67:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
while test_count is not 5:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_external/test_external.py:118:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if test_count is not 5:
/builddir/build/BUILD/cocotb-1.2.0/tests/test_cases/test_external/test_external.py:140:
SyntaxWarning: "is not" with a literal. Did you mean "!="?
if test_count is not 5:
./bin/combine_results.py:55: DeprecationWarning: This method will be removed
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2019-8154a87b30 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8154a87b30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383 --- Comment #10 from Simone Caronni --- > mesos-master.service > mesos-slave.service Please add a Documentation line in both: https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_unit_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744238] Review Request: golang-github-frankban-quicktest - Quick helpers for testing Go applications
https://bugzilla.redhat.com/show_bug.cgi?id=1744238 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2019-1b42d0adfc has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1b42d0adfc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383
--- Comment #9 from Simone Caronni ---
(In reply to Fabio Valentini from comment #7)
> > BuildRequires: python2-devel
>
> You'll either need to drop the python2 bindings from this package, or
> request an exception for the python2 dependency from FESCo.
> No new fedora packages are allowed to depend on python2 without FESCo
> approval.
>
> See: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal
Correct. If you instead plan to build for CentOS/RHEL 7 you can probably
introduce some conditionals. For example:
%if 0%{?fedora} || 0%{?rhel} >= 8
BuildRequires: python3-devel
%else
BuildRequires: python2-devel
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383 --- Comment #8 from Simone Caronni --- > License: ASL 2.0 The license field should contain all licenses, the bundled things have different ones: https://github.com/google/googletest/blob/master/LICENSE https://github.com/cameron314/concurrentqueue/blob/master/LICENSE.md So they need to be displayed in this field. See here on how to combine them: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_combined_dual_and_multiple_licensing_scenario https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_mixed_source_licensing_scenario The NVML header is probably not free: /* * Copyright 1993-2015 NVIDIA Corporation. All rights reserved. * * NOTICE TO USER: * * This source code is subject to NVIDIA ownership rights under U.S. and * international Copyright laws. Users and possessors of this source code * are hereby granted a nonexclusive, royalty-free license to use this code * in individual and commercial software. * * NVIDIA MAKES NO REPRESENTATION ABOUT THE SUITABILITY OF THIS SOURCE * CODE FOR ANY PURPOSE. IT IS PROVIDED "AS IS" WITHOUT EXPRESS OR * IMPLIED WARRANTY OF ANY KIND. NVIDIA DISCLAIMS ALL WARRANTIES WITH * REGARD TO THIS SOURCE CODE, INCLUDING ALL IMPLIED WARRANTIES OF * MERCHANTABILITY, NONINFRINGEMENT, AND FITNESS FOR A PARTICULAR PURPOSE. * IN NO EVENT SHALL NVIDIA BE LIABLE FOR ANY SPECIAL, INDIRECT, INCIDENTAL, * OR CONSEQUENTIAL DAMAGES, OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS * OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE * OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE * OR PERFORMANCE OF THIS SOURCE CODE. * * U.S. Government End Users. This source code is a "commercial item" as * that term is defined at 48 C.F.R. 2.101 (OCT 1995), consisting of * "commercial computer software" and "commercial computer software * documentation" as such terms are used in 48 C.F.R. 12.212 (SEPT 1995) * and is provided to the U.S. Government only as a commercial end item. * Consistent with 48 C.F.R.12.212 and 48 C.F.R. 227.7202-1 through * 227.7202-4 (JUNE 1995), all U.S. Government End Users acquire the * source code with only those rights set forth herein. * * Any use of this source code in individual and commercial software must * include, in the user documentation and internal comments to the code, * the above Disclaimer and U.S. Government End Users Notice. */ If you want to compile against we need to block FE-Legal: https://fedoraproject.org/wiki/Legal:Main#FE-Legal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383 --- Comment #7 from Fabio Valentini --- > BuildRequires: python2-devel You'll either need to drop the python2 bindings from this package, or request an exception for the python2 dependency from FESCo. No new fedora packages are allowed to depend on python2 without FESCo approval. See: https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383
--- Comment #6 from Simone Caronni ---
> BuildRequires: systemd
> BuildRequires: systemd
Duplicate BuildRequires.
Also please sort all the BuildRequires tags all together, they are in 3 blocks
not in alphabetical order and with no explanation. Makes spotting obvious
mistakes a bit harder.
> %description
> Apache Mesos is a cluster manager that provides efficient resource
> isolation and sharing across distributed applications, or frameworks.
> It can run Hadoop, MPI, Hypertable, Spark, and other applications on
> a dynamically shared pool of nodes.
Please align to 80 characters columns, if possible.
> Group:Development/Libraries
Remove all the Groups tags, they are obsolete since RHEL 5.
> Requires: mesos%{?_isa} = %{version}-%{release}
Should be %{name}%{?_isa}, for consistency.
> BuildRequires: python2-devel
Do not sort BuildRequires in the subpackage definition. It is also a duplicate.
> %setup -q
> %patch0 -p1 -F2
Please use the %autosetup macro. Also do not change the fuzz lines, the strict
fuzz rules are there to avoid patching the wrong block (it happened!). Rebase
the patch if necessary.
> # Apparently bundled:
> # 1. CSI spec: https://github.com/container-storage-interface/spec/releases
> # 2. ConcurrentQueue: https://github.com/cameron314/concurrentqueue
> # 3. File gmock-all.cc from Google Gmock: https://github.com/google/googletest
> # 4. Nvidia GPU deployment kit nvml.h header file.
> cd 3rdparty
> tar xzf concurrentqueue-7b69a8f.tar.gz
> tar xzf googletest-release-1.8.0.tar.gz
> tar xzf nvml-352.79.tar.gz
> cd ..
If this is the case, then they must be listed in the bundled Provides tags.
> %make_build %{?_smp_mflags} V=1
Remove _smp_mflags, it's already part of the macro:
$ rpm --showrc | grep make_build
-13: make_build %{__make} %{_make_output_sync} %{?_smp_mflags}
> %if %skiptests
> echo "Skipping tests, do to mock issues"
> %else
> export LD_LIBRARY_PATH=`pwd`/src/.libs
> make check
> %endif
I would not print anything if disabled, maybe add a comment, but as you wish.
If you want to keep the output then typo (s/do/due/g).
> %{__python2} setup.py install --root=%{buildroot} --prefix=/usr
Use %{_prefix} instead of explicit /usr.
> # fedora guidelines no .a|.la
> rm -f %{buildroot}%{_libdir}/*.la
> rm -f %{buildroot}%{_libdir}/libexamplemodule*
> rm -f %{buildroot}%{_libdir}/libtest*
> rm -f %{buildroot}/%{_libdir}/%{name}/modules/*.la
You can probably just do something like:
find %{buildroot} -name '*.a' -o -name '*.la' -delete
But as you prefer.
> mkdir -p -m0755 %{buildroot}%{_sysconfdir}/tmpfiles.d
> install -m 0644 %{SOURCE1} %{buildroot}%{_sysconfdir}/tmpfiles.d/%{name}.conf
> %config(noreplace) %{_sysconfdir}/tmpfiles.d/%{name}.conf
Please replace these with the macro and don't mark it as a config file as it is
under /usr/lib/tmpfiles.d/:
mkdir -p -m0755 %{buildroot}%{_tmpfilesdir}
install -m 0644 %{SOURCE1} %{buildroot}%{_tmpfilesdir}/%{name}.conf
%{_tmpfilesdir}/%{name}.conf
> mkdir -p -m0755 %{buildroot}/%{_var}/log/%{name}
> mkdir -p -m0755 %{buildroot}/%{_var}/lib/%{name}
Please use:
mkdir -p -m0755 %{buildroot}/%{_localstatedir}/log/%{name}
mkdir -p -m0755 %{buildroot}/%{_sharedstatedir}/%{name}
> install -m
> cp -rf
Please replace with "install -p -m" as you are supposed to preserve timestamps
if possible. Same for cp, you can use the -a switch (for example).
> pathfix.py -pni "%{__python2} %{py2_shbang_opts}"
> %{buildroot}/usr/bin/mesos-cat
> pathfix.py -pni "%{__python2} %{py2_shbang_opts}"
> %{buildroot}/usr/bin/mesos-scp
> pathfix.py -pni "%{__python2} %{py2_shbang_opts}"
> %{buildroot}/usr/bin/mesos-ps
> pathfix.py -pni "%{__python2} %{py2_shbang_opts}"
> %{buildroot}/usr/bin/mesos-tail
> pathfix.py -pni "/usr/bin/bash" %{buildroot}/usr/share/mesos/examples
> pathfix.py -pni "/usr/bin/bash" %{buildroot}/usr/sbin/mesos*.sh
Please be consistent across the SPEC file, replace those paths with %{_bindir},
%{_sbindir}, and %{_datadir}.
> %files
> %doc LICENSE NOTICE
It should be:
%files
%license LICENSE
%doc NOTICE
Also, the license is fine in a reduced number of packages as long as it is
installed in any combination of the packages being installed. Considering the
base mesos package is required by all subpackages, you can skip entirely the
%license and %doc tag in all subpackages.
> %{_libdir}/*.so
Why is this unversioned? If it can not be versioned it needs an explanation or
to be moved to a different path.
> if ! getent passwd mesos >/dev/null ; then
> useradd -r -g mesos -d %{_sharedstatedir}/%{name} -s /sbin/nologin \
> -c "%{name} daemon account" mesos
> fi
Please use the packaging guidelines format, and especially add the shadow-utils
requirement:
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/#_dynamic_allocation
Also, you can probably use a variable at the top of the file:
%global user mesos
%global group mesos
[Bug 1744144] Review Request: golang-github-gobuffalo-packr - Simple and easy way to embed static files into Go binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1744144 --- Comment #9 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-gobuffalo-packr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1747574] Review Request: cocotb - Coroutine Co-simulation Test Bench
https://bugzilla.redhat.com/show_bug.cgi?id=1747574 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #1 from Jerry James --- I can take this review. I'll have something later tonight to ask you to review. It should be really easy; it's a header-only development library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1749383] Review Request: mesos - Apache Mesos Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1749383 --- Comment #5 from Simone Caronni --- (In reply to Javi Roman from comment #0) > Spec URL: > https://src.fedoraproject.org/fork/jromanes/rpms/mesos/blob/f30/f/mesos.spec This is not the raw file, so it can not be downloaded by the review. In case of changes post the link to the raw file. I'll do with the local files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743781] Review Request: golang-github-alecthomas-kong-hcl - Kong configuration loader for HCL
https://bugzilla.redhat.com/show_bug.cgi?id=1743781 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #9 from Fedora Update System --- FEDORA-2019-36f5925433 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-36f5925433 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752288] Review Request: coin - High-level 3D visualization library
https://bugzilla.redhat.com/show_bug.cgi?id=1752288 Richard Shaw changed: What|Removed |Added Summary|Review Request: Coin4 - |Review Request: coin - |High-level 3D visualization |High-level 3D visualization |library |library --- Comment #8 from Richard Shaw --- SPEC: https://hobbes1069.fedorapeople.org/coin.spec SRPM: https://hobbes1069.fedorapeople.org/coin-4.0.0-2.fc30.src.rpm * Tue Sep 17 2019 Richard Shaw - 4.0.0-2 - Update spec file per reviewer comments. - Change package name from Coin4 to coin. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743806] Review Request: golang-contrib-opencensus-integrations-ocsql - OpenCensus SQL database driver wrapper for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1743806 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-42c82e2138 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-42c82e2138 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743801] Review Request: golang-contrib-opencensus-exporter-aws - OpenCensus Go exporters for AWS
https://bugzilla.redhat.com/show_bug.cgi?id=1743801 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2019-5b284291f1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5b284291f1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750823] Review Request: virt-p2v - Convert a physical machine to run on KVM
https://bugzilla.redhat.com/show_bug.cgi?id=1750823 Pino Toscano changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-09-17 16:15:55 --- Comment #9 from Pino Toscano --- - packaging successfully imported - 'rjones' added as admin as requested - successful build done: https://koji.fedoraproject.org/koji/taskinfo?taskID=37707755 - bodhi update for rawhide sent: https://bodhi.fedoraproject.org/updates/FEDORA-2019-36f9e6e2a9 We will soon disable virt-p2v from the libguestfs source -- everything needed for this ticket seems to be done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library
https://bugzilla.redhat.com/show_bug.cgi?id=1752288 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- I think it's OK to have just once package with all the docs... This satisfies the main optimization, namely that this doesn't get pulled in through deps and on the buildroot. Real users don't care about a few megs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library
https://bugzilla.redhat.com/show_bug.cgi?id=1752288 --- Comment #6 from Richard Shaw --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > (In reply to Richard Shaw from comment #4) > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > > Naming: Coin4 → coin4 > > > [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > > > #_general_naming] > > > Provides:Coin4 can be added. > > > > I'm not necessarily against this but I was trying to stay consistent with > > Coin2 and Coin3 already in Fedora... > > Yeah. The guidelines say "SHOULD" so it's your choice. I try to push all new > packages to use lowercase, but that's just a preference. After thinking about it a bit I'm seriously considering just calling it "coin" that's what Debian does (well libcoin for the resultant package) and the provided RPM Spec calls it "Coin". Considering that typically when you have multiple major versions the number at the end of the package would be the soversion (not the release version) but I think that Coin2 and Coin3 are close enough :) So probably call this just plain "coin" as it's the latest release and do a Proivdes: Coin4 for consistency. I'll do the same for the -devel package. > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > > fedora-review says: > > > - Large documentation must go in a -doc subpackage. Large could be size > > > (~1MB) or number of files. > > > Note: Documentation size is 127211520 bytes in 4678 files. > > > > > > Yep, /usr/share/doc/Coin4/html should move to -doc subpackage. > > > > Yeah, the guidelines are somewhat ambiguous here... so -doc or > > -devel-doc? :) > > -doc. I agree in principle, as that's what the guidelines say, but the don't cover the fact that some of it is end user documentation (-doc) where in this case it's only useful for developers, hence my thoughts to call it -devel-doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1302904] Review Request: cacti - re-review
https://bugzilla.redhat.com/show_bug.cgi?id=1302904 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:50:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1394962] Review Request: clevis - Automated decryption framework
https://bugzilla.redhat.com/show_bug.cgi?id=1394962 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:48:49 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750823] Review Request: virt-p2v - Convert a physical machine to run on KVM
https://bugzilla.redhat.com/show_bug.cgi?id=1750823 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/virt-p2v -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1317178] Review Request: tcllauncher - launcher for Tcl applications
https://bugzilla.redhat.com/show_bug.cgi?id=1317178 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |INSUFFICIENT_DATA Flags|fedora-review+ | Last Closed||2019-09-17 15:45:42 --- Comment #8 from Zbigniew Jędrzejewski-Szmek --- It seems this was never built. If the package is needed, re-review will be required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1430107] Review Request: python-pymacaroons-pynacl - a Python implementation of Macaroons
https://bugzilla.redhat.com/show_bug.cgi?id=1430107 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:44:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal
https://bugzilla.redhat.com/show_bug.cgi?id=1341662 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:43:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1538658] Review Request: python-anyconfig - common API to load and dump configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1538658 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:43:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1388908] Review Request: python-flask-bootstrap - Python flask bootstrap
https://bugzilla.redhat.com/show_bug.cgi?id=1388908 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2019-09-17 15:41:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1317939] Review Request: dump1090 - Decode ADS-B messages from RTL-SDR
https://bugzilla.redhat.com/show_bug.cgi?id=1317939 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed||2019-09-17 15:40:42 --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- Let's close this. Feel free to restart the process at any time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750501] Review Request: fastbit - An Efficient Compressed Bitmap Index Technology (UNRETIRE)
https://bugzilla.redhat.com/show_bug.cgi?id=1750501 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||fastbit-2.0.3-14.fc29 Resolution|--- |RAWHIDE Last Closed||2019-09-17 15:40:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1358959] Review Request: nsntrace - Perform network trace of a program using network namespaces
https://bugzilla.redhat.com/show_bug.cgi?id=1358959 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed||2019-09-17 15:39:15 --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- Let's close this. Feel free to restart the process at any time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1200889] Review Request: lpod-python - a python library implementing the OpenDocument Format standard
https://bugzilla.redhat.com/show_bug.cgi?id=1200889 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed||2019-09-17 15:37:33 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- Let's close this. Feel free to restart the process at any time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1200893] Review Request: odpdown - a generator of OpenDocument Presentation files from markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1200893 Bug 1200893 depends on bug 1200889, which changed state. Bug 1200889 Summary: Review Request: lpod-python - a python library implementing the OpenDocument Format standard https://bugzilla.redhat.com/show_bug.cgi?id=1200889 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1362130] Review Request: olpcau-abc123-fonts - A nice font for kids/readability
https://bugzilla.redhat.com/show_bug.cgi?id=1362130 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed||2019-09-17 15:37:10 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Let's close this. Feel free to restart the process at any time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752288] Review Request: Coin4 - High-level 3D visualization library
https://bugzilla.redhat.com/show_bug.cgi?id=1752288 --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- (In reply to Richard Shaw from comment #4) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Naming: Coin4 → coin4 > > [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > > #_general_naming] > > Provides:Coin4 can be added. > > I'm not necessarily against this but I was trying to stay consistent with > Coin2 and Coin3 already in Fedora... Yeah. The guidelines say "SHOULD" so it's your choice. I try to push all new packages to use lowercase, but that's just a preference. > > Though I wonder one thing: is is worth to bother with > > alternatives? > > Maybe just make coin*-devel packages Conflict with each other? The user > > doesn't get > > much benefit either way: it is still not possible to build against multiple > > Coin versions > > at the same time, and conflicting packages are easier to implement. > > Yeah, I considered both but decided to stay consistent with Ralf's packages > as it does let you switch between them if you are actively developing with > the Coin3D stack, but yes, it serves no purpose on Fedora Infra. OK. > (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > fedora-review says: > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 127211520 bytes in 4678 files. > > > > Yep, /usr/share/doc/Coin4/html should move to -doc subpackage. > > Yeah, the guidelines are somewhat ambiguous here... so -doc or > -devel-doc? :) -doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752210] Review Request: json-table - Command-line tool to transform nested JSON into tabular data
https://bugzilla.redhat.com/show_bug.cgi?id=1752210 Raphael Groner changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-09-17 15:13:17 --- Comment #6 from Raphael Groner --- Imported and built in rawhide. More builds may follow, e.g. for epel7 and epel8, later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750823] Review Request: virt-p2v - Convert a physical machine to run on KVM
https://bugzilla.redhat.com/show_bug.cgi?id=1750823 Pino Toscano changed: What|Removed |Added Link ID||Fedora Pagure ||releng/fedora-scm-requests/ ||issue/16861 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1748012] Review Request: mkrdns - Automatic reverse DNS zone generator
https://bugzilla.redhat.com/show_bug.cgi?id=1748012 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2019-fa3fec14e3 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-fa3fec14e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1744287] Review Request: golang-mongodb-mongo-driver - Go driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1744287 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-mongodb-mongo-driver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743781] Review Request: golang-github-alecthomas-kong-hcl - Kong configuration loader for HCL
https://bugzilla.redhat.com/show_bug.cgi?id=1743781 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-kong-hcl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743806] Review Request: golang-contrib-opencensus-integrations-ocsql - OpenCensus SQL database driver wrapper for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1743806 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-contrib-opencensus-integrations-ocsql -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1743801] Review Request: golang-contrib-opencensus-exporter-aws - OpenCensus Go exporters for AWS
https://bugzilla.redhat.com/show_bug.cgi?id=1743801 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-contrib-opencensus-exporter-aws -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1750263] Review Request: eralchemy - Entity Relation Diagrams generation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1750263 --- Comment #5 from Pavel Raiskup --- > You have %_bindir/eralchemy listed in two subpackages Fixed. Spec URL: https://raw.githubusercontent.com/praiskup/rpm-eralchemy/4efe33e4acfc6a9c6f1d587376ce282c3cfde879/eralchemy.spec SRPM URL: http://praiskup.fedorapeople.org/eralchemy-1.2.10-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752298] Review Request: python-wurlitzer - Capture C-level output in context managers
https://bugzilla.redhat.com/show_bug.cgi?id=1752298 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-wurlitzer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides
https://bugzilla.redhat.com/show_bug.cgi?id=1752864 Miro Hrončok changed: What|Removed |Added Blocks||1752872 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1752872 [Bug 1752872] Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752872] Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services
https://bugzilla.redhat.com/show_bug.cgi?id=1752872 Miro Hrončok changed: What|Removed |Added Blocks||1737937 Depends On||1752864 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1737937 [Bug 1737937] bzr depends on Python 2 https://bugzilla.redhat.com/show_bug.cgi?id=1752864 [Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752872] New: Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services
https://bugzilla.redhat.com/show_bug.cgi?id=1752872 Bug ID: 1752872 Summary: Review Request: python-lazr-restfulclient - Programmable client library for lazr.restful web services Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-lazr-restfulclient.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-lazr-restfulclient-0.14.2-1.fc30.src.rpm Description: A programmable client library that takes advantage of the commonalities among lazr.restful web services to provide added functionality on top of wadllib. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752859] Review Request: python-lazr-uri - Parsing and dealing with URIs
https://bugzilla.redhat.com/show_bug.cgi?id=1752859 Miro Hrončok changed: What|Removed |Added Blocks||1752864 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1752864 [Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752864] New: Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides
https://bugzilla.redhat.com/show_bug.cgi?id=1752864 Bug ID: 1752864 Summary: Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-wadllib.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-wadllib-1.3.3-1.fc30.src.rpm Description: A Python library to navigate HTTP resources using WADL files as guides. Fedora Account System Username: churchyard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1752864] Review Request: python-wadllib - Navigate HTTP resources using WADL files as guides
https://bugzilla.redhat.com/show_bug.cgi?id=1752864 Miro Hrončok changed: What|Removed |Added Depends On||1752859 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1752859 [Bug 1752859] Review Request: python-lazr-uri - Parsing and dealing with URIs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
