[Bug 1785069] Review request: lector -- ebook reader and collection manager
https://bugzilla.redhat.com/show_bug.cgi?id=1785069 --- Comment #4 from Andrew Toskin --- Updated package spec. Spec URL: https://gitlab.com/terrycloth/packaging-lector/uploads/f26f97bd418649ed836fa71fbe9c455f/lector.spec SRPM URL: https://gitlab.com/terrycloth/packaging-lector/uploads/a333eb46140fbb9e42d114efe6d61403/lector-0.5.1-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785069] Review request: lector -- ebook reader and collection manager
https://bugzilla.redhat.com/show_bug.cgi?id=1785069 --- Comment #3 from Andrew Toskin --- Oh, thank you. I hadn't expected any feedback before I announced this package on the devel mailing list, but I appreciate it :) > Why isn't it noarch? I'm vaguely aware that Python is an interpreted language -- or at least, it can be, depending on the impelementation? -- but I thought that the compiled .pyc files meant that Python packages on Fedora were architecture-dependent after all. But I guess maybe not, if it's only byte code for the CPython VM? > See https://src.fedoraproject.org/rpms/python-djvulibre Ah, okay. I'd only searched for packages in dnf (and I'm still currently using Fedora 30 as my main workstation). And I see you included a generated spec for the DjVuLibre bindings package too. If I can just revive that old package, then that should make things a bit easier, thanks. See Bug #1786210. > python-markdown is in F31 and F32. Use a Recommends here if you need. Okay, sure. If the maintainer can't or won't backport python-markdown for F30, then setting that dependency to a Recommend might be good enough... Although, if I can't get python-lxml backported, there may not be much point in building Lector for F30 anyway, since users are most likely to expect Epub support. > Python requires are not necessary, they are autodetected on Fedora (not EPEL) Well, I do want to support EPEL, if feasible. I'll take a look at building on CentOS 8 sometime this week, and then we can decide whether to worry about EPEL stuff. > Consider providing an Appdata file Oh, yes, I'll put together the AppData/AppStream files and see if the upstream is willing to accept them into the main repository... https://github.com/BasioMeusPuga/Lector/issues/118 > Translations don't seem to work, ask upstream about it? Okay. If this is possibly a bug in upstream, then I'm not really sure where to start troubleshooting. So I basically just restate my original questions on their GitHub... https://github.com/BasioMeusPuga/Lector/issues/117 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786210] Review request: python-djvulibre -- Python bindings for the free DjVuLibre implementation of the DjVu file format
https://bugzilla.redhat.com/show_bug.cgi?id=1786210 Andrew Toskin changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Andrew Toskin --- NOTE this is a work-in-progress package spec, for an optional library to provide DjVu support to the ebook reader in Lector -- whose package is also a work in progress... See Bug #1785069. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786210] New: Review request: python-djvulibre -- Python bindings for the free DjVuLibre implementation of the DjVu file format
https://bugzilla.redhat.com/show_bug.cgi?id=1786210 Bug ID: 1786210 Summary: Review request: python-djvulibre -- Python bindings for the free DjVuLibre implementation of the DjVu file format Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: and...@tosk.in QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://gitlab.com/terrycloth/packaging-python-djvulibre/uploads/ce76e5c4cd2cc131f47066128cd39c81/python-djvulibre.spec SRPM URL: https://gitlab.com/terrycloth/packaging-python-djvulibre/uploads/6cc66733cd0dda9b794113a79fa0938d/python-djvulibre-0.8.5-1.fc32.src.rpm Description: python-djvulibre is a set of Python bindings for the DjVuLibre library, an open source implementation of DjVu. Fedora Account System Username: terrycloth -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786207] Review Request: python-aiozmq - ZeroMQ integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1786207 Mukundan Ragavan changed: What|Removed |Added CC||zbys...@in.waw.pl Doc Type|--- |If docs needed, set a value --- Comment #1 from Mukundan Ragavan --- Turns out the master branch of aiozmq has lots of fixes for building on recent versions of python. The spec/srpm above uses the master branch for the package. v0.8.0 was released in Dec 2016 and upstream has not released newer versions although there has been activity in the git repo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786207] New: Review Request: python-aiozmq - ZeroMQ integration with asyncio
https://bugzilla.redhat.com/show_bug.cgi?id=1786207 Bug ID: 1786207 Summary: Review Request: python-aiozmq - ZeroMQ integration with asyncio Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: nonamed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd1/python-aiozmq.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd1/python-aiozmq-0.8.0-2.20191223git56065a26.fc31.src.rpm Description: asyncio (PEP 3156) support for ZeroMQ, a messaging library. Features: * Implements create_zmq_connection() coroutine for making 0MQ connections. * Provides ZmqTransport and ZmqProtocol * Provides RPC Request-Reply, Push-Pull and Publish-Subscribe patterns for remote calls. Fedora Account System Username: nonamedotc koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39899386 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785977 --- Comment #3 from Mukundan Ragavan --- I have made the changes pointed out. I have implemented the patch from the upstream PR using sed. Modified SPEC: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd2/python-helpdev.spec Modified SRPM: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd2/python-helpdev-0.6.10-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786204] Review Request: golang-github-youmark-pkcs8 - Parse and convert private keys in PKCS#8 format
https://bugzilla.redhat.com/show_bug.cgi?id=1786204 --- Comment #1 from Robert-André Mauchin --- Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39898938 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for Flask applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785983 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-socketio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786204] New: Review Request: golang-github-youmark-pkcs8 - Parse and convert private keys in PKCS#8 format
https://bugzilla.redhat.com/show_bug.cgi?id=1786204 Bug ID: 1786204 Summary: Review Request: golang-github-youmark-pkcs8 - Parse and convert private keys in PKCS#8 format Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: zebo...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-youmark-pkcs8.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-youmark-pkcs8-1.1-1.fc32.src.rpm Description: Go package implementing functions to parse and convert private keys in PKCS#8 format, as defined in RFC5208 and RFC5958. Fedora Account System Username: eclipseo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings
https://bugzilla.redhat.com/show_bug.cgi?id=1785968 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-versioneer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params
https://bugzilla.redhat.com/show_bug.cgi?id=1785967 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-apply-defaults -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785981] Review Request: python-socketio - Socket.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785981 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-socketio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for Flask applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785983 --- Comment #2 from Mukundan Ragavan --- I will add the following description so that it is clear what the package is - "Flask-SocketIO gives Flask applications access to low latency bi-directional communications between the clients and the server. The client-side application can use any of the SocketIO official clients libraries in Javascript, C++, Java and Swift, or any compatible client to establish a permanent connection to the server." Taken from the docs. Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings
https://bugzilla.redhat.com/show_bug.cgi?id=1785968 --- Comment #2 from Mukundan Ragavan --- Thanks! I will update make all the changes pointed out during import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params
https://bugzilla.redhat.com/show_bug.cgi?id=1785967 --- Comment #2 from Mukundan Ragavan --- Thanks for the review. I will update the spec and will try and improve the description. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785981] Review Request: python-socketio - Socket.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785981
--- Comment #2 from Mukundan Ragavan ---
Thanks for the review.
I will update the spec with %{expand:...} and add the following description
instead of the current one.
"Socket.IO is a transport protocol that enables real-time bidirectional
event-based communication between clients (typically, though not always, web
browsers) and a server. The official implementations of the client and server
components are written in JavaScript. This package provides Python
implementations of both, each with standard and asyncio variants."
Taken, in verbatim, from docs.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785979] Review Request: python-engineio - Engine.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785979 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-engineio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785979] Review Request: python-engineio - Engine.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785979
--- Comment #2 from Mukundan Ragavan ---
Thanks for the review. I will update the specfile with %{expand:...} macro when
I import into dist-git.
I will update the description as follows when I import:
"Engine.IO is a lightweight transport protocol that enables real-time
bidirectional event-based communication between clients (typically, though not
always, web browsers) and a server. The official implementations of the client
and server components are written in JavaScript. This package provides Python
implementations of both, each with standard and asyncio variants."
Taken directly from the py-engineio docs.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786109] Review Request: scottfree - Interpreter for Scott Adams format text adventure games
https://bugzilla.redhat.com/show_bug.cgi?id=1786109 Andrea Musuruane changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767998] Review Request: mbpfan - A simple daemon to control fan speed on all MacBook/MacBook Pros
https://bugzilla.redhat.com/show_bug.cgi?id=1767998 --- Comment #14 from Fedora Update System --- FEDORA-2019-8f2dde35e7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8f2dde35e7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785852] Review Request: rust-rust_hawktracer_proc_macro - Helper crate for hawktracer profiling library
https://bugzilla.redhat.com/show_bug.cgi?id=1785852 Robert-André Mauchin changed: What|Removed |Added Blocks||1785849 ||(rust-rust_hawktracer) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785849 [Bug 1785849] Review Request: rust-rust_hawktracer - Rust bindings for hawktracer profiling library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library
https://bugzilla.redhat.com/show_bug.cgi?id=1785853 Robert-André Mauchin changed: What|Removed |Added Blocks||1785849 ||(rust-rust_hawktracer) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785849 [Bug 1785849] Review Request: rust-rust_hawktracer - Rust bindings for hawktracer profiling library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785851] Review Request: rust-rust_hawktracer_normal_macro - Helper crate for hawktracer profiling library
https://bugzilla.redhat.com/show_bug.cgi?id=1785851 Robert-André Mauchin changed: What|Removed |Added Blocks||1785849 ||(rust-rust_hawktracer) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785849 [Bug 1785849] Review Request: rust-rust_hawktracer - Rust bindings for hawktracer profiling library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785899] Review Request: rust-rav1e - Fastest and safest AV1 encoder
https://bugzilla.redhat.com/show_bug.cgi?id=1785899 Robert-André Mauchin changed: What|Removed |Added Depends On||1785849 ||(rust-rust_hawktracer) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785849 [Bug 1785849] Review Request: rust-rust_hawktracer - Rust bindings for hawktracer profiling library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785849] Review Request: rust-rust_hawktracer - Rust bindings for hawktracer profiling library
https://bugzilla.redhat.com/show_bug.cgi?id=1785849 Robert-André Mauchin changed: What|Removed |Added Blocks||1785899 (rust-rav1e) Depends On||1785851 ||(rust-rust_hawktracer_norma ||l_macro), 1785852 ||(rust-rust_hawktracer_proc_ ||macro), 1785853 ||(rust-rust_hawktracer_sys) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785851 [Bug 1785851] Review Request: rust-rust_hawktracer_normal_macro - Helper crate for hawktracer profiling library https://bugzilla.redhat.com/show_bug.cgi?id=1785852 [Bug 1785852] Review Request: rust-rust_hawktracer_proc_macro - Helper crate for hawktracer profiling library https://bugzilla.redhat.com/show_bug.cgi?id=1785853 [Bug 1785853] Review Request: rust-rust_hawktracer_sys - Sys crate for the rust_hawktracer library https://bugzilla.redhat.com/show_bug.cgi?id=1785899 [Bug 1785899] Review Request: rust-rav1e - Fastest and safest AV1 encoder -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763459] Review Request: rust-multipart - Backend-agnostic extension for HTTP libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1763459 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2019-12-23 17:51:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params
https://bugzilla.redhat.com/show_bug.cgi?id=1785967
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
%{python3_sitelib}/apply_defaults → %{python3_sitelib}/apply_defaults/
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
%description is incomprehensible ;( I assume this is something about rewriting
python function signatures... but the description should be more explicit.
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785968] Review Request: python-versioneer - Easy VCS-based management of project version strings
https://bugzilla.redhat.com/show_bug.cgi?id=1785968
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
"version- control system" — space after "-" should be removed.
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/__pycache__/*
is repeated. It would be better to not use a glob, but something like
%{python3_sitelib}/__pycache__/%{pypi_name}.*.py*
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info – add "/" a the end
if this is a directory.
+ package name is OK
+ license is acceptable for Fedora (public domain)
+ license is specified correctly
→ please use "Public Domain" (capitalized), as in
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List.
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for Flask applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785983 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1785970 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785970 [Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional params
https://bugzilla.redhat.com/show_bug.cgi?id=1785967 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1785970 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1785970 [Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785970] Review Request: python-jsonrpcserver - Process JSON-RPC requests
https://bugzilla.redhat.com/show_bug.cgi?id=1785970
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
Depends On||1785983, 1785967
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
CHANGELOG.md can be added to %doc.
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
- R/P/BR look OK, but some packages are not installable:
- nothing provides python3dist(aiozmq) needed by
python3-jsonrpcserver-4.0.5-1.fc32.noarch
- nothing provides python3.8dist(apply-defaults) < 1 needed by
python3-jsonrpcserver-4.0.5-1.fc32.noarch
- nothing provides python3dist(apply-defaults) < 1 needed by
python3-jsonrpcserver-4.0.5-1.fc32.noarch
I assume apply-default will be solved by #1785967, but aiozmq seems a problem
as you said in your mail.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785967
[Bug 1785967] Review Request: python-apply-defaults - Apply values to optional
params
https://bugzilla.redhat.com/show_bug.cgi?id=1785983
[Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for
Flask applications
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785982] Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- I'll review this once the two reviews this depends on move forward. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785983] Review Request: python-flask-socketio - Socket.IO integration for Flask applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785983
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
Package name should not be repeated in %description. Expanding the %description
a bit would be nice too.
http://github.com/miguelgrinberg/Flask-SocketIO/ → https://
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
%{python3_sitelib}/flask_socketio → %{python3_sitelib}/flask_socketio/
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785974] Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets
https://bugzilla.redhat.com/show_bug.cgi?id=1785974 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Depends On||1770859 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1770859 [Bug 1770859] python3-watchdog fails to install in Fedora rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785974] Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets
https://bugzilla.redhat.com/show_bug.cgi?id=1785974 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Oh, we have python3-watchdog, but it FTI: - nothing provides python3.8dist(pathtools) >= 0.1.1 needed by python3-watchdog-0.8.3-13.fc32.noarch https://bugzilla.redhat.com/show_bug.cgi?id=1770859 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785974] Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets
https://bugzilla.redhat.com/show_bug.cgi?id=1785974
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
%{python3_sitelib}/%{pypi_name} — please add "/" at the end.
- nothing provides python3.8dist(pathtools) >= 0.1.1 needed by
python3-watchdog-0.8.3-13.fc32.noarch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785981] Review Request: python-socketio - Socket.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785981
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
The Summary or %description should say what this package is for, at least a
little bit.
If someone (like me) doesn't know what Socket.IO is, it is hard to figure out
anything
about the package right now.
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785979] Review Request: python-engineio - Engine.IO server
https://bugzilla.redhat.com/show_bug.cgi?id=1785979
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
The Summary or %description should say what this package is for, at least a
little bit.
If someone (like me) doesn't know what Engine.IO is, it is hard to figure out
anything
about the package right now.
%description is repeated, defining it once as a macro using %{expand:} would
be nice.
+ package name is OK
+ license is acceptable for Fedora (MIT)
+ license is specified correctly
+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785977 --- Comment #2 from Zbigniew Jędrzejewski-Szmek --- Ah, the package is retired with https://src.fedoraproject.org/rpms/python-importlib-metadata/blob/master/f/dead.package: Use the standard library importlib.metadata module instead. https://gitlab.com/dpizetta/helpdev/merge_requests/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785977] Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #1 from Zbigniew Jędrzejewski-Szmek ---
The package name is repeated in summary unnecessarily in summary.
%description is repeated. I'd suggest the standard trick with %expand:
%global _description %{expand:
Helping users and developers to get information about the environment to report
bugs or even test your system without spending a day on it. It can get
information about hardware, OS, paths, Python distribution and packages,
including Qt-things.}
%description %_description
%description -n python3-%{pypi_name} %_description
> # install license file
> mkdir -p %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}/
> cp -pr %{SOURCE1} %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}
It should suffice to do
> %prep
> cp ${SOURCE1} .
But looking at the upstream repo, it already includes a license. Why not use
that file?
If it is not included in the pypi tarball, then provide a full URL to it:
Source1: https://gitlab.com/dpizetta/helpdev/raw/master/LICENSE.rst
Anyway, package looks good.
+ name is OK
+ license is acceptable (MIT)
+ license is specified correctly (upstream talks about CC-BY-4.0 for images,
but there
are no images in the binary package, so this doesn't apply).
+ builds OK
+ P/BR look OK
Unfortunately the package does not install:
- nothing provides python3dist(importlib-metadata) needed by
python3-helpdev-0.6.10-1.fc32.noarch
- nothing provides python3.8dist(importlib-metadata) needed by
python3-helpdev-0.6.10-1.fc32.noarch
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763459] Review Request: rust-multipart - Backend-agnostic extension for HTTP libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1763459 --- Comment #13 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-multipart -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785976] Review Request: git-lab-porcelain - Git porcelain for working with git-lab [FirstPackage, NeedSponsor]
https://bugzilla.redhat.com/show_bug.cgi?id=1785976 Neil Horman changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Neil Horman --- approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785365] Review Request: gap-pkg-caratinterface - GAP interface to CARAT
https://bugzilla.redhat.com/show_bug.cgi?id=1785365 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-caratinterface -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1784590] Review Request: quarter - Lightweight glue library between Coin and Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1784590 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/quarter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785976] Review Request: git-lab-porcelain - Git porcelain for working with git-lab [FirstPackage, NeedSponsor]
https://bugzilla.redhat.com/show_bug.cgi?id=1785976
--- Comment #1 from Neil Horman ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 8 files have unknown license. Detailed
output of licensecheck in /home/nhorman/1785976-git-lab-
porcelain/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[Bug 1785495] Review Request: python-pwntools - A CTF framework and exploit development library
https://bugzilla.redhat.com/show_bug.cgi?id=1785495
--- Comment #2 from W. Michael Petullo ---
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm
Description:
- Adjust package name to use beta0 rather than b0
- BuildRequires python3-setuptools
- Update sphinx comment
- Escape macros in comments
- Use %{python3_version}
- Add trailing slashes to directory paths
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1786109] New: Review Request: scottfree - Interpreter for Scott Adams format text adventure games
https://bugzilla.redhat.com/show_bug.cgi?id=1786109 Bug ID: 1786109 Summary: Review Request: scottfree - Interpreter for Scott Adams format text adventure games Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: musur...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pkgs.rpmfusion.org/cgit/free/scottfree.git/plain/scottfree.spec SRPM URL: http://koji.rpmfusion.org/kojifiles/packages/scottfree/1.14/17.fc32/src/scottfree-1.14-17.fc32.src.rpm Description: ScottFree is an interpreter for Scott-Adams-format text adventure games (remember those?). It reads and executes TRS-80 format data files. Most Adventure International Games are distributed as shareware and are available from http://ifarchive.org/if-archive/scott-adams/ Fedora Account System Username: musuruan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1785976] Review Request: git-lab-porcelain - Git porcelain for working with git-lab [FirstPackage, NeedSponsor]
https://bugzilla.redhat.com/show_bug.cgi?id=1785976 Neil Horman changed: What|Removed |Added CC||nhor...@redhat.com Assignee|nob...@fedoraproject.org|nhor...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1755084] Review Request: smbcmp - SMB network trace debugging tool
https://bugzilla.redhat.com/show_bug.cgi?id=1755084 Guenther Deschner changed: What|Removed |Added Fixed In Version||smbcmp-0.1-3.fc32 --- Comment #16 from Guenther Deschner --- Oh, thanks for the hint. I resolved it by now and correct dist tag use should be in place now. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
