[Bug 1773467] Review Request: avocado-vt - A avocado plugin for virtualization related tests
https://bugzilla.redhat.com/show_bug.cgi?id=1773467 --- Comment #20 from lnie --- Hi Richard, I really feel very sorry for having made you and seeing you quit this review process. If I may,would you please give me some time and tell me where the multiple issues are? I will work on them,and upload a new built.Though I hope you can change your decision then, I can understand if it's still the same,and thanks for your time anyway. I feel so close and excited(turns out too excited) to become a fedora package maintainer, when I had installed the rpm package,and it works well with the f31 config file I added, so I want to try one more time,if I may.Besides,virt-QE,who is the main consumer of avocado-vt, use setuptools and pip to install it,which is not,IMO,as convenient as one yum install command. I'd like to do a little contribution to change that,if it's not way hard. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1794971] Review Request: musescore - Music Composition & Notation Software
https://bugzilla.redhat.com/show_bug.cgi?id=1794971
Michel Alexandre Salim changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mic...@michel-slm.name
Flags||fedora-review+
--- Comment #3 from Michel Alexandre Salim ---
Looks mostly fine. APPROVED.
Would appreciate a swap with
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 (but only if you have time)
Some nits:
- 3.4.2 is out, you can update when importing
- not sure where exactly the CC-BY files are contained. If they are indeed used
in the -doc subpackage, this file might need to be added to -doc's %license or
%doc (since technically it's not really a license but a license declaration for
some files): mscore/data/icons/LICENSE.md
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
= MUST items =
C/C++:
[?]: Provides: bundled(gnulib) in place as required.
Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Uses parallel make
[Bug 1791588] Review Request: vapoursynth - A video processing framework with simplicity in mind
https://bugzilla.redhat.com/show_bug.cgi?id=1791588 --- Comment #9 from Luya Tshimbalanga --- Sorry for the delay. I had a busy week and will resume as soon as possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1615381] Review Request: minizip - Minizip contrib in zlib with the latest bug fixes and advanced features
https://bugzilla.redhat.com/show_bug.cgi?id=1615381 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2020-02-19 05:24:26 --- Comment #7 from Michel Alexandre Salim --- The initial build didn't reference this review request so it never auto-closed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804307] Review Request: python3-jack-client - JACK Audio Connection Kit (JACK) Client for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1804307 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED CC||mic...@michel-slm.name Doc Type|--- |If docs needed, set a value Flags||fedora-review? ||needinfo?(erich@ericheickme ||yer.com) --- Comment #1 from Michel Alexandre Salim --- I can sponsor. So far most things look fine, but the source package naming does not match the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ (the rationale is that the Python major version might change -- or your package might get branched for EPEL where we might build against multiple Python major/minor version combination -- so the Python version should not be hardcoded in the source package name). Could you rename to python-jack-client (without 3)? If you start with `rpmdev-newspec -t python python-jack-client` you'll get a boilerplate Python template with the right stubs in place to handle the source and binary name mismatch, and just need to move over your existing code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795292] Review Request: python-pytest-astropy-header - pytest plugin to add diagnostic info
https://bugzilla.redhat.com/show_bug.cgi?id=1795292 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Elliott Sales de Andrade --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804538] New: Review Request: ghc-path-io - Interface to âÂÂdirectoryâ package for users of âÂÂpathâÂÂ
https://bugzilla.redhat.com/show_bug.cgi?id=1804538 Bug ID: 1804538 Summary: Review Request: ghc-path-io - Interface to âÂÂdirectoryâ package for users of âÂÂpathâ Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://petersen.fedorapeople.org/reviews/ghc-path-io.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-path-io-1.4.2-1.fc31.src.rpm Description: Interface to âÂÂdirectoryâ package for users of âÂÂpathâÂÂ. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41635260 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797271] Review Request: ghc-filepath-bytestring - Library for manipulating RawFilePaths in a cross platform way
https://bugzilla.redhat.com/show_bug.cgi?id=1797271 --- Comment #7 from Fedora Update System --- FEDORA-2020-c0ebb5f9eb has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-c0ebb5f9eb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804529] New: Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes
https://bugzilla.redhat.com/show_bug.cgi?id=1804529 Bug ID: 1804529 Summary: Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mic...@michel-slm.name QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://salimma.fedorapeople.org/specs/admin/pam-cryptsetup.spec SRPM URL: https://salimma.fedorapeople.org/specs/admin/pam-cryptsetup-0.1-0.1.20190823.7b42892.fc31.src.rpm Description: pam-cryptsetup provides a PAM module that allows LUKS-based disk encryption passwords to be kept in sync with account passwords automatically based on factors like if the user has decrypted the disk successfully previously. The project as a whole consists of two parts: a PAM module pam_cryptsetup.so for triggering on user authentication, and a helper program pam_cryptsetup_helper to perform the actual encryption checks and modifications required. Fedora Account System Username: salimma -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803735] Review Request: golang-github-zyedidia-highlight - Go package for syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1803735 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #4 from Fedora Update System --- golang-github-zyedidia-highlight-0-0.1.20200218git291680f.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-012187ef43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Summary|Review Request: |Review Request:
|golang-gvisor-dev-gvisor - |golang-gvisor - A container
|A container sandbox runtime |sandbox runtime focused on
|focused on security,|security, efficiency, and
|efficiency, and ease of |ease of use.
|use.|
--- Comment #2 from Robert-André Mauchin ---
- Should be commit not tag:
# taken from the "go" branch (as bazel is not available in fedora)
%global commit 384ed132b902ead9aae62430382d38ae9afdb95d
- Name should be golang-gvisor.spec
- Please keep the forge URL above the goipath for ref (I use it for updates)
- Ping me for a review later
# Generated by go2rpm 1
%bcond_without check
# https://github.com/google/gvisor
%global goipath gvisor.dev/gvisor
%global forgeurlhttps://github.com/google/gvisor
Version:20200211.0
%global commit 384ed132b902ead9aae62430382d38ae9afdb95d
%gometa
%global common_description %{expand:
gVisor is an open-source, OCI-compatible sandbox runtime that provides
a virtualized container environment. It runs containers with a new
user-space kernel, delivering a low overhead container security
solution for high-density applications.
gVisor integrates with Docker, containerd and Kubernetes, making it
easier to improve the security isolation of your containers while
still using familiar tooling. Additionally, gVisor supports a variety
of underlying mechanisms for intercepting application calls, allowing
it to run in diverse host environments, including cloud-hosted virtual
machines.}
%global golicenses LICENSE
%global godocs AUTHORS README.md
Name: %{goname}
Release:1%{?dist}
Summary:Container Runtime Sandbox
# Upstream license specification: Apache-2.0
License:ASL 2.0
URL:%{gourl}
Source0:%{gosource}
BuildRequires: golang(github.com/cenkalti/backoff)
BuildRequires: golang(github.com/gofrs/flock)
BuildRequires: golang(github.com/golang/protobuf/proto)
BuildRequires: golang(github.com/golang/protobuf/ptypes)
BuildRequires: golang(github.com/google/btree)
BuildRequires: golang(github.com/google/subcommands)
BuildRequires: golang(github.com/kr/pty)
BuildRequires: golang(github.com/opencontainers/runtime-spec/specs-go)
BuildRequires: golang(github.com/syndtr/gocapability/capability)
BuildRequires: golang(github.com/vishvananda/netlink)
BuildRequires: golang(golang.org/x/sys/unix)
BuildRequires: golang(golang.org/x/time/rate)
%description
%{common_description}
%gopkg
%prep
%goprep
%build
for cmd in runsc; do
%gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done
%install
%gopkginstall
install -m 0755 -vd %{buildroot}%{_bindir}
install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
%if %{with check}
%check
%gocheck
%endif
%files
%license LICENSE
%doc AUTHORS README.md
%{_bindir}/*
%gopkgfiles
%changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Bug 1804288 depends on bug 1804289, which changed state. Bug 1804289 Summary: Please update to v1.2.0 https://bugzilla.redhat.com/show_bug.cgi?id=1804289 What|Removed |Added Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 --- Comment #15 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801765] Review Request: accounts-qml-module - QML bindings for libaccounts-qt + libsignon-qt
https://bugzilla.redhat.com/show_bug.cgi?id=1801765 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-02-19 01:53:37 --- Comment #10 from Fedora Update System --- accounts-qml-module-0.7-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2020-02-19 01:53:41 --- Comment #5 from Fedora Update System --- rust-procs-0.9.11-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763147] Review Request: golang-github-creack-goselect - Select(2) implementation in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1763147 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-02-19 01:28:14 --- Comment #14 from Fedora Update System --- golang-github-creack-goselect-0.1.1-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1763145] Review Request: golang-bug-serial-1 - Cross-platform serial library for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1763145 Bug 1763145 depends on bug 1763147, which changed state. Bug 1763147 Summary: Review Request: golang-github-creack-goselect - Select(2) implementation in Go https://bugzilla.redhat.com/show_bug.cgi?id=1763147 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/aeskeyfind -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Bug 1804288 depends on bug 1804292, which changed state. Bug 1804292 Summary: Please update to 555d28b269f0569763d25dbe1a237ae74c6bcc82 https://bugzilla.redhat.com/show_bug.cgi?id=1804292 What|Removed |Added Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1800675] Review Request: golang-github-crewjam-saml - SAML library for go
https://bugzilla.redhat.com/show_bug.cgi?id=1800675 Mark Goodwin changed: What|Removed |Added Flags||needinfo?(agerstmayr@redhat ||.com) --- Comment #9 from Mark Goodwin --- OK, BZ#1804467 reviewed, all good. Just need the new SPEC and SRPM URLs for saml version 0.4.0. (https://github.com/andreasgerstmayr/specs/tree/master/reviews/golang-github-crewjam-saml still has the 0.3.0 version) Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1694894] Review Request: aeskeyfind - Locate 128-bit and 256-bit AES keys in a captured memory image
https://bugzilla.redhat.com/show_bug.cgi?id=1694894 --- Comment #11 from Michal Ambroz --- Thank you Robert-Andre . Requesting the package repo - https://pagure.io/releng/fedora-scm-requests/issue/22261 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804467] Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1804467
Mark Goodwin changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
||needinfo?(agerstmayr@redhat
||.com)
--- Comment #1 from Mark Goodwin ---
package approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "Unknown or generated". 1 files have
unknown license. Detailed output of licensecheck in
/home/mgoodwin/src/fedora/reviews/1804467-golang-github-crewjam-
httperr/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin,
[Bug 1791958] Review Request: rust-target-lexicon - Targeting utilities for compilers and related tools
https://bugzilla.redhat.com/show_bug.cgi?id=1791958 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #5 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1778530] Review Request: libfido2 - FIDO2 libraries and utilities for support of U2F / WebAuthn
https://bugzilla.redhat.com/show_bug.cgi?id=1778530 --- Comment #13 from Gary Buhrmaster --- (In reply to Tomas Mraz from comment #11) > (In reply to Peter Robinson from comment #10) > > It got closed. Better if Gary opens a new ticket himself. Opened as: https://pagure.io/releng/fedora-scm-requests/issue/22260 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804467] Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1804467 Mark Goodwin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mgood...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803942] Review Request: dotnet-build-reference-packages - Reference packages needed by the .NET Core SDK build
https://bugzilla.redhat.com/show_bug.cgi?id=1803942 Michael Cronenworth changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|m...@cchtml.com Flags||fedora-review? --- Comment #2 from Michael Cronenworth --- I only see one issue so far: No license text is included. Can you add a %license LICENSE.txt line? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804450] Review Request: nodejs-toidentifier - Convert a string of words to a JavaScript identifier
https://bugzilla.redhat.com/show_bug.cgi?id=1804450 Jared Smith changed: What|Removed |Added Status|NEW |POST CC||jsmith.fed...@gmail.com Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Jared Smith --- The fedora-review tool seems broken again, but I have manually reviewed your package, and it is approved. The package * is under an appropriate Fedora-approved open source license * follows the Fedora Packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803934] Review Request: libhandy1 - Library with GTK+ widgets for mobile phones
https://bugzilla.redhat.com/show_bug.cgi?id=1803934 Yanko Kaneti changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2020-02-18 23:01:07 --- Comment #5 from Yanko Kaneti --- - I feel the libhandy situation is more gtk,gstreamer like so the libhandyN name makes more sense to me - To kalev's question about the conflict. I think in 99% it makes zero sense supporting parallel installable _devel_ environments for the same library. just my 2c. To whomever cares enough, please do whatever you feel is right. Sorry for the noise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1800675] Review Request: golang-github-crewjam-saml - SAML library for go
https://bugzilla.redhat.com/show_bug.cgi?id=1800675 Andreas Gerstmayr changed: What|Removed |Added Depends On||1804467 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1804467 [Bug 1804467] Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804467] Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1804467 Andreas Gerstmayr changed: What|Removed |Added CC||mgood...@redhat.com, ||nath...@redhat.com Blocks||1800675 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1800675 [Bug 1800675] Review Request: golang-github-crewjam-saml - SAML library for go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804467] New: Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP
https://bugzilla.redhat.com/show_bug.cgi?id=1804467 Bug ID: 1804467 Summary: Review Request: golang-github-crewjam-httperr - A golang error object that speaks HTTP Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: agerstm...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/golang-github-crewjam-httperr/golang-github-crewjam-httperr.spec SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github-crewjam-httperr/golang-github-crewjam-httperr-0.2.0-1.fc31.src.rpm Description: A golang error object that speaks HTTP Fedora Account System Username: agerstmayr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804450] Review Request: nodejs-toidentifier - Convert a string of words to a JavaScript identifier
https://bugzilla.redhat.com/show_bug.cgi?id=1804450 Ben Rosser changed: What|Removed |Added Blocks||1799694 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1799694 [Bug 1799694] nodejs-body-parser: FTBFS in Fedora rawhide/f32 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804450] New: Review Request: nodejs-toidentifier - Convert a string of words to a JavaScript identifier
https://bugzilla.redhat.com/show_bug.cgi?id=1804450 Bug ID: 1804450 Summary: Review Request: nodejs-toidentifier - Convert a string of words to a JavaScript identifier Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rosser@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://tc01.fedorapeople.org/nodejs/misc/nodejs-toidentifier.spec SRPM URL: https://tc01.fedorapeople.org/nodejs/misc/nodejs-toidentifier-1.0.0-1.fc33.src.rpm Description: Convert a string of words to a JavaScript identifier. Fedora Account System Username: tc01 This is a very simple nodejs package that's a new dependency of nodejs-http-errors, which is currently uninstallable in Fedora 32+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1802803 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dotnet3.1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1802803 --- Comment #9 from Omair Majid --- (In reply to Michael Cronenworth from comment #8) > As this is a compiler and not a 'runtime' package as the name implies I > don't have reservations any more. If it is safe to drop the .a and .h files > then go ahead, but I no longer think they block the review. I tested this out. It's not safe to remove them. The runtime fails to start if the files are missing. The `dotnet --info` at the end of the build fails: + /home/omajid/rpmbuild/BUILDROOT/dotnet3.1-3.1.101-2.fc31.x86_64/usr/lib64/dotnet/dotnet --info Error: An assembly specified in the application dependencies manifest (Microsoft.NETCore.App.deps.json) was not found: package: 'runtime.fedora.31-x64.Microsoft.NETCore.App', version: '3.1.1-servicing.19608.4' path: 'runtimes/fedora.31-x64/native/System.IO.Compression.Native.a' > One minor issue is that your patches don't provide comments or context for > their existance. I do see the git comments inside of them but a comment in > the spec is always nice. Could you include a comment around them? Sure! > This review will PASS. Thanks! Wow, that's a plesant surprise. Thanks for the insanely prompt review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Marc-Andre Lureau changed: What|Removed |Added Blocks||1804353 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1804353 [Bug 1804353] Review Request: golang-github-majek-slirpnetstack - Slirp4netns implementation using gvisor/netstack -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804353] Review Request: golang-github-majek-slirpnetstack - Slirp4netns implementation using gvisor/netstack
https://bugzilla.redhat.com/show_bug.cgi?id=1804353 Marc-Andre Lureau changed: What|Removed |Added Depends On||1804288 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1804288 [Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804353] New: Review Request: golang-github-majek-slirpnetstack - Slirp4netns implementation using gvisor/netstack
https://bugzilla.redhat.com/show_bug.cgi?id=1804353 Bug ID: 1804353 Summary: Review Request: golang-github-majek-slirpnetstack - Slirp4netns implementation using gvisor/netstack Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: marcandre.lur...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://elmarco.fedorapeople.org/golang-github-majek-slirpnetstack.spec SRPM URL: https://elmarco.fedorapeople.org/golang-github-majek-slirpnetstack-0-1.20200218git0a03a89.fc31.src.rpm Description: slirpnetstack provides user-mode networking for unprivileged network namespaces and virtual machines. Fedora Account System Username: elmarco -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804346] New: Review Request: operator-sdk
https://bugzilla.redhat.com/show_bug.cgi?id=1804346 Bug ID: 1804346 Summary: Review Request: operator-sdk Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: lross...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fedora-infra.s3-us-west-2.amazonaws.com/operator-sdk-rpm/operator-sdk.spec SRPM URL: https://fedora-infra.s3-us-west-2.amazonaws.com/operator-sdk-rpm/operator-sdk-0.15.2-1.fc31.src.rpm Description: Kubernetes operator sdk framework and tooling that is installed as a rpm package. It uses/needs the default go build tooling in order to work. Fedora Account System Username: lrossett -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804327] Review Request: rust-jsonrpc-lite - JSON-RPC 2.0 Specification serialization for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1804327 Artem changed: What|Removed |Added Status|NEW |POST CC||ego.corda...@gmail.com Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Artem --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804329] Review Request: rust-lsp-types - Types for interaction with a language server, using Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1804329 Artem changed: What|Removed |Added Status|NEW |POST CC||ego.corda...@gmail.com Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Artem --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804329] New: Review Request: rust-lsp-types - Types for interaction with a language server, using Language Server Protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1804329 Bug ID: 1804329 Summary: Review Request: rust-lsp-types - Types for interaction with a language server, using Language Server Protocol Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-lsp-types.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-lsp-types-0.70.1-1.fc33.src.rpm Description: Types for interaction with a language server, using VSCode's Language Server Protocol. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804327] New: Review Request: rust-jsonrpc-lite - JSON-RPC 2.0 Specification serialization for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1804327 Bug ID: 1804327 Summary: Review Request: rust-jsonrpc-lite - JSON-RPC 2.0 Specification serialization for Rust Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-jsonrpc-lite.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-jsonrpc-lite-0.5.0-1.fc33.src.rpm Description: JSON-RPC 2.0 Specification serialization for Rust. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1791958] Review Request: rust-target-lexicon - Targeting utilities for compilers and related tools
https://bugzilla.redhat.com/show_bug.cgi?id=1791958 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #4 from Tom "spot" Callaway --- Just say "ASL 2.0 with exceptions". Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-f91adb8066 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f91adb8066 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803934] Review Request: libhandy1 - Library with GTK+ widgets for mobile phones
https://bugzilla.redhat.com/show_bug.cgi?id=1803934 Fabio Valentini changed: What|Removed |Added CC||decatho...@gmail.com --- Comment #4 from Fabio Valentini --- (In reply to Kalev Lember from comment #3) > Yanko, I think you get to decide how you want it since you're the one doing > the work here. That's not really true. This is specified in the Packaging Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#multiple According to these rules, the package names should be libhandy and libhandy0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801088] Review request: usbguard-notifier - A tool for detecting usbguard policy and device presence changes
https://bugzilla.redhat.com/show_bug.cgi?id=1801088 --- Comment #8 from Raphael Groner --- (In reply to Attila Lakatos from comment #6) > (In reply to Kairui Song from comment #5) > > Hi, it looks like the link expires too quick? I can access the spec file a > > few hours ago, now I'm getting 403 error again. > > I am really sorry for that, it should work now. Why do you not use alakatos.fedorapeople.org? You can ssh to there. https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803934] Review Request: libhandy1 - Library with GTK+ widgets for mobile phones
https://bugzilla.redhat.com/show_bug.cgi?id=1803934 Kalev Lember changed: What|Removed |Added CC||klem...@redhat.com --- Comment #3 from Kalev Lember --- I'm fine either way and don't have a strong opinion if should be libhandy and libhandy1, or libhandy and libhandy0, or libhandy1 and libhandy0 :) Yanko, I think you get to decide how you want it since you're the one doing the work here. I see you've done explicit Conflicts with libhandy-devel, why is that so? Can we avoid that somehow? Is it gtk-doc files conflicting? Can you split them out to a subpackage in that case, or ask upstream to include the library version in the gtk-doc file paths or something? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804307] Review Request: python3-jack-client - JACK Audio Connection Kit (JACK) Client for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1804307 Erich Eickmeyer changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804307] New: Review Request: python3-jack-client - JACK Audio Connection Kit (JACK) Client for Python 3
https://bugzilla.redhat.com/show_bug.cgi?id=1804307 Bug ID: 1804307 Summary: Review Request: python3-jack-client - JACK Audio Connection Kit (JACK) Client for Python 3 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: er...@ericheickmeyer.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/python3-jack-client/raw/master/f/python3-jack-client.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01243525-python3-jack-client/python3-jack-client-0.5.2-1.fc33.src.rpm Description: Python 3 module that provides bindings for the JACK library. The module is able to create audio input and output ports, also provides the functionality to manage MIDI ports. This package installs the library for Python 3. Fedora Account System Username: eeickmeyer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1802803 Michael Cronenworth changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Michael Cronenworth --- As this is a compiler and not a 'runtime' package as the name implies I don't have reservations any more. If it is safe to drop the .a and .h files then go ahead, but I no longer think they block the review. One minor issue is that your patches don't provide comments or context for their existance. I do see the git comments inside of them but a comment in the spec is always nice. Could you include a comment around them? This review will PASS. Thanks! Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Expat License", "Expat License", "*No copyright* Apache License (v2.0)", "*No copyright* Apache License (v2.0) GNU Lesser General Public License", "Apache License (v2.0)", "Public domain Apache License (v2.0)", "Expat License Apache License (v2.0)", "GNU Lesser General Public License", "Expat License BSD 3-clause "New" or "Revised" License", "*No copyright* Creative Commons Attribution Public License (v4.0)", "GPL (v2.0)", "zlib/libpng license Expat License", "BSD (unspecified)", "Expat License BSD 2-clause "Simplified" License", "BSD 3-clause "New" or "Revised" License", "*No copyright* Apache License GNU Lesser General Public License", "*No copyright* Apache License", "*No copyright* Expat License Public domain", "*No copyright* Public domain", "ISC License", "zlib/libpng license", "*No copyright* Creative Commons CC0 Public License (v3)", "Microsoft Public License", "Apache License (v9.0)", "GNU General Public License", "Expat License GNU General Public License", "*No copyright* Microsoft Public License", "SIL Open Font License (v1.1)", "Expat License Eclipse Public License (v1.0)", "BSD 2-clause "Simplified" License", "*No copyright* Creative Commons CC0 Public License (v9)". 60081 files have unknown license. Detailed output of licensecheck in /home/michael/Projects/fedora/review/1802803-dotnet3.1/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/profile.d, /usr/lib64/dotnet [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint
[Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 --- Comment #1 from Marc-Andre Lureau --- fwiw, I wonder if the package/spec should be named "golang-gvisor" instead (that's the name of the resulting rpm). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798393] Review Request: ghc-lens-family-core - Haskell 98 Lens Families
https://bugzilla.redhat.com/show_bug.cgi?id=1798393 --- Comment #9 from Jens Petersen --- https://pagure.io/releng/fedora-scm-requests/issue/22257 (f31) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798393] Review Request: ghc-lens-family-core - Haskell 98 Lens Families
https://bugzilla.redhat.com/show_bug.cgi?id=1798393 --- Comment #8 from Jens Petersen --- https://pagure.io/releng/fedora-scm-requests/issue/22256 (f32) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798393] Review Request: ghc-lens-family-core - Haskell 98 Lens Families
https://bugzilla.redhat.com/show_bug.cgi?id=1798393 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-lens-family-core-1.2.3- ||1.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Marc-Andre Lureau changed: What|Removed |Added Depends On||1804289, 1804292 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1804289 [Bug 1804289] Please update to v1.2.0 https://bugzilla.redhat.com/show_bug.cgi?id=1804292 [Bug 1804292] Please update to 555d28b269f0569763d25dbe1a237ae74c6bcc82 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804288] New: Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use.
https://bugzilla.redhat.com/show_bug.cgi?id=1804288 Bug ID: 1804288 Summary: Review Request: golang-gvisor-dev-gvisor - A container sandbox runtime focused on security, efficiency, and ease of use. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: marcandre.lur...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://elmarco.fedorapeople.org/golang-gvisor-dev-gvisor.spec SRPM URL: https://elmarco.fedorapeople.org/golang-gvisor-20200211.0-1.20200218git384ed132b902ead9aae62430382d38ae9afdb95d.fc31.src.rpm Description: gVisor is an open-source, OCI-compatible sandbox runtime that provides a virtualized container environment. It runs containers with a new user-space kernel, delivering a low overhead container security solution for high-density applications. gVisor integrates with Docker, containerd and Kubernetes, making it easier to improve the security isolation of your containers while still using familiar tooling. Additionally, gVisor supports a variety of underlying mechanisms for intercepting application calls, allowing it to run in diverse host environments, including cloud-hosted virtual machines. Fedora Account System Username: elmarco -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801533] Review Request: memstrack - a memory allocation analyzer
https://bugzilla.redhat.com/show_bug.cgi?id=1801533
--- Comment #3 from Kairui Song ---
Hi, I've updated the spec and srpm:
Spec URL:
https://gist.githubusercontent.com/ryncsn/ed41a2d265ce6c897b1d87212a7a1754/raw/ca1bdfed3a7f771eb2e4239afb464ee23997d5db/memstrack.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3457/41613457/memstrack-0-1.20200218git9aefb50.fc33.src.rpm
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41613456
rpmlint result:
memstrack.src:44: E: hardcoded-library-path in %{_prefix}/lib/dracut
1 packages and 0 specfiles checked; 1 errors, 0 warnings.
The hardcoded-library-path is to keep the macro definition consistent with the
one in dracut.spec (dracut package), and also avoids noarch build error.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701567] Review Request: colorized-logs - Tools for logs with ANSI color
https://bugzilla.redhat.com/show_bug.cgi?id=1701567 Adam Borowski changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 15:40:09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1767537] Review Request: pmemkv - Key/Value Datastore for Persistent Memory
https://bugzilla.redhat.com/show_bug.cgi?id=1767537 Adam Borowski changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 15:40:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1701565] Review Request: vmemcache - buffer-based LRU cache
https://bugzilla.redhat.com/show_bug.cgi?id=1701565 Adam Borowski changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 15:40:00 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795330] Review Request: vmem - volatile memory allocation library
https://bugzilla.redhat.com/show_bug.cgi?id=1795330 Adam Borowski changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 15:39:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257
--- Comment #7 from jiri vanek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- This seems like a Java package, please install fedora-review-plugin-java
to get additional checks
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/swing-layout
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 16 files have unknown license. Detailed
output of licensecheck in /tmp/1804257-swing-layout/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[!]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 --- Comment #6 from jiri vanek --- Otherwise I have tried to build and run depending rpms, and wit minor change in build spec (you added[imho correct] directory) it worked fine. TY! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 jiri vanek changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from jiri vanek --- the check section is empty, still junit is required. Maybe try to enable it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 jiri vanek changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #4 from jiri vanek --- please fix requires. java is not necessary, only java-headless Afaik you do not need to reqyure junnit, but I'm not sure where it come from. I guess it is the pom in your sources. You require it without test scope. Please try to add it testscope. If it do not help, then drop it. I doubt it is really runtime dependence (but we may get surprised) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 --- Comment #3 from jiri vanek --- please state in spec why the url of sources is no longer valid. Afaik the upstream projet really do not exists anymore -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 --- Comment #2 from jiri vanek --- please drop the # javadoc comments and if 0 parts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 jiri vanek changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from jiri vanek --- please fix your changelog. You made a lot of changes according to the diff. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 jiri vanek changed: What|Removed |Added CC||jva...@redhat.com Assignee|nob...@fedoraproject.org|jva...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801088] Review request: usbguard-notifier - A tool for detecting usbguard policy and device presence changes
https://bugzilla.redhat.com/show_bug.cgi?id=1801088
Kairui Song changed:
What|Removed |Added
Flags|needinfo?(alakatos@redhat.c |
|om) |
--- Comment #7 from Kairui Song ---
Hi, I found some problems with the spec.
> %build
> mkdir -p ./m4
> autoreconf -i -f -v --no-recursive ./
> %configure \
> --disable-silent-rules \
> --without-bundled-catch \
> --enable-debug-build
>
> make %{?_smp_mflags}
The build system doesn't seem to honor Fedora's CFLAGS from environment.
> %install
> make install INSTALL='install -p' DESTDIR=%{buildroot}
> execstack -c $RPM_BUILD_ROOT%{_bindir}/*
I never used execstack before, but according to
https://fedoraproject.org/wiki/Packaging_tricks#Executable_stack
it disables executable stack, but shouldn't the code generated by gcc/g++ have
that by default?
>
> # Cleanup
> find %{buildroot} \( -name '*.o' -o -name '*.a' \) -exec rm -f {} ';'
Clean up is not needed in %install, anything not included by %files is not
packaged.
> %files
> %doc README.md CHANGELOG.md
> %license LICENSE
> %{_bindir}/usbguard-notifier
> %{_bindir}/usbguard-notifier-cli
> %{_datadir}/man/man1/usbguard-notifier.1.gz
> %{_datadir}/man/man1/usbguard-notifier-cli.1.gz
> %{_userunitdir}/usbguard-notifier.service
Consider using %{_mandir}
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
And systemd unit should go to _unitdir, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_filesystem_locations
And some issues found by fedora-review:
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
- systemd_user_post is invoked in %post and systemd_user_preun in %preun
for Systemd user units service files.
Note: Systemd user unit service file(s) in usbguard-notifier
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Scriptlets/#_user_units
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1802803 Tom Deseyn changed: What|Removed |Added CC||tdes...@redhat.com --- Comment #7 from Tom Deseyn --- From the github issue (https://github.com/dotnet/runtime/issues/3447#issuecomment-461640228), I think PublishSingleFile cannot yet leverage the static libraries in 3.1. So it should be safe to remove them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802803] Review Request: dotnet3.1 - .NET Core Runtime and SDK
https://bugzilla.redhat.com/show_bug.cgi?id=1802803 --- Comment #6 from Omair Majid --- (In reply to Michael Cronenworth from comment #5) > Looks like they are leaning to remove static libs. > > Would a C header and a static library be necessary to build a C# app? As far as I can tell, the C header is not required for C# applications. But the static library *may* be required depending on the build configuration (and release version). For example, this may work: dotnet publish -r linux-x64 -c Release But this *may* blow up: dotnet publish -r linux-x64 -c Release /p:PublishSingleFile=true And it wont be obvious that it's because of the missing static library since other .NET Core installations will include the static library and will appear to Just Work. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 jandrlik changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804257] New: Review Request: swing-layout - Swing Extensions
https://bugzilla.redhat.com/show_bug.cgi?id=1804257 Bug ID: 1804257 Summary: Review Request: swing-layout - Swing Extensions Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jandr...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jvanek.fedorapeople.org/jandrlik/swing-layout.spec SRPM URL: https://jvanek.fedorapeople.org/jandrlik/swing-layout-1.0.4-18.fc30.src.rpm Description: So I basically adopted orphaned swing-layout project and rebuilded it. Only did changes inside the specfile, for those interested, here is the link to the diff against the previous specfile: https://jvanek.fedorapeople.org/jandrlik/swing-layout.spec.patch Fedora Account System Username: jandrlik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1795249] Review Request: sdbus-cpp - High-level C++ D-Bus library
https://bugzilla.redhat.com/show_bug.cgi?id=1795249 Marek Blaha changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 14:29:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1760617] Review Request: mmc - A GPU mesh-based Monte Carlo photon simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1760617
--- Comment #29 from Qianqian Fang ---
to verify the toolbox, simply type "mmc" and enter in Octave, you should see a
short help info.
also, run mmclab('gpuinfo'), this should call mmc.mex and list all supported
OpenCL devices.
because 'which mmc' currently does not return anything, so the above two
command will not succeed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1801580] Review Request: openjfx-11 - Rich client application platform for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1801580 Mat Booth changed: What|Removed |Added CC||mat.bo...@redhat.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1791588] Review Request: vapoursynth - A video processing framework with simplicity in mind
https://bugzilla.redhat.com/show_bug.cgi?id=1791588 --- Comment #8 from Simone Caronni --- Any chance we can progress with the review? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797271] Review Request: ghc-filepath-bytestring - Library for manipulating RawFilePaths in a cross platform way
https://bugzilla.redhat.com/show_bug.cgi?id=1797271 Jens Petersen changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version||ghc-filepath-bytestring-1.4 ||.2.1.6-1.fc33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 --- Comment #3 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-procs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797271] Review Request: ghc-filepath-bytestring - Library for manipulating RawFilePaths in a cross platform way
https://bugzilla.redhat.com/show_bug.cgi?id=1797271 --- Comment #6 from Jens Petersen --- https://pagure.io/releng/fedora-scm-requests/issue/22250 (f31) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #2 from Neal Gompa --- (In reply to Artem from comment #1) > Package was generated through rust2rpm, simplifying the review considerably. > > - Conforms to packaging guidelines (rust2rpm generated spec) > - license correct and valid > - only sources installed > > Package approved. This package generates a binary crate as well, though there is nothing wrong packaging wise anyway... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 Artem changed: What|Removed |Added Status|NEW |POST CC||ego.corda...@gmail.com Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Artem --- Can't run fedora-review since not all deps available in Koji at this moment. Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1797271] Review Request: ghc-filepath-bytestring - Library for manipulating RawFilePaths in a cross platform way
https://bugzilla.redhat.com/show_bug.cgi?id=1797271 --- Comment #5 from Jens Petersen --- https://pagure.io/releng/fedora-scm-requests/issue/22249 (f32) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1773467] Review Request: avocado-vt - A avocado plugin for virtualization related tests
https://bugzilla.redhat.com/show_bug.cgi?id=1773467 Richard W.M. Jones changed: What|Removed |Added Assignee|rjo...@redhat.com |nob...@fedoraproject.org --- Comment #19 from Richard W.M. Jones --- This is still problematic because there are still multiple issues that haven't been addressed. Perhaps a Copr repo is a better place for this package to live, and it seems like you are already doing Copr builds. Anyway I am unassigning myself from this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802992] Review Request: rust-anyhow - Flexible concrete Error type built on std::error::Error
https://bugzilla.redhat.com/show_bug.cgi?id=1802992 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 12:40:34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804197] New: Review Request: rust-procs - Modern replacement for ps
https://bugzilla.redhat.com/show_bug.cgi?id=1804197 Bug ID: 1804197 Summary: Review Request: rust-procs - Modern replacement for ps Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: i.gnatenko.br...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-procs.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-procs-0.9.11-1.fc33.src.rpm Description: Modern replacement for ps. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798393] Review Request: ghc-lens-family-core - Haskell 98 Lens Families
https://bugzilla.redhat.com/show_bug.cgi?id=1798393 --- Comment #7 from Igor Gnatenko --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-lens-family-core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802988] Review Request: rust-thiserror - Derive(Error)
https://bugzilla.redhat.com/show_bug.cgi?id=1802988 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:57:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1760617] Review Request: mmc - A GPU mesh-based Monte Carlo photon simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1760617 --- Comment #28 from Ankur Sinha (FranciscoD) --- Can you give me the complete steps on how to check this please? I built it for f31, and it loads OK. What should one do next to verify if the mex file can be used? (ins)>> pkg list Package Name | Version | Installation directory --+-+--- iso2mesh | 1.9.1 | /usr/share/octave/packages/iso2mesh-1.9.1 jnifti | 0.5 | /usr/share/octave/packages/jnifti-0.5 jsonlab | 1.9.8 | /usr/share/octave/packages/jsonlab-1.9.8 mmclab | 1.7.9 | /usr/share/octave/packages/mmclab-1.7.9 zmat | 0.9 | /usr/share/octave/packages/zmat-0.9 (ins)>> pkg load mmclab (ins)>> pkg mmclab load (ins)>> pkg list Package Name | Version | Installation directory --+-+--- iso2mesh *| 1.9.1 | /usr/share/octave/packages/iso2mesh-1.9.1 jnifti *| 0.5 | /usr/share/octave/packages/jnifti-0.5 jsonlab *| 1.9.8 | /usr/share/octave/packages/jsonlab-1.9.8 mmclab *| 1.7.9 | /usr/share/octave/packages/mmclab-1.7.9 zmat *| 0.9 | /usr/share/octave/packages/zmat-0.9 (ins)>> /usr/share/octave/octave_packages correctly lists the package directories, so that looks OK too: # name: dir # type: sq_string # elements: 1 # length: 39 /usr/share/octave/packages/mmclab-1.7.9 # name: archprefix # type: sq_string # elements: 1 # length: 39 /usr/lib64/octave/packages/mmclab-1.7.9 I do not, however, see this in the output of path(): (ins)>> path() Octave's search path contains the following directories: . /usr/share/octave/packages/zmat-0.9 /usr/share/octave/packages/jsonlab-1.9.8 /usr/share/octave/packages/jnifti-0.5 /usr/share/octave/packages/iso2mesh-1.9.1 /usr/share/octave/packages/mmclab-1.7.9 /usr/lib64/octave/5.1.0/site/oct/x86_64-redhat-linux-gnu /usr/lib64/octave/site/oct/api-v53/x86_64-redhat-linux-gnu /usr/lib64/octave/site/oct/x86_64-redhat-linux-gnu /usr/share/octave/5.1.0/site/m /usr/share/octave/site/api-v53/m /usr/share/octave/site/m /usr/share/octave/site/m/startup /usr/lib64/octave/5.1.0/oct/x86_64-redhat-linux-gnu /usr/share/octave/5.1.0/m /usr/share/octave/5.1.0/m/audio /usr/share/octave/5.1.0/m/deprecated /usr/share/octave/5.1.0/m/elfun /usr/share/octave/5.1.0/m/general /usr/share/octave/5.1.0/m/geometry /usr/share/octave/5.1.0/m/gui /usr/share/octave/5.1.0/m/help /usr/share/octave/5.1.0/m/image /usr/share/octave/5.1.0/m/io /usr/share/octave/5.1.0/m/java /usr/share/octave/5.1.0/m/legacy /usr/share/octave/5.1.0/m/linear-algebra /usr/share/octave/5.1.0/m/miscellaneous /usr/share/octave/5.1.0/m/ode /usr/share/octave/5.1.0/m/optimization /usr/share/octave/5.1.0/m/path /usr/share/octave/5.1.0/m/pkg /usr/share/octave/5.1.0/m/plot /usr/share/octave/5.1.0/m/plot/appearance /usr/share/octave/5.1.0/m/plot/draw /usr/share/octave/5.1.0/m/plot/util /usr/share/octave/5.1.0/m/polynomial /usr/share/octave/5.1.0/m/prefs /usr/share/octave/5.1.0/m/profiler /usr/share/octave/5.1.0/m/set /usr/share/octave/5.1.0/m/signal /usr/share/octave/5.1.0/m/sparse /usr/share/octave/5.1.0/m/specfun /usr/share/octave/5.1.0/m/special-matrix /usr/share/octave/5.1.0/m/startup /usr/share/octave/5.1.0/m/statistics /usr/share/octave/5.1.0/m/strings /usr/share/octave/5.1.0/m/testfun /usr/share/octave/5.1.0/m/time /usr/share/octave/5.1.0/data -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803000] Review Request: rust-unbytify - Convert units of digital information from string into the numeric equivalent
https://bugzilla.redhat.com/show_bug.cgi?id=1803000 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |WONTFIX Last Closed||2020-02-18 11:25:02 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803735] Review Request: golang-github-zyedidia-highlight - Go package for syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1803735 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #3 from Fedora Update System --- FEDORA-2020-012187ef43 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-012187ef43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802993] Review Request: rust-getch - Portable implementation of getch, using _getch on Windows, and termios on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1802993 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:12:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802987] Review Request: rust-thiserror-impl - Implementation detail of the `thiserror` crate
https://bugzilla.redhat.com/show_bug.cgi?id=1802987 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:11:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802986] Review Request: rust-procfs - Interface to the linux procfs pseudo-filesystem
https://bugzilla.redhat.com/show_bug.cgi?id=1802986 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:11:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1804132] Review Request: rust-sluice - Efficient ring buffer for byte buffers, FIFO queues, and SPSC channels
https://bugzilla.redhat.com/show_bug.cgi?id=1804132 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:10:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1778530] Review Request: libfido2 - FIDO2 libraries and utilities for support of U2F / WebAuthn
https://bugzilla.redhat.com/show_bug.cgi?id=1778530 Tomas Mraz changed: What|Removed |Added Assignee|gary.buhrmas...@gmail.com |tm...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802994] Review Request: rust-process_path - Rust library to get the path of the currently executing process
https://bugzilla.redhat.com/show_bug.cgi?id=1802994 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:03:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1802048] Review Request: rust-random-fast-rng - Rust library for Blazing fast non cryptographic random number generator
https://bugzilla.redhat.com/show_bug.cgi?id=1802048 Igor Gnatenko changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-02-18 11:01:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
