[Bug 1839840] Review Request: rust-slash-formatter - Functions to deal with slashes and backslashes in strings
https://bugzilla.redhat.com/show_bug.cgi?id=1839840 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-slash-formatter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839052] Review Request: plasma-wayland-protocols - Plasma Specific Protocols for Wayland
https://bugzilla.redhat.com/show_bug.cgi?id=1839052 --- Comment #5 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-wayland-protocols -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1827880] Review Request: fswatch - A cross-platform file change monitor
https://bugzilla.redhat.com/show_bug.cgi?id=1827880 --- Comment #12 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fswatch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1832632] Review Request: python-authres - RFC 8601 Authentication-Results Headers generation and parsing
https://bugzilla.redhat.com/show_bug.cgi?id=1832632 --- Comment #14 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-authres -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839873] Review Request: rust-path-dedot - Parse path with dots in `Path` and `PathBuf`
https://bugzilla.redhat.com/show_bug.cgi?id=1839873 --- Comment #3 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-path-dedot -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839452] Review Request: rust-piper - Async pipes, channels, mutexes, and more
https://bugzilla.redhat.com/show_bug.cgi?id=1839452 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-piper -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839083] Review Request: kwayland-server - Wayland server components built on KDE Frameworks
https://bugzilla.redhat.com/show_bug.cgi?id=1839083 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kwayland-server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839478] Review Request: python-uamqp - AMQP 1.0 client library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1839478 --- Comment #2 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-uamqp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839475] Review Request: python-msal - Microsoft Authentication Library (MSAL) for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1839475 --- Comment #3 from Igor Raits --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-msal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830529] Re-Review Request: seahorse-adventures - Retro side-scrolling platformer game
https://bugzilla.redhat.com/show_bug.cgi?id=1830529
--- Comment #5 from Dennis Payne ---
rpmlint spelling errors are incorrect. The text is fine. I'm correcting the fsf
address in the repository. Is it alright to leave that as is for now and have
it fixed in the next release?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see
[Bug 1820915] Review Request: bettercap - Tool for 802.11, BLE/Ethernet reconnaissance and MITM attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1820915 --- Comment #7 from Germano Massullo --- (In reply to Fabian Affolter from comment #6) > There is still some work to do. With the latest upstream release this SPEc > file fails to build. Right, because there are some dependencies that still miss a koji build, like No matching package to install: 'golang(github.com/bettercap/nrf24)' No matching package to install: 'golang(github.com/jpillora/go-tld)' No matching package to install: 'golang(github.com/mdlayher/dhcp6)' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839877] Review Request: alacarte - Menu editor for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1839877 Yaakov Selkowitz changed: What|Removed |Added Link ID||Fedora Pagure ||releng/issue/9471 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839902] Review Request: urlocator - Locate URLs in character streams
https://bugzilla.redhat.com/show_bug.cgi?id=1839902 Stefano Figura changed: What|Removed |Added Depends On||1839330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839330 [Bug 1839330] Review Request: rust-rustc_tools_util - Small helper to generate version information for git packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839330] Review Request: rust-rustc_tools_util - Small helper to generate version information for git packages
https://bugzilla.redhat.com/show_bug.cgi?id=1839330 Stefano Figura changed: What|Removed |Added Blocks||1839902 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1839902 [Bug 1839902] Review Request: urlocator - Locate URLs in character streams -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839902] New: Review Request: urlocator - Locate URLs in character streams
https://bugzilla.redhat.com/show_bug.cgi?id=1839902 Bug ID: 1839902 Summary: Review Request: urlocator - Locate URLs in character streams Product: Fedora Version: rawhide Hardware: All Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: stef...@figura.im QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://git.sr.ht/~returntrip/urlocator/blob/master/rust-urlocator.spec SRPM URL: https://git.sr.ht/~returntrip/urlocator/blob/master/rust-urlocator-0.1.3-1.fc33.src.rpm Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44833127 Description: Small helper to generate version information for git packages. Fedora Account System Username: returntrip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839873] Review Request: rust-path-dedot - Parse path with dots in `Path` and `PathBuf`
https://bugzilla.redhat.com/show_bug.cgi?id=1839873 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review+ --- Comment #2 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839840] Review Request: rust-slash-formatter - Functions to deal with slashes and backslashes in strings
https://bugzilla.redhat.com/show_bug.cgi?id=1839840 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839452] Review Request: rust-piper - Async pipes, channels, mutexes, and more
https://bugzilla.redhat.com/show_bug.cgi?id=1839452 Neal Gompa changed: What|Removed |Added Status|NEW |POST CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839877] Review Request: alacarte - Menu editor for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1839877 Artem changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839877] Review Request: alacarte - Menu editor for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1839877
Artem changed:
What|Removed |Added
Attachment||review+
#1692061 Flags||
--- Comment #2 from Artem ---
Created attachment 1692061
--> https://bugzilla.redhat.com/attachment.cgi?id=1692061=edit
SPEC file patch
LGTM, just few minor issues, see attached patch.
E: incorrect-fsf-address /usr/share/doc/alacarte/COPYING
This should be fixed though and reported upstream.
---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
Fixed in attached patch.
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/alacarte
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
Not issue since this is re-review procedure.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "FSF All Permissive License", "GNU
Lesser General Public License (v2 or later)", "Expat License". 137
files have unknown license. Detailed output of licensecheck in
/mnt/data-linux/tmp/review/1839877-alacarte/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies
[Bug 1839889] Review Request: python-angr - A multi-architecture binary analysis toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1839889 W. Michael Petullo changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from W. Michael Petullo --- I am still working through some packaging issues, namely a reliance on modified dependencies. Requires: https://bugzilla.redhat.com/show_bug.cgi?id=1839885 https://bugzilla.redhat.com/show_bug.cgi?id=1839886 https://bugzilla.redhat.com/show_bug.cgi?id=1839887 https://bugzilla.redhat.com/show_bug.cgi?id=1839888 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839889] New: Review Request: python-angr - A multi-architecture binary analysis toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1839889 Bug ID: 1839889 Summary: Review Request: python-angr - A multi-architecture binary analysis toolkit Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@flyn.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.flyn.org/SRPMS/python-angr.spec SRPM URL: https://www.flyn.org/SRPMS/python-angr-8.20.1.7-1.fc32.src.rpm Description: angr is a platform-agnostic binary analysis framework with the ability to perform dynamic symbolic execution and various static analyses on binaries. Fedora Account System Username: mikep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839888] New: Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation
https://bugzilla.redhat.com/show_bug.cgi?id=1839888 Bug ID: 1839888 Summary: Review Request: python-pyvex - A Python interface to libVEX and the VEX intermediate representation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@flyn.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.flyn.org/SRPMS/python-pyvex.spec SRPM URL: https://www.flyn.org/SRPMS/python-pyvex-8.20.1.7-1.fc32.src.rpm Description: A Python interface to libVEX and the VEX intermediate representation Fedora Account System Username: mikep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839887] New: Review Request: python-cle - A Python interface for analyzing binary formats
https://bugzilla.redhat.com/show_bug.cgi?id=1839887 Bug ID: 1839887 Summary: Review Request: python-cle - A Python interface for analyzing binary formats Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@flyn.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.flyn.org/SRPMS/python-cle.spec SRPM URL: https://www.flyn.org/SRPMS/python-cle-8.20.1.7-1.fc32.src.rpm Description: CLE loads binaries and their associated libraries, resolves imports and provides an abstraction of process memory the same way as if it was loader by the OS's loader. Fedora Account System Username: mikep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839886] New: Review Request: python-claripy - An abstraction layer for constraint solvers
https://bugzilla.redhat.com/show_bug.cgi?id=1839886 Bug ID: 1839886 Summary: Review Request: python-claripy - An abstraction layer for constraint solvers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@flyn.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.flyn.org/SRPMS/python-claripy.spec SRPM URL: https://www.flyn.org/SRPMS/python-claripy-8.20.1.7-1.fc32.src.rpm Description: An abstraction layer for constraint solvers Fedora Account System Username: mikep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839886] Review Request: python-claripy - An abstraction layer for constraint solvers
https://bugzilla.redhat.com/show_bug.cgi?id=1839886 W. Michael Petullo changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from W. Michael Petullo --- Depends on https://bugzilla.redhat.com/show_bug.cgi?id=1839885. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839885] New: Review Request: python-z3-solver - A theorem prover
https://bugzilla.redhat.com/show_bug.cgi?id=1839885 Bug ID: 1839885 Summary: Review Request: python-z3-solver - A theorem prover Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@flyn.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://www.flyn.org/SRPMS/python-z3-solver.spec SRPM URL: https://www.flyn.org/SRPMS/python-z3-solver-4.8.8.0-1.fc32.src.rpm Description: Z3 is a theorem prover from Microsoft Research with support for bitvectors, booleans, arrays, floating point numbers, strings, and other data types. Fedora Account System Username: mikep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839877] Review Request: alacarte - Menu editor for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1839877 Yaakov Selkowitz changed: What|Removed |Added CC||ego.corda...@gmail.com --- Comment #1 from Yaakov Selkowitz --- This is needed for "Edit Menus" to work in gnome-panel 3.36 (F32) and newer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839877] New: Review Request: alacarte - Menu editor for the GNOME desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1839877 Bug ID: 1839877 Summary: Review Request: alacarte - Menu editor for the GNOME desktop Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: yselk...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://yselkowitz.fedorapeople.org/SRPMS/alacarte.spec SRPM URL: https://yselkowitz.fedorapeople.org/SRPMS/alacarte-3.36.0-1.fc33.src.rpm Description: Alacarte is a graphical menu editor that lets you edit, add, and delete menu entries. It follows the freedesktop.org menu specification and should work with any desktop environment that uses this specification. Fedora Account System Username: yselkowitz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839873] Review Request: rust-path-dedot - Parse path with dots in `Path` and `PathBuf`
https://bugzilla.redhat.com/show_bug.cgi?id=1839873 Igor Raits changed: What|Removed |Added Summary|Review Request: |Review Request: |rust-path-dedot - Library |rust-path-dedot - Parse |for extending `Path` and|path with dots in `Path` |`PathBuf` in order to parse |and `PathBuf` |the path which contains | |dots| Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839873] New: Review Request: rust-path-dedot - Library for extending `Path` and `PathBuf` in order to parse the path which contains dots
https://bugzilla.redhat.com/show_bug.cgi?id=1839873 Bug ID: 1839873 Summary: Review Request: rust-path-dedot - Library for extending `Path` and `PathBuf` in order to parse the path which contains dots Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-dedot.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-dedot-1.2.2-1.fc33.src.rpm Description: Library for extending `Path` and `PathBuf` in order to parse the path which contains dots. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839873] Review Request: rust-path-dedot - Library for extending `Path` and `PathBuf` in order to parse the path which contains dots
https://bugzilla.redhat.com/show_bug.cgi?id=1839873 --- Comment #1 from Igor Raits --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-dedot.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-path-dedot-1.2.2-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839870] New: Review Request: mk-files - BSD make include routines
https://bugzilla.redhat.com/show_bug.cgi?id=1839870 Bug ID: 1839870 Summary: Review Request: mk-files - BSD make include routines Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pemen...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://src.fedoraproject.org/fork/pemensik/rpms/mk-files/raw/master/f/mk-files.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3721/44963721/mk-files-20200505-1.fc33.src.rpm Description: The mk-files package provides some bmake macros derived from the NetBSD bsd.*.mk macros. These macros allow the creation of simple Makefiles to build all kinds of targets, including, for example, C/C++ programs and/or shared libraries. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=44963721 Fedora Account System Username: pemensik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839840] New: Review Request: rust-slash-formatter - Functions to deal with slashes and backslashes in strings
https://bugzilla.redhat.com/show_bug.cgi?id=1839840 Bug ID: 1839840 Summary: Review Request: rust-slash-formatter - Functions to deal with slashes and backslashes in strings Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: igor.ra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-slash-formatter.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-slash-formatter-2.2.6-1.fc33.src.rpm Description: Functions to deal with slashes and backslashes in strings. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242
--- Comment #2 from Andrew Bauer ---
UPDATE:
Created the fw_services macro, so now rpmlint complains a little less:
> $ rpmlint /var/lib/mock/fedora-32-x86_64/result/*.rpm
> python3-ouimeaux.noarch: W: no-manual-page-for-binary wemo
> python-ouimeaux.src:9: E: hardcoded-library-path in
> %{_prefix}/lib/firewalld/services
> 2 packages and 0 specfiles checked; 1 errors, 1 warnings.
UPDATED SPECFILE URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/python-ouimeaux.spec
UPDATED SRPM URL:
https://download.copr.fedorainfracloud.org/results/kni/ouimeaux-fedora/fedora-rawhide-x86_64/01407906-python-ouimeaux/python-ouimeaux-0.8.2-3.git.6b6984b.fc33.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839242] Review Request: python-ouimeaux - Open source control for Belkin WeMo devices
https://bugzilla.redhat.com/show_bug.cgi?id=1839242
Andrew Bauer changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Andrew Bauer ---
UPDATE:
I moved the examples folder out of the build and into the docs folder
The wemo binary requires udp port 54321 to be open in the firewall.
A firewalld config file and readme instructions were added to document this.
UPDATE SPECFILE URL:
https://raw.githubusercontent.com/knight-of-ni/specfiles/master/python-ouimeaux.spec
UPDATED SRPM URL:
https://download.copr.fedorainfracloud.org/results/kni/ouimeaux-fedora/fedora-rawhide-x86_64/01407798-python-ouimeaux/python-ouimeaux-0.8.2-2.git.6b6984b.fc33.src.rpm
Note that this does introduce new errors running rpmlint:
> $ rpmlint /var/lib/mock/fedora-32-x86_64/result/*.rpm
> python3-ouimeaux.noarch: W: no-manual-page-for-binary wemo
> python-ouimeaux.src:76: E: hardcoded-library-path in
> %{_prefix}/lib/firewalld/services
> python-ouimeaux.src:77: E: hardcoded-library-path in
> %{_prefix}/lib/firewalld/services/
> python-ouimeaux.src:91: E: hardcoded-library-path in
> %{_prefix}/lib/firewalld/services/%{srcname}.xml
> 2 packages and 0 specfiles checked; 3 errors, 1 warnings.
However, these library paths have been implemented in the manner documented in
the following link and in the firewalld specfile.
https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets/Firewalld
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 markusN changed: What|Removed |Added Attachment|0 |1 #1691203 is|| obsolete|| Attachment|0 |1 #1691596 is|| obsolete|| Attachment|0 |1 #1691769 is|| obsolete|| --- Comment #21 from markusN --- Created attachment 1691970 --> https://bugzilla.redhat.com/attachment.cgi?id=1691970=edit updated PDAL spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686
--- Comment #20 from markusN ---
Concerning the library versioning (answer by the PDAL maintainer):
> The library versioning adopted by PDAL is pretty unusual, i.e. in
> CMakeLists.txt
This was a bug that is fixed in https://github.com/PDAL/PDAL/pull/3042. This is
merged to the 2.1-maintenance branch and will be included in PDAL 2.1.1, which
is expected by the end of June 2020.
Concerning the failing pgpointcloudtest:
- https://github.com/PDAL/PDAL/issues/742 "Test for pgpointcloud fails"
First I tried to define the PG related env vars:
%check
# test the compiled code (see doc/project/testing.rst)
PGUSER=pdal PGPASSWORD=password PGHOST=localhost PGPORT=5432 ctest -V
Also now this test is still failing ("could not connect to server: Connection
refused").
I suspect that during the RPM compilation the PG server is simply not running
and I have no idea how to start that in the SPEC file.
Debian seems to face the same test problem, they have work-arounded it like
this:
ctest -V --exclude-regex "pgpointcloudtest"
Now,
- we can deactivate the PostgreSQL support entirely as I was not able to find
so far a SPEC file with working ctest-running PostgreSQL combo.
- or skip the pgpointcloudtest test.
Hence, I now adopted the next suggestion from above PDAL ticket 742 to skip the
test:
-D BUILD_PGPOINTCLOUD_TESTS:BOOL=OFF
Latest log:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44957096
successes:
- i686
- x86_64
remaining failures:
- armv7hl
(https://kojipkgs.fedoraproject.org//work/tasks/7211/44957211/build.log):
Start 38: pdal_io_las_writer_test
38: Test command:
/builddir/build/BUILD/PDAL-2.1.0-src/bin/pdal_io_las_writer_test
38: Environment variables:
38: PDAL_DRIVER_PATH=/builddir/build/BUILD/PDAL-2.1.0-src/lib
38: Test timeout computed to be: 1000
38: [==] Running 27 tests from 1 test suite.
38: [--] Global test environment set-up.
38: [--] 27 tests from LasWriterTest
38: [ RUN ] LasWriterTest.srs
38: [ OK ] LasWriterTest.srs (35 ms)
38: [ RUN ] LasWriterTest.srs2
38: [ OK ] LasWriterTest.srs2 (12 ms)
38: [ RUN ] LasWriterTest.auto_offset
38: [ OK ] LasWriterTest.auto_offset (10 ms)
38: [ RUN ] LasWriterTest.auto_offset2
38: [ OK ] LasWriterTest.auto_offset2 (15 ms)
38: [ RUN ] LasWriterTest.extra_dims
38: [ OK ] LasWriterTest.extra_dims (16 ms)
38: [ RUN ] LasWriterTest.all_extra_dims
38: [ OK ] LasWriterTest.all_extra_dims (24 ms)
38: [ RUN ] LasWriterTest.forward
38: (readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs
not found
38: (readers.las Error) GDAL failure (1) PROJ: proj_create_from_database: crs
not found
38: [ OK ] LasWriterTest.forward (1204 ms)
38: [ RUN ] LasWriterTest.forwardvlr
38: proj_uom_get_info_from_database: unit of measure not found
38: [ OK ] LasWriterTest.forwardvlr (85 ms)
38: [ RUN ] LasWriterTest.flex
38: [ OK ] LasWriterTest.flex (16 ms)
38: [ RUN ] LasWriterTest.flex2
38: [ OK ] LasWriterTest.flex2 (11 ms)
38: [ RUN ] LasWriterTest.laszip
38: [ OK ] LasWriterTest.laszip (797 ms)
38: [ RUN ] LasWriterTest.laszip1_4
38/107 Test #38: pdal_io_las_writer_test Bus
error***Exception: 3.11 sec
aarch64
(https://kojipkgs.fedoraproject.org//work/tasks/7214/44957214/build.log):
Start 89: pdal_filters_stats_test
89: Test command:
/builddir/build/BUILD/PDAL-2.1.0-src/bin/pdal_filters_stats_test
89: Environment variables:
89: PDAL_DRIVER_PATH=/builddir/build/BUILD/PDAL-2.1.0-src/lib64
89: Test timeout computed to be: 1000
89: [==] Running 9 tests from 1 test suite.
89: [--] Global test environment set-up.
89: [--] 9 tests from Stats
89: [ RUN ] Stats.handcalc
89: [ OK ] Stats.handcalc (2 ms)
89: [ RUN ] Stats.baseline
89: [ OK ] Stats.baseline (2 ms)
89: [ RUN ] Stats.simple
89: [ OK ] Stats.simple (2 ms)
89: [ RUN ] Stats.advanced
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:211:
Failure
89: The difference between statsX.sampleSkewness() and -5.2235397e-16 is
1.9919314947420312e-18, which exceeds 1e-23, where
89: statsX.sampleSkewness() evaluates to -5.2036203850525794e-16,
89: -5.2235397e-16 evaluates to -5.22353967e-16, and
89: 1e-23 evaluates to 9.9996e-24.
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:212:
Failure
89: The difference between statsY.sampleSkewness() and -5.7098153e-16 is
1.1898719537472993e-20, which exceeds 1e-23, where
89: statsY.sampleSkewness() evaluates to -5.7096963128046251e-16,
89: -5.7098153e-16 evaluates to -5.70981528e-16, and
89: 1e-23 evaluates to 9.9996e-24.
89:
/builddir/build/BUILD/PDAL-2.1.0-src/test/unit/filters/StatsFilterTest.cpp:213:
Failure
89: The difference between statsZ.sampleSkewness() and
[Bug 1839555] Review Request: bloaty - A size profiler for binaries
https://bugzilla.redhat.com/show_bug.cgi?id=1839555
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>%install
>rm -rf %{buildroot}
Don't remove the buildroot at start of %install.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections
Also - since you're not using the Google-provided .bz2 archive, but rather the
GitHub generated tarball as Source0, the test suite is included in the
download. How about running those in %check?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839572] Review Request: chaos-client - Client to interact with the Chaos DNS API
https://bugzilla.redhat.com/show_bug.cgi?id=1839572 --- Comment #2 from aegor...@redhat.com --- I'm sorry to say, but I've got an unexpected workload and most probably I'll have no time capacity to finish the review this week. If this review is urgent feel free to set nob...@fedoraproject.org as assignee and change status to NEW. If not, I'll start review later on this week. Thank you for understanding. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839773] Review Request: bst-external - Additional BuildStream plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1839773 --- Comment #1 from Artem --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44954525 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839773] New: Review Request: bst-external - Additional BuildStream plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1839773 Bug ID: 1839773 Summary: Review Request: bst-external - Additional BuildStream plugins Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: ego.corda...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://atim.fedorapeople.org//bst-external.spec SRPM URL: https://atim.fedorapeople.org//bst-external-0.20.0-2.fc32.src.rpm Description: A collection of BuildStream plugins that don't fit in with the core plugins for whatever reason. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839773] Review Request: bst-external - Additional BuildStream plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1839773 Artem changed: What|Removed |Added CC||gasinv...@gmail.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1218410] Review Request: python-APSscheduler - In-process task scheduler with Cron-like capabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1218410 Miro Hrončok changed: What|Removed |Added Depends On||1838027 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1838027 [Bug 1838027] Review Request: zuul - Trunk Gating System -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838027] Review Request: zuul - Trunk Gating System
https://bugzilla.redhat.com/show_bug.cgi?id=1838027 Miro Hrončok changed: What|Removed |Added Blocks||1218410 --- Comment #5 from Miro Hrončok --- *** Bug 1220451 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1218410 [Bug 1218410] Review Request: python-APSscheduler - In-process task scheduler with Cron-like capabilities -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1218410] Review Request: python-APSscheduler - In-process task scheduler with Cron-like capabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1218410 Bug 1218410 depends on bug 1220451, which changed state. Bug 1220451 Summary: Review Request: zuul - Trunk gating system developed for the OpenStack Project https://bugzilla.redhat.com/show_bug.cgi?id=1220451 What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project
https://bugzilla.redhat.com/show_bug.cgi?id=1220451 Miro Hrončok changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |DUPLICATE Last Closed||2020-05-25 13:27:25 --- Comment #27 from Miro Hrončok --- *** This bug has been marked as a duplicate of bug 1838027 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #19 from Sandro Mani --- > OK, but I don't get it running. How so? Are there other errors? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project
https://bugzilla.redhat.com/show_bug.cgi?id=1220451 --- Comment #26 from Fabien Boucher --- New package review request is: https://bugzilla.redhat.com/show_bug.cgi?id=1838027 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1831347] Review Request: We10X-icon-theme - Icon theme inspired by Microsoft Windows 10 aesthetic
https://bugzilla.redhat.com/show_bug.cgi?id=1831347 Artur Iwicki changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Iwicki --- New build using the latest upstream git snapshot. spec: https://svgames.pl/fedora/We10X-icon-theme-0-2.20200522git1e951299/We10X-icon-theme.spec srpm: https://svgames.pl/fedora/We10X-icon-theme-0-2.20200522git1e951299/We10X-icon-theme-0-2.20200522git1e951299.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=44952986 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837757] Review Request: python-threadpoolctl - Thread-pool Controls
https://bugzilla.redhat.com/show_bug.cgi?id=1837757 --- Comment #4 from Miro Hrončok --- This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask. The Python 3.9 rebuild is in progress in a Koji side tag. If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with: $ fedpkg build --target=f33-python The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you. You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together. If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #18 from markusN --- (In reply to Sandro Mani from comment #17) > Is there any other test failing other than pgpointcloudtest? Yes, only this one. FWIW, in the openSuSe PDAL package they doesn't test at all and in Debian pgpointcloudtest is excluded (I got that from there). > It would be > better to leave out the " || echo "Ignoring test failures"", as otherwise > no-one will notice the test failures. OK, but I don't get it running. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 Paul Howarth changed: What|Removed |Added CC||p...@city-fan.org --- Comment #9 from Paul Howarth --- The music license is non-free because it only allows use in conjunction with the game. This is not acceptable for Fedora: https://fedoraproject.org/wiki/Licensing:Main#Content_Licenses It think it may be OK for RPM Fusion though. You wouldn't need the downloader script for a package there either, you could just package the music tarball directly. If such a music package had "Supplements: 7kaa" then users with the additional repo enabled would get the music installed when they installed 7kaa. Another possible approach would be to use autodownloader: https://src.fedoraproject.org/rpms/autodownloader -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1803223] Review Request: golang-github-google-starlark - Starlark is a dialect of Python intended for use as a configuration language.
https://bugzilla.redhat.com/show_bug.cgi?id=1803223
Jakub Čajka changed:
What|Removed |Added
Status|POST|ASSIGNED
Assignee|chedi.toue...@gmail.com |jca...@redhat.com
Flags|fedora-review+ |fedora-review?
--- Comment #12 from Jakub Čajka ---
Generally looks good to me. I see two issues. First the name of the
package/spec. I think it can be even just starlark, but golang-starlak(or the
full "import" path) will work too. Please adjust the name of the package in the
review request title and change the name of the spec to the name that you will
choose.
Second is that there are two files of testdata under the apache 2.0 license.
Could you please adjust the license tag and add license breakdown in to the
comment above it?
Otherwise look good to me. Thank you for packaging :).
Fedora review output follows.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: golang-github-google-starlark.spec should be golang-starlark.spec
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_spec_file_naming
- contains testdata under apache2.0 license not listed under the license tag
* starlark/testdata/paths.star
* syntax/testdata/scan.star
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
[Bug 1832562] Review Request: tpcclib - Tools for processing data from Turku PET Centre (TPC)
https://bugzilla.redhat.com/show_bug.cgi?id=1832562 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #5 from Ankur Sinha (FranciscoD) --- Thanks. I'll have a look at it this week. Please ping me in the channel if you need to. I should be lurking there during the day time in BST. PS: the needinfo flag is generally used when one has not received a response on the bug for a while---it sends addition notifications to uses. So not needed here, since I am actively looking at this bug :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1727505] Review Request: python-bluepyopt - Bluebrain Python Optimisation Library (bluepyopt)
https://bugzilla.redhat.com/show_bug.cgi?id=1727505 Ankur Sinha (FranciscoD) changed: What|Removed |Added Flags|needinfo?(sanjay.ankur@gmai | |l.com) | --- Comment #11 from Ankur Sinha (FranciscoD) --- Hi Anil, The package needs to be built correctly so we can complete the review. Quite a few issues outstanding with the current spec: Are you a package maintainer already? I can help you with the package and sponsor you as a maintainer if you wish: please e-mail me and we can work on that. Issues: === - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ^ Needs to be checked - I've filed a ticket asking upstream to add tests and licenses to the release, or make sure the github releases/tags match pypi so we can use them: https://github.com/BlueBrain/BluePyOpt/issues/280 We should use the github tar here. It contains: - license files - tests - docs. - Please complete the description. It is incomplete. Probably worth defining a macro and re-using it. Example here: https://pagure.io/neuro-sig/NeuroFedora/blob/master/f/spec-templates/python.spec#_10 Some more work needed. Unfortunately, the mock build seemed to have failed here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #17 from Sandro Mani --- Is there any other test failing other than pgpointcloudtest? It would be better to leave out the " || echo "Ignoring test failures"", as otherwise no-one will notice the test failures. Once you believe that all is addressed, please post a new SPEC+SRPM to finish the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #13 from Honggang LI --- (In reply to igor.ivanov.va from comment #10) > I added patch with man pages > (https://raw.githubusercontent.com/igor-ivanov/libvma/pr/fedora-package/ > fedora/0001-issue-928161-Add-man-pages.patch) > and > updated source rpm with spec. The updated spec file looks good to me. I will set the fedora-review+ flag, after the patch get into upstream. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #16 from markusN --- Problem of `pgpointcloudtest` addressed, it now compile successfully: https://koji.fedoraproject.org/koji/taskinfo?taskID=44944553 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1838686] Review Request: PDAL - Point Data Abstraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1838686 --- Comment #15 from markusN --- Created attachment 1691769 --> https://bugzilla.redhat.com/attachment.cgi?id=1691769=edit updated PDAL spec file Successfully compiling -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #8 from Paul Dufresne --- Created attachment 1691766 --> https://bugzilla.redhat.com/attachment.cgi?id=1691766=edit License file for the music of 7KAA (apparently original music of the game) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #7 from Paul Dufresne --- The license for the music is describe in a file in the zip (or bzip2) archive shown at: https://7kfans.com/?p=96 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #6 from Paul Dufresne --- In fact, I believe that by making music a sub-package of your package, you are tainting your package with the license of the music... Which I can read from: https://fedora.pkgs.org/31/fedora-x86_64/7kaa-music-2.14.7-6.fc31.noarch.rpm.html: is "Redistributable, no modification permitted" ... and I don't think you want to add that to your package, because the game would become non-free (not allowing modification to source code). So I think they "must" be separate packages. But... I am just a newbie to packaging and I am frankly unsure of what I am saying. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1835421] Review Request: python-sgmllib3k - Py3k port of sgmllib
https://bugzilla.redhat.com/show_bug.cgi?id=1835421 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- Mock build fails with: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Idbluu + umask 022 + cd /builddir/build/BUILD + cd sgmllib3k-1.0.0 + %py3_build /var/tmp/rpm-tmp.Idbluu: line 32: fg: no job control RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.Idbluu (%build) Bad exit status from /var/tmp/rpm-tmp.Idbluu (%build) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #12 from igor.ivanov...@gmail.com --- Ok, I will update you after getting pacth into master. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 --- Comment #5 from Paul Dufresne --- About downloading the music, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_build_time_network_access "Packages in the Fedora buildsystem are built in a mock chroot with no access to the internet. Packages must not depend or or use any network resources that they don’t themselves create (i.e., for tests). In no cases should source code be downloaded from any external sources, only from the lookaside cache and/or the Fedora git repository." So I think you are supposed to add a source line for the music files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1727505] Review Request: python-bluepyopt - Bluebrain Python Optimisation Library (bluepyopt)
https://bugzilla.redhat.com/show_bug.cgi?id=1727505 Anil Tuncel changed: What|Removed |Added CC||tuncel.ma...@gmail.com Flags||needinfo?(sanjay.ankur@gmai ||l.com) --- Comment #10 from Anil Tuncel --- Hi Ankur, I can work on this. Could you summarise what is remaining? Best, Anil Tuncel Blue Brain Project -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1826439] Review Request: libvma - LD_PRELOAD-able library with standard BSD sockets API
https://bugzilla.redhat.com/show_bug.cgi?id=1826439 --- Comment #11 from Honggang LI --- (In reply to igor.ivanov.va from comment #10) > I added patch with man pages > (https://raw.githubusercontent.com/igor-ivanov/libvma/pr/fedora-package/ > fedora/0001-issue-928161-Add-man-pages.patch) I checked libvma git repo. I did not found this patch. The patch should be applied in upstream before apply it for fedora. Please see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_patch_guidelines . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839572] Review Request: chaos-client - Client to interact with the Chaos DNS API
https://bugzilla.redhat.com/show_bug.cgi?id=1839572 aegor...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||aegor...@redhat.com Assignee|nob...@fedoraproject.org|aegor...@redhat.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? --- Comment #1 from aegor...@redhat.com --- I'll review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
