[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 yanqiy...@gmail.com changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- SPEC URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec COPR build: https://copr.fedorainfracloud.org/coprs/yanqiyu/trojan/build/1446987/ koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45651819 SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/trojan/fedora-rawhide-x86_64/01446987-trojan/trojan-1.16.0-3.fc33.src.rpm Description: An unidentifiable mechanism that helps you bypass GFW. Fedora Account System Username: yanqiyu -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 --- Comment #9 from yanqiy...@gmail.com --- Since I have already dropped the patch, I am still using %setup, will that be fine? And the legal problem, I posted that on legal mailing list[1]. One reply says that: > This appears to be identical to the OpenSSL linking exception appended > to the GPLv2 license file in cryptsetup > (https://gitlab.com/cryptsetup/cryptsetup/-/blob/master/COPYING). It's > one of a number of OpenSSL linking exceptions that have been in use by > GPL projects. I am doing further check if this can be a problem. For all other SPEC file problem, they all have been fixed: new SPEC file: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec new SRPM file: https://kojipkgs.fedoraproject.org//work/tasks/3105/45683105/trojan-1.16.0-4.fc32.src.rpm new koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45683104 fedora-review results can be found here: https://github.com/karuboniru/trojan-rpmbuild/issues/2 * since COPR is down now, I can't build on COPR * for the crypto-policy-non-compliance-openssl warning, the shipped configuration will set "cipher": "PROFILE=SYSTEM", so that is no violence with the guideline, I think * for the invalid-url URL in my fedora-review result, that is because my network situation here [1] https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/MJUOORX66O65W73JMO4UN64KSNHOPQCI/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821703] Review Request: golang-github-temoto-robotstxt - Robots.txt exclusion protocol implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1821703 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821645] Review Request: golang-github-urfave-cli-2 - A package for building command line apps
https://bugzilla.redhat.com/show_bug.cgi?id=1821645 --- Comment #1 from Hirotaka Wakabayashi --- Hello Fabian, A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-urfave-cli-2 https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Best, Hirotaka Wakabayashi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1830306] Review Request: python-git-revise - Efficiently update, split, and rearrange git commits
https://bugzilla.redhat.com/show_bug.cgi?id=1830306 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #10 from Fedora Update System --- FEDORA-2020-d1530ee346 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1530ee346 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 --- Comment #8 from yanqiy...@gmail.com --- For the test, maybe I lost some build dependencies, I will check tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 --- Comment #7 from yanqiy...@gmail.com --- I see, the difference in license with vanilla GPLv3 is a exception to link this code against openssl. Should I set a blocker for FE-Legal or send a mail to le...@lists.fedoraproject.org? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175
--- Comment #6 from yanqiy...@gmail.com ---
Thank you for your review!
(In reply to dan.cermak from comment #5)
> This is mostly ok, a few things should be addressed though:
>
> - Upstream's license is not a vanilla GPLv3+, you should check with legal
> how to proceed in this case.
Upstream license is https://github.com/trojan-gfw/trojan/blob/master/LICENSE,
isn't that a GPLv3+, I can see some file without a license, which are mostly
documents and test cases. Really I don't know the difference. After all, how do
I contact legal team?
> - your BuildRequires are lacking version numbers (e.g. BuildRequires:
> boost-devel >= 1.66)
> - use %autosetup -p1 instead of %setup and %patch
> - use %make_build and %make_install instead of make %{?_smp_mflags}
> - don't glob the files in %_bindir and %_unitdir, as this is just 1 file
> each, simply write: %{_bindir}/%{name}
I will fix those then.
> - your package should own %{_sysconfdir}/trojan via: %dir
> %{_sysconfdir}/trojan
This has been fixed in the latest source. Which you can see in the modified
comment 0
> - add the note in the patch (why it exists) to the spec file
This patch was removed, instead I modified the shipped configuration files, I
will comment this in spec file.
> - upstream provides gpg signatures, please use %gpgverify to check the
> sources for consistency as described here:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_source_file_verification
I will fix this.
> - upstream has a test suite, but it is not run in %check, is that
> intentional?
Yes, those tests won't run in a mock build environment. Maybe something related
to network, in this test, it will open an instance to listen on certain port
and another will try to connect. But this fails inside the container. Those
will pass when build with rpmbuild without mock (same srpm file)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1654426] Review Request: rubygem-xdg - dependency of new version of tmuxinator
https://bugzilla.redhat.com/show_bug.cgi?id=1654426 Mattia Verga changed: What|Removed |Added CC||mattia.ve...@protonmail.com Flags||needinfo?(i...@dmeijboom.nl ||) --- Comment #9 from Mattia Verga --- This package was approved but never imported. Are you still interested in getting it into Fedora repositories? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1199693] Review Request: pcp-pmda-cpp - C++ library for PCP PMDAs
https://bugzilla.redhat.com/show_bug.cgi?id=1199693 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-13 15:56:36 --- Comment #43 from Mattia Verga --- This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1476434] Review Request: bstrlib - Better String Library
https://bugzilla.redhat.com/show_bug.cgi?id=1476434 Mattia Verga changed: What|Removed |Added CC||mattia.ve...@protonmail.com Flags||needinfo?(18969068329@163.c ||om) --- Comment #18 from Mattia Verga --- This package was approved some years ago, but never imported. Are you still interested in getting it into Fedora repositories? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers
https://bugzilla.redhat.com/show_bug.cgi?id=1268360 Mattia Verga changed: What|Removed |Added CC||mattia.ve...@protonmail.com Flags||needinfo?(ilya.gradina@gmai ||l.com) --- Comment #22 from Mattia Verga --- This package was approved some years ago, but never imported. Are you still interested in getting it into Fedora repositories? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1626470] Review Request: amtk - Actions, Menus and Toolbars Kit for GTK+ applications
https://bugzilla.redhat.com/show_bug.cgi?id=1626470 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-13 15:49:28 --- Comment #4 from Mattia Verga --- This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623469] Review Request: python-click-man - Generate man pages for click based CLI applications
https://bugzilla.redhat.com/show_bug.cgi?id=1623469 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-13 15:47:24 --- Comment #14 from Mattia Verga --- This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Bug 1623220 depends on bug 1623469, which changed state. Bug 1623469 Summary: Review Request: python-click-man - Generate man pages for click based CLI applications https://bugzilla.redhat.com/show_bug.cgi?id=1623469 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1623220] Review Request: python-mmdzanata - Tools for working with translations of modulemd
https://bugzilla.redhat.com/show_bug.cgi?id=1623220 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2020-06-13 15:45:38 --- Comment #12 from Mattia Verga --- This package was approved and imported in repositories and it was later retired, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 453264] Review Request: jscoverage - A tool that measures code coverage for JavaScript programs
https://bugzilla.redhat.com/show_bug.cgi?id=453264 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2020-06-13 15:44:18 --- Comment #9 from Mattia Verga --- I'm going to close this as dead review, since the package was never imported and the original submitter account is no more active. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1262470] Review Request: python-PyPDF2 - A pure Python library built as a PDF toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1262470 Mattia Verga changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed|2015-10-23 16:20:46 |2020-06-13 15:41:11 --- Comment #27 from Mattia Verga --- This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1234210] Review Request: pdf-stapler - tool for manipulating PDF documents from the command line
https://bugzilla.redhat.com/show_bug.cgi?id=1234210 Bug 1234210 depends on bug 1262470, which changed state. Bug 1262470 Summary: Review Request: python-PyPDF2 - A pure Python library built as a PDF toolkit https://bugzilla.redhat.com/show_bug.cgi?id=1262470 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1211529] Review Request: docker-machine - Tool for managing Docker hosts
https://bugzilla.redhat.com/show_bug.cgi?id=1211529 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||mattia.ve...@protonmail.com Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2020-06-13 15:38:47 --- Comment #26 from Mattia Verga --- I'm going to close this as dead review, package has been retired from Rawhide. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 858060] Review Request: qpid-snmpd - SNMP agent for qpid broker
https://bugzilla.redhat.com/show_bug.cgi?id=858060 Mattia Verga changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2020-06-13 15:27:38 --- Comment #19 from Mattia Verga --- Package has been retired from Fedora Rawhide. Closing this ticket as dead review. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175
dan.cer...@cgc-instruments.com changed:
What|Removed |Added
CC||dan.cermak@cgc-instruments.
||com
--- Comment #5 from dan.cer...@cgc-instruments.com ---
This is mostly ok, a few things should be addressed though:
- Upstream's license is not a vanilla GPLv3+, you should check with legal how
to proceed in this case.
- your BuildRequires are lacking version numbers (e.g. BuildRequires:
boost-devel >= 1.66)
- use %autosetup -p1 instead of %setup and %patch
- use %make_build and %make_install instead of make %{?_smp_mflags}
- don't glob the files in %_bindir and %_unitdir, as this is just 1 file each,
simply write: %{_bindir}/%{name}
- your package should own %{_sysconfdir}/trojan via: %dir %{_sysconfdir}/trojan
- add the note in the patch (why it exists) to the spec file
- upstream provides gpg signatures, please use %gpgverify to check the sources
for consistency as described here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_source_file_verification
- upstream has a test suite, but it is not run in %check, is that intentional?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846749] New: Review Request: rubygem-rotp - A Ruby library for generating and verifying one time passwords
https://bugzilla.redhat.com/show_bug.cgi?id=1846749 Bug ID: 1846749 Summary: Review Request: rubygem-rotp - A Ruby library for generating and verifying one time passwords Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: patilsuraj...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/supatil/rubygem-rotp/fedora-32-x86_64/01447086-rubygem-rotp/rotp.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/supatil/rubygem-rotp/fedora-32-x86_64/01447086-rubygem-rotp/rubygem-rotp-5.1.0-1.fc32.src.rpm Description: rotp is a ruby library for generating and verifying one time passwords. This is my first package and I need a sponsor. rotp ruby gem is not created by me. I have created the spec file using gem2rpm. Fedora Account System Username: supatil Koji build URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=45658478 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 yanqiy...@gmail.com changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- SPEC URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec COPR build: https://copr.fedorainfracloud.org/coprs/yanqiyu/trojan/build/1446987/ koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45651819 SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/trojan/fedora-rawhide-x86_64/01446987-trojan/trojan-1.16.0-3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 yanqiy...@gmail.com changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- SPEC URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec COPR build: https://copr.fedorainfracloud.org/coprs/yanqiyu/trojan/build/1446847/ koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=45640323 SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/trojan/fedora-rawhide-x86_64/01446847-trojan/trojan-1.16.0-2.fc33.src.rpm And a fedora-review result: https://github.com/karuboniru/trojan-rpmbuild/issues/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821645] Review Request: golang-github-urfave-cli-2 - A package for building command line apps
https://bugzilla.redhat.com/show_bug.cgi?id=1821645 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1821546] Review Request: ghc-aeson-better-errors - Better error messages when decoding JSON values
https://bugzilla.redhat.com/show_bug.cgi?id=1821546
Hirotaka Wakabayashi changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Hirotaka Wakabayashi ---
Hello Jens,
Package approved. rpmlint puts an error, but it's not a problem.
```
$ ldd
/usr/lib64/libHSaeson-better-errors-0.9.1.0-654wnSShBkq8kjZZSC1e3o-ghc8.6.5.so|grep
libc
libc.so.6 => /lib64/libc.so.6 (0x7fed3c2ea000)
```
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 6 files have unknown
license. Detailed output of licensecheck in
/home/vagrant/FedoraReview/1821546-ghc-aeson-better-
errors/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/doc/ghc(ghc-Agda-
doc, ghc-EdisonCore-doc, ghc-geniplate-mirror-doc, ghc-uri-encode-doc,
ghc-murmur-hash-doc, ghc-EdisonAPI-doc, ghc-compiler, ghc-dns-doc),
/usr/share/doc/ghc/html(ghc-Agda-doc, ghc-EdisonCore-doc, ghc-
geniplate-mirror-doc, ghc-uri-encode-doc, ghc-murmur-hash-doc, ghc-
EdisonAPI-doc, ghc-compiler, ghc-dns-doc),
/usr/share/doc/ghc/html/libraries(ghc-Agda-doc, ghc-EdisonCore-doc,
ghc-geniplate-mirror-doc, ghc-uri-encode-doc, ghc-murmur-hash-doc,
ghc-EdisonAPI-doc, ghc-compiler, ghc-dns-doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 cashflow changed: What|Removed |Added CC||cashflowstatementshub@gmail ||.com --- Comment #124 from cashflow --- amazing fact http://wordjumblesolvers.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1846175] Review Request: Trojan - an unidentifiable proxy software
https://bugzilla.redhat.com/show_bug.cgi?id=1846175 yanqiy...@gmail.com changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2282/45592282/trojan-1.15.1-1.fc32.src.rpm My Patch URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan-ssl_cipher_list.patch The patch is for using System-wide crypto policy Description: An unidentifiable mechanism that helps you bypass GFW. Fedora Account System Username: yanqiyu And a scratch build on koji here: https://koji.fedoraproject.org/koji/taskinfo?taskID=45592281 - Update to 1.16.0 new COPR build: https://copr.fedorainfracloud.org/coprs/yanqiyu/trojan/build/1446213/ new SRPM: https://download.copr.fedorainfracloud.org/results/yanqiyu/trojan/fedora-rawhide-x86_64/01446213-trojan/trojan-1.16.0-1.fc33.src.rpm Spec URL: https://raw.githubusercontent.com/karuboniru/trojan-rpmbuild/master/trojan.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1844918] Review Request: rust-choosier - Choose your browser based on the URL given
https://bugzilla.redhat.com/show_bug.cgi?id=1844918 Michel Alexandre Salim changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-06-13 06:34:26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
