[Red Hat Bugzilla] Your Outstanding Requests
The following is a list of bugs or attachments to bugs in which a user has been waiting more than 3 days for a response from you. Please take action on these requests as quickly as possible. (Note that some of these bugs might already be closed, but a user is still waiting for your response.) We'll remind you again tomorrow if these requests are still outstanding, or if there are any new requests where users have been waiting more than 3 days for your response. If you want these mails to stop you need to go to the bug[s] and cancel or ack the needinfo flags. See: * https://bugzilla.redhat.com/page.cgi?id=faq.html#flags point 3 * https://bugzilla.redhat.com/page.cgi?id=faq.html#miscellaneous point 2 needinfo Bug 1855094: Review Request: pveclib - Library for simplified access to PowerISA vector operations (7 days old) https://bugzilla.redhat.com/show_bug.cgi?id=1855094 To see all your outstanding requests, visit: https://bugzilla.redhat.com/request.cgi?action=queue=package-review%40lists.fedoraproject.org=type ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1839376] Review Request: rust-log-panics - Panic hook which logs panic messages rather than printing them
https://bugzilla.redhat.com/show_bug.cgi?id=1839376 Michel Alexandre Salim changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-22 01:21:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1837107] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries (claiming ownership of package)
https://bugzilla.redhat.com/show_bug.cgi?id=1837107 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-22 01:20:07 --- Comment #24 from Fedora Update System --- FEDORA-2020-cd5132634d has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1854202 --- Comment #9 from Fedora Update System --- FEDORA-2020-8755e3db8b has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1854202] Review Request: golang-github-instrumenta-kubeval - Validate your Kubernetes configuration files
https://bugzilla.redhat.com/show_bug.cgi?id=1854202 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #8 from Fedora Update System --- FEDORA-2020-49e3e8d996 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 --- Comment #3 from Michel Alexandre Salim --- Created attachment 1702012 --> https://bugzilla.redhat.com/attachment.cgi?id=1702012=edit Rawhide build.log Looks like libavif in Rawhide is too old: CMake Warning at CMakeLists.txt:25 (find_package): Could not find a configuration file for package "libavif" that is compatible with requested version "0.8.0". The following configuration files were considered but not accepted: /usr/lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 /lib64/cmake/libavif/libavif-config.cmake, version: 0.7.3 -- libavif not found! Searching for local build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859416] New: Review Request: rubygem-actiontext - Rich text framework
https://bugzilla.redhat.com/show_bug.cgi?id=1859416 Bug ID: 1859416 Summary: Review Request: rubygem-actiontext - Rich text framework Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pval...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/pvalena/ruby-on-rails/fedora-rawhide-x86_64/01571722-rubygem-actiontext/rubygem-actiontext.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pvalena/ruby-on-rails/fedora-rawhide-x86_64/01571722-rubygem-actiontext/rubygem-actiontext-6.0.3.1-1.fc33.src.rpm Description: Edit and display rich text in Rails applications. Fedora Account System Username: pvalena COPR build: https://copr.fedorainfracloud.org/coprs/build/1571722 This is part of Upgrade to Ruby on Rails 6.0: https://fedoraproject.org/wiki/Changes/Ruby_on_Rails_6.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859414] New: Review Request: rubygem-actionmailbox - Email composition and delivery framework (part of Rails)
https://bugzilla.redhat.com/show_bug.cgi?id=1859414 Bug ID: 1859414 Summary: Review Request: rubygem-actionmailbox - Email composition and delivery framework (part of Rails) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pval...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/pvalena/ruby-on-rails/fedora-rawhide-x86_64/01571675-rubygem-actionmailbox/rubygem-actionmailbox.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pvalena/ruby-on-rails/fedora-rawhide-x86_64/01571675-rubygem-actionmailbox/rubygem-actionmailbox-6.0.3.1-1.fc33.src.rpm Description: Email on Rails. Compose, deliver, and test emails using the familiar controller/view pattern. First-class support for multipart email and attachments. Fedora Account System Username: pvalena COPR build: https://copr.fedorainfracloud.org/coprs/build/1571675 This is part of Upgrade to Ruby on Rails 6.0: https://fedoraproject.org/wiki/Changes/Ruby_on_Rails_6.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #3 from Robert-André Mauchin ---
Ok so I asked upstream and they say the Mbed Crypto implementation is not
thread safe so running the test with the default command is likely to trigger
errors.
Instead you should pass --test-threads=1 to cargo test:
%if %{with check}
%check
%cargo_test -- -- --test-threads=1
%endif
After doing this I was able to build the package successfully.
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Packaging Guidelines
Package approved. Please fix the test issue before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1350884 --- Comment #27 from Brandon Nielsen --- (In reply to Andy Mender from comment #26) > The SPEC file looks better, but I'm having some issues trying to build it. > `fedora-pkg` refuses to download the source tarball, even though `wget` gets > it without issues. When running a scratch build in koji, I unfortunately see > this: > https://koji.fedoraproject.org/koji/taskinfo?taskID=47582012 > > I'll try to fiddle with this a bit more and let you know. wget follows redirects, other parts of the rpm build chain don't seem to, though rpmlint seems to now. The koji build failure looks like an issue with my workaround for the changes to strip in F33[0], interesting that it seemed to work in copr? I'll dig into it more. [0] - https://bugzilla.redhat.com/show_bug.cgi?id=1789099 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 HyderabadVIP changed: What|Removed |Added CC||vinodhy...@gmail.com --- Comment #154 from HyderabadVIP --- The IDE displays hints when Javadoc is missing or Javadoc tags are needed. Click the bulb icon on the lefthand margin of the editor to fix Javadoc errors. If you do not want to see the hints related to Javadoc, choose Tools > Options > Editor > Hints, and clear the Javadoc checkbox in the list of hints that are displayed. https://www.hyderabadvipescorts.in/ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1858503 Ken Dreyer changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #8 from Ken Dreyer --- Koji builders are firewalled from the internet so that builds are secure and deterministic, and the HTTPS requests will always time out. We could probably delete the intersphinx_mapping settings entirely. https://www.sphinx-doc.org/en/master/usage/extensions/intersphinx.html#confval-intersphinx_mapping There are references in docs/conf.py to cached inventory files, but it's not clear to me where those live or how they're updated: https://github.com/ansible-community/sphinx_ansible_theme/issues/22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 810049] Review Request: netbeans-ide - Netbeans Integrated Development Environment (IDE)
https://bugzilla.redhat.com/show_bug.cgi?id=810049 Nathan Andrew changed: What|Removed |Added CC||andreastone...@gmail.com --- Comment #153 from Nathan Andrew --- Thank you for sharing. This blog is awesome. SO simple and easy to navigate https://uniprojectmaterials.com https://projectregards.com https://www.imperialwriters.org -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 Troy Dawson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 21:58:19 --- Comment #5 from Troy Dawson --- Package has been built and it rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Michel Alexandre Salim changed: What|Removed |Added Status|NEW |ASSIGNED CC||mic...@michel-slm.name Flags||fedora-review? --- Comment #2 from Michel Alexandre Salim --- I can review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858419] Review Request: libavif - Library for encoding and decoding .avif filesLibrary for encoding and decoding .avif files
https://bugzilla.redhat.com/show_bug.cgi?id=1858419
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |CLOSED
Resolution|--- |NOTABUG
Last Closed||2020-07-21 21:03:34
--- Comment #3 from Robert-André Mauchin ---
(In reply to Andy Mender from comment #2)
> > Name: libavif
> > Version:0.8.0
> > Release:1%{?dist}
> > Summary:Library for encoding and decoding .avif files
>
> > License:BSD
>
> I would indicate which version of the BSD license it is. `fedora-review`
> reports BSDv2 mostly.
We don't version the BSD license in Fedora. We have that list
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses
where you can see what shorthand to use for any "good" licence.
>
> > %files devel
> > %doc examples/
> > %{_includedir}/avif
> > %{_libdir}/libavif.so
> > %{_libdir}/cmake/libavif
> > %{_libdir}/pkgconfig/libavif.pc
>
> The -devel package should probably include the license as well.
The -devel subpackage depends on the main package, therefore it is not needed
to reinclude the license. The license must be included once per package
combination.
>
> > %package -n avif-tools
> > Summary: Tools to encode and decode AVIF files
>
> > %description -n avif-tools
> > Tools to encode and decode AVIF files.
>
> > %package -n avif-pixbuf-loader
> > Summary:AVIF image loader for GTK+ applications
> > BuildRequires: pkgconfig(gdk-pixbuf-2.0)
> > Requires: gdk-pixbuf2
>
> Should the sub-packages not explicitly depend on the main package with
> %{version} restrictions?
>
Both packages contain binaries that are linked to libavif versioned library, so
it will be autodetected by RPM dependency manager. I could explicitly Requires
it if needed.
> > %files -n avif-pixbuf-loader
> > %license LICENSE
> > %{_libdir}/gdk-pixbuf-2.0/*/loaders/libpixbufloader-avif.so
>
> Should this shared object not be versioned?
>
No, this is a plugin in a private directory, versioning only applies to
libraries in the libdir top level directory.
>
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> ===
> - Package does not use a name that already exists.
> Note: A package with this name already exists. Please check
> https://src.fedoraproject.org/rpms/libavif
> See: https://docs.fedoraproject.org/en-US/packaging-
> guidelines/Naming/#_conflicting_package_names
>
>
Apparently this is already packaged but I didn't notice it. Sorry.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858639] Review Request: qt-avif-image-plugin - Qt plug-in to read/write AVIF images
https://bugzilla.redhat.com/show_bug.cgi?id=1858639 Bug 1858639 depends on bug 1858419, which changed state. Bug 1858419 Summary: Review Request: libavif - Library for encoding and decoding .avif filesLibrary for encoding and decoding .avif files https://bugzilla.redhat.com/show_bug.cgi?id=1858419 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kernel-srpm-macros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858419] Review Request: libavif - Library for encoding and decoding .avif filesLibrary for encoding and decoding .avif files
https://bugzilla.redhat.com/show_bug.cgi?id=1858419
--- Comment #2 from Andy Mender ---
> Name: libavif
> Version:0.8.0
> Release:1%{?dist}
> Summary:Library for encoding and decoding .avif files
> License:BSD
I would indicate which version of the BSD license it is. `fedora-review`
reports BSDv2 mostly.
> %files devel
> %doc examples/
> %{_includedir}/avif
> %{_libdir}/libavif.so
> %{_libdir}/cmake/libavif
> %{_libdir}/pkgconfig/libavif.pc
The -devel package should probably include the license as well.
> %package -n avif-tools
> Summary: Tools to encode and decode AVIF files
> %description -n avif-tools
> Tools to encode and decode AVIF files.
> %package -n avif-pixbuf-loader
> Summary:AVIF image loader for GTK+ applications
> BuildRequires: pkgconfig(gdk-pixbuf-2.0)
> Requires: gdk-pixbuf2
Should the sub-packages not explicitly depend on the main package with
%{version} restrictions?
> %files -n avif-pixbuf-loader
> %license LICENSE
> %{_libdir}/gdk-pixbuf-2.0/*/loaders/libpixbufloader-avif.so
Should this shared object not be versioned?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/libavif
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License BSD 2-clause
"Simplified" License", "BSD 2-clause "Simplified" License", "Expat
License". 70 files have unknown license. Detailed output of
licensecheck in /home/amender/fedora-
scm/1858419-libavif/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 Merlin Mathesius changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Merlin Mathesius --- Looks good. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 Troy Dawson changed: What|Removed |Added Flags|needinfo?(tdaw...@redhat.co | |m) | --- Comment #2 from Troy Dawson --- Fixed mixed space and tabs. Did a test review and rpmlint cleaned that part up. I purposely didn't bump the release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343
Merlin Mathesius changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags||needinfo?(tdaw...@redhat.co
||m)
--- Comment #1 from Merlin Mathesius ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
ISSUES
- Just one minor suggestion from me: address rpmlint's complaints about mixed
spaces and tabs in the spec file
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/rpm,
/usr/lib/rpm/macros.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[?]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin,
[Bug 1853081] Review Request: mlxbf-bfscripts - Helper scripts for Mellanox BlueField systems
https://bugzilla.redhat.com/show_bug.cgi?id=1853081 --- Comment #2 from Spencer Lingard --- New version for review. Spec URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01571580-mlxbf-bfscripts/mlxbf-bfscripts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01571580-mlxbf-bfscripts/mlxbf-bfscripts-3.0.0~beta1-2.fc33.src.rpm Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=47584583 Fixes shellcheck issues, and issues detected automatically by fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858971] Review Request: nicotine+ - A graphical client for Soulseek
https://bugzilla.redhat.com/show_bug.cgi?id=1858971 --- Comment #5 from Mohamed El Morabity --- (In reply to Miro Hrončok from comment #4) > I've built it in mock. Surprisingly it works fine, because the + is at the > end. Sorry for the noise. No problem, thanks for being cautious and wise ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #35 from Simone Caronni --- Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-6.fc32.src.rpm * Tue Jul 21 2020 Simone Caronni - 0.20.0-6 - Update systemd unit. - Update configuration options. - Declared bundled libraries/forks. Room for improvements: - Rework SELinux policy - Check about bundling libdb4 (deprecated everywhere in Fedora, not available in EPEL), upstream accepts any libdb versions for building but wallets are not compatible across different libdb versions and need to be converted. Debian builds with the latest libdb: https://salsa.debian.org/cryptocoin-team/bitcoin/-/blob/master/debian/rules#L31 I've run out of procrastination items for the SELinux policy :D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858971] Review Request: nicotine+ - A graphical client for Soulseek
https://bugzilla.redhat.com/show_bug.cgi?id=1858971 --- Comment #4 from Miro Hrončok --- I've built it in mock. Surprisingly it works fine, because the + is at the end. Sorry for the noise. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858971] Review Request: nicotine+ - A graphical client for Soulseek
https://bugzilla.redhat.com/show_bug.cgi?id=1858971 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #3 from Miro Hrončok --- Does this build fine after https://fedoraproject.org/wiki/Changes/PythonExtras (given the + in the package name)? Can you please post the provides/requires or a scratch build? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858971] Review Request: nicotine+ - A graphical client for Soulseek
https://bugzilla.redhat.com/show_bug.cgi?id=1858971 --- Comment #2 from Mohamed El Morabity --- Many thanks for your review Robert-André :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Bug 1859159 depends on bug 1859151, which changed state. Bug 1859151 Summary: Review Request: rust-rsa - Pure Rust RSA implementation https://bugzilla.redhat.com/show_bug.cgi?id=1859151 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 19:37:26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Bug 1859159 depends on bug 1857748, which changed state. Bug 1857748 Summary: Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API https://bugzilla.redhat.com/show_bug.cgi?id=1857748 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857748] Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1857748 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 19:29:30 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1376511] Review Request: nexus - NeXus scientific data file format
https://bugzilla.redhat.com/show_bug.cgi?id=1376511 Andy Mender changed: What|Removed |Added Flags||needinfo?(stuart@stuartcamp ||bell.me) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 Merlin Mathesius changed: What|Removed |Added CC||mmath...@redhat.com Assignee|nob...@fedoraproject.org|mmath...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1350884 --- Comment #26 from Andy Mender --- The SPEC file looks better, but I'm having some issues trying to build it. `fedora-pkg` refuses to download the source tarball, even though `wget` gets it without issues. When running a scratch build in koji, I unfortunately see this: https://koji.fedoraproject.org/koji/taskinfo?taskID=47582012 I'll try to fiddle with this a bit more and let you know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859118] Review Request: rust-sha3 - SHA-3 (Keccak) hash function
https://bugzilla.redhat.com/show_bug.cgi?id=1859118 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 19:09:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug 1859151 depends on bug 1859118, which changed state. Bug 1859118 Summary: Review Request: rust-sha3 - SHA-3 (Keccak) hash function https://bugzilla.redhat.com/show_bug.cgi?id=1859118 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug 1859151 depends on bug 1858603, which changed state. Bug 1858603 Summary: Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library https://bugzilla.redhat.com/show_bug.cgi?id=1858603 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1858603 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 19:05:22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug 1859151 depends on bug 1857740, which changed state. Bug 1857740 Summary: Review Request: rust-num-bigint-dig - Big integer implementation for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1857740 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 19:04:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159
--- Comment #2 from Robert-André Mauchin ---
Backtrace
export_key_pair_test stdout
thread 'export_key_pair_test' panicked at 'called `Result::unwrap()` on an
`Err` value: StorageFailure', tests/mod.rs:155:22
stack backtrace:
0: 0x559ebc0118a5 -
::fmt::h83fd459720a1b780
1: 0x559ebc0358dc - core::fmt::write::h0fb2c8a7c74dc706
2: 0x559ebbf8c0a5 - std::io::Write::write_fmt::hb203e303045fd2e8
3: 0x559ebc00bcb1 - std::io::impls::>::write_fmt::hbcb41256641e1664
4: 0x559ebc0140d0 -
std::panicking::default_hook::{{closure}}::hbb12a969b90f30ab
5: 0x559ebc013dca - std::panicking::default_hook::hd46a6f05cd95ae1c
6: 0x559ebc014707 -
std::panicking::rust_panic_with_hook::hfaf36f07e96e1a70
7: 0x559ebc01430b - rust_begin_unwind
8: 0x559ebc034281 - core::panicking::panic_fmt::ha79c22c8889dbf6b
9: 0x559ebc0340a3 - core::option::expect_none_failed::he9f78d166510670b
10: 0x559ebbf8a659 - core::result::Result::unwrap::h3e1a442c611a1234
at
/builddir/build/BUILD/rustc-1.45.0-src/src/libcore/result.rs:1005
11: 0x559ebbf8a659 -
mod::test_tools::TestClient::import::h2b975496b53e491a
at tests/mod.rs:155
12: 0x559ebbf8a659 - mod::export_key_pair_test::hc1fe2c966e9ab52a
at tests/mod.rs:124
13: 0x559ebbf8a659 -
mod::export_key_pair_test::{{closure}}::hfebe911071c9ccf8
at tests/mod.rs:82
14: 0x559ebbf8a659 -
core::ops::function::FnOnce::call_once::hb7c8e6f4e27a34b4
at
/builddir/build/BUILD/rustc-1.45.0-src/src/libcore/ops/function.rs:232
15: 0x559ebbfb33b2 -
test::run_test::run_test_inner::{{closure}}::h8ead2fffa18ec440
16: 0x559ebbf8b566 -
std::sys_common::backtrace::__rust_begin_short_backtrace::h0514d4ec185c1c32
17: 0x559ebbf906e5 -
core::ops::function::FnOnce::call_once{{vtable.shim}}::h6d24acaff99ea573
18: 0x559ebc01a9da -
std::sys::unix::thread::Thread::new::thread_start::h4354789cb8f1f413
19: 0x7f601626d53a - start_thread
20: 0x7f601617e283 - __GI___clone
21:0x0 -
failures:
export_key_pair_test
test result: FAILED$<2>. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered
out
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-num-bigint-dig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859118] Review Request: rust-sha3 - SHA-3 (Keccak) hash function
https://bugzilla.redhat.com/show_bug.cgi?id=1859118 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sha3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857748] Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1857748 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-psa-crypto-sys -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1858603 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-simple_asn1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rsa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment #1 from Robert-André Mauchin --- I've got one test failure: Running `/builddir/build/BUILD/psa-crypto-0.3.0/target/release/deps/mod-bf0093524e460258` running 3 tests test export_key_pair_test ... ok test import_integration_test ... FAILED test generate_integration_test ... ok failures: import_integration_test stdout thread 'import_integration_test' panicked at 'called `Result::unwrap()` on an `Err` value: StorageFailure', tests/mod.rs:155:22 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failures: import_integration_test test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
needinfo denied: [Bug 1281948] Review Request: rack - RackSpace Cloud CLI tool
Product: Fedora Version: rawhide Component: Package Review Steven Soulen has denied Package Review 's request for Steven Soulen 's needinfo: Bug 1281948: Review Request: rack - RackSpace Cloud CLI tool https://bugzilla.redhat.com/show_bug.cgi?id=1281948 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1281948] Review Request: rack - RackSpace Cloud CLI tool
https://bugzilla.redhat.com/show_bug.cgi?id=1281948 Steven Soulen changed: What|Removed |Added Flags|needinfo?(ste...@soulen.net |needinfo- |) | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #7 from Robert-André Mauchin --- Yeah my bad it's optional - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859343] New: Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on
https://bugzilla.redhat.com/show_bug.cgi?id=1859343 Bug ID: 1859343 Summary: Review Request: kernel-srpm-macros - RPM macros that list arches the full kernel is built on Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tdaw...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://tdawson.fedorapeople.org/review/kernel-srpm-macros.spec SRPM URL: https://tdawson.fedorapeople.org/review/kernel-srpm-macros-1.0-1.el8.src.rpm Description: This packages contains the rpm macro that list what arches the full kernel is built on. Fedora Account System Username: tdawson -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 --- Comment #6 from Peter Robinson --- SPEC: https://pbrobinson.fedorapeople.org/rust-num-bigint-dig.spec SRPM: https://pbrobinson.fedorapeople.org/rust-num-bigint-dig-0.6.0-3.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 --- Comment #5 from Peter Robinson --- koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=47578760 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 --- Comment #4 from Peter Robinson --- > DEBUG util.py:621: Problem 2: package > rust-num-bigint-dig+nightly-devel-0.6.0-2.fc33.noarch requires > (crate(rand/nightly) >= 0.7.0 with crate(rand/nightly) < 0.8.0), but none of > the providers can be installed > DEBUG util.py:621:- package rust-rand+nightly-devel-0.7.3-2.fc33.noarch > requires crate(rand/simd_support) = 0.7.3, but none of the providers can be > installed > DEBUG util.py:621:- conflicting requests > DEBUG util.py:621:- nothing provides (crate(packed_simd/default) >= > 0.3.0 with crate(packed_simd/default) < 0.4.0) needed by > rust-rand+simd_support-devel-0.7.3-2.fc33.noarch > DEBUG util.py:621:- nothing provides (crate(packed_simd/into_bits) >= > 0.3.0 with crate(packed_simd/into_bits) < 0.4.0) needed by > rust-rand+simd_support-devel-0.7.3-2.fc33.noarch > > TLDR crate(rand/nightly) needs crate(rand/simd_support) which needs > crate(packed_simd/default) That looks like that rust-rand package is already broken and unrelated to this review? dnf install rust-rand+nightly-devel Last metadata expiration check: 1:05:33 ago on Tue 21 Jul 2020 16:50:49 UTC. Error: Problem: package rust-rand+nightly-devel-0.7.3-2.fc33.noarch requires crate(rand/simd_support) = 0.7.3, but none of the providers can be installed - conflicting requests - nothing provides (crate(packed_simd/default) >= 0.3.0 with crate(packed_simd/default) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch - nothing provides (crate(packed_simd/into_bits) >= 0.3.0 with crate(packed_simd/into_bits) < 0.4.0) needed by rust-rand+simd_support-devel-0.7.3-2.fc33.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857748] Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1857748 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #2 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 17:54:24 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Bug 1857740 depends on bug 1858486, which changed state. Bug 1858486 Summary: Review Request: rust-zeroize - Securely clear secrets from memory https://bugzilla.redhat.com/show_bug.cgi?id=1858486 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Bug 1859159 depends on bug 1858486, which changed state. Bug 1858486 Summary: Review Request: rust-zeroize - Securely clear secrets from memory https://bugzilla.redhat.com/show_bug.cgi?id=1858486 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug 1859151 depends on bug 1858486, which changed state. Bug 1858486 Summary: Review Request: rust-zeroize - Securely clear secrets from memory https://bugzilla.redhat.com/show_bug.cgi?id=1858486 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857059] Review Request: bleachbit - Remove sensitive data and free up disk space
https://bugzilla.redhat.com/show_bug.cgi?id=1857059 Andrew Toskin changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 17:50:44 --- Comment #5 from Andrew Toskin --- Okay, the package repo has been reopened on Pagure. https://pagure.io/releng/issue/9604 BleachBit is building in Koji now. https://koji.fedoraproject.org/koji/packageinfo?packageID=8886 And it should appear in Bodhi soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #34 from Simone Caronni --- I'll be away from the 25th of July for holidays until the 17th of August. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #33 from Simone Caronni --- (In reply to Björn Persson from comment #32) > Thank you for adding the signature verification, but you're still using HTTP > instead of HTTPS in URL and Source20 for no reason I can see. Just forgot it to change it in %url which get expanded in the Source20 line. Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-5.fc32.src.rpm More cleanups: * Tue Jul 21 2020 Simone Caronni - 0.20.0-5 - Use HTTPS for url tag. - Reorganize sources. Add cleaned files from the packaging repository directly; bash completion snippets are now supported in the main sources. - Move check section after install and include desktop file validating in there. Room for improvements: - Check hardening measures for the systemd unit (differences between the various distributions). Ex.: https://github.com/bitcoin/bitcoin/blob/master/contrib/init/bitcoind.service#L53-L74 - Rework SELinux policy - Check about bundling libdb4 (deprecated everywhere in Fedora, not available in EPEL), upstream accepts any libdb versions for building but wallets are not compatible across different libdb versions and need to be converted. Debian builds with the latest libdb: https://salsa.debian.org/cryptocoin-team/bitcoin/-/blob/master/debian/rules#L31 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1858603 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858770] Re-Review Request: rust-copydeps - find and copy a program's dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1858770
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
- Please install the license with %license in %files:
%files -n %{crate}
%license LICENCE.txt
%doc README.md
%{_bindir}/%{crate}
%{_mandir}/man1/%{crate}.1*
%{_datadir}/bash-completion/completions/%{crate}
- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
Package approved. Please install the license before import.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859118] Review Request: rust-sha3 - SHA-3 (Keccak) hash function
https://bugzilla.redhat.com/show_bug.cgi?id=1859118 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858971] Review Request: nicotine+ - A graphical client for Soulseek
https://bugzilla.redhat.com/show_bug.cgi?id=1858971
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #1 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v3 or later)", "GNU General
Public License (v3 or later)", "*No copyright* Public domain", "*No
copyright* GPL (v3)", "Expat License", "*No copyright* Creative
Commons CC0 Universal 1.0 Public Domain Dedication". 445 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/nicotine+/review-nicotine+/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug 1859151 depends on bug 1858604, which changed state. Bug 1858604 Summary: Review Request: rust-zeroize_derive - Custom derive support for zeroize https://bugzilla.redhat.com/show_bug.cgi?id=1858604 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Bug 1859159 depends on bug 1858604, which changed state. Bug 1858604 Summary: Review Request: rust-zeroize_derive - Custom derive support for zeroize https://bugzilla.redhat.com/show_bug.cgi?id=1858604 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Bug 1858486 depends on bug 1858604, which changed state. Bug 1858604 Summary: Review Request: rust-zeroize_derive - Custom derive support for zeroize https://bugzilla.redhat.com/show_bug.cgi?id=1858604 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize
https://bugzilla.redhat.com/show_bug.cgi?id=1858604 Peter Robinson changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-21 17:05:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zeroize -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize
https://bugzilla.redhat.com/show_bug.cgi?id=1858604 --- Comment #2 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zeroize_derive -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize
https://bugzilla.redhat.com/show_bug.cgi?id=1858604 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST CC||zebo...@gmail.com Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #1 from Robert-André Mauchin --- - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #8 from Robert-André Mauchin --- It's a rpmlint warning: explicit-lib-dependency, not mandatory, just a recommendation. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858781] Review Request: maven-mapping - Apache Maven Mapping
https://bugzilla.redhat.com/show_bug.cgi?id=1858781 Hirotaka Wakabayashi changed: What|Removed |Added Status|NEW |ASSIGNED CC||hiw...@yahoo.com Assignee|nob...@fedoraproject.org|hiw...@yahoo.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859207] Review Request: sane-airscan - SANE backend for eSCL and WSD protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1859207
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from Artur Iwicki ---
>Source:
>https://github.com/alexpevzner/%{name}/archive/%{version}.tar.gz
1. You can use %{URL} here to make the line shorter.
2. GitHub allows you to do "archive/%{version}/%{name}-%{version}.tar.gz" - you
can get a file containing the repo name, not just the version.
>%autosetup -n %{name}-%{version} -S git
The "-S git" part is not needed. Package builds fine without it and the
resulting executables/libraries are the same.
>%make_build CFLAGS="%{optflags}" CPPFLAGS="%{optflags}"
>LDFLAGS="%{build_ldflags}"
You can call the %set_build_flags macro before %make_build, that should setup
up CFLAGS/LDFLAGS.
>%{_mandir}/man1/airscan-discover.1.gz
>%{_mandir}/man5/sane-airscan.5.gz
Do not assume that man pages will be gzipped. Use a wildcard that can match any
compression method (including no compression at all).
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #7 from cli...@gmail.com --- So requires are unnecessary because they will dynamically added by rpm. I still don't think this should be an error. There is rarely anything wrong with being explicit instead of implicit (in programming circles). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #6 from Robert-André Mauchin --- (In reply to clime7 from comment #5) > - These should be autodetected: > > rpm-git-tag-sort.x86_64: E: explicit-lib-dependency libgit2 > rpm-git-tag-sort.x86_64: E: explicit-lib-dependency rpm-libs > > You mean I shouldn't put them into spec file as build requires? I think it > is not bad to be a little bit more explicit than necessary though... I don't think this is necessary, if correctly linked, the app will require the library with the correct soname it has been compiled with. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859207] New: Review Request: sane-airscan - SANE backend for eSCL and WSD protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1859207 Bug ID: 1859207 Summary: Review Request: sane-airscan - SANE backend for eSCL and WSD protocols Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: zdoh...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://zdohnal.fedorapeople.org/sane-airscan/sane-airscan.spec SRPM URL: https://zdohnal.fedorapeople.org/sane-airscan/sane-airscan-0.99.10-1.fc32.src.rpm Description: This package contains a tool for discovering scanning devices in cases when automatic discovery fails - airscan-discover - and a SANE backend for MFP and document scanners that implements either eSCL (AirScan/AirPrint scanning) or WSD "driverless" scanning protocol. Fedora Account System Username: zdohnal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858998] Review Request: eclipse-cdt - Eclipse C/C++ Development Tools (CDT) plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1858998
Alexander Kurtakov changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|akurt...@redhat.com
Flags||fedora-review+
--- Comment #3 from Alexander Kurtakov ---
Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
= SHOULD items =
Generic:
[x]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/snapshot/org.eclipse.cdt-
CDT_9_11_1.tar.xz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1350884 --- Comment #25 from Brandon Nielsen --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/nielsenb/msp430-development-tools/fedora-rawhide-x86_64/01565363-msp430-elf-toolchain/msp430-elf-toolchain.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/nielsenb/msp430-development-tools/srpm-builds/01565363/msp430-elf-toolchain-9.2.0.0-2.fc32.src.rpm This hopefully addresses the issues from comment 21, as well as changing to specifying --prefix=/usr/msp430-elf as discussed in comment 23 and comment 24. The more I think about it, the more that's absolutely the right way to do it. The only oddity is a lot of the actual headers and libraries for the target end of in /usr/msp430-elf/msp430-elf, which isn't an issue, just a little ugly. For some reason it fails to build for Fedora 32 on aarch64[0], but I was able to do the same build with mock locally, so I'm going to assume it was an issue on the copr end. 0 - https://copr.fedorainfracloud.org/coprs/nielsenb/msp430-development-tools/build/1565812/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Peter Robinson changed: What|Removed |Added Blocks||1859159 (rust-psa-crypto) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859159 [Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Peter Robinson changed: What|Removed |Added Blocks||1269538 (IoT) Depends On||1857748 ||(rust-psa-crypto-sys), ||1859151 (rust-rsa), 1858486 ||(rust-zeroize), 1858604 ||(rust-zeroize_derive) Alias||rust-psa-crypto Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1857748 [Bug 1857748] Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API https://bugzilla.redhat.com/show_bug.cgi?id=1858486 [Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory https://bugzilla.redhat.com/show_bug.cgi?id=1858604 [Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize
https://bugzilla.redhat.com/show_bug.cgi?id=1858604 Peter Robinson changed: What|Removed |Added Blocks||1859159 (rust-psa-crypto) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859159 [Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857748] Review Request: rust-psa-crypto-sys - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1857748 Peter Robinson changed: What|Removed |Added Blocks||1859159 (rust-psa-crypto) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859159 [Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859159] New: Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API
https://bugzilla.redhat.com/show_bug.cgi?id=1859159 Bug ID: 1859159 Summary: Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pbrobin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC: https://pbrobinson.fedorapeople.org/rust-psa-crypto.spec SRPM: https://pbrobinson.fedorapeople.org/rust-psa-crypto-0.3.0-1.fc32.src.rpm Description: Wrapper around the PSA Cryptography API FAS: pbrobinson -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Peter Robinson changed: What|Removed |Added Blocks||1859159 (rust-psa-crypto) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859159 [Bug 1859159] Review Request: rust-psa-crypto - Wrapper around the PSA Cryptography API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859118] Review Request: rust-sha3 - SHA-3 (Keccak) hash function
https://bugzilla.redhat.com/show_bug.cgi?id=1859118 Peter Robinson changed: What|Removed |Added Blocks||1859151 (rust-rsa) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 Peter Robinson changed: What|Removed |Added Blocks||1859151 (rust-rsa) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Peter Robinson changed: What|Removed |Added Blocks||1269538 (IoT) Depends On||1857740 ||(rust-num-bigint-dig), ||1859118 (rust-sha3), ||1858603 (rust-simple_asn1), ||1858486 (rust-zeroize), ||1858604 ||(rust-zeroize_derive) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1857740 [Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust https://bugzilla.redhat.com/show_bug.cgi?id=1858486 [Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory https://bugzilla.redhat.com/show_bug.cgi?id=1858603 [Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library https://bugzilla.redhat.com/show_bug.cgi?id=1858604 [Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize https://bugzilla.redhat.com/show_bug.cgi?id=1859118 [Bug 1859118] Review Request: rust-sha3 - SHA-3 (Keccak) hash function -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1858603 Peter Robinson changed: What|Removed |Added Blocks||1859151 (rust-rsa) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1857740] Review Request: rust-num-bigint-dig - Big integer implementation for Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1857740 Peter Robinson changed: What|Removed |Added Blocks||1859151 (rust-rsa) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858604] Review Request: rust-zeroize_derive - Custom derive support for zeroize
https://bugzilla.redhat.com/show_bug.cgi?id=1858604 Peter Robinson changed: What|Removed |Added Blocks||1859151 (rust-rsa) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1859151 [Bug 1859151] Review Request: rust-rsa - Pure Rust RSA implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1859151] New: Review Request: rust-rsa - Pure Rust RSA implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1859151 Bug ID: 1859151 Summary: Review Request: rust-rsa - Pure Rust RSA implementation Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pbrobin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC: https://pbrobinson.fedorapeople.org/rust-rsa.spec SRPM: https://pbrobinson.fedorapeople.org/rust-rsa-0.3.0-1.fc32.src.rpm Description: Pure Rust RSA implementation FAS: pbrobinson -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858603] Review Request: rust-simple_asn1 - Simple DER/ASN.1 encoding/decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1858603 --- Comment #5 from Peter Robinson --- > and refer to an upstream PR including that change: I will do upstream PRs when I get time, I have details logged, I don't have the time to do them ATM with other deadlines. > - You must include the LICENSE file and should include the README.md: I've added the README but IMO it doesn't actually provide anything useful to a consumer of the package. SPEC: https://pbrobinson.fedorapeople.org/rust-simple_asn1.spec SRPM: https://pbrobinson.fedorapeople.org/rust-simple_asn1-0.4.1-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1858486] Review Request: rust-zeroize - Securely clear secrets from memory
https://bugzilla.redhat.com/show_bug.cgi?id=1858486 --- Comment #2 from Peter Robinson --- Updated SPEC: https://pbrobinson.fedorapeople.org/rust-zeroize.spec SRPM: https://pbrobinson.fedorapeople.org/rust-zeroize-1.1.0-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1575255] Review Request: gibo - gitignore boilerplate
https://bugzilla.redhat.com/show_bug.cgi?id=1575255 Sascha Peilicke changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Flags|needinfo?(sascha@peilicke.d | |e) | Last Closed||2020-07-21 09:54:51 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
