[Bug 1867561] Review Request: perl-MaxMind-DB-Common - Code shared by the MaxMind database reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1867561

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-MaxMind-DB-Common-0.04
   ||0001-1.fc34
 Resolution|--- |RAWHIDE
Last Closed||2020-08-24 05:48:47



--- Comment #4 from Petr Pisar  ---
Thank you for the review and the repository.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1867617] Review Request: perl-MaxMind-DB-Reader - Read MaxMind database files and look up IP addresses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1867617
Bug 1867617 depends on bug 1867561, which changed state.

Bug 1867561 Summary: Review Request: perl-MaxMind-DB-Common - Code shared by 
the MaxMind database reader and writer
https://bugzilla.redhat.com/show_bug.cgi?id=1867561

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1867967] Review Request: perl-MaxMind-DB-Reader-XS - Fast XS implementation of MaxMind DB reader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1867967
Bug 1867967 depends on bug 1867561, which changed state.

Bug 1867561 Summary: Review Request: perl-MaxMind-DB-Common - Code shared by 
the MaxMind database reader and writer
https://bugzilla.redhat.com/show_bug.cgi?id=1867561

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1867999] Review Request: perl-GeoIP2 - Perl API for MaxMind's GeoIP2 web services and databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1867999

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871648] Review Request: ghc-text-manipulate - Case conversion, word boundary manipulation, and textual subjugation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871648

Jens Petersen  changed:

   What|Removed |Added

 Blocks||1871697





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1871697
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to
terminate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871644] Review Request: ghc-pretty-simple - Pretty printer for data types with a 'Show' instance

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871644

Jens Petersen  changed:

   What|Removed |Added

 Blocks||1871697





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1871697
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to
terminate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871697] Review Request: dhall - A configuration language guaranteed to terminate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871697

Jens Petersen  changed:

   What|Removed |Added

 Depends On||1871452, 1871643, 1871644,
   ||1871648





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1871452
[Bug 1871452] Review Request: ghc-atomic-write - Atomically write to a file
https://bugzilla.redhat.com/show_bug.cgi?id=1871643
[Bug 1871643] Review Request: ghc-data-fix - Fixpoint data types
https://bugzilla.redhat.com/show_bug.cgi?id=1871644
[Bug 1871644] Review Request: ghc-pretty-simple - Pretty printer for data types
with a 'Show' instance
https://bugzilla.redhat.com/show_bug.cgi?id=1871648
[Bug 1871648] Review Request: ghc-text-manipulate - Case conversion, word
boundary manipulation, and textual subjugation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871452] Review Request: ghc-atomic-write - Atomically write to a file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871452

Jens Petersen  changed:

   What|Removed |Added

 Blocks||1871697





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1871697
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to
terminate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871643] Review Request: ghc-data-fix - Fixpoint data types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871643

Jens Petersen  changed:

   What|Removed |Added

 Blocks||1871697





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1871697
[Bug 1871697] Review Request: dhall - A configuration language guaranteed to
terminate
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871697] New: Review Request: dhall - A configuration language guaranteed to terminate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871697

Bug ID: 1871697
   Summary: Review Request: dhall - A configuration language
guaranteed to terminate
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL: https://petersen.fedorapeople.org/reviews/dhall/dhall.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/dhall/dhall-1.32.0-1.fc33.src.rpm

Description:
Dhall is an explicitly typed configuration language that is not Turing
complete. Despite being Turing incomplete, Dhall is a real programming language
with a type-checker and evaluator.

Use this library to parse, type-check, evaluate, and pretty-print the Dhall
configuration language. This package also includes an executable which
type-checks a Dhall file and reduces the file to a fully evaluated normal form.

Read "Dhall.Tutorial" to learn how to use this library.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1869433] Review Request: php-opis-closure - A library that can be used to serialize closures and arbitrary objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1869433



--- Comment #10 from Fedora Update System  ---
FEDORA-2020-644d4cf4e7 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing
--advisory=FEDORA-2020-644d4cf4e7`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-644d4cf4e7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1869433] Review Request: php-opis-closure - A library that can be used to serialize closures and arbitrary objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1869433

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
FEDORA-EPEL-2020-b006932aa7 has been pushed to the Fedora EPEL 7 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-b006932aa7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883



--- Comment #5 from Fedora Update System  ---
FEDORA-2020-692c8128b3 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870882] Review Request: python-tubes - Flow control and backpressure for event-driven applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870882



--- Comment #6 from Fedora Update System  ---
FEDORA-2020-692c8128b3 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870571] Review Request: python-zstd - Zstd Bindings for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870571



--- Comment #4 from Fedora Update System  ---
FEDORA-2020-7597c40a16 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-08-24 01:06:17



--- Comment #4 from Fedora Update System  ---
FEDORA-2020-63342e187d has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883
Bug 1870883 depends on bug 1870882, which changed state.

Bug 1870882 Summary: Review Request: python-tubes - Flow control and 
backpressure for event-driven applications
https://bugzilla.redhat.com/show_bug.cgi?id=1870882

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870882] Review Request: python-tubes - Flow control and backpressure for event-driven applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870882

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-08-24 01:06:15



--- Comment #5 from Fedora Update System  ---
FEDORA-2020-63342e187d has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1851205



--- Comment #27 from Fedora Update System  ---
FEDORA-2020-0796d826d6 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870571] Review Request: python-zstd - Zstd Bindings for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870571

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-08-24 01:06:10



--- Comment #3 from Fedora Update System  ---
FEDORA-2020-e9eaa58f7e has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853



--- Comment #4 from Qiyu Yan  ---
added 
- Requires:   kf5-kcmutils


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01614376-fcitx5-configtool/fcitx5-configtool.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01614376-fcitx5-configtool/fcitx5-configtool-0-0.2.gitecd16e5.fc34.src.rpm
Description: Configuration tools used by fcitx5.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850



--- Comment #3 from Qiyu Yan  ---
- removed ExcludeArch
- switched to pkgconfig(curl) 
- added -data subpackage
- more specific on /usr/share/*


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01627140-fcitx5-chinese-addons/fcitx5-chinese-addons.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01627140-fcitx5-chinese-addons/fcitx5-chinese-addons-0-0.2.20200812gitef9beb7.fc33.src.rpm
Description: Chinese related addon for fcitx5
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1851205] Review Request: AusweisApp2 - Online identification with German ID card (Personalausweis)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1851205



--- Comment #26 from Fedora Update System  ---
FEDORA-EPEL-2020-0c4a8e2bde has been pushed to the Fedora EPEL 8 stable
repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850
Bug 1868850 depends on bug 1868849, which changed state.

Bug 1868849 Summary: Review Request: libime - This is a library to support 
generic input method implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1868849

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849

Qiyu Yan  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-24 00:28:23



--- Comment #17 from Qiyu Yan  ---
built in rawhide (with i386/i686 target)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861

Qiyu Yan  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-24 00:16:17




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #16 from Qiyu Yan  ---
Last night (night, here), upstream have published a fix, I confirmed that it
will build on i686 just now[1]

I will build the new version without ExcludeArch tag, and update the
fcitx5-chinese-addons then

[1]: https://koji.fedoraproject.org/koji/taskinfo?taskID=50003629


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861



--- Comment #4 from Qiyu Yan  ---
Built in rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Qiyu Yan  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-24 00:05:30



--- Comment #7 from Qiyu Yan  ---
Built in rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868854

Qiyu Yan  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-23 23:47:41



--- Comment #7 from Qiyu Yan  ---
Built in rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850
Bug 1868850 depends on bug 1868854, which changed state.

Bug 1868854 Summary: Review Request: fcitx5-lua - Lua support for fcitx.
https://bugzilla.redhat.com/show_bug.cgi?id=1868854

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822142



--- Comment #5 from Elliott Sales de Andrade  ---
Also, you have %files for the (no-suffix) main package, but it's empty and
doesn't have any additional Requires. I don't think it's necessary to produce
that main package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1822142] Review Request: golang-github-chromedp - Drive browsers supporting the Chrome DevTools Protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1822142



--- Comment #4 from Elliott Sales de Andrade  ---
This should have a runtime dependency on `chromium`, or you can't run tests in
dependent packages without specifying it also. Or if you want to allow real
chrome for people in RPMfusion, then a Recommends instead.

%global godevelheader %{expand:
Requires:   chromium}


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868991

Fabio Valentini  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||jakarta-el-4.0.0-1.fc33
 Resolution|--- |NEXTRELEASE
Last Closed||2020-08-23 20:10:39



--- Comment #13 from Fabio Valentini  ---
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1598848
And for fedora 33:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1598850


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868992] Review Request: jakarta-server-pages - Jakarta Server Pages (JSP)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868992
Bug 1868992 depends on bug 1868991, which changed state.

Bug 1868991 Summary: Review Request: jakarta-el - Jakarta Expression Language
https://bugzilla.redhat.com/show_bug.cgi?id=1868991

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871648] New: Review Request: ghc-text-manipulate - Case conversion, word boundary manipulation, and textual subjugation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871648

Bug ID: 1871648
   Summary: Review Request: ghc-text-manipulate - Case conversion,
word boundary manipulation, and textual subjugation
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://petersen.fedorapeople.org/reviews/ghc-text-manipulate/ghc-text-manipulate.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/ghc-text-manipulate/ghc-text-manipulate-0.2.0.1-1.fc33.src.rpm

Description:
Manipulate identifiers and structurally non-complex pieces of text by
delimiting word boundaries via a combination of whitespace, control-characters,
and case-sensitivity.

Has support for common idioms like casing of programmatic variable names,
taking, dropping, and splitting by word, and modifying the first character of a
piece of text.

/Caution:/ this library makes heavy use of the
 library's internal loop
optimisation framework. Since internal modules are not guaranteed to have a
stable API there is potential for build breakage when the text dependency is
upgraded. Consider yourself warned!.


Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49984490


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871644] New: Review Request: ghc-pretty-simple - Pretty printer for data types with a 'Show' instance

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871644

Bug ID: 1871644
   Summary: Review Request: ghc-pretty-simple - Pretty printer for
data types with a 'Show' instance
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://petersen.fedorapeople.org/reviews/ghc-pretty-simple/ghc-pretty-simple.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/ghc-pretty-simple/ghc-pretty-simple-3.2.3.0-1.fc33.src.rpm

Description:
Please see .


Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49983161


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871345] Review Request: jakarta-saaj - SOAP with Attachments API for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871345



--- Comment #3 from Fabio Valentini  ---
(In reply to Jerry James from comment #2)
> The issues are not blocking issues, so this package is APPROVED.

Awesome, thanks for the fast review!

> Issues:
> ===
> - Version 2.0.0 is the latest version
> 
> - The missing test classes are in https://github.com/eclipse-ee4j/metro-saaj
>   with different package names (but maybe I'm looking at mismatched
> versions).

This is why I noted this in the bug description:

> Note 2: For the initial package, version 1.4.2 is targeted while 2.0.0 has 
> been released upstream, because 2.0.0 requires a version of 
> jakarta-activation that has not been released yet (2.0.0).

So I'm going to update the involved packages once all dependencies are there.

>   Would it be worth leaving a note in this spec file that the tests can be
>   enabled if we get metro-saaj packaged for Fedora?

That's good detective work! I'll add a comment that an "saaj-impl" provider is
missing for the tests.

Thanks!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871345] Review Request: jakarta-saaj - SOAP with Attachments API for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871345

Jerry James  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Jerry James  ---
The issues are not blocking issues, so this package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
- Version 2.0.0 is the latest version

- The missing test classes are in https://github.com/eclipse-ee4j/metro-saaj
  with different package names (but maybe I'm looking at mismatched versions).
  Would it be worth leaving a note in this spec file that the tests can be
  enabled if we get metro-saaj packaged for Fedora?

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.

 The specification is under a different license, but we do not appear to
 include it in the binary rpm.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
 publishes signatures.
 Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section 

[Bug 1871643] New: Review Request: ghc-data-fix - Fixpoint data types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871643

Bug ID: 1871643
   Summary: Review Request: ghc-data-fix - Fixpoint data types
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://petersen.fedorapeople.org/reviews/ghc-data-fix/ghc-data-fix.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/ghc-data-fix/ghc-data-fix-0.2.1-1.fc33.src.rpm

Description:
Fixpoint types and recursion schemes. If you define your AST as fixpoint type,
you get fold and unfold operations for free.

Thanks for contribution to: Matej Kollar, Herbert Valerio Riedel.


Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49982291


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871452] New: Review Request: ghc-atomic-write - Atomically write to a file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871452

Bug ID: 1871452
   Summary: Review Request: ghc-atomic-write - Atomically write to
a file
   Product: Fedora
   Version: rawhide
Status: NEW
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://petersen.fedorapeople.org/reviews/ghc-atomic-write/ghc-atomic-write.spec
SRPM URL:
https://petersen.fedorapeople.org/reviews/ghc-atomic-write/ghc-atomic-write-0.2.0.7-1.fc33.src.rpm

Description:
Atomically write to a file on POSIX-compliant systems while preserving
permissions.

On most Unix systems, `mv` is an atomic operation. This makes it simple to
write to a file atomically just by using the mv operation. However, this will
destroy the permissions on the original file. This library does the following
to preserve permissions while atomically writing to a file:

* If an original file exists, take those permissions and apply them to the temp
file before `mv`ing the file into place.

* If the original file does not exist, create a following with default
permissions (based on the currently-active umask).

This way, when the file is `mv`'ed into place, the permissions will be the ones
held by the original file.

This library is based on similar implementations found in common libraries in
Ruby and Python:

* 

*


* 

To use `atomic-write`, import the module corresponding to the type you wish to
write atomically, e.g., to write a (strict) ByteString atomically:

> import System.AtomicWrite.Writer.ByteString

Then you can use the atomicWriteFile function that accepts a `FilePath` and a
`ByteString`, e.g.:

> atomicWriteFile myFilePath myByteString.


Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49980469


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871345] Review Request: jakarta-saaj - SOAP with Attachments API for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871345

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
I will take this review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850

Andy Mender  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850

Andy Mender  changed:

   What|Removed |Added

 CC||andymenderu...@gmail.com



--- Comment #2 from Andy Mender  ---
COPR build:
https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1627154/

> BuildRequires:  boost-devel
> BuildRequires:  cmake
> BuildRequires:  curl-devel

Minor thing: curl provides a pkgconfig file so it's okay to use
"pkgconfig(curl)"

> %{_libdir}/fcitx5/qt5/libpinyindictmanager.so
> %{_datadir}/fcitx5/*
> %{_datadir}/icons/hicolor/*/apps/*

> %files devel
> %{_includedir}/Fcitx5/Module/fcitx-module/*
> %{_libdir}/cmake/Fcitx5Module*

I'm a little on the fence with some of the above wildcards, though the files
are clearly split across multiple dirs (like the
%{_datadir}/fcitx5/{addon,inputmethod,lua,...} dirs) so one would have to list
them individually otherwise.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 Review: For internal use only. Ignore warning.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
 Review: Tested in COPR.
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* GNU Lesser General
 Public License", "GNU Lesser General Public License". 163 files have
 unknown license. Detailed output of licensecheck in
 /home/amender/rpmbuild/SPECS/fcitx5-chinese-addons/fcitx5-chinese-
 addons/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/fcitx5/qt5, /usr/lib64/fcitx5,
 /usr/include/Fcitx5, /usr/include/Fcitx5/Module,
 /usr/include/Fcitx5/Module/fcitx-module, /usr/share/fcitx5
 Review: Above dirs are provided by dependencies.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/include/Fcitx5/Module/fcitx-module, /usr/lib64/fcitx5/qt5,
 /usr/share/fcitx5, /usr/include/Fcitx5, /usr/lib64/fcitx5,
 /usr/include/Fcitx5/Module
 Review: as above.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
 Review: Ignore bogus rpmlint warnings.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #15 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/libime


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861



--- Comment #3 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/fcitx5-chewing


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857



--- Comment #6 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/fcitx5-skk


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868854



--- Comment #6 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/fcitx5-lua


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853



--- Comment #3 from Qiyu Yan  ---
And for the /usr/lib64/qt5/plugins/kcms, it might here (UTC+8), I will fix
tommorow.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853



--- Comment #2 from Qiyu Yan  ---
(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49972115
> COPR build:
> https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1627144/
> 
> > BuildRequires:  fcitx5-qt-devel
> > BuildRequires:  gettext-devel
> > BuildRequires:  kf5-kwidgetsaddons-devel
> > BuildRequires:  kf5-kirigami2-devel
> > BuildRequires:  kf5-kdeclarative-devel
> > BuildRequires:  kf5-kpackage-devel
> > BuildRequires:  kf5-ki18n-devel
> > BuildRequires:  kf5-kcoreaddons-devel
> > BuildRequires:  kf5-kitemviews-devel
> 
> Can any of these be converted to the pkgconfig(foo) format as well?

they doesn't provide pkgconfig(foo) but have 
cmake(foo), while cmake(foo) was introduced recently, some package didn't build
with that. On f33+, mostly yes, on f32 some don't have tags like this.

> 
> > %files -f %{name}.lang -f %{translation_domain}.lang 
> > %license LICENSES/GPL-2.0-or-later.txt
> > %doc README
> 
> I checked the README and it's empty. Upstream never added anything to it:
> https://github.com/fcitx/fcitx5-configtool/blob/master/README
> Not sure whether it's worth adding an empty README file to the package
> itself...

Just in case upstream add content to readme, I won't forget to include that.

> 
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
> 
> 
> = MUST items =
> 
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
>  Note: Unversioned so-files in private %_libdir subdirectory (see
>  attachment). Verify they are not in ld path.
>  Review: Internal use only. Should be okay.
> [x]: If your application is a C or C++ application you must list a
>  BuildRequires against gcc, gcc-c++ or clang.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [x]: Package successfully compiles and builds into binary rpms on at least
>  one supported primary architecture.
>  Note: Using prebuilt packages
>  Review: Works in COPR and Koji.
> [x]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> [x]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "Unknown or generated", "GNU Lesser General Public License".
>  124 files have unknown license. Detailed output of licensecheck in
> 
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool/
> licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms
>  Review: Missing Requires? A quick repo check shows that the dir is used
> by:
>  kwin-common
>  kf5-kcmutils
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Development files must be in a -devel package
> [?]: Package uses nothing in %doc for runtime.
> [x]: The spec file handles locales properly.
> [x]: Package consistently uses macros (instead of hard-coded directory
>  names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc subpackage. Large could be size
>  (~1MB) or number of files.
>  Note: Documentation size is 10240 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Rpmlint is run on all rpms the build produces.
>  Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>  license(s) in its own file, then that file, containing the text of the
>  license(s) for the 

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853



--- Comment #1 from Andy Mender  ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49972115
COPR build:
https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1627144/

> BuildRequires:  fcitx5-qt-devel
> BuildRequires:  gettext-devel
> BuildRequires:  kf5-kwidgetsaddons-devel
> BuildRequires:  kf5-kirigami2-devel
> BuildRequires:  kf5-kdeclarative-devel
> BuildRequires:  kf5-kpackage-devel
> BuildRequires:  kf5-ki18n-devel
> BuildRequires:  kf5-kcoreaddons-devel
> BuildRequires:  kf5-kitemviews-devel

Can any of these be converted to the pkgconfig(foo) format as well?

> %files -f %{name}.lang -f %{translation_domain}.lang 
> %license LICENSES/GPL-2.0-or-later.txt
> %doc README

I checked the README and it's empty. Upstream never added anything to it:
https://github.com/fcitx/fcitx5-configtool/blob/master/README
Not sure whether it's worth adding an empty README file to the package
itself...

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 Review: Internal use only. Should be okay.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
 Review: Works in COPR and Koji.
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GNU Lesser General Public License".
 124 files have unknown license. Detailed output of licensecheck in

/home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms
 Review: Missing Requires? A quick repo check shows that the dir is used
by:
 kwin-common
 kf5-kcmutils
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
  

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|POST




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849

Andy Mender  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Andy Mender  ---
Approved!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626586-fcitx5-chinese-addons/fcitx5-chinese-addons.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626586-fcitx5-chinese-addons/fcitx5-chinese-addons-0-0.2.20200812gitef9beb7.fc33.src.rpm
Description: Chinese related addon for fcitx5
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850

Qiyu Yan  changed:

   What|Removed |Added

   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Qiyu Yan  ---
Added 
ExcludeArch:   i686

After approval and repo created I will follow:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures
to fill architecture_build_failures bug


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #13 from Qiyu Yan  ---
Added 
ExcludeArch:   i686

After approval and repo created I will follow:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures
to fill architecture_build_failures bug


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01618231-libime/libime.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01618231-libime/libime-0-0.2.gita108d15.sgit96d303c.fc34.src.rpm
Description: This is a library to support generic input method implementation
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853

Andy Mender  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||andymenderu...@gmail.com
   Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|POST




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|POST




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868854

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|POST




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #12 from Andy Mender  ---
Sounds good! I'll proceed with the rest of the reviews in the meantime.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #11 from Qiyu Yan  ---
(In reply to Andy Mender from comment #10)
> > If debian developers reports that ignoring the test on i686 doesn't lead to 
> > bugs, I think we can do the same thing. 
> 
> By ignoring, you mean disabling the failing tests? I don't think we can just
> ignore the fact that %test fails on i386/i686 as this will trigger warnings
> in Pagure, right?

my plan is
  - do ExcludeArch anyway (and fill a bug to block F-ExcludeArch-x86), continue
the packaging process and wait for response from upstream developer/debian
developer
- if upstream developer or debian developers say that it is safe to ignore
this error, I will do a change as "%ctest||:" for i686 (may need approval from
Packaging Committee) and wait for bug reports.
- if otherwise, keep the ExcludeArch
> 
> > Without fcitx5-chinese-addons, pinyin will become not easy to use.
> 
> Alright, in this case we should strive to get the libime package in as well.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861

Andy Mender  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Andy Mender  ---
COPR build:
https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626698/
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49969087

Looks good. Package Approved. Review below.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 Review: Internal SO file. Ignore warning.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
 Review: Tested in COPR and Koji.
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GNU Lesser General Public License". 26
 files have unknown license. Detailed output of licensecheck in

/home/amender/rpmbuild/SPECS/fcitx5-chewing/fcitx5-chewing/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/fcitx5/inputmethod,
 /usr/share/fcitx5/addon, /usr/share/fcitx5, /usr/lib64/fcitx5
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/fcitx5,
 /usr/share/fcitx5/inputmethod, /usr/share/fcitx5/addon,
 /usr/lib64/fcitx5
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided 

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Andy Mender  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Andy Mender  ---
Good catch! Approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #10 from Andy Mender  ---
> If debian developers reports that ignoring the test on i686 doesn't lead to 
> bugs, I think we can do the same thing. 

By ignoring, you mean disabling the failing tests? I don't think we can just
ignore the fact that %test fails on i386/i686 as this will trigger warnings in
Pagure, right?

> Without fcitx5-chinese-addons, pinyin will become not easy to use.

Alright, in this case we should strive to get the libime package in as well.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857



--- Comment #4 from Qiyu Yan  ---
(In reply to Andy Mender from comment #3)
> > fixed by adding 
> > %dir %{_datadir}/fcitx5/skk
> 
> This one's clear, but I now noticed that fcitx5-skk places a file in
> %{_libdir}/fcitx5/qt5/, but doesn't call for any of the fcitx5-qt SO libs.
> It needs a Requires line for fcitx5-qt, therefore:
> Requires:   fcitx5-qt

[yan@BOOK-KARUBONIRU yanqi]$ sudo dnf repoquery --requires
fcitx5-skk-0:0-0.2.git02fb41d.fc34.x86_64
上次元数据过期检查：4:36:45 前，执行于 2020年08月23日 星期日 17时54分35秒。
fcitx5
hicolor-icon-theme
libFcitx5Config.so.6()(64bit)
libFcitx5Core.so.6()(64bit)
libFcitx5Qt5WidgetsAddons.so.2()(64bit)
libFcitx5Utils.so.2()(64bit)
libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit)
libQt5Core.so.5(Qt_5.14)(64bit)
libQt5Gui.so.5()(64bit)
libQt5Gui.so.5(Qt_5)(64bit)
libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit)
libc.so.6(GLIBC_2.14)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libskk.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libstdc++.so.6(GLIBCXX_3.4)(64bit)
libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
libstdc++.so.6(GLIBCXX_3.4.20)(64bit)
libstdc++.so.6(GLIBCXX_3.4.21)(64bit)
libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
rtld(GNU_HASH)
skkdic


We have libFcitx5Qt5WidgetsAddons.so.2()(64bit) here.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1829334] Review Request: 3mux - Terminal multiplexer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1829334

dan.cer...@cgc-instruments.com changed:

   What|Removed |Added

 CC||dan.cermak@cgc-instruments.
   ||com
  Flags||needinfo?(mail@fabian-affol
   ||ter.ch)



--- Comment #2 from dan.cer...@cgc-instruments.com ---
(In reply to Robert-André Mauchin  from comment #1)
>  Please bump to 1.0.1.

Note that upstream marked 1.0.1 as a pre-release.

Fabian, do you want to bump the version nevertheless or package 0.3.0?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857



--- Comment #3 from Andy Mender  ---
> fixed by adding 
> %dir %{_datadir}/fcitx5/skk

This one's clear, but I now noticed that fcitx5-skk places a file in
%{_libdir}/fcitx5/qt5/, but doesn't call for any of the fcitx5-qt SO libs. It
needs a Requires line for fcitx5-qt, therefore:
Requires:   fcitx5-qt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #9 from Qiyu Yan  ---
(In reply to Andy Mender from comment #7)
> > Contacting to csslayer (upstream developer) for help, and there is already 
> > an upstream issue about this https://github.com/fcitx/libime/issues/4
> > This may take some time to fix :(`
> 
> Thanks for checking this. I see that the issue was opened on March 13th 2020
> and still no responses other than yours. For the sake of fcitx5's
> completeness, we can set an ExcludeArch for i386 in libime and add a comment
> with the link to the GitHub issue above. However, then we would need a
> similar comment and ExcludeArch in fcitx5-chinese-addons most likely to
> avoid problems with dependency resolution, otherwise fcitx5-chinese-addons
> becomes uninstallable.

If debian developers reports that ignoring the test on i686 doesn't lead to
bugs, I think we can do the same thing. 

Without fcitx5-chinese-addons, pinyin will become not easy to use.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868861] Review Request: fcitx5-chewing - Chewing Wrapper for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868861

Andy Mender  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||andymenderu...@gmail.com
   Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871432] New: Review Request: jakarta-interceptors - Jakarta Interceptors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871432

Bug ID: 1871432
   Summary: Review Request: jakarta-interceptors - Jakarta
Interceptors
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://decathorpe.fedorapeople.org/packages/jakarta-interceptors.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/jakarta-interceptors-2.0.0-1.fc32.src.rpm

Description:
Jakarta Interceptors defines a means of interposing on business method
invocations and specific events—such as lifecycle events and timeout
events—that occur on instances of Jakarta EE components and other
managed classes.

Fedora Account System Username: decathorpe

Note: This is a rename-update-review-request for geronimo-interceptor. Please
verify that Provides, Obsoletes, %mvn_alias and %mvn_file calls are correct.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #8 from Qiyu Yan  ---
(In reply to Andy Mender from comment #7)
> > Contacting to csslayer (upstream developer) for help, and there is already 
> > an upstream issue about this https://github.com/fcitx/libime/issues/4
> > This may take some time to fix :(`
> 
> Thanks for checking this. I see that the issue was opened on March 13th 2020
> and still no responses other than yours. For the sake of fcitx5's
> completeness, we can set an ExcludeArch for i386 in libime and add a comment
> with the link to the GitHub issue above. However, then we would need a
> similar comment and ExcludeArch in fcitx5-chinese-addons most likely to
> avoid problems with dependency resolution, otherwise fcitx5-chinese-addons
> becomes uninstallable.

The debian developers just ignores the error, I am asking them if this don't
lead to problems in fcitx5-chinese-addons.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #7 from Andy Mender  ---
> Contacting to csslayer (upstream developer) for help, and there is already an 
> upstream issue about this https://github.com/fcitx/libime/issues/4
> This may take some time to fix :(`

Thanks for checking this. I see that the issue was opened on March 13th 2020
and still no responses other than yours. For the sake of fcitx5's completeness,
we can set an ExcludeArch for i386 in libime and add a comment with the link to
the GitHub issue above. However, then we would need a similar comment and
ExcludeArch in fcitx5-chinese-addons most likely to avoid problems with
dependency resolution, otherwise fcitx5-chinese-addons becomes uninstallable.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857



--- Comment #2 from Qiyu Yan  ---
(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49963649
> COPR build:
> https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626665/
> 
> > %files -f %{name}.lang
> > %license COPYING
> > %doc README.md 
> > %{_libdir}/fcitx5/qt5/libfcitx5-skk-config.so
> > %{_libdir}/fcitx5/skk.so
> > %{_datadir}/fcitx5/addon/skk.conf
> > %{_datadir}/fcitx5/inputmethod/skk.conf
> > %{_datadir}/fcitx5/skk/dictionary_list
> 
> fedora-review reports that nothing owns %{_datadir}/fcitx5/skk/ (in addition
> to the bogus reports about the remaining dirs). I think it's okay for this
> package to own the entire %{_datadir}/fcitx5/skk/ dir.
> 

fixed by adding 
%dir %{_datadir}/fcitx5/skk


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Qiyu Yan  changed:

   What|Removed |Added

Comment|0   |updated



--- Comment #0 has been edited ---

Spec URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626585-fcitx5-skk/fcitx5-skk.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626585-fcitx5-skk/fcitx5-skk-0-0.2.20200813git02fb41d.fc33.src.rpm
Description: Fcitx5-skk is an SKK (Simple Kana Kanji) engine for Fcitx.  It
provides Japanese input method using libskk.
Fedora Account System Username: yanqiyu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Andy Mender  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857

Andy Mender  changed:

   What|Removed |Added

 CC||andymenderu...@gmail.com
   Doc Type|--- |If docs needed, set a value



--- Comment #1 from Andy Mender  ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49963649
COPR build:
https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626665/

> %files -f %{name}.lang
> %license COPYING
> %doc README.md 
> %{_libdir}/fcitx5/qt5/libfcitx5-skk-config.so
> %{_libdir}/fcitx5/skk.so
> %{_datadir}/fcitx5/addon/skk.conf
> %{_datadir}/fcitx5/inputmethod/skk.conf
> %{_datadir}/fcitx5/skk/dictionary_list

fedora-review reports that nothing owns %{_datadir}/fcitx5/skk/ (in addition to
the bogus reports about the remaining dirs). I think it's okay for this package
to own the entire %{_datadir}/fcitx5/skk/ dir.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
 Review: Ignore warning. Unversioned SO files are for internal use only.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
 Review: Tested in COPR and Koji.
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "GPL (v3 or later)". 37 files have
 unknown license. Detailed output of licensecheck in
 /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/fcitx5, /usr/share/fcitx5/skk,
 /usr/lib64/fcitx5/qt5, /usr/share/fcitx5,
 /usr/share/fcitx5/inputmethod, /usr/share/fcitx5/addon
 Review: Only /usr/share/fcitx5/skk is unowned. The rest belongs
 to fcitx5 subpackages and fcitx5-qt.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/fcitx5/qt5,
 /usr/share/fcitx5, /usr/share/fcitx5/inputmethod, /usr/lib64/fcitx5,
 /usr/share/fcitx5/skk, /usr/share/fcitx5/addon
 Review: as above.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
 Review: Yes, but see comments about owned dirs.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the 

[Bug 1870882] Review Request: python-tubes - Flow control and backpressure for event-driven applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870882



--- Comment #4 from Fedora Update System  ---
FEDORA-2020-63342e187d has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-63342e187d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Fedora Update System  ---
FEDORA-2020-692c8128b3 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-692c8128b3


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883



--- Comment #3 from Fedora Update System  ---
FEDORA-2020-63342e187d has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-63342e187d


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870882] Review Request: python-tubes - Flow control and backpressure for event-driven applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870882

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #3 from Fedora Update System  ---
FEDORA-2020-692c8128b3 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-692c8128b3


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #6 from Qiyu Yan  ---
Contacting to csslayer (upstream developer) for help, and there is already an
upstream issue about this https://github.com/fcitx/libime/issues/4
This may take some time to fix :(`

libime only blocks fcitx5-chinese-addons (not essential but provides some
benefits for chinese typing).

> I don't see these errors in the project's official Jenkins job: 
> https://jenkins.fcitx-im.org/job/libime/lastBuild/console

seems that the upstream only test in x86_64


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870571] Review Request: python-zstd - Zstd Bindings for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870571

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



--- Comment #2 from Fedora Update System  ---
FEDORA-2020-e9eaa58f7e has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-e9eaa58f7e


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868854] Review Request: fcitx5-lua - Lua support for fcitx.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868854

Andy Mender  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Andy Mender  ---
Verified freshly in Koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49962023

Package approved!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870882] Review Request: python-tubes - Flow control and backpressure for event-driven applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870882



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-tubes


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1870883] Review Request: python-klein - Python microframework built on werkzeug + twisted.web

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1870883



--- Comment #1 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-klein


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871426] Review Request: python-zope-i18nmessageid - Message Identifiers for internationalization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871426

Igor Raits  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||igor.ra...@gmail.com
   Assignee|nob...@fedoraproject.org|igor.ra...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review+




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868849] Review Request: libime - This is a library to support generic input method implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868849



--- Comment #5 from Andy Mender  ---
Apologies for the delay with this one!

Triggered a Koji build from your F34 SRPM for this, but 3 tests are failing on
i686: https://koji.fedoraproject.org/koji/taskinfo?taskID=49959204
Same thing happens when using my F32 SRPM:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49960408
It fails in COPR for i386 as well:
https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626656/

Here's the link to the build log with the failing tests:
https://kojipkgs.fedoraproject.org//work/tasks/9276/49959276/build.log

I don't see these errors in the project's official Jenkins job:
https://jenkins.fcitx-im.org/job/libime/lastBuild/console


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868848] Review Request: fcitx5-qt - Qt library and IM module for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868848

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-23 12:23:10



--- Comment #9 from Qiyu Yan  ---
Built in rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868850] Review Request: fcitx5-chinese-addons - Chinese related addon for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868850
Bug 1868850 depends on bug 1868848, which changed state.

Bug 1868848 Summary: Review Request: fcitx5-qt - Qt library and IM module for 
fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1868848

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868857] Review Request: fcitx5-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868857
Bug 1868857 depends on bug 1868848, which changed state.

Bug 1868848 Summary: Review Request: fcitx5-qt - Qt library and IM module for 
fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1868848

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868853] Review Request: fcitx5-configtool - Configuration tools used by fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868853
Bug 1868853 depends on bug 1868848, which changed state.

Bug 1868848 Summary: Review Request: fcitx5-qt - Qt library and IM module for 
fcitx5
https://bugzilla.redhat.com/show_bug.cgi?id=1868848

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868851] Review Request: fcitx5-rime - RIME support for Fcitx

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868851

Qiyu Yan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2020-08-23 12:17:47



--- Comment #5 from Qiyu Yan  ---
Built in rawhide


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1871426] New: Review Request: python-zope-i18nmessageid - Message Identifiers for internationalization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1871426

Bug ID: 1871426
   Summary: Review Request: python-zope-i18nmessageid - Message
Identifiers for internationalization
   Product: Fedora
   Version: rawhide
  Hardware: All
OS: Linux
Status: NEW
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
  Target Milestone: ---
Classification: Fedora



Spec URL:
https://ngompa.fedorapeople.org/for-review/python-zope-i18nmessageid.spec
SRPM URL:
https://ngompa.fedorapeople.org/for-review/python-zope-i18nmessageid-4.0.3-20.fc34.src.rpm
Description: This module provides message identifiers for internationalization.
Fedora Account System Username: ngompa


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868848] Review Request: fcitx5-qt - Qt library and IM module for fcitx5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868848



--- Comment #8 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/fcitx5-qt


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1868991] Review Request: jakarta-el - Jakarta Expression Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1868991



--- Comment #12 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/jakarta-el


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1857584] Review Request: python-serpent - Serialization based on ast.literal_eval

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1857584



--- Comment #2 from Igor Raits  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-serpent


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org