[Bug 1878514] Review Request: catimg - Print images in a terminal with 256 colors support
https://bugzilla.redhat.com/show_bug.cgi?id=1878514 Kees de Jong changed: What|Removed |Added Flags||needinfo?(fed...@svgames.pl ||) --- Comment #8 from Kees de Jong --- (In reply to Artur Frenszek-Iwicki from comment #3) Hi Artur, Could you please finalize your review? If the package looks alright, then please approve it. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888473] Review Request: vim-ansible - Vim plugin for syntax highlighting ansible's common filetypes
https://bugzilla.redhat.com/show_bug.cgi?id=1888473 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com Assignee|nob...@fedoraproject.org|ngomp...@gmail.com Flags||fedora-review+ --- Comment #1 from Neal Gompa --- Review notes: * Package is named appropriately per packaging guidelines * Package builds and installs properly * Licensing is correctly noted and license files are correctly installed PACKAGE APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888473] New: Review Request: vim-ansible - Vim plugin for syntax highlighting ansible's common filetypes
https://bugzilla.redhat.com/show_bug.cgi?id=1888473 Bug ID: 1888473 Summary: Review Request: vim-ansible - Vim plugin for syntax highlighting ansible's common filetypes Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: c...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01698519-vim-ansible/vim-ansible.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01698519-vim-ansible/vim-ansible-3.0-1.fc34.src.rpm Description: This is a vim syntax plugin for Ansible 2.x, it supports YAML playbooks, Jinja2 templates, and Ansible's hosts files. Fedora Account System Username: carlwgeorge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885040] Review Request: python-authheaders - A library wrapping email authentication header verification and generation
https://bugzilla.redhat.com/show_bug.cgi?id=1885040
Carl George 鸞 changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Carl George 鸞 ---
Package approved. Please add the license comment before importing.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
[!]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
Since upstream has a breakdown in their COPYING file, a comment referencing
that will be sufficient. In the comment you should also point out there is
an MPL 2.0 file, but it is not shipped (authheaders/public_suffix_list.txt).
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "zlib/libpng license Zope Public
License 2.1", "*No copyright* Mozilla Public License 2.0",
"zlib/libpng license", "Zope Public License 2.1". 15 files have
unknown license. Detailed output of licensecheck in
/home/carl/packaging/reviews/1885040-python-
authheaders/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
[-]: %check is present and all tests pass.
Upstream has some files
[Bug 1884984] Review Request: python-omnilogic - Integration for the Hayward OmniLogic pool control system
https://bugzilla.redhat.com/show_bug.cgi?id=1884984 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-22b17c498f has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-22b17c498f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888452] Review Request: python-nuheat - Python library for NuHeat Signature radiant floor thermostats
https://bugzilla.redhat.com/show_bug.cgi?id=1888452 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888452] New: Review Request: python-nuheat - Python library for NuHeat Signature radiant floor thermostats
https://bugzilla.redhat.com/show_bug.cgi?id=1888452 Bug ID: 1888452 Summary: Review Request: python-nuheat - Python library for NuHeat Signature radiant floor thermostats Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-nuheat.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-nuheat-0.3.0-1.fc33.src.rpm Project URL: https://github.com/broox/python-nuheat Description: A Python library that allows control of connected NuHeat Signature radiant floor thermostats. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53476550 rpmlint output: $ rpmlint python-nuheat-0.3.0-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*-nuheat* 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887621] Review Request: folly - An open-source C++ library developed and used at Facebook
https://bugzilla.redhat.com/show_bug.cgi?id=1887621 Antonio T. sagitter changed: What|Removed |Added Status|NEW |ASSIGNED CC||trp...@rocketmail.com Assignee|nob...@fedoraproject.org|trp...@rocketmail.com Flags||fedora-review? --- Comment #1 from Antonio T. sagitter --- Hi Michel. Please, take care of SeqAn: https://bugzilla.redhat.com/show_bug.cgi?id=1810293 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885040] Review Request: python-authheaders - A library wrapping email authentication header verification and generation
https://bugzilla.redhat.com/show_bug.cgi?id=1885040 Carl George 鸞 changed: What|Removed |Added CC||c...@redhat.com Assignee|nob...@fedoraproject.org|c...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885721] Review Request: python-hatasmota - Python module to help parse and construct Tasmota MQTT messages
https://bugzilla.redhat.com/show_bug.cgi?id=1885721 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-0b2e5201ed has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-0b2e5201ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888359] Review Request: python-hdate - Hebrew date and Zmanim
https://bugzilla.redhat.com/show_bug.cgi?id=1888359 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-hdate -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877841] Review Request: python-molecule-podman - Molecule Podman plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1877841 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-molecule-podman -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1877809] Review Request: python-molecule-docker - molecule Docker plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1877809 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-molecule-docker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888359] Review Request: python-hdate - Hebrew date and Zmanim
https://bugzilla.redhat.com/show_bug.cgi?id=1888359 --- Comment #2 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1885036] Review Request: python-ring-doorbell - Python library to communicate with Ring Door Bells
https://bugzilla.redhat.com/show_bug.cgi?id=1885036 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #4 from Fedora Update System --- FEDORA-2020-8c8a51dc14 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8c8a51dc14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888305] Review Request: python-waterfurnace - Python interface for Waterfurnace geothermal systems
https://bugzilla.redhat.com/show_bug.cgi?id=1888305
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Andy Mender ---
Some minor items picked up rpmlint. Please fix them on import:
python-waterfurnace-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-waterfurnace-doc/html/objects.inv
python-waterfurnace-doc.noarch: W: file-not-utf8
/usr/share/doc/python-waterfurnace-doc/html/objects.inv
Package approved. Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0". 25 files have
unknown license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/python-waterfurnace/python-
waterfurnace/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain
[Bug 1888305] Review Request: python-waterfurnace - Python interface for Waterfurnace geothermal systems
https://bugzilla.redhat.com/show_bug.cgi?id=1888305 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888351] Review Request: python-volvooncall - Communicate with Volvo On Call
https://bugzilla.redhat.com/show_bug.cgi?id=1888351
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Andy Mender ---
Rpmlint found some forgotten shebangs, please remove them:
python3-volvooncall.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/volvooncall/mqtt.py 644 /usr/bin/env python3
python3-volvooncall.noarch: E: non-executable-script
/usr/lib/python3.9/site-packages/volvooncall/volvooncall.py 644 /usr/bin/env
python3
The rest looks good so you can do it on package import. Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 12 files have unknown license. Detailed
output of licensecheck in /home/amender/rpmbuild/SPECS/python-
volvooncall/python-volvooncall/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
=
[Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345
--- Comment #1 from Andy Mender ---
Looks good, but there is a problem with the -doc package:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
Review: This is problematic. The package adds fonts as part of the Sphinx
HTML docs to usr/share/doc/python-hbmqtt-doc/html/_static/fonts/
I'm afraid these tightly coupled with the docs and fonts should not be
bundled with non-font packages.
Full review below:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file license.rst.txt is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
Review: I think this is a RestructuredText template file, correct?
The warning can probably be ignored.
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 98 files have unknown
license. Detailed output of licensecheck in
/home/amender/rpmbuild/SPECS/python-hbmqtt/python-
hbmqtt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3-
[Bug 1888351] Review Request: python-volvooncall - Communicate with Volvo On Call
https://bugzilla.redhat.com/show_bug.cgi?id=1888351 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888359] Review Request: python-hdate - Hebrew date and Zmanim
https://bugzilla.redhat.com/show_bug.cgi?id=1888359
Andy Mender changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Andy Mender ---
> BuildRequires: python3-devel
> BuildRequires: python3dist(pytz)
> BuildRequires: python3dist(setuptools)
> BuildRequires: python3dist(pytest)
> %{?python_provide:%python_provide python3-%{pypi_name}}
Try to switch to the %py_provides macro:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
Package approved. Full review below.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package must not depend on deprecated() packages.
Note: python3-pytest4 is deprecated, you must not depend on it.
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 22 files have unknown license. Detailed
output of licensecheck in /home/amender/rpmbuild/SPECS/python-
hdate/python-hdate/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
[Bug 1888359] Review Request: python-hdate - Hebrew date and Zmanim
https://bugzilla.redhat.com/show_bug.cgi?id=1888359 Andy Mender changed: What|Removed |Added Status|NEW |ASSIGNED CC||andymenderu...@gmail.com Assignee|nob...@fedoraproject.org|andymenderu...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1886858] Review Request: pngcheck - Verifies the integrity of PNG, JNG and MNG files
https://bugzilla.redhat.com/show_bug.cgi?id=1886858 --- Comment #6 from Andy Mender --- Awesome! Thank you very much for the update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1886858] Review Request: pngcheck - Verifies the integrity of PNG, JNG and MNG files
https://bugzilla.redhat.com/show_bug.cgi?id=1886858 --- Comment #5 from c...@musicinmybrain.net --- This comment is just to report that Greg Roelofs responded to my email rather promptly; upstream should be considered active even though the software is “done.” He was happy to hear of my packaging efforts and was willing to consider making a future upstream release with a separate MIT license file and with the -Werror=format-security patch or similar. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1856005] Review Request: dmtcp - Checkpoint/Restart functionality for Linux processes
https://bugzilla.redhat.com/show_bug.cgi?id=1856005 --- Comment #16 from Paul Grosu --- Hi Orion, When we last heard, you were checking with the lawyers if it was okay for us to have two slightly different open-source copyrights. For almost all of DMTCP, it's LGPLv3. But for the single file include/dmtcp.h , it's Apache (or any other completely open license). The file include/dmtcp.h needs to be added to the end user's own program. We don't want LGPLv3 there, since it would make claims about the copyright of the larger execution unit in which it is embedded. Thanks, - Paul and Gene -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888359] New: Review Request: python-hdate - Hebrew date and Zmanim
https://bugzilla.redhat.com/show_bug.cgi?id=1888359 Bug ID: 1888359 Summary: Review Request: python-hdate - Hebrew date and Zmanim Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-hdate.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-hdate-0.9.11-1.fc33.src.rpm Project URL: https://github.com/py-libhdate/py-libhdate Description: Jewish/Hebrew date and Zmanim in native Python. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53458381 rpmlint output: $ rpmlint python-hdate-0.9.11-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*-hdate* 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1364651] Review Request: nodejs-global-modules - The directory used by npm for globally installed npm modules
https://bugzilla.redhat.com/show_bug.cgi?id=1364651 Bug 1364651 depends on bug 1400513, which changed state. Bug 1400513 Summary: nodejs-global-prefix-1.0.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1400513 What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888351] Review Request: python-volvooncall - Communicate with Volvo On Call
https://bugzilla.redhat.com/show_bug.cgi?id=1888351 Fabian Affolter changed: What|Removed |Added Summary|Review Request: |Review Request: |python-volvooncall -|python-volvooncall - |Communicate with Volco On |Communicate with Volvo On |Call|Call -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345 Fabian Affolter changed: What|Removed |Added Blocks||1888351 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1888351 [Bug 1888351] Review Request: python-volvooncall - Communicate with Volco On Call -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888351] Review Request: python-volvooncall - Communicate with Volco On Call
https://bugzilla.redhat.com/show_bug.cgi?id=1888351 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Depends On||1888345 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora https://bugzilla.redhat.com/show_bug.cgi?id=1888345 [Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888351] New: Review Request: python-volvooncall - Communicate with Volco On Call
https://bugzilla.redhat.com/show_bug.cgi?id=1888351 Bug ID: 1888351 Summary: Review Request: python-volvooncall - Communicate with Volco On Call Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-volvooncall.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-volvooncall-0.8.12-1.fc33.src.rpm Project URL: https://github.com/molobrakos/volvooncall Description: Retrieve statistics about your Volvo from the Volvo On Call (VOC) online service. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53456748 rpmlint output: $ rpmlint python-volvooncall-0.8.12-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*-volvo* python3-volvooncall.noarch: W: no-manual-page-for-binary voc 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888345] New: Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345 Bug ID: 1888345 Summary: Review Request: python-hbmqtt - MQTT client/broker Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-hbmqtt.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-hbmqtt-0.9.6-1.fc33.src.rpm Project URL: https://github.com/beerfactory/hbmqtt Description: HBMQTT is an open source MQTT client and broker implementation. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53456032 rpmlint output: $ rpmlint python-hbmqtt-0.9.6-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python*-hbmqtt* python3-hbmqtt.noarch: W: no-manual-page-for-binary hbmqtt python3-hbmqtt.noarch: W: no-manual-page-for-binary hbmqtt_pub python3-hbmqtt.noarch: W: no-manual-page-for-binary hbmqtt_sub 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker
https://bugzilla.redhat.com/show_bug.cgi?id=1888345 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 Petr Pisar changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-10-14 15:45:04 --- Comment #5 from Petr Pisar --- Removed in perl-5.32.0-465.fc34. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1880729] Review Request: rust-plotters - Rust drawing library with a focus on data plotting
https://bugzilla.redhat.com/show_bug.cgi?id=1880729 --- Comment #2 from Fabio Valentini --- I have removed the cairo/cairo-rs and piston/piston_window features and subpackages. Now all produced binary packages are installable in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884085] Review Request: prewikka-updatedb - Database update scripts for prewikka
https://bugzilla.redhat.com/show_bug.cgi?id=1884085
Jerry James changed:
What|Removed |Added
CC||loganje...@gmail.com
--- Comment #1 from Jerry James ---
Here are some preliminary questions and observations.
- The name of the package/spec file should be python-prewikka-updatedb; see
https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_python_source_package_naming
- Why does the spec file contain this:
# Since mass rebuild, debugpackage wont works for prelude-correlator
%define debug_package %{nil}
instead of this?
BuildArch: noarch
- Where did you get the license tag? The only mention of a license that I see
is in prewikkaupdatedb/filter/update310.py, where the Converter class is
declared to be in the public domain. PKG-INFO says that the license is
UNKNOWN.
- The text at the top of /usr/lib/rpm/macros.d/macros.python-srpm indicates
that %{python3} should be used instead of %{__python3} when invoking the
interpreter in a spec file. On the other hand, is there a reason why
%install doesn't just invoke %py3_install?
- Isn't line 22 of the spec file:
Requires: python3-prewikka >= %{version}
backwards? That is, doesn't prewikka require prewikka-updatedb, not the
other way around?
- Line 23 of the spec file:
%{?python_provide:%python_provide python3-%{name}}
is no longer needed in Fedora 33 and later. If you do not plan to build for
EPEL or Fedora <= 32, then you can omit this line.
- The empty %files on line 37 of the spec file is wrong. It leads to the
creation of an empty and unnecessary prewikka-updatedb binary package. Once
that is removed, the Requires on lines 11 and 21 are also not needed. If you
want the python3 package to be installable via the name prewikka-updatedb,
then add "Provides: prewikka-updatedb = %{version}-%{release}" to the python3
subpackage.
- Line 40 of the spec file has an extraneous /:
%{python3_sitelib}//prewikkaupdatedb/
^^
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888305] Review Request: python-waterfurnace - Python interface for Waterfurnace geothermal systems
https://bugzilla.redhat.com/show_bug.cgi?id=1888305 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888305] New: Review Request: python-waterfurnace - Python interface for Waterfurnace geothermal systems
https://bugzilla.redhat.com/show_bug.cgi?id=1888305 Bug ID: 1888305 Summary: Review Request: python-waterfurnace - Python interface for Waterfurnace geothermal systems Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-waterfurnace.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-waterfurnace-1.1.0-1.fc33.src.rpm Project URL: https://github.com/sdague/waterfurnace Description: Python interface for waterfurnace geothermal systems. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53450483 rpmlint output: $ rpmlint python-waterfurnace-1.1.0-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python-waterfurnace-doc-1.1.0-1.fc33.noarch.rpm python-waterfurnace-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-waterfurnace-doc/html/objects.inv python-waterfurnace-doc.noarch: W: file-not-utf8 /usr/share/doc/python-waterfurnace-doc/html/objects.inv 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882908] Review Request: kernelshark - GUI analysis for Ftrace data captured by trace-cmd
https://bugzilla.redhat.com/show_bug.cgi?id=1882908 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2020-e78d4f1508 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e78d4f1508 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1882908] Review Request: kernelshark - GUI analysis for Ftrace data captured by trace-cmd
https://bugzilla.redhat.com/show_bug.cgi?id=1882908 --- Comment #6 from Fedora Update System --- FEDORA-2020-e78d4f1508 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e78d4f1508 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|MODIFIED Fixed In Version||perl-Tie-RefHash-1.40-1.fc3 ||4 --- Comment #4 from Petr Pisar --- Thank you for the review and the repository. I will close this report after removing this package from perl.spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888266] New: Review Request: python-zm - Python wrapper around the ZoneMinder REST API
https://bugzilla.redhat.com/show_bug.cgi?id=1888266 Bug ID: 1888266 Summary: Review Request: python-zm - Python wrapper around the ZoneMinder REST API Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-zm.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-zm-0.5.1-1.fc33.src.rpm Project URL: https://github.com/rohankapoorcom/zm-py Description: A Python wrapper around the ZoneMinder RESTful API. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53447215 rpmlint output: $ rpmlint python-zm-0.5.1-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint python3-zm-0.5.1-1.fc33.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888266] Review Request: python-zm - Python wrapper around the ZoneMinder REST API
https://bugzilla.redhat.com/show_bug.cgi?id=1888266 Fabian Affolter changed: What|Removed |Added Blocks||1269538 (IoT) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884984] Review Request: python-omnilogic - Integration for the Hayward OmniLogic pool control system
https://bugzilla.redhat.com/show_bug.cgi?id=1884984 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-omnilogic -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 --- Comment #3 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Tie-RefHash -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1884984] Review Request: python-omnilogic - Integration for the Hayward OmniLogic pool control system
https://bugzilla.redhat.com/show_bug.cgi?id=1884984 --- Comment #2 from Fabian Affolter --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 970972] Review Request: cuisine - Chef-like functionnality for Fabric
https://bugzilla.redhat.com/show_bug.cgi?id=970972 Miroslav Suchý changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2020-10-14 10:25:55 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 --- Comment #2 from Petr Pisar --- https://pagure.io/releng/fedora-scm-requests/issue/29746https://pagure.io/releng/fedora-scm-requests/issue/29746 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Tie-RefHash-1.40-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(Config) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(overload) 1 perl(strict) 1 perl(Tie::Hash) Binary requires are Ok. $ rpm -qp --provides perl-Tie-RefHash-1.40-1.fc34.noarch.rpm | sort | uniq -c 1 perl(Tie::RefHash) = 1.40 1 perl-Tie-RefHash = 1.40-1.fc34 Binary provides are Ok. $ rpmlint ./perl-Tie-RefHash* perl-Tie-RefHash.noarch: W: spelling-error %description -l en_US Nestable -> Testable, Ne stable, Ne-stable perl-Tie-RefHash.src: W: spelling-error %description -l en_US Nestable -> Testable, Ne stable, Ne-stable 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888167] New: Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's "Scalablilty Protocols"
https://bugzilla.redhat.com/show_bug.cgi?id=1888167 Bug ID: 1888167 Summary: Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's "Scalablilty Protocols" Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-nanomsg-mangos-3.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-nanomsg-mangos-3-3.1.3-1.fc33.src.rpm Project URL: https://github.com/nanomsg/mangos Description: Mangos is a pure Golang implementation of nanomsg's "Scalablilty Protocols". Koji scratch build: fails due to missing dependency rpmlint output: $ rpmlint golang-nanomsg-mangos-3-3.1.3-1.fc33.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint golang-nanomsg-mangos-3-devel-3.1.3-1.fc33.noarch.rpm golang-nanomsg-mangos-3-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/go.nanomsg.org/mangos/v3/.goipath 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888167] Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's "Scalablilty Protocols"
https://bugzilla.redhat.com/show_bug.cgi?id=1888167 Fabian Affolter changed: What|Removed |Added Depends On||1888117 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1888117 [Bug 1888117] Review Request: golang-github-gdamore-optopia - Yet another getopt implementation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888117] Review Request: golang-github-gdamore-optopia - Yet another getopt implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1888117 Fabian Affolter changed: What|Removed |Added Blocks||1888167 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1888167 [Bug 1888167] Review Request: golang-nanomsg-mangos-3 - Golang implementation of nanomsg's "Scalablilty Protocols" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1810293] Review Request: seqan3 - The modern C++ library for sequence analysis
https://bugzilla.redhat.com/show_bug.cgi?id=1810293 --- Comment #3 from Antonio T. sagitter --- Add Upstream patches for bug #2209 and #2210. Spec URL: https://sagitter.fedorapeople.org/seqan3/seqan3.spec SRPM URL: https://sagitter.fedorapeople.org/seqan3/seqan3-3.0.2-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1887937] Review Request: perl-Tie-RefHash - Use references as hash keys
https://bugzilla.redhat.com/show_bug.cgi?id=1887937 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1881782] Review Request: accel-config - Utility library for configuring the accelerator subsystem
https://bugzilla.redhat.com/show_bug.cgi?id=1881782 --- Comment #7 from Yunying Sun --- Thanks a lot for the review. I will try to fix the identified issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888121] Review Request: commit-stream - Github event API consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1888121 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888121] New: Review Request: commit-stream - Github event API consumer
https://bugzilla.redhat.com/show_bug.cgi?id=1888121 Bug ID: 1888121 Summary: Review Request: commit-stream - Github event API consumer Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/commit-stream.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/commit-stream-0.1.2-1.fc33.src.rpm Project URL: https://github.com/x1sec/commit-stream Description: OSINT tool for finding Github repositories by extracting commit logs in real time from the Github event API. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53426619 rpmlint output: $ rpmlint commit-stream-0.1.2-1.fc33.src.rpm commit-stream.src: W: spelling-error Summary(en_US) Github -> GitHub, Git hub, Git-hub 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint commit-stream* commit-stream.x86_64: W: spelling-error Summary(en_US) Github -> GitHub, Git hub, Git-hub commit-stream.x86_64: W: no-manual-page-for-binary commit-stream 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1888117] New: Review Request: golang-github-gdamore-optopia - Yet another getopt implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1888117 Bug ID: 1888117 Summary: Review Request: golang-github-gdamore-optopia - Yet another getopt implementation Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-gdamore-optopia.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/golang-github-gdamore-optopia-0.2.0-1.fc33.src.rpm Project URL: https://github.com/gdamore/optopia Description: Yet another getopt implementation for golang. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53425727 rpmlint output: $ rpmlint golang-github-gdamore-optopia-0.2.0-1.fc33.src.rpm golang-github-gdamore-optopia.src: W: spelling-error Summary(en_US) getopt -> get opt, get-opt, treetop golang-github-gdamore-optopia.src: W: spelling-error %description -l en_US getopt -> get opt, get-opt, treetop golang-github-gdamore-optopia.src: W: no-%build-section 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint golang-github-gdamore-optopia-devel-0.2.0-1.fc33.noarch.rpm golang-github-gdamore-optopia-devel.noarch: W: spelling-error Summary(en_US) getopt -> get opt, get-opt, treetop golang-github-gdamore-optopia-devel.noarch: W: spelling-error %description -l en_US getopt -> get opt, get-opt, treetop golang-github-gdamore-optopia-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/gdamore/optopia/.goipath 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
