[Bug 1981982] Review Request: biglybt - Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client.
https://bugzilla.redhat.com/show_bug.cgi?id=1981982 --- Comment #4 from Sergio Basto --- also need add apache-commons-cli https://koji.fedoraproject.org/koji/taskinfo?taskID=74113482 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981982] Review Request: biglybt - Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client.
https://bugzilla.redhat.com/show_bug.cgi?id=1981982 --- Comment #3 from Sergio Basto --- Thanks for the feedback I found and fix the problem I was the patch to java /usr/lib/jvm/java-11/bin/java , when the correct is /usr/lib/jvm/java-11/bin/java warnig messages of "/usr/bin/build-classpath: Could not find" also fixed I have updated biglybt.spec and biglybt-2.8.0.0-1.fc35.src.rpm in same place . I you builds in copr for f33+ 64 bits platforms https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/package/biglybt/ https://copr.fedorainfracloud.org/coprs/sergiomb/builds_for_Stable_Releases/build/2529595/ https://koji.fedoraproject.org/koji/taskinfo?taskID=74113193 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 --- Comment #9 from Fedora Update System --- FEDORA-2021-170572cbc8 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-170572cbc8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-170572cbc8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 --- Comment #8 from Fedora Update System --- FEDORA-2021-a22b4cd39d has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-a22b4cd39d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a22b4cd39d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994063] Review Request: nginx-mod-naxsi - nginx web application firewall module
https://bugzilla.redhat.com/show_bug.cgi?id=1994063 --- Comment #9 from Fedora Update System --- FEDORA-2021-9ba7f42344 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-9ba7f42344 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ba7f42344 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994065] Review Request: nginx-mod-vts - Nginx virtual host traffic status module
https://bugzilla.redhat.com/show_bug.cgi?id=1994065 --- Comment #8 from Fedora Update System --- FEDORA-2021-e0c54f34c4 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-e0c54f34c4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e0c54f34c4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2021-671b010a99 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-671b010a99 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-671b010a99 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2021-b9f8ee66ff has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b9f8ee66ff \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b9f8ee66ff See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994063] Review Request: nginx-mod-naxsi - nginx web application firewall module
https://bugzilla.redhat.com/show_bug.cgi?id=1994063 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- FEDORA-2021-363146d5cc has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-363146d5cc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-363146d5cc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994065] Review Request: nginx-mod-vts - Nginx virtual host traffic status module
https://bugzilla.redhat.com/show_bug.cgi?id=1994065 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- FEDORA-2021-8471f47319 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-8471f47319 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8471f47319 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1985108] Review Request: python-rpm-head-signing - Small python module to extract RPM header and file digests
https://bugzilla.redhat.com/show_bug.cgi?id=1985108 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2021-60cc8e3981 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1985108] Review Request: python-rpm-head-signing - Small python module to extract RPM header and file digests
https://bugzilla.redhat.com/show_bug.cgi?id=1985108 --- Comment #13 from Fedora Update System --- FEDORA-2021-60e6a25bae has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1985108] Review Request: python-rpm-head-signing - Small python module to extract RPM header and file digests
https://bugzilla.redhat.com/show_bug.cgi?id=1985108 --- Comment #12 from Fedora Update System --- FEDORA-2021-8d506fdb7b has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977110] Review Request: rust-gtk4-macros - Macros helpers for GTK 4 bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1977110 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-08-19 01:07:33 --- Comment #6 from Fedora Update System --- FEDORA-2021-2766a68e92 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1977132] Review Request: rust-gtk4 - Rust bindings of the GTK 4 library
https://bugzilla.redhat.com/show_bug.cgi?id=1977132 Bug 1977132 depends on bug 1977110, which changed state. Bug 1977110 Summary: Review Request: rust-gtk4-macros - Macros helpers for GTK 4 bindings https://bugzilla.redhat.com/show_bug.cgi?id=1977110 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1985108] Review Request: python-rpm-head-signing - Small python module to extract RPM header and file digests
https://bugzilla.redhat.com/show_bug.cgi?id=1985108 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2021-08-19 00:32:24 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2021-639f30caae has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982772] Review Request: ndppd - NDP Proxy Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1982772 --- Comment #13 from Fedora Update System --- FEDORA-EPEL-2021-caf4df5837 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982011] Review Request: netperf - Benchmark to measure the performance of many different types of networking
https://bugzilla.redhat.com/show_bug.cgi?id=1982011 --- Comment #15 from Fedora Update System --- FEDORA-EPEL-2021-941089b392 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 --- Comment #7 from Fedora Update System --- FEDORA-2021-170572cbc8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-170572cbc8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2021-671b010a99 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-671b010a99 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989300] Review Request: fontawesome5-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1989300 --- Comment #2 from Jerry James --- The package now fully complies with the font packaging guidelines. New URLs: Spec URL: https://jjames.fedorapeople.org/fontawesome5-fonts/fontawesome5-fonts.spec SRPM URL: https://jjames.fedorapeople.org/fontawesome5-fonts/fontawesome5-fonts-5.15.4-1.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-grpc -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 --- Comment #4 from Jerry James --- Gotcha. That's a good reason for the choice you made. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917
--- Comment #3 from Ben Beasley ---
Thanks for the review!
> A comment, not an issue: the %pypi_source macro should give you a tarball
> without needing all of the %forge* machinery.
Thanks. Indeed, %{pypi_source} is simpler, but in this case, I can’t use it
because upstream added a LICENSE file since the last release to PyPI. To
include the LICENSE in my RPM, I must either package a git snapshot (which is
what I chose) or apply the added LICENSE file as a patch to the PyPI tarball,
which I think would be even more complicated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1992879] Review Request: pari-nftables - PARI/GP Computer Algebra System number field tables
https://bugzilla.redhat.com/show_bug.cgi?id=1992879 --- Comment #18 from Jerry James --- Thanks, Ben. Nobody seems to want that review. :-) I think I'm going to drop the -web subpackage for now, as I don't need it. If somebody comes along with a valid use case, we can talk about adding it then. In any case, thank you again for the reviews you did for me. I appreciate the effort. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jerry James ---
This package is APPROVED. A comment, not an issue: the %pypi_source macro
should give you a tarball without needing all of the %forge* machinery.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages
[Bug 1995309] Review Request: cri-tools - CLI and validation tools for Container Runtime Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1995309 --- Comment #1 from Peter Hunt --- copy pasta errors :facepalm: Spec URL: https://haircommander.fedorapeople.org/cri-tools.spec SRPM URL: https://haircommander.fedorapeople.org/cri-tools-1.21.0-1.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995309] New: Review Request: cri-tools - CLI and validation tools for Container Runtime Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1995309 Bug ID: 1995309 Summary: Review Request: cri-tools - CLI and validation tools for Container Runtime Interface Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: peh...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://haircommander.fedorapeople.org/cri-o.spec SRPM URL: https://haircommander.fedorapeople.org/cri-o-1.21.2-1.fc32.src.rpm Description: CLI and validation tools for Container Runtime Interface Fedora Account System Username: haircommander -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1990917] Review Request: python-pytest-grpc - Allow testing gRPC with pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1990917 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Doc Type|--- |If docs needed, set a value Flags||fedora-review? Assignee|nob...@fedoraproject.org|loganje...@gmail.com --- Comment #1 from Jerry James --- I will take this review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 --- Comment #6 from Fedora Update System --- FEDORA-2021-a22b4cd39d has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a22b4cd39d -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992879] Review Request: pari-nftables - PARI/GP Computer Algebra System number field tables
https://bugzilla.redhat.com/show_bug.cgi?id=1992879 --- Comment #17 from Ben Beasley --- Please feel free to CC me in any additional review requests you might have coming up and I’ll consider taking them. I have seen https://bugzilla.redhat.com/show_bug.cgi?id=1989300, but I’m not willing to take it due to the domain knowledge required to review font packages properly, and due to the conflict with https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_web_fonts. I suspect it will require some very unpleasant workarounds to patch out the web fonts, or an exception from FPC to allow them. I chose the unpleasant workarounds for https://src.fedoraproject.org/rpms/gi-docgen, but this might be less workable for your packages. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2021-b9f8ee66ff has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b9f8ee66ff -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #8 from Miro Hrončok --- I won'T be able to finish this review today and I'll be offline until the end of the week. Sorry about that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995266] New: Review Request: python-mirrors-countme - scripts to create repository access statistics
https://bugzilla.redhat.com/show_bug.cgi?id=1995266 Bug ID: 1995266 Summary: Review Request: python-mirrors-countme - scripts to create repository access statistics Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: asa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://asaleh.fedorapeople.org/python-mirrors-countme.spec SRPM URL: https://asaleh.fedorapeople.org/python-mirrors-countme-0.0.4-1.fc34.src.rpm Description: A python module and scripts for parsing httpd access_log to find requests including `countme=N`, parse the data included with those requests, and compile weekly counts of DNF clients broken out by OS name, OS version, system arch, etc. Fedora Account System Username: asaleh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fmidi -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 --- Comment #3 from Ben Beasley --- Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992877] Review Request: flintqs - William Hart's quadratic sieve
https://bugzilla.redhat.com/show_bug.cgi?id=1992877 Jerry James changed: What|Removed |Added Resolution|--- |NEXTRELEASE Fixed In Version||flintqs-1.0-1.fc36 Status|ASSIGNED|CLOSED Last Closed||2021-08-18 16:30:15 --- Comment #9 from Jerry James --- Built in Rawhide and F35. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 Bug 1991138 depends on bug 1991135, which changed state. Bug 1991135 Summary: Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests https://bugzilla.redhat.com/show_bug.cgi?id=1991135 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135 Mikel Olasagasti Uranga changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2021-08-18 15:50:10 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jerry James ---
This package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is prese
[Bug 1982210] Review Request: shutter - GTK+3-based screenshot application written in Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1982210
--- Comment #5 from Petr Pisar ---
I'm sorry for the delay. I did not have much free time recently.
This is a rebase, reviewing from the beginning.
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-512)
5a3321db635a81f6f67d5789cf374d846f21003a9bd3fd748bb58481d8a5fde450a1c4b5ad4d3edee49804cee6dd8da6ad7b4422eaef96bb333b8b3059cb3e41)
is original. Ok.
TODO: Move "%global __provides_exclude_from" just above a description section.
This where we usually place the filtering macros.
Summary is Ok.
Description is Ok.
FIX: share/shutter/resources/icons/drawing_tool/cursor files are GPLv2+
according to README.
FIX: List the licenses of all the packaged files into the License section
("License: GPLv3+ and GPLv2+ and GPLv2 and CC-BY-SA and MIT and CC0 and Public
Domain").
$ rpmlint shutter.spec ../SRPMS/shutter-0.98-3.fc36.src.rpm
../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm
= rpmlint session
starts
rpmlint: 2.1.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
shutter.noarch: W: dangling-symlink
/usr/share/shutter/resources/icons/drawing_tool/objects/Tango
/usr/share/icons/Tango/scalable
shutter.noarch: W: cross-directory-hard-link /usr/share/pixmaps/shutter.png
/usr/share/icons/hicolor/48x48/apps/shutter.png
shutter.noarch: W: cross-directory-hard-link
/usr/share/shutter/resources/icons/drawing_tool/draw-image.svg
/usr/share/shutter/resources/icons/Image.svg
shutter.noarch: W: cross-directory-hard-link
/usr/share/shutter/resources/icons/drawing_tool/objects/Cursors/Normal.cur
/usr/share/shutter/resources/icons/Normal.cur
== 2 packages and 1 specfiles checked; 0 errors, 4
warnings, 0 badness; has taken 0.8 s =
TODO: I recommend creating symbolic links (ln -s) instead of hard links in the
%install section. If a user had the files on different file systems, they would
become duplicated.
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/shutter-0.98-3.fc36.noarch.rpm | sort -f
| uniq -c
1 /usr/bin/bash
1 /usr/bin/perl
1 hicolor-icon-theme
1 ImageMagick
1 perl(:MODULE_COMPAT_5.34.0)
1 perl(:VERSION) >= 5.10.1
1 perl(base)
1 perl(Carp::Always)
1 perl(constant)
1 perl(Data::Dumper)
1 perl(diagnostics)
1 perl(Digest::MD5)
1 perl(Encode)
1 perl(Encode::Locale)
1 perl(Exporter)
1 perl(File::Basename)
1 perl(File::Copy)
1 perl(File::Copy::Recursive)
1 perl(File::Glob)
1 perl(File::Spec)
1 perl(File::stat)
1 perl(File::Temp)
1 perl(File::Which)
1 perl(FindBin)
1 perl(Getopt::Long)
1 perl(Glib)
1 perl(Glib::Object::Introspection)
1 perl(Glib::Object::Subclass)
1 perl(Goo::Canvas)
1 perl(GooCanvas2)
2 perl(GooCanvas2::CairoTypes)
1 perl(Gtk3)
2 perl(Gtk3::ImageView) >= 9
1 perl(Gtk3::ImageView::Tool::Selector)
1 perl(HTTP::Request::Common)
1 perl(HTTP::Status)
1 perl(Image::ExifTool)
1 perl(Image::Magick)
1 perl(IO::File)
1 perl(JSON::MaybeXS)
1 perl(lib)
1 perl(List::Util)
1 perl(Locale::gettext)
1 perl(LWP::UserAgent)
1 perl(MIME::Base64)
1 perl(Net::DBus)
1 perl(Net::FTP)
1 perl(Number::Bytes::Human)
1 perl(Pango)
1 perl(Path::Class)
1 perl(Pod::Usage)
1 perl(POSIX)
1 perl(Proc::Killfam)
1 perl(Proc::Simple)
1 perl(Readonly)
1 perl(Shutter::App::AboutDialog)
1 perl(Shutter::App::Autostart)
1 perl(Shutter::App::Common)
1 perl(Shutter::App::Directories)
1 perl(Shutter::App::GlobalSettings)
1 perl(Shutter::App::HelperFunctions)
1 perl(Shutter::App::Menu)
1 perl(Shutter::App::Notification)
1 perl(Shutter::App::Optional::Exif)
1 perl(Shutter::App::Options)
1 perl(Shutter::App::ShutterNotification)
1 perl(Shutter::App::SimpleDialogs)
1 perl(Shutter::App::Toolbar)
1 perl(Shutter::Geometry::Region)
1 perl(Shutter::Pixbuf::Border)
1 perl(Shutter::Pixbuf::Load)
1 perl(Shutter::Pixbuf::Save)
1 perl(Shutter::Screenshot::Error)
1 perl(Shutter::Screenshot::History)
1 perl(Shutter::Screenshot::ImageViewSelector)
1 perl(Shutter::Screenshot::Main)
1 perl(Shutter::Screenshot::SelectorAdvanced)
1 perl(Shutter::Screenshot::SelectorAuto)
1 perl(Shutter::Screenshot::Web)
1 perl(Shutter::Screenshot::Window)
1 perl(Shutter::Screenshot::WindowName)
1 perl(Sh
[Bug 1992877] Review Request: flintqs - William Hart's quadratic sieve
https://bugzilla.redhat.com/show_bug.cgi?id=1992877 --- Comment #8 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/flintqs -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mirakuru -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1989592] Review Request: fmidi - A library to read and play back MIDI files
https://bugzilla.redhat.com/show_bug.cgi?id=1989592 Jerry James changed: What|Removed |Added Flags||fedora-review? CC||loganje...@gmail.com Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Assignee|nob...@fedoraproject.org|loganje...@gmail.com --- Comment #1 from Jerry James --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992877] Review Request: flintqs - William Hart's quadratic sieve
https://bugzilla.redhat.com/show_bug.cgi?id=1992877 --- Comment #7 from Jerry James --- Thank you, Ben! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995127] New: Review Request: restool - A tool to create and manage the DPAA2 Management Complex (MC)
https://bugzilla.redhat.com/show_bug.cgi?id=1995127 Bug ID: 1995127 Summary: Review Request: restool - A tool to create and manage the DPAA2 Management Complex (MC) Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pbrobin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora SPEC: https://pbrobinson.fedorapeople.org/restool.spec SRPM: https://pbrobinson.fedorapeople.org/restool-2.3.0-1.fc34.src.rpm Description: restool is a user space application providing the ability to dynamically create and manage DPAA2 containers and objects from Linux. restool interacts with the DPAA2 Management Complex (MC). It uses an ioctl to send MC commands, and thus requires a Linux kernel driver providing the needed ioctl support. koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=74074006 FAS: pbrobinson -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1995127] Review Request: restool - A tool to create and manage the DPAA2 Management Complex (MC)
https://bugzilla.redhat.com/show_bug.cgi?id=1995127 Peter Robinson changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Blocks||245418 (ARMTracker), ||1269538 (IoT) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=245418 [Bug 245418] Tracker for ARM support https://bugzilla.redhat.com/show_bug.cgi?id=1269538 [Bug 1269538] Tracker for IoT on Fedora -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #7 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql-3.1.1-2.fc34.src.rpm - Added COPYING file back -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #6 from Miro Hrončok --- > Upstream and tarball has both COPYING and COPYING.lesser and that confused me. That is the requirement by the LGPL: """ Add a COPYING file with a copy of the GNU GPL or GNU AGPL. Also add a COPYING.LESSER file with a copy of the GNU LGPL, if you use that. """ https://www.gnu.org/licenses/gpl-howto.html Please, keep both files packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992931] Review Request: rubygem-image_size - Measure image size using pure Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #4 from Mamoru TASAKA --- Updated: * For FSF address issue, I will ask the upstream later * For spec Gemfile and so on, I will keep removing them. https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-image_size.spec https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-image_size-2.1.1-2.fc34.src.rpm * Wed Aug 18 2021 Mamoru TASAKA - 2.1.1-2 - Remove unneeded environment setting - Disable failing test on s390x -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #5 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-pytest-postgresql-3.1.1-2.fc34.src.rpm - Changed license to LGPLv3+ - Remove COPYING license file Upstream and tarball has both COPYING and COPYING.lesser and that confused me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1992914] Review Request: rubygem-middleware - Generalized implementation of the middleware abstraction for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1992914 Mamoru TASAKA changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Mamoru TASAKA --- Okay, looks good * spec file clean * license acceptable (MIT) * buildable on all archs: https://koji.fedoraproject.org/koji/taskinfo?taskID=74008041 * installable * rpmlint clean (for srpm, binary rpms, installed rpm) * example seems to work: https://github.com/mitchellh/middleware/blob/master/README.md works as written = This package (rubygem-middleware) is APPROVED by mtasaka = -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991138] Review Request: python-pytest-postgresql - pytest plugin that allows to test code that relies on a running PostgreSQL database
https://bugzilla.redhat.com/show_bug.cgi?id=1991138 --- Comment #4 from Miro Hrončok --- License:GPLv3 and LGPLv3 Upstream says: License :: OSI Approved :: GNU Lesser General Public License v3 or later (LGPLv3+) Where is the catch? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135 Miro Hrončok changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Miro Hrončok --- Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135 --- Comment #5 from Mikel Olasagasti Uranga --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/python-mirakuru.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/python-mirakuru-2.4.1-2.fc34.src.rpm Changed to LGPLv3+ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1991135] Review Request: python-mirakuru - A process orchestration tool designed for functional and integration tests
https://bugzilla.redhat.com/show_bug.cgi?id=1991135
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags||fedora-review?
Assignee|nob...@fedoraproject.org|mhron...@redhat.com
--- Comment #4 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Change license from LGPLv3 to LGPLv3+.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU Lesser General Public License,
Version 3", "*No copyright* GNU Lesser General Public License v3.0 or
later", "GNU Lesser General Public License v3.0 or later", "BSD
2-clause "Simplified" License".
BSD file is tests only, not shipped.
Package is GNU Lesser General Public License v3 or later (LGPLv3+), but
the tag is LGPLv3.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the packag
[Bug 1991096] Review Request: python-port-for - Utility that helps with local TCP ports management
https://bugzilla.redhat.com/show_bug.cgi?id=1991096
Miro Hrončok changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGNED|POST
--- Comment #5 from Miro Hrončok ---
Package APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License", "*No copyright* Expat
License".
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]:
[Bug 1991096] Review Request: python-port-for - Utility that helps with local TCP ports management
https://bugzilla.redhat.com/show_bug.cgi?id=1991096 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1982621] Review Request: php-giggsey-libphonenumber-for-php - PHP Port of Google's libphonenumber
https://bugzilla.redhat.com/show_bug.cgi?id=1982621 Tomas Korbar changed: What|Removed |Added Flags||needinfo?(c...@lcts.de) --- Comment #1 from Tomas Korbar --- Hi Christopher, I am ok with specfile but in the meantime, new version of this library has been released, so please package 8.12.30 and then i will give you review+. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994946] New: Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1994946 Bug ID: 1994946 Summary: Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: chei...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://cheimes.fedorapeople.org/rust/rust-pyo3-build-config.spec SRPM URL: https://cheimes.fedorapeople.org/rust/rust-pyo3-build-config-0.14.2-1.fc34.src.rpm Description: Build configuration for the PyO3 ecosystem Fedora Account System Username: cheimes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1974358] Review Request: fdr - Flight Data Recorder
https://bugzilla.redhat.com/show_bug.cgi?id=1974358 Mikel Olasagasti Uranga changed: What|Removed |Added Resolution|--- |RAWHIDE Status|ASSIGNED|CLOSED Last Closed||2021-08-18 09:06:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994946] Review Request: rust-pyo3-build-config - Build configuration for the PyO3 ecosystem
https://bugzilla.redhat.com/show_bug.cgi?id=1994946 --- Comment #1 from Christian Heimes --- rust-pyo3-build-config is a build dependency of rust-pyo3-macros-backend and ultimately of rust-pyo3. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994912] Review Request: rust-aliasable - Basic aliasable (non unique pointer) types
https://bugzilla.redhat.com/show_bug.cgi?id=1994912 --- Comment #1 from Christian Heimes --- Package is a dependency of rust-ouroboros 0.10, https://crates.io/crates/ouroboros/0.10.1/dependencies -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1994912] New: Review Request: rust-aliasable - Basic aliasable (non unique pointer) types
https://bugzilla.redhat.com/show_bug.cgi?id=1994912 Bug ID: 1994912 Summary: Review Request: rust-aliasable - Basic aliasable (non unique pointer) types Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: chei...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://cheimes.fedorapeople.org/rust/rust-aliasable.spec SRPM URL: https://cheimes.fedorapeople.org/rust/rust-aliasable-0.1.3-1.fc34.src.rpm Description: Rust library providing basic aliasable (non core::ptr::Unique) types Fedora Account System Username: cheimes -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981982] Review Request: biglybt - Source for BiglyBT, a feature filled, open source, ad-free, bittorrent client.
https://bugzilla.redhat.com/show_bug.cgi?id=1981982 Didik Supriadi changed: What|Removed |Added Doc Type|--- |If docs needed, set a value CC||didiksupriad...@gmail.com --- Comment #2 from Didik Supriadi --- Hi, I just installed biglybt*.noarch.rpm and this error occurs: > $ biglybt > Starting BiglyBT... > /usr/bin/build-classpath: Could not find json_simple Java extension for this > JVM > /usr/bin/build-classpath: Could not find bcprov Java extension for this JVM > /usr/bin/build-classpath: Could not find apache-commons-cli Java extension > for this JVM > /usr/bin/build-classpath: Could not find apache-commons-lang Java extension > for this JVM > /usr/bin/build-classpath: error: Some specified jars were not found > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by > com.biglybt.core.util.spi.AENameServiceJava9 > (file:/usr/share/java/biglybt/BiglyBT.jar) to field java.net.InetAddress.impl > WARNING: Please consider reporting this to the maintainers of > com.biglybt.core.util.spi.AENameServiceJava9 > WARNING: Use --illegal-access=warn to enable warnings of further illegal > reflective access operations > WARNING: All illegal access operations will be denied in a future release > Loading BiglyBT: > Error: Unable to initialize main class com.biglybt.ui.Main > Caused by: java.lang.NoClassDefFoundError: > org/apache/commons/cli/ParseException > Exit from BiglyBT complete > WARNING: An illegal reflective access operation has occurred > WARNING: Illegal reflective access by > com.biglybt.core.util.spi.AENameServiceJava9 > (file:/usr/share/java/biglybt/BiglyBT.jar) to field java.net.InetAddress.impl > WARNING: Please consider reporting this to the maintainers of > com.biglybt.core.util.spi.AENameServiceJava9 > WARNING: Use --illegal-access=warn to enable warnings of further illegal > reflective access operations > WARNING: All illegal access operations will be denied in a future release > No shutdown tasks to do > BiglyBT TERMINATED. it looks like the package is not installed correctly. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
