[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #30 from marcd...@fedoraproject.org --- (In reply to Maxwell G from comment #24) > No problem, Marc. If I review any KDE packages in the future, should I also > ask the reviewee to do that? In general, yes (although don't really know how much of a "rule" we can make of that). There wasn't need of such a thing in the past in general because the main three contributors to kde-sig (Rex, Neal and Jan) are also proven packagers. However, there are contributers such as myself or Onuralp who are not ;-) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2027818] New: Review Request: dotnet6.0 - .NET 6.0 SDK and Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2027818 Bug ID: 2027818 Summary: Review Request: dotnet6.0 - .NET 6.0 SDK and Runtime Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: oma...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://pagure.io/dotnet-sig/dotnet6.0/blob/84b428a155cda8d96ddf3aa2a844d22b1ac27c50/f/dotnet6.0.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/%40dotnet-sig/dotnet-preview/srpm-builds/02995120/dotnet6.0-6.0.100-1.fc34.src.rpm Description: .NET is a fast, lightweight and modular platform for creating cross platform applications that work on Linux, macOS and Windows. It particularly focuses on creating console applications, web applications and micro-services. .NET contains a runtime conforming to .NET Standards a set of framework libraries, an SDK containing compilers and a 'dotnet' application to drive everything. Fedora Account System Username: omajid This is not an upgrade or replacement of the existing dotnet3.1 or dotnet5.0 packages, but an entirely new package. The packages can all be installed side-by-side. Here's a diff of the dotnet5.0 and this new dotnet6.0 spec file: https://gist.github.com/omajid/604d9d6d559258286f476864626a01e1 This package needs to be bootstrapped. Which can be done by changing the %bcond_without. We have a blanket bootstrap exception from the fedora packaging committee: https://pagure.io/packaging-committee/issue/989. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2027818 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2023085] Review Request: xq - Command line XML beautifier and content extractor, similar to jq
https://bugzilla.redhat.com/show_bug.cgi?id=2023085 --- Comment #9 from Fedora Update System --- FEDORA-2021-dcc8f652f2 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023085 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2011830] Review Request: perl-Archive-Zip-SimpleZip - Create Zip Archives
https://bugzilla.redhat.com/show_bug.cgi?id=2011830 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2021-12-01 01:13:32 --- Comment #9 from Fedora Update System --- FEDORA-2021-23818d4355 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2011830 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2027872] New: Review Request: rust-io-extras - File/socket handle/descriptor utilities
https://bugzilla.redhat.com/show_bug.cgi?id=2027872 Bug ID: 2027872 Summary: Review Request: rust-io-extras - File/socket handle/descriptor utilities Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nob...@fedoraproject.org Reporter: o.lema...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://olem.fedorapeople.org/reviews/rust-io-extras.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-io-extras-0.12.2-1.fc35.src.rpm Description: File/socket handle/descriptor utilities. Fedora Account System Username: olem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2027872 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2011830] Review Request: perl-Archive-Zip-SimpleZip - Create Zip Archives
https://bugzilla.redhat.com/show_bug.cgi?id=2011830 --- Comment #11 from Fedora Update System --- FEDORA-EPEL-2021-64ba45d661 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011830 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #29 from Fedora Update System --- FEDORA-2021-3dedb719ce has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-3dedb719ce` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3dedb719ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2011830] Review Request: perl-Archive-Zip-SimpleZip - Create Zip Archives
https://bugzilla.redhat.com/show_bug.cgi?id=2011830 --- Comment #10 from Fedora Update System --- FEDORA-2021-d38d4f7c04 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2011830 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2023085] Review Request: xq - Command line XML beautifier and content extractor, similar to jq
https://bugzilla.redhat.com/show_bug.cgi?id=2023085 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed||2021-12-01 01:13:48 --- Comment #8 from Fedora Update System --- FEDORA-2021-594822c195 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2023085 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2027872] Review Request: rust-io-extras - File/socket handle/descriptor utilities
https://bugzilla.redhat.com/show_bug.cgi?id=2027872 --- Comment #1 from Olivier Lemasle --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=79449418 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2027872 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2007419] Review Request: rust-rustix - Safe Rust bindings to POSIX/Unix/Linux syscalls
https://bugzilla.redhat.com/show_bug.cgi?id=2007419 Olivier Lemasle changed: What|Removed |Added Summary|Review Request: rust-rsix - |Review Request: rust-rustix |Safe Rust bindings to |- Safe Rust bindings to |POSIX-like/Unix-like/Linux |POSIX/Unix/Linux syscalls |syscalls| --- Comment #2 from Olivier Lemasle --- This is a re-review. Crate "posish" has been renamed "rsix", then "rustix", so the package "rust-posish" should be renamed "rust-rustix". This package obsoletes rust-posish. (Cf https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/#re_review_required) Spec URL: https://olem.fedorapeople.org/reviews/rust-rustix.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-rustix-0.27.1-1.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2007419 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2027872] Review Request: rust-io-extras - File/socket handle/descriptor utilities
https://bugzilla.redhat.com/show_bug.cgi?id=2027872 Olivier Lemasle changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #2 from Olivier Lemasle --- This is a re-review. Crate "unsafe-io" has been renamed "io-extras", so the package "rust-unsafe-io" should be renamed "rust-io-extras". This package obsoletes rust-unsafe-io. (Cf https://docs.fedoraproject.org/en-US/package-maintainers/Package_Renaming_Process/#re_review_required) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2027872 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2025024] Review Request: python-ukkonen - Implementation of bounded Levenshtein distance (Ukkonen)
https://bugzilla.redhat.com/show_bug.cgi?id=2025024 --- Comment #2 from Gwyn Ciesla --- Yes, please! This was a quick-and dirty pypy2rpm, and it shows. :) Updated. SPEC: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen.spec SRPM: https://fedorapeople.org/~limb/review/python-ukkonen/python-ukkonen-1.0.1-2.fc35.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2025024 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2024094] Review Request: rust-fasteval - Fast evaluation of algebraic expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2024094 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Thank you for the review. > [!]: Spec file according to URL is the same as in SRPM. In the meantime, upstream merged my patch to adjust the filter used to generate the .crate file to include the tests again. So for the next release, the upstream create should be usable again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2024094 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #28 from Fedora Update System --- FEDORA-2021-3dedb719ce has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3dedb719ce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #26 from Fedora Update System --- FEDORA-2021-25be101ebe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2021-25be101ebe -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2021-11-30 20:12:21 --- Comment #27 from Fedora Update System --- FEDORA-2021-25be101ebe has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1785982] Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 Bug 1785982 depends on bug 1906117, which changed state. Bug 1906117 Summary: python3-qdarkstyle should not requires stuff only used as build dependencies https://bugzilla.redhat.com/show_bug.cgi?id=1906117 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |EOL -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1785982 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2024094] Review Request: rust-fasteval - Fast evaluation of algebraic expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2024094
Jerry James changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jerry James ---
Looks good. This package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "MIT License". 43 files have unknown
license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #25 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kalendar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2008416] Review Request: ghc-hspec-megaparsec - Utility functions for testing Megaparsec parsers with Hspec
https://bugzilla.redhat.com/show_bug.cgi?id=2008416 Mohamed El Morabity changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2021-11-30 17:36:34 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2008416 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988286] Review Request: rust-zmq-sys - Low-level bindings to the zeromq library
https://bugzilla.redhat.com/show_bug.cgi?id=1988286 --- Comment #1 from Daiki Ueno --- Sergio spotted an issue installing the resulting RPMs to compile rust-zmq package, which was caused by the "vendored" feature (i.e., building zeromq C library locally). As this does not make much sense in Fedora, I've dropped those packages. Also switched to using system-deps instead of metadeps, which has been retired some time ago. The new spec file and SRPM can be found below: Spec file: https://ueno.fedorapeople.org/rust-zmq-sys-no-vendor/rust-zmq-sys.spec SRPM: https://ueno.fedorapeople.org/rust-zmq-sys-no-vendor/rust-zmq-sys-0.11.0-1.fc36.src.rpm Sergio, could you take a look? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1988286 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #24 from Maxwell G --- (In reply to marcdeop from comment #23) > (In reply to Maxwell G from comment #22) > > I approved your package. When you import this package, please make sure that > > you add `Fixes rhbz#2020883` to the rpm changelog and/or manually add this > > bug to the Bodhi update so it gets marked as CLOSED. > > > > I also added `kalendar` to release-montioring.org (AKA Antiya)[1]. Antiya > > will create a Bugzilla bug against your package for each new upstream > > release so you can make sure your package is up to date. > > > > Please let me know if you have any questions. > > > > Thanks, > > Maxwell > > > > [1]: https://release-monitoring.org/project/241436/ > > Thanks Maxwell for all the hard work. > > I would like to ask @Onuralp to give @KDE-Sig admin permissions on the > repository so we could contribute in the future :-) No problem, Marc. If I review any KDE packages in the future, should I also ask the reviewee to do that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2024094] Review Request: rust-fasteval - Fast evaluation of algebraic expressions
https://bugzilla.redhat.com/show_bug.cgi?id=2024094 Jerry James changed: What|Removed |Added Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|loganje...@gmail.com CC||loganje...@gmail.com Flags||fedora-review? --- Comment #1 from Jerry James --- I will take this review. I don't have any pending reviews right now, so this is a freebie. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2024094 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #23 from marcd...@fedoraproject.org --- (In reply to Maxwell G from comment #22) > I approved your package. When you import this package, please make sure that > you add `Fixes rhbz#2020883` to the rpm changelog and/or manually add this > bug to the Bodhi update so it gets marked as CLOSED. > > I also added `kalendar` to release-montioring.org (AKA Antiya)[1]. Antiya > will create a Bugzilla bug against your package for each new upstream > release so you can make sure your package is up to date. > > Please let me know if you have any questions. > > Thanks, > Maxwell > > [1]: https://release-monitoring.org/project/241436/ Thanks Maxwell for all the hard work. I would like to ask @Onuralp to give @KDE-Sig admin permissions on the repository so we could contribute in the future :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 Maxwell G changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #22 from Maxwell G --- I approved your package. When you import this package, please make sure that you add `Fixes rhbz#2020883` to the rpm changelog and/or manually add this bug to the Bodhi update so it gets marked as CLOSED. I also added `kalendar` to release-montioring.org (AKA Antiya)[1]. Antiya will create a Bugzilla bug against your package for each new upstream release so you can make sure your package is up to date. Please let me know if you have any questions. Thanks, Maxwell [1]: https://release-monitoring.org/project/241436/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883
--- Comment #21 from Maxwell G ---
(In reply to Onuralp SEZER from comment #17)
> (In reply to Maxwell G from comment #16)
> > Hi Onuralp,
> >
> > We are almost there; there are just a couple minor issues left.
>
> cmake(KF5DBusAddons) is added, thank you very much.
>
> > (In reply to Maxwell G from comment #9)
> > > You should also add `BuildRequires: cmake(KF5DBusAddons)`[3] to be
> > > explicit.
> > >
> > > [3]:
> > > https://invent.kde.org/pim/kalendar/-/compare/v0.1.0...v0.2.1?from_project_id=7106#9a2aa4db38d3115ed60da621e012c0efc0172aae
> >
> > This still needs to be fixed.
>
> kf5 macros used.
> And uuid section added as well.
>
> >
> > > %check
> > > desktop-file-validate
> > > %{buildroot}%{_datadir}/applications/org.kde.%{name}.desktop
> > > appstream-util validate-relax --nonet
> > > %{buildroot}%{_metainfodir}/org.kde.%{name}.appdata.xml
> >
> > According to the KDE SIG,`%{_kf5_*}` macros should be used for KDE
> > applications[1,2]. In your case, you should use `%{_kf5_datadir}` instead of
> > `%{_datadir}` and `%{_kf5_metainfodir}` instead of `%{_metainfodir}`. For
> > the aforementioned macros, the kf5 variants actually have the same values as
> > the non kf5 variants in Fedora, but the kf5 macros are still preferred.
> > Also, you should remain consistent; don't use `%{_datadir}` in one part of
> > the spec and `%{_kf5_datadir}` in another. Admittedly, this is an
> > unimportant change, but I don't think it requires much effort to implement,
> > so we should do so.
> >
> > Thanks,
> > Maxwell
> >
> > [1]:
> > https://lists.fedoraproject.org/archives/list/k...@lists.fedoraproject.org/
> > thread/ZPZTD4F77OICVSPIL7BL22GGQXWQM7PL/
> > [2]:
> > https://lists.fedoraproject.org/archives/list/k...@lists.fedoraproject.org/
> > thread/A4B7MUWO3QYKNA26V2FIEP73C4RT6IJU/
Great! Thank you.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2020883
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 2020883] Review Request: kalendar - A calendar application using Akonadi to sync with external services
https://bugzilla.redhat.com/show_bug.cgi?id=2020883 --- Comment #20 from Maxwell G --- (In reply to Onuralp SEZER from comment #19) > (In reply to Onuralp SEZER from comment #18) > > (In reply to Maxwell G from comment #2) > > > It also probably makes sense to add `Recommends: kdepim-runtime`, as the > > > README recommends. > > > > > > > **We also strongly recommend you install the `kdepim-runtime` package > > > > before starting Kalendar** -- this will provide you with the ability to > > > > add calendars from online resources. Having this package will also let > > > > Kalendar's backend automatically create a default local calendar. > > > > https://pagure.io/kalendar/c/ > > f660fa8cb14b15be448ee9021468bd3a3647e2f1?branch=main > > > > This is added as well. > > I removed it, (sorry for duplication) No problem. It looks like it should be `Requires:` instead of `Recommends:` anyways. ` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020883 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2024881] Review Request: java-17-openjdk - The OpenJDK 17 runtime and development environment.
https://bugzilla.redhat.com/show_bug.cgi?id=2024881 jiri vanek changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #6 from jiri vanek --- Thank you very much for awesome review. Will elaborate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2024881 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1988280] Review Request: rust-compress-tools - Utility functions for compressed and archive files handling
https://bugzilla.redhat.com/show_bug.cgi?id=1988280 Daiki Ueno changed: What|Removed |Added Resolution|--- |RAWHIDE Status|POST|CLOSED Last Closed||2021-11-30 12:13:47 --- Comment #6 from Daiki Ueno --- Thank you for the review and sorry for the delay; built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2021-91a8c99d02 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1988280 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
