[Bug 1822847] Review Request: vl-gothic-fonts - Japanese TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1822847 --- Comment #9 from Akira TAGOH --- Spec URL: https://tagoh.fedorapeople.org/reviews/vl-gothic-fonts/vl-gothic-fonts.spec SRPM URL: https://tagoh.fedorapeople.org/reviews/vl-gothic-fonts/vl-gothic-fonts-20220612-1.fc37.src.rpm Updated spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1822847 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104533] Review Request: fuse2fs - fuse implementation of e2fs -- epel7 only
https://bugzilla.redhat.com/show_bug.cgi?id=2104533
--- Comment #5 from Maxwell G ---
%{?_smp_mflags} is redundant when %make_build is used. Please remove it. I will
continue with the review later, I just noticed that on first glance.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2104533
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #15 from Fedora Update System --- FEDORA-EPEL-2022-1df65ad7ce has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #14 from Fedora Update System --- FEDORA-2022-bd477dea35 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-bd477dea35 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #11 from Fedora Update System --- FEDORA-2022-963a200d96 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-963a200d96 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-963a200d96 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2095005] Review Request: python-rfc3339-validator - Pure python RFC3339 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2095005 --- Comment #15 from Fedora Update System --- FEDORA-2022-7b934a61f4 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-7b934a61f4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-7b934a61f4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2095005 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 --- Comment #10 from Fedora Update System --- FEDORA-2022-0ea1fec992 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-0ea1fec992 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-0ea1fec992 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #13 from Fedora Update System --- FEDORA-2022-8f22b16fe5 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-8f22b16fe5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2095005] Review Request: python-rfc3339-validator - Pure python RFC3339 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2095005 --- Comment #14 from Fedora Update System --- FEDORA-2022-a93360355b has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a93360355b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a93360355b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2095005 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #10 from Fedora Update System --- FEDORA-2022-6e7fe9b9a1 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-6e7fe9b9a1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6e7fe9b9a1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 --- Comment #9 from Fedora Update System --- FEDORA-2022-882a7fffd7 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-882a7fffd7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-882a7fffd7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2102693] Review Request: python-pytest-httpserver - HTTP server for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=2102693 Nathan Scott changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Nathan Scott --- Yep - OK - I see the license file there in the egginfo now. That looks good enough to me, we shouldn't ship it twice - thanks Ali! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2102693 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104533] Review Request: fuse2fs - fuse implementation of e2fs -- epel7 only
https://bugzilla.redhat.com/show_bug.cgi?id=2104533 --- Comment #4 from Dave Dykstra --- Spec URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04630876-fuse2fs/fuse2fs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04630876-fuse2fs/fuse2fs-1.46.5-3.el7.src.rpm Description: FUSE file system client for ext2/ext3/ext4 file systems Fedora Account System Username: dwd Fedora review: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/fedora-rawhide-x86_64/04630876-fuse2fs/fedora-review/review.txt Ok, please re-review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104533 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104533] Review Request: fuse2fs - fuse implementation of e2fs -- epel7 only
https://bugzilla.redhat.com/show_bug.cgi?id=2104533 --- Comment #3 from Dave Dykstra --- Oh I just realized I forgot the %make_build, will make version 3. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104533 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104533] Review Request: fuse2fs - fuse implementation of e2fs -- epel7 only
https://bugzilla.redhat.com/show_bug.cgi?id=2104533 --- Comment #2 from Dave Dykstra --- Spec URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04630859-fuse2fs/fuse2fs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04630859-fuse2fs/fuse2fs-1.46.5-2.src.rpm Description: FUSE file system client for ext2/ext3/ext4 file systems Fedora Account System Username: dwd Thanks, Maxwell G! I have addressed your comments, please take another look. For some reason I don't understand copr didn't make a new fedora-review file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104533 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2086265] Review Request: budgie-control-center - Budgie Desktop's Control Center
https://bugzilla.redhat.com/show_bug.cgi?id=2086265 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #12 from Neal Gompa --- Yeah, things look good to me now, so... PACKAGE APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086265 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2086265] Review Request: budgie-control-center - Budgie Desktop's Control Center
https://bugzilla.redhat.com/show_bug.cgi?id=2086265 --- Comment #11 from Joshua Strobl --- So I know it has been a fair bit since the last update on this, but I believe this is ready for review again. I have been using fedora-review to aid me in identifying issues and I believe I have addressed the most crucial ones. Sources: https://github.com/BuddiesOfBudgie/fedora-pkg/tree/main/budgie-control-center This has been built under both f37 and f36, with active usage under f36. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086265 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #12 from Fedora Update System --- FEDORA-EPEL-2022-1df65ad7ce has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-1df65ad7ce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #7 from chedi toueiti --- done, please check again (same links) https://chedi.fedorapeople.org/python-rfc3986-validator.spec https://chedi.fedorapeople.org/python-rfc3986-validator-0.1.0-1.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2106171 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #11 from Fedora Update System --- FEDORA-2022-bd477dea35 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-bd477dea35 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #10 from Fedora Update System --- FEDORA-2022-8f22b16fe5 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8f22b16fe5 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2022-07-12 19:44:26 --- Comment #9 from Fedora Update System --- FEDORA-2022-ce53f1ef2f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2022-ce53f1ef2f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ce53f1ef2f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #6 from Maxwell G --- Thanks for incorporating my changes. > - I prefer to keep that convention with slugname even if used once if you > don't mind I don't agree with it, but as I said, it's up to you :). > - added a patch removing the pytest-runner from the setup.py (I'll try to > escalate the issue upstream) Thanks. Please leave a comment explaining the patch and a comment linking to the upstream issue or at least saying that it will be submitted upstream. You can also shorten Patch0 to Patch, if you'd like. > %bcond_with tests Please enable the tests. > PYTHONWARNINGS=ignore %python3 -m pytest tests Please use the %pytest macro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2106171 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104533] Review Request: fuse2fs - fuse implementation of e2fs -- epel7 only
https://bugzilla.redhat.com/show_bug.cgi?id=2104533
Maxwell G changed:
What|Removed |Added
CC||gotmax@e.email
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Maxwell G ---
Some initial comments:
> Group: System Environment/Base
Group tags must not be present in Fedora specfiles.
> ./configure
Does this project use autotools? If so, you should use %configure. Also, please
use `%make_build` instead of calling make directly, if possible.
> cp misc/%{name} %{buildroot}%{_sbindir}/
> cp misc/%{name}.1 %{buildroot}%{_mandir}/man1
This should be `cp -p`
You're missing the URL directive.
> # download with:
> # $ curl -o %{name}-%{version}.tar.gz \
> #https://codeload.github.com/tytso/e2fsprogs/tar.gz/v%{version}
> Source0: %{name}-%{version}.tar.gz
Don't do this, if you can avoid it. Use
https://github.com/tytso/e2fsprogs/archive/v%{version}/%{name}-%{version}.tar.gz
instead.
> %{!?_licensedir:%global license %%doc}
Shouldn't this be above the first usage of %license? Also, please install the
README in %doc.
> License: GPLv2
The project is not entirely licensed under the GPLv2 and other licenses apply.
Please make sure to include all of these in the License tag.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2104533
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #9 from Fedora Update System --- FEDORA-2022-963a200d96 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-963a200d96 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/authbind -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #8 from Fedora Update System --- FEDORA-2022-6e7fe9b9a1 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6e7fe9b9a1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 Fedora Update System changed: What|Removed |Added Resolution|--- |ERRATA Status|MODIFIED|CLOSED Last Closed||2022-07-12 17:20:30 --- Comment #7 from Fedora Update System --- FEDORA-2022-dc4dfeffc6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2022-dc4dfeffc6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-dc4dfeffc6 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106445] Review Request: qucs-s - Qucs circuit simulator which works with SPICE
https://bugzilla.redhat.com/show_bug.cgi?id=2106445 Jaroslav Škarvada changed: What|Removed |Added Comment|0 |updated --- Comment #0 has been edited --- Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-1.fc35.src.rpm Description: Qucs-S is a spin-off of the Qucs cross-platform circuit simulator. "S" letter indicates SPICE. The purpose of the Qucs-S subproject is to use free SPICE circuit simulation kernels with the Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs GUI. Fedora Account System Username: jskarvad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2106445 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106445] New: Review Request: qucs-s - Qucs circuit simulator which works with SPICE
https://bugzilla.redhat.com/show_bug.cgi?id=2106445 Bug ID: 2106445 Summary: Review Request: qucs-s - Qucs circuit simulator which works with SPICE Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jskar...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s.spec SRPM URL: https://jskarvad.fedorapeople.org/qucs-s/qucs-s-0.0.24-1.fc35.src.rpm Description: Qucs-S is a spin-off of the Qucs cross-platform circuit simulator. "S" letter indicates SPICE. The purpose of the Qucs-S subproject is to use free SPICE circuit simulation kernels with the Qucs GUI. It merges the power of SPICE and the simplicity of the Qucs GUI. Fedora Account System Username: jskarvad -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2106445 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2106171 --- Comment #5 from chedi toueiti --- here is the last update with the following changes: - added the period to the common_description - added a patch removing the pytest-runner from the setup.py (I'll try to escalate the issue upstream) - I was fooled by the error message into thinking rfc3987 was not present in Fedora while in fact, the test requirements were missing from the config (added them in the same patch as pytest-runner) - tests are running ok now - I prefer to keep that convention with slugname even if used once if you don't mind same links: https://chedi.fedorapeople.org/python-rfc3986-validator.spec https://chedi.fedorapeople.org/python-rfc3986-validator-0.1.0-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2106171 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 --- Comment #6 from Davide Cavalca --- Thanks! $ fedpkg request-repo authbind 2058364 https://pagure.io/releng/fedora-scm-requests/issue/45713 $ fedpkg request-branch --repo authbind f36 https://pagure.io/releng/fedora-scm-requests/issue/45714 $ fedpkg request-branch --repo authbind f35 https://pagure.io/releng/fedora-scm-requests/issue/45715 $ fedpkg request-branch --repo authbind epel8 https://pagure.io/releng/fedora-scm-requests/issue/45716 $ fedpkg request-branch --repo authbind epel9 https://pagure.io/releng/fedora-scm-requests/issue/45717 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2058364] Review Request: authbind - Allow non-root users to open restricted ports
https://bugzilla.redhat.com/show_bug.cgi?id=2058364 Neal Gompa changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Neal Gompa --- Review notes: * Package is named appropriately * Package licensing is correctly indicated * Package builds and installs properly * Package generally follows guidelines I would advise reaching out to upstream to add a COPYING file for the license itself, since the path in debian/copyright doesn't exist on Fedora systems. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2058364 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 --- Comment #8 from Fedora Update System --- FEDORA-2022-0ea1fec992 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-0ea1fec992 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-memcached-rs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136 --- Comment #4 from Davide Cavalca --- Thanks! $ fedpkg request-repo rust-memcached-rs 1981136 https://pagure.io/releng/fedora-scm-requests/issue/45709 $ fedpkg request-branch --repo rust-memcached-rs f36 https://pagure.io/releng/fedora-scm-requests/issue/45710 $ fedpkg request-branch --repo rust-memcached-rs f35 https://pagure.io/releng/fedora-scm-requests/issue/45711 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1981136 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1981136] Review Request: rust-memcached-rs - MemCached Library in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1981136
Michel Alexandre Salim changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
Status|ASSIGNED|POST
--- Comment #3 from Michel Alexandre Salim ---
LGTM, approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "MIT License", "Apache License (v2.0)
or MIT license". 10 files have unknown license. Detailed output of
licensecheck in /home/michel/src/fedora/reviews/dcavalca/1981136-rust-
memcached-rs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
memcached-rs-devel , rust-memcached-rs+default-devel , rust-memcached-
rs+nightly-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original
[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2106171
--- Comment #4 from Maxwell G ---
Sure, no problem!
(In reply to Maxwell G from comment #1)
> > %global common_description %{expand:
> > A pure python RFC3986 validator
> > }
>
> This should end with a period.
Don't forget to fix this.
> %global srcname rfc3986-validator
> %global slugname rfc3986_validator
> %global pkgname python-rfc3986-validator
(I thought I brought this up in the first comment, but it looks like I forgot
to)
I'm really not a fan of all of those *name macros. It makes the specfile harder
to read than just using the appropriate name in the appropriate place. It feels
a bit silly to define %slugname and %pkgname which are only used once. %srcname
is used multiple times, but I still think it's cleaner in this case to just use
actual name. However, that's not an actual guideline, as far as I know, so it's
really up to you.
> I didn't add checks because the tests are using another package (rfc3987) not
> present yet in fedora.
rfc3987 appears to be present in Fedora:
https://packages.fedoraproject.org/pkgs/python-rfc3987/python3-rfc3987/
Please also see the comments in
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-a002237477#comment-26035445
about removing pytest-runner. It's deprecated upstream, and we would like to
avoid having any more packages depend on this. If you're not comfortable
patching this out, I would appreciate if you at least created an issue
upstream.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106171
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 --- Comment #7 from Fedora Update System --- FEDORA-2022-882a7fffd7 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-882a7fffd7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2022-07-12 14:50:22 --- Comment #6 from Fedora Update System --- FEDORA-2022-846aa0c2f2 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #5 from Fedora Update System --- FEDORA-2022-846aa0c2f2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-846aa0c2f2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 505845] Review Request: hyphen-cy - Welsh hyphenation patterns
https://bugzilla.redhat.com/show_bug.cgi?id=505845 Mina Gerry changed: What|Removed |Added CC||themin...@yahoo.com --- Comment #11 from Mina Gerry --- Thanks for report this bug: https://www.cevagraf.fr/imprimerie-haguenau/ -- You are receiving this mail because: You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=505845 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2105796] Review Request: nagelfar - Syntax checker for Tcl
https://bugzilla.redhat.com/show_bug.cgi?id=2105796 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/nagelfar -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2105796 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2097799] Review Request: perl-B-Hooks-AtRuntime - Lower blocks from compile time to runtime
https://bugzilla.redhat.com/show_bug.cgi?id=2097799
Jitka Plesnikova changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||jples...@redhat.com
Flags||fedora-review?
Assignee|nob...@fedoraproject.org|jples...@redhat.com
--- Comment #2 from Jitka Plesnikova ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires
FIX: Use 'perl(:VERSION) >= 5.8.1' instead of 'perl >= 0:5.008001' because
the package has an epoch.
FIX: Please add build-requires:
coreutils - needed for macro %{_fixperms}
findutils - spec file line 47
perl(Carp) - lib/B/Hooks/AtRuntime.pm:8
perl(constant) - lib/B/Hooks/AtRuntime.pm:19
perl(lib) - t/00use.t:5
perl(Exporter) - tlib/t/Util.pm:6
perl(strict) - lib/B/Hooks/AtRuntime.pm:4
perl(warnings) - lib/B/Hooks/AtRuntime.pm:3
perl(XSLoader) - lib/B/Hooks/AtRuntime.pm:6
$ rpm -qp --requires perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq
-c | grep -v rpmlib
1 ld-linux-x86-64.so.2()(64bit)
1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 perl(Carp)
1 perl(constant)
1 perl(Exporter::Tiny)
1 perl(:MODULE_COMPAT_5.36.0)
1 perl(parent)
1 perl(strict)
1 perl(Sub::Name)
1 perl(warnings)
1 perl(XSLoader)
1 rtld(GNU_HASH)
Binary requires
FIX: Please add run-requires
perl(Filter::Util::Call) - lib/B/Hooks/AtRuntime.pm:25
$ rpm -qp --provides perl-B-Hooks-AtRuntime-7-1.fc37.x86_64.rpm | sort | uniq
-c
1 perl(B::Hooks::AtRuntime) = 7
1 perl-B-Hooks-AtRuntime = 7-1.fc37
1 perl-B-Hooks-AtRuntime(x86-64) = 7-1.fc37
Binary provides are Ok.
$ rpmlint ./perl-B-Hooks-AtRuntime*
= rpmlint session starts
rpmlint: 2.2.0
configuration:
/usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has
taken 0.2 s =
Rpmlint is ok
TODO: I think 'Build', 'META.json' and the test directory 'tlib' could be
removed from %doc.
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new
spec file.
Resolution:
Not approved
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2097799
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[Bug 2056309] Review Request: tytools - Collection of tools to manage Teensy boards
https://bugzilla.redhat.com/show_bug.cgi?id=2056309 --- Comment #4 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tytools -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2056309 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2106063] Review Request: python-ovh - Lightweight wrapper around OVHcloud's APIs
https://bugzilla.redhat.com/show_bug.cgi?id=2106063 Paul Wouters changed: What|Removed |Added Assignee|nob...@fedoraproject.org|paul.wout...@aiven.io Flags||fedora-review? Doc Type|--- |If docs needed, set a value CC||paul.wout...@aiven.io Status|NEW |ASSIGNED -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2106063 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2102693] Review Request: python-pytest-httpserver - HTTP server for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=2102693 --- Comment #2 from Ali Erdinc Koroglu --- Hello Nathan, as I know %pyproject_save_files automatically mark license files with %license macro so that's why I did not add %license. is it ok ? BR, Ali -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2102693 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2104932] Review Request: rest1 - A library for access to RESTful web services
https://bugzilla.redhat.com/show_bug.cgi?id=2104932 Michael Catanzaro changed: What|Removed |Added Flags|needinfo?(mcatanza@redhat.c | |om) | -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104932 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2095005] Review Request: python-rfc3339-validator - Pure python RFC3339 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2095005 --- Comment #13 from Fedora Update System --- FEDORA-2022-7b934a61f4 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7b934a61f4 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2095005 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2095005] Review Request: python-rfc3339-validator - Pure python RFC3339 validator
https://bugzilla.redhat.com/show_bug.cgi?id=2095005 --- Comment #12 from Fedora Update System --- FEDORA-2022-a93360355b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a93360355b -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2095005 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2097925] Review Request: cepces - Certificate Enrollment through CEP/CES
https://bugzilla.redhat.com/show_bug.cgi?id=2097925 Andreas Schneider changed: What|Removed |Added Assignee|pfili...@redhat.com |a...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2097925 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2097925] Review Request: cepces - Certificate Enrollment through CEP/CES
https://bugzilla.redhat.com/show_bug.cgi?id=2097925 Andreas Schneider changed: What|Removed |Added Assignee|a...@redhat.com |pfili...@redhat.com Keywords||Triaged -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2097925 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2089270] Review Request: golang-github-zeebo-hmux - Minimal, well tested, http muxing library
https://bugzilla.redhat.com/show_bug.cgi?id=2089270 Mikel Olasagasti Uranga changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2022-07-12 09:08:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2089270 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2089270] Review Request: golang-github-zeebo-hmux - Minimal, well tested, http muxing library
https://bugzilla.redhat.com/show_bug.cgi?id=2089270 Bug 2089270 depends on bug 2089269, which changed state. Bug 2089269 Summary: Review Request: golang-github-zeebo-assert - Helpers for tests https://bugzilla.redhat.com/show_bug.cgi?id=2089269 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2089270 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2089269] Review Request: golang-github-zeebo-assert - Helpers for tests
https://bugzilla.redhat.com/show_bug.cgi?id=2089269 Mikel Olasagasti Uranga changed: What|Removed |Added Resolution|--- |RAWHIDE Status|ASSIGNED|CLOSED Last Closed||2022-07-12 09:08:40 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2089269 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 2102693] Review Request: python-pytest-httpserver - HTTP server for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=2102693
--- Comment #1 from Nathan Scott ---
Hi Ali,
Just the one possible issue I see - can that upstream LICENSE file be listed as
%license for this package?
Everything else looks fine and I'm happy to sign-off once a decision is made
there.
cheers.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is not marked as %license
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/LicensingGuidelines/#_license_text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* MIT License", "MIT
License". 89 files have unknown license. Detailed output of
licensecheck in /home/nathans/tmp/2102693-python-pytest-
httpserver/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists
[Bug 2102693] Review Request: python-pytest-httpserver - HTTP server for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=2102693 Nathan Scott changed: What|Removed |Added CC||nath...@redhat.com Flags||fedora-review? Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|nath...@redhat.com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2102693 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
