[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Hanns-Joachim Uhl  changed:

   What|Removed |Added

 Blocks||1384450



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Vivek Goyal vgo...@redhat.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



--- Comment #9 from Vivek Goyal vgo...@redhat.com ---
Ok, both licensing and source issues have been sorted out. I have uploaded a
new set of spec and source rpm file. Pleaese review..

http://people.redhat.com/vgoyal/ima-evm-utils/ima-evm-utils.spec
http://people.redhat.com/vgoyal/ima-evm-utils/ima-evm-utils-0.6-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=d8MHaMoPiOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275



--- Comment #5 from Josh Bressers bress...@redhat.com ---
Created attachment 791795
  -- https://bugzilla.redhat.com/attachment.cgi?id=791795action=edit
Package review document

Here are the only things I found in this review that need to be addressed.

The spec file claims this package is covered under LGPLv2. The COPYING file is
for GPLv2, the single source file uses LGPLv2 in its header comment. - I'm not
a lawyer, I don't know how to sort this one (generally we include the COPYING
file in the docs directory). Spot can probably clarify.

I can't find the upstream source tarball for this. Can the full URL be added to
the spec file.

Otherwise it looked good. The full report is attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=W1RJ7sFAMia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275



--- Comment #6 from Vivek Goyal vgo...@redhat.com ---
(In reply to Christopher Meng from comment #4)
 Where does your source come from?
 
 I can only see 0.2...
 
 http://sourceforge.net/projects/linux-ima/files/ima-evm-utils/

Maintainer has released 0.6 yesterday but for some reason URL of that tar file
is not showing up at sourceforge. Even maintainer is confused. When he logs in
he can see the file there and it says URL will show up shortly and it has been
close to 24 hours and URL is not showing yet.

He sent me tar file in mail personally and that's what I used for this source
rpm.

I will ping him again and see if he can do something to make situation better.

BTW, git tree for this source is here and there one can see that version 0.6
has been released.

http://sourceforge.net/p/linux-ima/ima-evm-utils/ci/master/tree/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gVT78i8lXVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275



--- Comment #7 from Vivek Goyal vgo...@redhat.com ---
(In reply to Josh Bressers from comment #5)
 
 The spec file claims this package is covered under LGPLv2. The COPYING file
 is for GPLv2, the single source file uses LGPLv2 in its header comment. -
 I'm not a lawyer, I don't know how to sort this one (generally we include
 the COPYING file in the docs directory). Spot can probably clarify.

Thanks Josh. This is a good point. I have sent mail to upstream maintainer for
clarification in this matter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=guheAtVGRXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Dan Horák d...@danny.cz changed:

   What|Removed |Added

 CC||d...@danny.cz



--- Comment #8 from Dan Horák d...@danny.cz ---
re licensing - please see
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
and https://fedoraproject.org/wiki/Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=WHsTCaX7D0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Vivek Goyal vgo...@redhat.com changed:

   What|Removed |Added

 Blocks||998565



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EcS9K7Gfsya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Vivek Goyal vgo...@redhat.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=8kq9jjHwDHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275



--- Comment #1 from Vivek Goyal vgo...@redhat.com ---
Here is rpmlint report.

$ rpmlint ima-evm-utils.spec ../RPMS/*/ima-evm-utils*.rpm
../SRPMS/ima-evm-utils*.rpm
ima-evm-utils.spec: W: invalid-url Source0: ima-evm-utils-0.6.tar.gz
ima-evm-utils.x86_64: W: spelling-error %description -l en_US executables -
executable, executable s, executrices
ima-evm-utils.x86_64: W: no-manual-page-for-binary evmctl
ima-evm-utils.src: W: spelling-error %description -l en_US executables -
executable, executable s, executrices
ima-evm-utils.src: W: invalid-url Source0: ima-evm-utils-0.6.tar.gz
3 packages and 1 specfiles checked; 0 errors, 5 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aZCaWJuUdKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275



--- Comment #2 from Paul Wouters pwout...@redhat.com ---
I will sponsor Vivek, but  as I started this package review originally, I will
let someone else formally review it (though I'll review it as well)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HPS36n493Ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Josh Bressers bress...@redhat.com changed:

   What|Removed |Added

 CC||bress...@redhat.com
   Assignee|nob...@fedoraproject.org|bress...@redhat.com



--- Comment #3 from Josh Bressers bress...@redhat.com ---
I can do the review. I'm taking the bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=E0bpMBLiqwa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |
 CC||cicku...@gmail.com



--- Comment #4 from Christopher Meng cicku...@gmail.com ---
Where does your source come from?

I can only see 0.2...

http://sourceforge.net/projects/linux-ima/files/ima-evm-utils/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gmRjDiRwnva=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002275] Review Request: ima-evm-utils - IMA/EVM Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1002275

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

 CC||ke...@scrye.com,
   ||package-review@lists.fedora
   ||project.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DNmnnOnHXka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review