[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||eclipse-pdt-3.3.0-3.fc20 Resolution|--- |ERRATA Last Closed||2014-07-07 21:02:44 --- Comment #38 from Fedora Update System upda...@fedoraproject.org --- eclipse-pdt-3.3.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #36 from Fedora Update System upda...@fedoraproject.org --- eclipse-pdt-3.3.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/eclipse-pdt-3.3.0-3.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #37 from Fedora Update System upda...@fedoraproject.org --- eclipse-pdt-3.3.0-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #32 from Mat Booth mat.bo...@redhat.com --- Done: Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt.spec SRPM URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt-3.3.0-3.fc20.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #33 from Alexander Kurtakov akurt...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
x ]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 2439 files have unknown license. Detailed output
of licensecheck in /home/akurtakov/tmp/1003188-eclipse-
pdt/licensecheck.txt
Manually checked and licensecheck seems to count EPL as unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
Maven:
[-]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in eclipse-
pdt-tests
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Mat Booth mat.bo...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #34 from Mat Booth mat.bo...@redhat.com --- New Package SCM Request === Package Name: eclipse-pdt Short Description: PHP Development Tools (PDT) Eclipse plugin Upstream URL: http://www.eclipse.org/pdt/ Owners: mbooth Branches: f20 InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #35 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #31 from Alexander Kurtakov akurt...@redhat.com --- Latest tycho in F20 is aware of eclipse-license, please verify and drop the lines dealing with it from the spec. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #28 from Julien Enselme juj...@jujens.eu --- With the new version all the tests pass and the plugin seems to work fine on my system. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #29 from Alex Villacís Lasso a_villa...@palosanto.com --- I have just tested the 3.3.0-2 version. All files with a .php extension are recognized correctly. However, my projects have lots of PHP files that do not have a .php extension, such as reconfigure-foo. These files are meant to be run from the command line and have PHP as a script interpreter. These files are initially not associated with any specialized editor. If I force the use of the PHP editor with such a file, a popup appear that states that the content type is not supported by the editor, and should be manually associated. After this, the file is opened with the default text editor, with no syntax highlighting or anything. This is the wrong behavior. If the user specified the PHP editor for the file, the plugin should just attempt to open the file with the PHP editor, no questions asked. This is the behavior of other language plugins in the system. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #30 from Mat Booth mat.bo...@redhat.com --- Thanks to you both for the feedback! :-) Alex for your problem with extension-less files, a separate bug should be filed for this -- I believe fixing it would be out of scope of this package review. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #25 from Mat Booth mat.bo...@redhat.com --- Upstream have tagged a new release, I will update this package review shortly. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #26 from Mat Booth mat.bo...@redhat.com --- Changes: * Updated to latest upstream release * Pre-generate the lexer/parser source Pre-generating the source with upstream's preferred version of jflex works around the incompatibilities between that jflex and the jflex packaged in fedora. All the previously failing tests now pass. Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt.spec SRPM URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt-3.3.0-1.fc21.src.rpm Here is a rawhide/F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7047605 Alex Villacís Lasso, Julien Enselme, Tim Flubshi -- If possible please test the above build. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #27 from Mat Booth mat.bo...@redhat.com --- Changes: * Now also builds on F20. Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt.spec SRPM URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt-3.3.0-2.fc21.src.rpm Here is a F20 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=7047896 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 flub...@web.de changed: What|Removed |Added CC||flub...@web.de --- Comment #24 from flub...@web.de --- I'm also interested in getting pdt in the official Fedora repos. Whats the current status? Can I help? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Julien Enselme juj...@jujens.eu changed: What|Removed |Added CC||juj...@jujens.eu --- Comment #22 from Julien Enselme juj...@jujens.eu --- Created attachment 886796 -- https://bugzilla.redhat.com/attachment.cgi?id=886796action=edit Test results output -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #23 from Julien Enselme juj...@jujens.eu --- When I try to build this package with mock, some tests fail: [ERROR] [ERROR] Please refer to /builddir/build/BUILD/org.eclipse.pdt-0be0c8386e0e840af876f895a543205942c88f86/tests/org.eclipse.php.core.tests/target/surefire-reports for the individ\ ual test results. [ERROR] - [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn goals -rf :org.eclipse.php.core.tests View attachment for more infos. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #21 from relaxc...@gmail.com --- What is the status of this package and the tests ? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #19 from Mat Booth fed...@matbooth.co.uk --- Alex Villacís Lasso, it seems to be my patches at fault. I previously was not running the integration tests due to them requiring an X display. Now I have got them running I see that some parser tests fail when I apply the patches to make it use the system jflex/java_cup. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #20 from Mat Booth fed...@matbooth.co.uk --- I have updated the SPEC file to run the integration tests. The problems seen by Alex Lasso above are now highlighted by test failures. I don't think this should block the review of the SPEC file, because the fix will only change the patches. Unfortunately patches are necessary due to rules on bundling libs, so I obviously won't push a build until all the tests pass. If you want to force a local build of this SPEC to succeed, you can change clean verify to clean package in the call to mvn. Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt.spec SRPM URL: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt-3.2.0-3.git0be0c838.fc20.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Nitin Dahyabhai nit...@us.ibm.com changed: What|Removed |Added CC||nit...@us.ibm.com --- Comment #15 from Nitin Dahyabhai nit...@us.ibm.com --- (In reply to Mat Booth from comment #9) Hmm, F20 wasn't released yet when I submitted this review. It seems to build, install and work fine on F19, but I will try on a F20 VM to see if I can reproduce your problem. Thanks for giving it a try :-) Alexander Kurtakov: The Git SHA is what I could determine to be the SHA of the 3.2.0 release as unfortunately upstream has not tagged any recent releases. Which releases are missing tags? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #16 from Mat Booth fed...@matbooth.co.uk --- (In reply to Nitin Dahyabhai from comment #15) Which releases are missing tags? Hi Nitin, 3.2.0 seems to be available for download from http://www.eclipse.org/pdt/downloads/ but I do not see a corresponding tag in git at http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/refs/tags -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #17 from Nitin Dahyabhai nit...@us.ibm.com --- Opened http://bugs.eclipse.org/429477 . -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #18 from Mat Booth fed...@matbooth.co.uk --- Nice one, thanks. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #14 from Mat Booth fed...@matbooth.co.uk --- Thanks for attaching a test-case Alex, I can reproduce your problem with that. It looks like a problem with PDT, nothing to do with PHPEclipse. I will look into it. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #11 from Alex Villacís Lasso a_villa...@palosanto.com --- I have built and installed the updated package. These are the results: When creating a brand new project on a existing directory that has never before been used for an phpeclipse project, eclipse-pdt works correctly and can open the files. When attempting to open a phpeclipse project with eclipse-pdt, the previously-reported backtrace appears. Removing the phpeclipse project and re-creating it under the same directory does NOT remove the backtrace problem. This situation makes migration to eclipse-pdt very difficult. All tests were done on Fedora 20 x86_64 with latest system updates. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #12 from Alex Villacís Lasso a_villa...@palosanto.com --- The previous comment is partially incorrect. I cleared out the .eclipse and workspace directories to simulate a clean setup. I then created a new eclipse-pdt project with an existing project, and it also triggered the backtrace. The only difference I can see is that the directory is versioned under CVS, and the other directory (that did not trigger the backtrace) is unversioned. However, I have seen the backtrace with SVN versioned projects too. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #13 from Alex Villacís Lasso a_villa...@palosanto.com --- Created attachment 863902 -- https://bugzilla.redhat.com/attachment.cgi?id=863902action=edit Small PHP project that triggers the bug PHP project directory that triggers the backtrace. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #9 from Mat Booth fed...@matbooth.co.uk --- Hmm, F20 wasn't released yet when I submitted this review. It seems to build, install and work fine on F19, but I will try on a F20 VM to see if I can reproduce your problem. Thanks for giving it a try :-) Alexander Kurtakov: The Git SHA is what I could determine to be the SHA of the 3.2.0 release as unfortunately upstream has not tagged any recent releases. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #10 from Mat Booth fed...@matbooth.co.uk --- I have updated the package to a post-release snapshot version of what is currently the head of upstream's master branch. This version includes support for PHP 5.5 and proper Eclipse = 4.3 support: http://fedorapeople.org/~mbooth/reviews/eclipse-pdt.spec http://fedorapeople.org/~mbooth/reviews/eclipse-pdt-3.2.0-2.git0be0c838.fc19.src.rpm I have built and installed this on both F19 and F20 machines and I can start Eclipse and create a PHP project and open some PHP files, both trivial examples and some I got from some random PHP projects on Github. This seems to work for me, please Alex give this new SRPM a try. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #8 from Alex Villacís Lasso a_villa...@palosanto.com --- (In reply to Alexander Kurtakov from comment #7) Alex, does it happen for every file? The build process creates eclipse-pdt, eclipse-pdt-mylyn, eclipse-pdt-sdk, and eclipse-pdt-tests. I only installed eclipse-pdt for the tests. I opened an existing project that used phpeclipse, the legacy plugin for PHP. All of the PHP files trigger the error. If neither phpeclipse nor pdt are installed, the same project uses the default text editor for PHP files (without syntax highlighting). Even in new project with helloworld kind of file? Not tested. I have to test that. I'm trying to understand whether this is an upstream bug or packaging issue. Mat, how did you decided on the git sha to download? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #7 from Alexander Kurtakov akurt...@redhat.com --- Alex, does it happen for every file? Even in new project with helloworld kind of file? I'm trying to understand whether this is an upstream bug or packaging issue. Mat, how did you decided on the git sha to download? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #6 from Alex Villacís Lasso a_villa...@palosanto.com --- I built the linked SRPM under Fedora 20 with latest updates as of 2014-01-20. When installing and trying to open a PHP file in a project, I get this backtrace: java.lang.IllegalArgumentException: Overlapping start in StyleRange 2:1 at org.eclipse.php.internal.ui.editor.configuration.PresentationCollector.add(PresentationCollector.java:35) at org.eclipse.php.internal.ui.editor.highlighter.LineStyleProviderForPhp.prepareTextRegions(LineStyleProviderForPhp.java:610) at org.eclipse.php.internal.ui.editor.highlighter.LineStyleProviderForPhp.prepareRegions(LineStyleProviderForPhp.java:466) at org.eclipse.php.internal.ui.editor.configuration.StructuredDocumentDamagerRepairer.createPresentation(StructuredDocumentDamagerRepairer.java:80) at org.eclipse.php.internal.ui.editor.configuration.PHPStructuredPresentationReconciler.createPresentation(PHPStructuredPresentationReconciler.java:352) at org.eclipse.wst.sse.ui.internal.provisional.style.StructuredPresentationReconciler.processDamage(StructuredPresentationReconciler.java:870) at org.eclipse.wst.sse.ui.internal.provisional.style.StructuredPresentationReconciler$InternalListener.inputDocumentChanged(StructuredPresentationReconciler.java:271) at org.eclipse.wst.sse.ui.internal.provisional.style.StructuredPresentationReconciler.install(StructuredPresentationReconciler.java:600) at org.eclipse.wst.sse.ui.internal.StructuredTextViewer.updateHighlighter(StructuredTextViewer.java:987) at org.eclipse.wst.sse.ui.internal.StructuredTextViewer.setDocument(StructuredTextViewer.java:865) at org.eclipse.php.internal.ui.editor.PHPStructuredTextViewer.setDocument(PHPStructuredTextViewer.java:645) at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java:590) at org.eclipse.ui.texteditor.AbstractTextEditor.initializeSourceViewer(AbstractTextEditor.java:4047) at org.eclipse.ui.texteditor.AbstractTextEditor.createPartControl(AbstractTextEditor.java:3575) at org.eclipse.ui.texteditor.StatusTextEditor.createPartControl(StatusTextEditor.java:54) at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.createPartControl(AbstractDecoratedTextEditor.java:447) at org.eclipse.wst.sse.ui.StructuredTextEditor.createPartControl(StructuredTextEditor.java:1516) at org.eclipse.php.internal.ui.editor.PHPStructuredEditor.createPartControl(PHPStructuredEditor.java:2265) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:142) at org.eclipse.ui.internal.e4.compatibility.CompatibilityEditor.createPartControl(CompatibilityEditor.java:96) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:323) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56) at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:877) at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:857) at org.eclipse.e4.core.internal.di.InjectorImpl.inject(InjectorImpl.java:119) at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:333) at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:254) at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:162) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:102) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:71) at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:53) at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(ContributedPartRenderer.java:129) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:949) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:633) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:735) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$2(PartRenderingEngine.java:706) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$7.run(PartRenderingEngine.java:700) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:685)
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com Assignee|nob...@fedoraproject.org|akurt...@redhat.com --- Comment #5 from Alexander Kurtakov akurt...@redhat.com --- I would review this one. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #4 from Mat Booth fed...@matbooth.co.uk --- Indeed. Once this package is reviewed, it will be the replacement for eclipse-phpeclipse. Don't forget you can still perform a package review even if you are not yet a Fedora contributor -- it's a good way to demonstrate your understanding of RPM and the packaging guidelines :-) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Alex Villacís Lasso a_villa...@palosanto.com changed: What|Removed |Added CC||a_villa...@palosanto.com --- Comment #3 from Alex Villacís Lasso a_villa...@palosanto.com --- What is the status of this package? According to #903830, the package eclipse-phpeclipse is obsolete. However, there is no replacement in the Fedora 19 repositories. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Mat Booth fed...@matbooth.co.uk changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Mat Booth fed...@matbooth.co.uk --- (In reply to Mat Booth from comment #1) Scratch build in progress: https://koji.fedoraproject.org/koji/taskinfo?taskID=5877033 That build hung on arm for some reason, here's one that actually completed: https://koji.fedoraproject.org/koji/taskinfo?taskID=5877949 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DHJw7871y7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 --- Comment #1 from Mat Booth fed...@matbooth.co.uk --- Scratch build in progress: https://koji.fedoraproject.org/koji/taskinfo?taskID=5877033 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lNcoHwcGkAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
