[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 Juan Hernández juan.hernan...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Juan Hernández juan.hernan...@redhat.com --- New Package SCM Request === Package Name: ovirt-engine-sdk-python Short Description: oVirt Engine Software Development Kit (Python) Owners: jhernand oschreib Branches: f18 f19 f20 el6 InitialCC: mpastern -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PwLnGMw8TGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- SCM request and review summary name don't match, please correct. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=irjQ7wBOA5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QBDRc7tESHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Christopher Meng cicku...@gmail.com --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WOj82rkhd5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||bugs.mich...@gmx.net
Summary|Review Request: |Rename Request:
|ovirt-engine-sdk - oVirt|ovirt-engine-sdk - oVirt
|Engine Software Development |Engine Software Development
|Kit (Python)|Kit (Python)
Flags||needinfo?(bugs.michael@gmx.
||net)
--- Comment #4 from Christopher Meng cicku...@gmail.com ---
Issue:
0-1. From your Koji scratch build:
warning: File listed twice: /usr/lib/python2.7/site-packages/ovirtsdk
0-2. ovirt-engine-sdk-python.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/ovirtsdk/xml/params.py 0644L /usr/bin/env
This file has env shebang but it's 644 perms.
Suggestion before importing:
1. %doc AUTHORS
%doc README
%doc LICENSE
can be
%doc AUTHORS LICENSE README
2. I lifted needinfo to Michael(he has sent many emails about this recently to
list) to see if your
Provides: ovirt-engine-sdk = %{version}
Obsoletes: ovirt-engine-sdk 3.3.0.0
are correct or not.
Since it's a rename request, and I've finished fedora-review running, I think
there is no problem now.
Only need info from Michael.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TwBMpOofLIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029 --- Comment #5 from Juan Hernández juan.hernan...@redhat.com --- Fixed the issues with duplicated files and with the shebang and also applied your suggestion about the %doc: Spec URL: http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-3/ovirt-engine-sdk-python.spec SRPM URL: http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-3/ovirt-engine-sdk-python-3.3.0.6-3.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5892987 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kfUmi9kFDla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029
--- Comment #6 from Michael Schwendt bugs.mich...@gmx.net ---
Well, the renaming guidelines aren't too difficult:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages
[...]
Latest build in koji of the package to be replaced is:
ovirt-engine-sdk.noarch 3.2.0.11-2.fc20
Pick anything that's higher than 3.2.0.11-2.fc20. For example:
Obsoletes: ovirt-engine-sdk 3.2.0.11-3
or
Obsoletes: ovirt-engine-sdk 3.2.0.12
or since this renamed package is at version 3.3.0.6:
Obsoletes: ovirt-engine-sdk 3.3.0.6
The important thing to understand here is that as long as the Obsoletes tag
is present in any available package (whether installed or in the repos), it
blocks package ovirt-engine-sdk from returning with a version that's too low.
However, ovirt-engine-sdk may return with a higher version, e.g. 3.4 or
3.3.0.7, basically anything that's higher than what's specified in the
Obsoletes tag. A package may be renamed once more or return with different
contents. That's why we prefer blocking obsolete packages with no more than
their last published version.
Even if it's unlikely that ovirt-engine-sdk returns ever, doing it right (and
accurate) doesn't hurt anyone, does it?
Occasionally, the accuracy really helps. Simple scenarios like: foo-libs
obsoleted by libfoo from a separate src.rpm, some time later foo.src.rpm builds
a new foo-libs package for newly added libs. Pray that libfoo doesn't also
obsolete the new foo-libs package EVR. Or vice versa: libfoo obsoleted by and
merged into foo-libs, some time later a different project uses the libfoo name
for something else.
Provides: ovirt-engine-sdk = %{version}
The guidelines want -%{release} to be added to be as accurate as normal
packages.
[...]
Name: ovirt-engine-sdk-python
I'm really bad at these naming guidelines things. Since this is a Python
module,
shouldn't it be named
python-ovirt-engine-sdk
to satisfy the %parent-%child relationship guidelines for Python add-on
packages?
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=61aMcB2Kqia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004029] Rename Request: ovirt-engine-sdk - oVirt Engine Software Development Kit (Python)
https://bugzilla.redhat.com/show_bug.cgi?id=1004029
--- Comment #7 from Juan Hernández juan.hernan...@redhat.com ---
Michael, if I understand correctly your suggestion is to do this:
Provides: ovirt-engine-sdk = %{version}-%{release}
Obsoletes: ovirt-engine-sdk 3.3.0.6
I updated the spec accordingly:
Spec URL:
http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-4/ovirt-engine-sdk-python.spec
SRPM URL:
http://jhernand.fedorapeople.org/rpms/ovirt-engine-sdk-python/3.3.0.6-4/ovirt-engine-sdk-python-3.3.0.6-4.fc19.src.rpm
Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5893157
Regarding the name with the python- prefix or -python suffix: I really don't
have a preference. But the upstream project already provides the .spec and the
binary packages in their own yum repository, and they have decided to to go
with the -python suffix. I would rather respect their decision and use the same
name, even if it doesn't match perfectly the naming guidelines. If we use a
different name in Fedora then there will be issues and confusion for the users.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JKMEfdCptCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
