[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #28 from Christopher Meng i...@cicku.me --- Package Change Request == Package Name: python-SecretStorage New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-SecretStorage-1.1.0- |python-SecretStorage-1.1.0- |1.fc19 |1.fc20 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- python-SecretStorage-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||python-SecretStorage-1.1.0- ||1.fc19 Resolution|--- |ERRATA Last Closed||2013-11-26 23:38:05 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- python-SecretStorage-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #23 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- python-SecretStorage-1.1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-SecretStorage-1.1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- python-SecretStorage-1.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-SecretStorage-1.1.0-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #20 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: python-SecretStorage Short Description: Python module for secure storing of passwords and secrets Owners: cicku Branches: f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #21 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: python-SecretStorage Short Description: Python module for secure storing of passwords and secrets Owners: cicku Branches: f20 f19 f18 el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #22 from Christopher Meng cicku...@gmail.com --- Something wrong with my browser yesterday. New Package SCM Request === Package Name: python-SecretStorage Short Description: Python module for secure storing of passwords and secrets Owners: cicku Branches: f20 f19 f18 el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||needinfo?(mario.blaetterman ||n...@gmail.com) --- Comment #18 from Christopher Meng cicku...@gmail.com --- Sorry for using needinfo, I'm really annoyed now by making user experience worse and worse. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|needinfo?(mario.blaetterman |
|n...@gmail.com)|
--- Comment #19 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6214374
$ rpmlint -i -v *
python3-SecretStorage.noarch: I: checking
python3-SecretStorage.noarch: I: checking-url
http://launchpad.net/python-secretstorage (timeout 10 seconds)
python-SecretStorage.noarch: I: checking
python-SecretStorage.noarch: I: checking-url
http://launchpad.net/python-secretstorage (timeout 10 seconds)
python-SecretStorage.src: I: checking
python-SecretStorage.src: I: checking-url
http://launchpad.net/python-secretstorage (timeout 10 seconds)
python-SecretStorage.src:101: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:101: W: macro-in-comment %{python2_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:101: W: macro-in-comment %{python2_version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:103: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:104: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:104: W: macro-in-comment %{python3_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src:104: W: macro-in-comment %{python3_version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.src: W: invalid-url Source0:
python-secretstorage-bzr83.tgz
The value should be a valid, public HTTP, HTTPS, or FTP URL.
python-SecretStorage-doc.noarch: I: checking
python-SecretStorage-doc.noarch: I: checking-url
http://launchpad.net/python-secretstorage (timeout 10 seconds)
python-SecretStorage.spec:101: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:101: W: macro-in-comment %{python2_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:101: W: macro-in-comment %{python2_version}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:103: W: macro-in-comment %{py3dir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:104: W: macro-in-comment %{buildroot}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:104: W: macro-in-comment %{python3_sitelib}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
python-SecretStorage.spec:104: W: macro-in-comment %{python3_version}
There is a unescaped macro after a shell
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #17 from Christopher Meng cicku...@gmail.com --- PING! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #15 from Christopher Meng cicku...@gmail.com ---
(In reply to Björn besser82 Esser from comment #14)
(In reply to Mario Blättermann from comment #13)
The test suite expects a running X server and a valid display number. As far
as I can evaluate, the tests will fail again and again because a Koji server
doesn't have the ability to start an X server. So we should disable the
tests for now.
One actually can start a framebuffer-based x-server on koji ;)
BuildRequires: xorg-x11-server-Xvfb
...
%check
xvfb-run -a %{your_testsuite_cmd}
Cheers,
Björn
BR added.
Still failed.
Using:
%check
pushd tests
PYTHONPATH=%{buildroot}%{python2_sitelib} xvfb-run -a
nosetests-%{python2_version}
popd
pushd %{py3dir}
PYTHONPATH=%{buildroot}%{python3_sitelib} xvfb-run -a
nosetests-%{python3_version}
popd
http://koji.fedoraproject.org/koji/taskinfo?taskID=6204843
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #16 from Christopher Meng cicku...@gmail.com --- Disable tests, I don't have patience to wait and let many users not able to use backintime: Spec URL: http://cicku.me/python-SecretStorage.spec SRPM URL: http://cicku.me/python-SecretStorage-1.0.0-0.3.bzr83.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #12 from Christopher Meng cicku...@gmail.com --- ---Upstream latest reply--- I'm going to rewrite the test suite to use the (real) Secret Service daemon written in C++. Unfortunately that code won't go into mainline branch of secretstorage. ---Upstream latest reply--- Spec URL: http://cicku.me/python-SecretStorage.spec SRPM URL: http://cicku.me/python-SecretStorage-1.0.0-0.3.bzr83.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #13 from Mario Blättermann mario.blaetterm...@gmail.com --- New scratch build fails again: http://koji.fedoraproject.org/koji/taskinfo?taskID=6199437 From build.log: ERROR: test suite for class 'test_collection.CollectionTest' -- Traceback (most recent call last): File /usr/lib/python2.7/site-packages/nose/suite.py, line 208, in run self.setUp() File /usr/lib/python2.7/site-packages/nose/suite.py, line 291, in setUp self.setupContext(ancestor) File /usr/lib/python2.7/site-packages/nose/suite.py, line 314, in setupContext try_run(context, names) File /usr/lib/python2.7/site-packages/nose/util.py, line 469, in try_run return func() File /builddir/build/BUILD/python-secretstorage-bzr83/tests/test_collection.py, line 16, in setUpClass cls.bus = dbus_init(main_loop=False) File /builddir/build/BUILDROOT/python-SecretStorage-1.0.0-0.3.bzr83.fc21.noarch/usr/lib/python2.7/site-packages/secretstorage/__init__.py, line 51, in dbus_init e.get_dbus_message()) SecretServiceNotAvailableException: Unable to autolaunch a dbus-daemon without a $DISPLAY for X11 The test suite expects a running X server and a valid display number. As far as I can evaluate, the tests will fail again and again because a Koji server doesn't have the ability to start an X server. So we should disable the tests for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #14 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Mario Blättermann from comment #13)
The test suite expects a running X server and a valid display number. As far
as I can evaluate, the tests will fail again and again because a Koji server
doesn't have the ability to start an X server. So we should disable the
tests for now.
One actually can start a framebuffer-based x-server on koji ;)
BuildRequires: xorg-x11-server-Xvfb
...
%check
xvfb-run -a %{your_testsuite_cmd}
Cheers,
Björn
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #11 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=6193993 From root.log: DEBUG util.py:266: Updating / installing... DEBUG util.py:266: python-SecretStorage-1.0.0-0.2.bzr83.f DEBUG util.py:266: warning: user rpmaker does not exist - using root DEBUG util.py:266: warning: group rpmaker does not exist - using root DEBUG util.py:266: error: unpacking of archive failed on file /builddir/build/SPECS/python-SecretStorage.spec;528a370c: cpio: Digest mismatch DEBUG util.py:266: error: /builddir/build/originals/python-SecretStorage-1.0.0-0.2.bzr83.fc21.src.rpm cannot be installed There's something wrong with the srpm, although I was able to unpack it locally. Moreover, the -doc package still misses a license. It is independent from the main package, which is OK because reading docs is independent from the Python module installed. But then the docs lacks a license declaration. Read comment #8 once again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bjoern.es...@gmail.com |nob...@fedoraproject.org Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #10 from Christopher Meng cicku...@gmail.com --- Just find the best way of mine to handle snapshot packages, so new here: Spec URL: http://cicku.me/python-SecretStorage.spec SRPM URL: http://cicku.me/python-SecretStorage-1.0.0-0.2.bzr83.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #6 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Christopher Meng from comment #5)
(In reply to Björn besser82 Esser from comment #4)
[!]: License file installed when any subpackage combination is installed.
--- License is missing in -doc. The -doc sub-pkg should have
`%doc changelog LICENSE README build/sphinx/html` (without that
'/*' suffixed) instead of `%doc build/sphinx/html/*`. So it
will pick-up all docs carry a html-subdir.
I'm sorry, but I don't agree.
I think doc package should only contains docs, but no need to ship changelog
LICENSE README anymore. Besides I think keeping /* will let users enter the
dir and see docs immediately but not enter a html folder again.
Ain't changelog, license, readme docs, are they? I usually _strongly
recommend_ to add them to -doc. And for that reason finding them between a
kazillion other files is extremely hard, I recommend keeping html-doc in a
html-subdir...
[!]: %check is present and all tests pass.
--- there is a tests-subdir in tarball. You should BR:
python-nose, python3-nose and run the corresponding
`nosetests` within %check.
Because tests will fail to test.
1. Simply use
nosetests-%{python_version}
Failed because ImportError: No module named secretstorage
2. Then I did a tricks:
PYTHONPATH=%{buildroot}%{python_sitelib} nosetests-%{python_version}
This time real failures are coming:
--
Ran 7 tests in 0.893s
FAILED (errors=5)
error: Bad exit status from /var/tmp/rpm-tmp.NGiSNR (%check)
--
Also my computer's keyring unlock window bumped out and asked my password.
So I didn't add tests.
Did you ask upstream about that? Failing test are usually _really_ bad. :(
I will listen to your new opinions and then upload a new version.
There you go. :D
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added External Bug ID||Launchpad 1243622 --- Comment #7 from Christopher Meng cicku...@gmail.com --- (In reply to Björn besser82 Esser from comment #6) Ain't changelog, license, readme docs, are they? I usually _strongly recommend_ to add them to -doc. And for that reason finding them between a kazillion other files is extremely hard, I recommend keeping html-doc in a html-subdir... No, IMHO -doc should contains docs about software itself but not package itself. Well, if I add changelog, license and readme as docs, of course I will use html but not html/* ;) But now I need some proven people to tell me whether the opinion is true or false... Did you ask upstream about that? Failing test are usually _really_ bad. :( Externel bug tracker added. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #8 from Michael Schwendt bugs.mich...@gmx.net --- Whether to include the license file in the -doc package boils down to: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing That way the licensing terms are distributed with each individual piece of the software as shipped by Fedora. I also find it worthwhile to include the other few %doc files, so somebody who examines just the -doc package can find all documentation in it. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #9 from Björn besser82 Esser bjoern.es...@gmail.com --- Just got that by pm: Please take a look at mail below, maybe I have to disable tests for a while(I can't wait as backintime pulls in this dependency and I've pushed the updates...). Thanks. -- Forwarded message -- From: Dmitry Shachnev mity...@gmail.com Date: Oct 23, 2013 6:25 PM Subject: [Bug 1243622] Re: Tests failed with locked collection To: cicku...@gmail.com Cc: Thanks for packaging it for Fedora! The current trunk in lp:secretstorage (I'm going to release 1.1 in the next couple of weeks) contains a secretservice_mock.py file which allows you to export USE_SS_MOCK=1 and then the tests will pass even if there is no SecretService daemon running. However, when you want to test it against a real-life implementation (i.e. GNOME Keyring), you should make sure it is running and the keyring is unlocked. -- You received this bug notification because you are subscribed to the bug report. https://bugs.launchpad.net/bugs/1243622 # So my recommendation would be to update to latest prerelease-bzr-snapshot and let's see testsuite passes on this... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Susi Lehtola susi.leht...@iki.fi changed: What|Removed |Added CC||susi.leht...@iki.fi Severity|urgent |medium -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||1014976 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1014976 [Bug 1014976] [abrt] backintime-kde-1.0.26-2.fc19: app.py:259:__init__:TypeError: KDirModel.removeColumns() is a private method -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? --- Comment #1 from Björn besser82 Esser bjoern.es...@gmail.com --- taken ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #2 from Björn besser82 Esser bjoern.es...@gmail.com ---
Created attachment 815008
-- https://bugzilla.redhat.com/attachment.cgi?id=815008action=edit
build.log -- FTBFS on rawhide
FTBFS on rawhide!!! :( It seems rpmbuild complains about non-existing files,
when creating rpm(s) from %{buildroot}...
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Fixed, forgot to mark it as noarch. Same URL again. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #4 from Björn besser82 Esser bjoern.es...@gmail.com ---
= Review report for python-SecretStorage-1.0.0-1 =
Package has issues. :(
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 12 files have unknown license. Detailed output of
licensecheck in /home/besser82/shared/fedora/review/1021733-python-
SecretStorage/licensecheck.txt
--- License-tag is fine. :)
[!]: License file installed when any subpackage combination is installed.
--- License is missing in -doc. The -doc sub-pkg should have
`%doc changelog LICENSE README build/sphinx/html` (without that
'/*' suffixed) instead of `%doc build/sphinx/html/*`. So it
will pick-up all docs carry a html-subdir.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 6 files.
[!]: Package complies to the Packaging Guidelines
--- issues are present.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-SecretStorage , python-SecretStorage-doc
--- not needed
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733
--- Comment #5 from Christopher Meng cicku...@gmail.com ---
(In reply to Björn besser82 Esser from comment #4)
[!]: License file installed when any subpackage combination is installed.
--- License is missing in -doc. The -doc sub-pkg should have
`%doc changelog LICENSE README build/sphinx/html` (without that
'/*' suffixed) instead of `%doc build/sphinx/html/*`. So it
will pick-up all docs carry a html-subdir.
I'm sorry, but I don't agree.
I think doc package should only contains docs, but no need to ship changelog
LICENSE README anymore. Besides I think keeping /* will let users enter the dir
and see docs immediately but not enter a html folder again.
[!]: %check is present and all tests pass.
--- there is a tests-subdir in tarball. You should BR:
python-nose, python3-nose and run the corresponding
`nosetests` within %check.
Because tests will fail to test.
1. Simply use
nosetests-%{python_version}
Failed because ImportError: No module named secretstorage
2. Then I did a tricks:
PYTHONPATH=%{buildroot}%{python_sitelib} nosetests-%{python_version}
This time real failures are coming:
---
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.NGiSNR
+ umask 022
+ cd /home/rpmaker/rpmbuild/BUILD
+ cd SecretStorage-1.0.0
+ pushd tests
~/rpmbuild/BUILD/SecretStorage-1.0.0/tests ~/rpmbuild/BUILD/SecretStorage-1.0.0
+
PYTHONPATH=/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages
+ nosetests-2.7
....E
==
ERROR: test_create_empty_item (test_collection.CollectionTest)
--
Traceback (most recent call last):
File
/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_collection.py,
line 28, in test_create_empty_item
item = self.collection.create_item('', {}, b'')
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py,
line 120, in create_item
self.ensure_not_locked()
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py,
line 55, in ensure_not_locked
raise LockedException('Collection is locked!')
LockedException: Collection is locked!
==
ERROR: test_label (test_collection.CollectionTest)
--
Traceback (most recent call last):
File
/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_collection.py,
line 33, in test_label
self.collection.set_label('Hello!')
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py,
line 109, in set_label
self.ensure_not_locked()
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py,
line 55, in ensure_not_locked
raise LockedException('Collection is locked!')
LockedException: Collection is locked!
==
ERROR: test suite for class 'test_compat_functions.CompatFunctionsTest'
--
Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/nose/suite.py, line 208, in run
self.setUp()
File /usr/lib/python2.7/site-packages/nose/suite.py, line 291, in setUp
self.setupContext(ancestor)
File /usr/lib/python2.7/site-packages/nose/suite.py, line 314, in
setupContext
try_run(context, names)
File /usr/lib/python2.7/site-packages/nose/util.py, line 469, in try_run
return func()
File
/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_compat_functions.py,
line 23, in setUpClass
ATTRIBUTES, PASSWORD)
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/__init__.py,
line 96, in create_item
collection.unlock()
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py,
line 70, in unlock
return exec_prompt_glib(self.bus, prompt)[0]
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/util.py,
line 85, in exec_prompt_glib
exec_prompt(bus, prompt, callback)
File
/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/util.py,
line 73, in exec_prompt
prompt_iface.connect_to_signal('Completed', new_callback)
File /usr/lib/python2.7/site-packages/dbus/proxies.py, line 544, in
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks||1021192 Severity|medium |urgent Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1021192 [Bug 1021192] backintime-1.0.28 is available -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
