[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #29 from Fedora Update System  ---
hans-1.0-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-08 21:20:01



--- Comment #28 from Fedora Update System  ---
hans-1.0-3.fc26 has been pushed to the Fedora 26 stable repository. If problems
still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #27 from Pavel Alexeev  ---
Michal Ambroz thank you very much for the review. Hans eventually in Fedora.
Could I also review something for you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #26 from Fedora Update System  ---
hans-1.0-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab6f36271b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #25 from Fedora Update System  ---
hans-1.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-289180fc05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #24 from Fedora Update System  ---
hans-1.0-3.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-289180fc05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #23 from Fedora Update System  ---
hans-1.0-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ab6f36271b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #21 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #22 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #20 from Pavel Alexeev  ---
Sorry for the delay.
Repo requested https://pagure.io/releng/fedora-scm-requests/issue/23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #19 from Michal Ambroz  ---
Ping Pavel?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Michal Ambroz  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Michal Ambroz  ---
Hello Pavel,
perfect - tested the package and it won't start if password was not changed.
Good.

Please there are some minor typos in the changelog.


Other than that - free to go.
Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #17 from Pavel Alexeev  ---
Ok, I introduce separate variable PASSWORD and add implicit check.

Changes:
https://github.com/Hubbitus/rpm-hans/commit/cf15bd1572a6eba488a8462c5dcdc3f0d466f5fd
Spec:
https://raw.githubusercontent.com/Hubbitus/rpm-hans/cf15bd1572a6eba488a8462c5dcdc3f0d466f5fd/hans.spec
Srpm: http://rpm.hubbitus.info/Fedora25/hans/hans-1.0-3.fc27.src.rpm
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19356749

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #16 from Michal Ambroz  ---
Hello Pavel,
I still see a password in the config, just this time it is literally
"" as a password. Or am I missing something?

You know - things like Mirai are spreading because of default passwords.

Mik.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #15 from Pavel Alexeev  ---
Michal Ambroz do you plan answer and continue? I think all found by you issues
resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #14 from Pavel Alexeev  ---
Michal ping

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Pavel Alexeev  changed:

   What|Removed |Added

  Flags|needinfo?(pa...@hubbitus.in |
   |fo) |



--- Comment #13 from Pavel Alexeev  ---
Honestly, I do not see problem there. If you must change IP address before it
start to work you will see password in same line of config to be able change
it.

Meantime if you insist I change it to  placeholder and add line of
note to require user set it.

Other issues also should be addressed.

Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/e568e5469e069e8dd0ade1f5454deb30a7a1deb3
Spec:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/e568e5469e069e8dd0ade1f5454deb30a7a1deb3/SPECS/hans.spec
Srpm: http://rpm.hubbitus.info/Fedora25/hans/hans-1.0-2.fc26.src.rpm
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17375774

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Michal Ambroz  changed:

   What|Removed |Added

 CC||pa...@hubbitus.info
  Flags||needinfo?(pa...@hubbitus.in
   ||fo)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #12 from Michal Ambroz  ---
Still I believe that having the package in workable state with default password
of "password" or any other hardcoded password will results in many people
vulnerabe.

If you see this achivable it would be great if package wont start untill you
change the default password so something else.

Mik

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #11 from Michal Ambroz  ---

Package Review
==

Summary:
- please use the %{optflags}
- consider syncing the %pre and "%pre server" macros for user creation
- consider making the dependency of the client and server fully versioned


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
 GPLv3+
 sha1.cpp licensed with sha1_license.txt
 tunemu licensed with 2 clause BSD - compatible to be included in GPLv3+
project
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v2 or later)", "GPL (v3 or later)",
 "Unknown or generated". 7 files have unknown license. Detailed output
 of licensecheck in licensecheck.txt
[X]: License file installed when any subpackage combination is installed
 license included in the base has package, it is required from the
subpackages
[!]: %build honors applicable compiler flags or justifies otherwise.
 please use the %{optflags} such as 
 make %{?_smp_mflags} CFLAGS="%{optflags}"

[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[X ]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hans-
 client , hans-server , hans-debuginfo
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: 

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #10 from Michal Ambroz  ---
Yes ... the xmass frenzy is behind us I will be on it now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #9 from Pavel Alexeev  ---
@Michal, do you plan continue review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Michal Ambroz  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |re...@seznam.cz



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #8 from Michal Ambroz  ---
As there is no update from Christopher Meng for couple of years, I will take
over the package review.

Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #7 from Pavel Alexeev  ---
Michal thank you very much taking that.

Update to 1.0 and address most mentioned issues.

But what about password? I can't generate it in on build time, and as it in
just in options now can't handle "first run". Do you think it have worth move
it in some separate file and wrap into script checking it present??

Does it have worth? In any case you can't run it without administrator
configuration because forced to provide IP instead of placeholder .
Do you want I also replace `-p password` on something like `-p `?

Provided patch present in version 1.0 sources code.

Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/b96a43057e188def285881d8d47800e20b1a82ff
Spec:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/b96a43057e188def285881d8d47800e20b1a82ff/SPECS/hans.spec
Rpm: http://rpm.hubbitus.info/Fedora25/hans/hans-1.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #6 from Michal Ambroz  ---
One more bit - the LICENSE should go to separate %license tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #5 from Michal Ambroz  ---
Hello Pavel,
thaks for packaging hans. As Christopher Meng doesn't seem to be responding I
would like to take over the package review.
I have found the spec and sources on github, but the spec and srpm is not
available for download anymore. Claimed links do not download the files.


Generally package sees good to me and - just few coments:
- update to 0.4.4 
- I would recommend to change the source reference to 
https://github.com/friedrich/%{name}/archive/v%{version}.tar.gz#/hans-%{version}.tar.gz
so the source file is named hans-%{version}.tar.gz
- rpmlint reports that there is missing-call-to-setgroups-before-setuid
Will be fixed by this patch (https://github.com/friedrich/hans/issues/15)
- I would say it is dangerous having working default configuration. I would
recommend generating random password with first use - something like server key
for the ssh.
- fix typos sulution->solution, dinamic->dynamic (hans-client.sysconfig)

Other issues from rpmlint seems to be minors.
$ rpmlint SRPMS/hans-0.4.4-1.fc24.src.rpm
RPMS/x86_64/hans-0.4.4-1.fc24.x86_64.rpm
RPMS/x86_64/hans-client-0.4.4-1.fc24.x86_64.rpm
RPMS/x86_64/hans-server-0.4.4-1.fc24.x86_64.rpm
RPMS/x86_64/hans-debuginfo-0.4.4-1.fc24.x86_64.rpm
hans.src: W: spelling-error %description -l en_US firewalled -> fire walled,
fire-walled, firewall ed
hans.x86_64: W: spelling-error %description -l en_US firewalled -> fire walled,
fire-walled, firewall ed
hans.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/hans
hans.x86_64: W: no-manual-page-for-binary hans
hans-client.x86_64: W: spelling-error %description -l en_US sulution ->
solution, insulation, ululation
hans-client.x86_64: W: no-documentation
hans-client.x86_64: W: non-standard-uid /etc/sysconfig/hans-client hans
hans-client.x86_64: E: non-readable /etc/sysconfig/hans-client 600
hans-server.x86_64: W: no-documentation
hans-server.x86_64: W: non-standard-uid /etc/sysconfig/hans-server hans
hans-server.x86_64: E: non-readable /etc/sysconfig/hans-server 600
5 packages and 0 specfiles checked; 3 errors, 10 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fabian Affolter  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fabian Affolter  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #4 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
Christopher could we continue please??

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
Hello, Christoper. Thanks for the comments.

%changelog  
* Tue Mar 11 2014 Pavel Alexeev pa...@hubbitus.info - 0.4.3-3 
- Drop all sysvinit support because it now MUST NOT be present in new packages
(https://fedoraproject.org/wiki/Packaging:SysVInitScript?rd=Packaging/SysVInitScript#Initscripts_in_addition_to_systemd_unit_files).
 
- Change user creation procedure, move in base package.

Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6622750
Spec changes:
https://github.com/Hubbitus/Fedora-packaging/commit/4e1c066a0a0ff81571276ec43676466a6fd0cbf2
Spec:
https://raw.github.com/Hubbitus/Fedora-packaging/4e1c066a0a0ff81571276ec43676466a6fd0cbf2/SPECS/hans.spec
Srpm: http://hubbitus.info/rpm/Fedora20/hans/hans-0.4.3-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743



--- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info ---
All issues addressed except 5. I prefer leave that slash on my oiunt of view it
looks more like traditional path.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Fabian Affolter m...@fabian-affolter.ch changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch
 Blocks||563471 (FE-SECLAB)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. Update systemd scriptlets.

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd

2. Users  Groups template:

https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation

3. Conditional lines for different init systems please if you want to maintain
it in one spec. Currently they are broken.

4. No -sysvinit package please, handle them in conditional lines. Or turn it
into %_bindir.

5. %{buildroot}/ -- %{buildroot}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028743] Review Request: hans - IP over ICMP tunneling solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1028743

Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info changed:

   What|Removed |Added

  Alias||hans



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review