[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|telegram-cli-0-0.5.20140321 |telegram-cli-0-0.5.20140321 |git1dad2e.fc19 |git1dad2e.el6 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||telegram-cli-0-0.5.20140321 ||git1dad2e.fc20 Resolution|--- |ERRATA Last Closed||2014-05-03 15:53:23 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|telegram-cli-0-0.5.20140321 |telegram-cli-0-0.5.20140321 |git1dad2e.fc20 |git1dad2e.fc19 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- Package telegram-cli-0-0.5.20140321git1dad2e.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing telegram-cli-0-0.5.20140321git1dad2e.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-1231/telegram-cli-0-0.5.20140321git1dad2e.el6 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/telegram-cli-0-0.5.20140321git1dad2e.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/telegram-cli-0-0.5.20140321git1dad2e.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- telegram-cli-0-0.5.20140321git1dad2e.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/telegram-cli-0-0.5.20140321git1dad2e.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Antonio Trande anto.tra...@gmail.com --- Thanks. New Package SCM Request === Package Name: telegram-cli Short Description: Linux Command-line interface for Telegram Owners: sagitter Branches: f19 f20 el6 el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(cicku...@gmail.co |
|m) |
--- Comment #14 from Christopher Meng cicku...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 3 files have unknown
license. Detailed output of licensecheck:
GPL (v2 or later)
-
tg-90f6271261cef487d0259b773acc2fdb90c2f478/binlog.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/binlog.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/constants.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/include.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/interface.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/interface.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/loop.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/loop.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/main.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/mtproto-client.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/mtproto-client.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/mtproto-common.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/mtproto-common.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/net.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/net.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/no-preview.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/queries.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/queries.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/structures.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/structures.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/telegram.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/tools.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/tools.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/tree.h
Unknown or generated
tg-90f6271261cef487d0259b773acc2fdb90c2f478/LICENSE.h
tg-90f6271261cef487d0259b773acc2fdb90c2f478/lua-tg.c
tg-90f6271261cef487d0259b773acc2fdb90c2f478/lua-tg.h
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Flags||needinfo?(cicku...@gmail.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #13 from Antonio Trande anto.tra...@gmail.com --- Spec URL: http://sagitter.fedorapeople.org/telegram/telegram-cli.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.4.20140316git90f627.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #8 from Antonio Trande anto.tra...@gmail.com --- (In reply to Christopher Meng from comment #7) (In reply to Antonio Trande from comment #6) (In reply to Christopher Meng from comment #4) However I think tg is the right name of this package. In my opinion, this package must be named 'telegram-cli' for three reasons: - 'tg' is too short No. This doesn't support anything. - The name 'telegram-cli' says immediately which platform this application supports. - 'telegram-cli' is also the name used by upstream for the rpm packaging. Spec URL: http://sagitter.fedorapeople.org/telegram/telegram.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.3. 20140312git046b8f.fc20.src.rpm Upstream clarification? Please ask upstream about this and post the feedback. https://github.com/vysheng/tg/issues/105 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #9 from Antonio Trande anto.tra...@gmail.com --- Spec URL: http://sagitter.fedorapeople.org/telegram/telegram-cli.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.3.20140312git046b8f.fc20.src.rpm Defined progname option. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046
--- Comment #10 from Matías Kreder mkre...@gmail.com ---
I believe that server.pub should be placed in /etc/telegram instead of
/etc/telegram-cli. Please check and use telegram instead of %{name} in the
files section if needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046
--- Comment #11 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Matías Kreder from comment #10)
I believe that server.pub should be placed in /etc/telegram instead of
/etc/telegram-cli. Please check and use telegram instead of %{name} in the
files section if needed.
Hi Matías.
Effectively, by default, server.pub must be placed in /etc/telegram/server.pub
directory, otherwise user must specify where to find it by '-k' option.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #12 from Antonio Trande anto.tra...@gmail.com --- server.pub must be placed in /etc/telegram/server.pub directory I meant, tg-server.pub must be placed in /etc/telegram/server.pub directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com --- Comment #3 from Parag AN(पराग) panem...@gmail.com --- Note this package is again submitted by some other contributor with different package name. See bug 1075825. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #4 from Christopher Meng cicku...@gmail.com --- (In reply to Parag AN(पराग) from comment #3) Note this package is again submitted by some other contributor with different package name. See bug 1075825. Agree. However I think tg is the right name of this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||mkre...@gmail.com --- Comment #5 from Christopher Meng cicku...@gmail.com --- *** Bug 1075825 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #6 from Antonio Trande anto.tra...@gmail.com --- (In reply to Christopher Meng from comment #4) However I think tg is the right name of this package. In my opinion, this package must be named 'telegram-cli' for three reasons: - 'tg' is too short - The name 'telegram-cli' says immediately which platform this application supports. - 'telegram-cli' is also the name used by upstream for the rpm packaging. Spec URL: http://sagitter.fedorapeople.org/telegram/telegram.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.3.20140312git046b8f.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 --- Comment #7 from Christopher Meng cicku...@gmail.com --- (In reply to Antonio Trande from comment #6) (In reply to Christopher Meng from comment #4) However I think tg is the right name of this package. In my opinion, this package must be named 'telegram-cli' for three reasons: - 'tg' is too short No. This doesn't support anything. - The name 'telegram-cli' says immediately which platform this application supports. - 'telegram-cli' is also the name used by upstream for the rpm packaging. Spec URL: http://sagitter.fedorapeople.org/telegram/telegram.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.3. 20140312git046b8f.fc20.src.rpm Upstream clarification? Please ask upstream about this and post the feedback. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074046] Review Request: telegram-cli - Linux Command-line interface for Telegram
https://bugzilla.redhat.com/show_bug.cgi?id=1074046 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Summary|Review Request: telegram - |Review Request: |Private, fast and open |telegram-cli - Linux |platform for instant|Command-line interface for |messaging |Telegram --- Comment #2 from Antonio Trande anto.tra...@gmail.com --- Spec URL: http://sagitter.fedorapeople.org/telegram/telegram-cli.spec SRPM URL: http://sagitter.fedorapeople.org/telegram/telegram-cli-0-0.2.20140307git8b78b6.fc20.src.rpm Package renamed in telegram-cli. Summary tag changed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
