[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-09-02 04:14:54 --- Comment #30 from Haïkel Guémar karlthe...@gmail.com --- Package has been imported, closing ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Flags||needinfo?(karlthered@gmail. ||com) --- Comment #28 from Jon Bernard jober...@redhat.com --- Haïkel, we can close this bug now? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags|needinfo?(karlthered@gmail. | |com)| --- Comment #29 from Haïkel Guémar karlthe...@gmail.com --- You should have told bodhi to close this ticket for you. Anyway as soon as it lands in the repositories, you could close the ticket with resolution: next release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #23 from Haïkel Guémar karlthe...@gmail.com --- Few things: * it is common to have the %files section the last and scriptlets before, though it's not a blocker, please fix it. * for the record, you'll be co-maintainer of openstack-glance with Flavio and not Mattias I finished reviewing the package, fix the %files section and it's all good for me :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #24 from Jon Bernard jober...@redhat.com --- Spec URL: https://gist.githubusercontent.com/jbernard/8602750/raw/6dd53138ff54ec91f894a5760b21dd4d829c1fc2/openstack-marconi.spec SRPM URL: https://gist.githubusercontent.com/jbernard/8602750/raw/9bd8a0b54eab184fbda5315f306b34c677267b13/openstack-marconi-2014.1.b3-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #25 from Haïkel Guémar karlthe...@gmail.com ---
Thanks, congratulations for joining the Fedora Packager group :)
I hereby approve this package into Fedora Packages Collection, please file a
scm request and feel free to ping me if you need help.
http://fedoraproject.org/wiki/Package_SCM_admin_requests
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
3 files have unknown license. Detailed output of licensecheck in
/home/haikel/1075822-openstack-marconi/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/logrotate.d
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #26 from Jon Bernard jober...@redhat.com --- New Package SCM Request === Package Name: openstack-marconi Short Description: OpenStack Message Queuing Service Owners: jbernard flaper87 Branches: el6-icehouse epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jens Petersen peter...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #27 from Jens Petersen peter...@redhat.com --- Git done (by process-git-requests). Note there is no such branch as el6-icehouse AFAIK, so I created a normal EL-6 branch. If you need a f20 branch, please make a Package Change Request later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags|needinfo?(karlthered@gmail. | |com)| --- Comment #20 from Haïkel Guémar karlthe...@gmail.com --- Since you improved the previous review and that Mattias offered to take you as a co-maintainer for glance, I'll sponsor you. Remember that as your sponsor, you could always ping me for help or packaging questions until you become either a sponsor yourself or provenpackager. Let's move on. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #21 from Matthias Runge mru...@redhat.com --- Haikel, nope, I'm afraid, I'm not the maintainer for glance, but that shouldn't prevent you from sponsoring Jon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #22 from Haïkel Guémar karlthe...@gmail.com --- @Matthias: no problem, we had a little chat with Jon today, and I will be sponsoring him anyway :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Flags||needinfo?(mru...@redhat.com ||) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #16 from Jon Bernard jober...@redhat.com --- I removed the hardcoded UID and GID, here are the new links: Spec URL: https://gist.githubusercontent.com/jbernard/8602750/raw/687551e932d071d73320d8f6d15aa02169606869/openstack-marconi.spec SRPM URL: https://gist.githubusercontent.com/jbernard/8602750/raw/0d7097a0511c14cf2d6ed677c2efa77460fdbb4f/openstack-marconi-2014.1-b3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Flags|needinfo?(mru...@redhat.com |
|) |
--- Comment #17 from Haïkel Guémar karlthe...@gmail.com ---
Release: b3%{dist}
Please fix the release tag according the guidelines
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
As soon as we clear the sponsoring (you still have to provide another informal
review), we'll move forward.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #18 from Jon Bernard jober...@redhat.com --- This might count as an informal review: https://bugzilla.redhat.com/show_bug.cgi?id=1087053 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Flags||needinfo?(karlthered@gmail. ||com) --- Comment #19 from Jon Bernard jober...@redhat.com --- Release tag fixed: Spec URL: https://gist.githubusercontent.com/jbernard/8602750/raw/348d2be7ac6cae4bdcc70d1280804d83439e122b/openstack-marconi.spec SRPM URL: https://gist.githubusercontent.com/jbernard/8602750/raw/bddea79ea186c53c9b3ff4cfd5e93feed2b8f6ee/openstack-marconi-2014.1.b3-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #13 from Matthias Runge mru...@redhat.com --- Ugh, I just saw, you're inserting a hard coded user id. Please don't do that, unless really necessary, and I don't see that in this case. Wenn iterating in review, please add a comment to the changelog and increase the release, as it makes it easier for the reviewer to follow the changes. Regarding sponsoring, I'll take care of that. Jon will become co-maintainer of glance, too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #14 from Jon Bernard jober...@redhat.com --- Yes, that was the one thing that bothered me - it seems both the glance and nova packages do this same thing so I wasn't sure if there was some technical reason. I will fix this up, and update the glance packages as well. Thanks for the input. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #15 from Jon Bernard jober...@redhat.com --- I posted some review comments on the python-dicttoxml package: https://bugzilla.redhat.com/show_bug.cgi?id=1084199 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags|needinfo?(karlthered@gmail. | |com)| --- Comment #12 from Haïkel Guémar karlthe...@gmail.com --- FYI, we discussed with Jon on irc and by emails. Basically, until we move forward with the sponsorship process, we can't finish this review. He still need to come up with a good informal review so sponsors may assess his knowledge about RPM packaging and Fedora guidelines. As for the commitment part, I am affirmative that Jon will be committed to maintain properly this package. I'm pretty confident that the review will go well from my preliminary reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Flavio Percoco fperc...@redhat.com changed: What|Removed |Added Flags||needinfo?(karlthered@gmail. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822
--- Comment #8 from Haïkel Guémar karlthe...@gmail.com ---
The build fails in mock since you have a missing BR on systemd (it brings all
the systemd rpm macros like %{_unitdir})
BuildRequires: systemd
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #9 from Jon Bernard jober...@redhat.com --- Can you tell me the exact command you're running? I would like to reproduce this failure here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #10 from Haïkel Guémar karlthe...@gmail.com --- mock -r fedora-rawhide-x86_64 openstack-marconi-2014.1.b2.dev57.gd8341ad-1.fc20.src.rpm It doesn't fail on a standard Fedora install, only in mock chroot but it's a mandatory point for the review. The BR is also documented in the guidelines: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #11 from Jon Bernard jober...@redhat.com --- Ok, I see. Try this: https://gist.githubusercontent.com/jbernard/8602750/raw/cae7545d62494827b91af0170656b0052fcf1697/openstack-marconi.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #7 from Jon Bernard jober...@redhat.com --- Here is one for Mino: https://bugzilla.redhat.com/show_bug.cgi?id=1078960#c2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags|needinfo?(karlthered@gmail. | |com)| --- Comment #6 from Haïkel Guémar karlthe...@gmail.com --- I'll start reviewing and testing your package but I can't approve it until you've been sponsored into the packager group. To move forward into the sponsoring process, I'll ask you to do two informal reviews and link them back here. Avoid FE-NEEDSPONSOR tickets as I usually finish the reviews, it will get me into a recursive loop ;) http://fedoraproject.org/PackageReviewStatus/NEW.html = list of review tickets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Flavio Percoco fperc...@redhat.com changed: What|Removed |Added Flags||needinfo?(karlthered@gmail. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Flavio Percoco fperc...@redhat.com changed: What|Removed |Added CC||jober...@redhat.com Flags||needinfo?(jobernar@redhat.c ||om) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Flavio Percoco fperc...@redhat.com changed: What|Removed |Added Comment #4 is|1 |0 private|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Flags|needinfo?(jobernar@redhat.c | |om) | --- Comment #5 from Jon Bernard jober...@redhat.com --- Thanks for all of the input. I have made all of the suggested changes: Spec URL: https://gist.github.com/jbernard/8602750#file-openstack-marconi-spec SRPM URL: https://gist.github.com/jbernard/8602750#file-openstack-marconi-2014-1-b3-fc20-src-rpm I have submitted a patch upstream to include the full license content, I should wait for the new build once it's merged, or just put it into the package now? For the RDO packagers, what is the correct way to make this packaging known to them? Thanks for all of the input! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
CC||echevemas...@gmail.com
--- Comment #3 from Eduardo Echeverria echevemas...@gmail.com ---
The unversioned macros, %{__python}, %{python_sitelib}, and %{python_sitearch}
are deprecated. Please use the correct macros
https://fedoraproject.org/wiki/Packaging:Python#Macros
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added CC||socho...@redhat.com --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com --- Few notes before Haïkel gets to this: 1. Version is incorrect. Look at naming guidelines[1]. This seems like post-release version situation. I'd strongly suggest packaging upstream releases whenever possible 2. Source0 URL doesn't exist (it seems almost as a joke...) 3. There is no changelog 4. Apache 2.0 requires full LICENSE text to be distributed with all binary/source packages. You have to include it even if upstream doesn't (but that should be fixed upstream eventually because they cause all redistributors to fail their own license...) 5. While you are at it packaging ChangeLog would be nice as well [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/NamingGuidelines#Version_Tag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 --- Comment #2 from Haïkel Guémar karlthe...@gmail.com --- Thanks Stanislav :) I'll add few more points: * use the systemd scriptlets https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd * did you check with RDO packagers to coordinate with them ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added CC||karlthe...@gmail.com Assignee|nob...@fedoraproject.org|karlthe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service
https://bugzilla.redhat.com/show_bug.cgi?id=1075822 Jon Bernard jober...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
