[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Maverick Kaung  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(mavj...@gmail.com |
   |)   |
Last Closed||2018-08-30 13:30:06



--- Comment #24 from Maverick Kaung  ---
Hi Ben, Andrew,

Thank you for taking your time on getting in touch with me after a long absence
on my side.

Unfortunately, the game is dead. The developer has decided to let the game
development go. Therefore, I shall not be pushing forward with the packaging
either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Ben Rosser  changed:

   What|Removed |Added

  Flags||needinfo?(mavj...@gmail.com
   ||)



--- Comment #23 from Ben Rosser  ---
Hi Maverick,

Any news? Please respond soon, or (as mentioned before) I'll close the ticket
in accordance with the "stalled reviews" policy. :(

Note that if you are still interested in packaging voxelands you're more than
welcome to open a new ticket, should this one get closed. (Or if someone else
wants to package voxelands they can too).

As I said before, I'm still happy to sponsor you if you are interested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KBJVB7PLLHOGLFO4XSLM5SM4TZVNVRU5/

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #22 from Andrew Toskin  ---
Any updates on this package, Maverick Kaung?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #21 from Andrew Toskin  ---
I'm still interested in reviewing this package (and playing the game) if you're
still interested in working on it, Maverick.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Maverick Kaung  changed:

   What|Removed |Added

  Flags|needinfo?(mavj...@gmail.com |
   |)   |



--- Comment #20 from Maverick Kaung  ---
Hi all,

The development of voxelands stalled for awhile, so I thought of closing it
out, but I didn't. But as of 23/09/2017, the main developer has released a new
version thus I will be fixing up some config option to work better with the way
the config in the new release work. So, do watch this space for a new spec
submission.

And thank you to the folks who have offered to sponsor my package, I appreciate
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com
  Flags||needinfo?(mavj...@gmail.com
   ||)



--- Comment #19 from Ben Rosser  ---
Hi,

It's been several months since the last request about the status of this
review, but with no response from the submitter. As per the "policy for stalled
package reviews"
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews please
respond soon if you're still interested in the submission.

Also, I am (as of a few hours ago!) a sponsor, so I could sponsor you if you
are still interested in getting voxelands into Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #18 from Matthew Miller  ---
Note that Fedora rules around bundling have changed, possibly making this
easier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

terrycloth  changed:

   What|Removed |Added

 CC||and...@tosk.in



--- Comment #17 from terrycloth  ---
What's the status on this package?

I liked Minetest, but felt like it was sorely missing better-developed creeps,
which Voxelands seems to have worked on. So I'd be interested in seeing it
packaged for Fedora. I'm also looking to do package reviews, as part of joining
the official packagers group, so I could help get this moving again, if you're
still interested in maintaining it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1364745




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] (FE-GAMESIG) Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Dennis Chen  changed:

   What|Removed |Added

 CC||barracks...@gmail.com
   Assignee|nob...@fedoraproject.org|barracks...@gmail.com
  Flags||fedora-review?



--- Comment #16 from Dennis Chen  ---
I'll take this under review. I am under the impression that Voxelands no longer
bundles jthread. Do you still need a sponsor?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #14 from Ye Myat Kaung mavj...@gmail.com ---
I've made a newer spec file that is similar to minetest - which is already in
the fedora repos, and since voxelands is a fork of that.

WIth this new spec file there is no need to pass the -DBUILD_SERVER=0, and it
also builds the voxelands-server package. My only concern is that voxelands,
like minetest bundles jthread, so, I an not sure I'd need to apply Bundled
Library Exception with FPC. The issue is the same as the original Exception:
https://fedorahosted.org/fpc/ticket/347

Do I still need to apply for Bundled Library Exception with FPC for
voxelands, as well?

A new stable version of voxelands (1409.00) was released some weekend ago.

SPEC URL: https://mavjs.fedorapeople.org/voxelands/1409.00/voxelands.spec (This
spec is used to build the voxelands packages on mavjs/voxelands on copr)
SRPM URL:
https://mavjs.fedorapeople.org/voxelands/1409.00/voxelands-1409.00-4.fc20.src.rpm
SOURCE FILE URLs: https://mavjs.fedorapeople.org/voxelands/1409.00/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #15 from Matthew Miller mat...@redhat.com ---
(In reply to Ye Myat Kaung from comment #14)
 Do I still need to apply for Bundled Library Exception with FPC for
 voxelands, as well?

'Fraid so. Note the other ticket and exception when doing so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #12 from Matthew Miller mat...@redhat.com ---
(In reply to Christopher Meng from comment #11)
 * Thu Sep 11 2014 Ye Myat Kaung mavj...@gmail.com - 1408.00
 
 The version in the end is not correct, you can use rpmdev-bumpspec to bump
 it and see the standard.

I assume you mean this part:

  %global verrel 1408.00

  Name: voxelands
  Version:%{verrel}
  Release:1%{?dist}
  Summary:The Fun-Focused Free Software Voxel World Game

  License:GPLv3
  URL:http://www.voxelands.com
  Source0:http://www.voxelands.com/downloads/%{name}-%{verrel}-src.tar.bz2

This could be more simply done just like this:


  Name: voxelands
  Version:  1408.00
  Release:  1%{?dist}
  Summary:   The Fun-Focused Free Software Voxel World Game

  License:  GPLv3
  URL:  http://www.voxelands.com
  Source0: 
http://www.voxelands.com/downloads/%{name}-%{version}-src.tar.bz2


No need for a special global, because %{version} already works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #13 from Ye Myat Kaung mavj...@gmail.com ---
Thanks for the reviews. I have made a few changes as suggested.

Got rid of:
%{verrel}
-DCMAKE_INSTALL_PREFIX=/usr
1408.00 (and changed to 1408.00-1)

-DBUILD_SERVER=0 is passed to cmake, because, if not the project also builds
the server binary at the same time.

-DRUN_IN_PLACE=0 is passed so that the client binary reads configuration and
map data from ~/.voxelands and not from the parent directory the binary was
launched from.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #9 from Ye Myat Kaung mavj...@gmail.com ---
Thanks for the (informal) review(s). I've change the suggested remarks.

URL: https://mavjs.fedorapeople.org/voxelands/voxelands.spec


@Christopher Meng - I don't think I have %{_prefix}/local/ anymore in the
voxelands.spec, I believe it was in the minetest-classic.spec (which was the
old project/spec file)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #10 from Christopher Meng i...@cicku.me ---
Yes, by after using %cmake macro the usr/local should be nuked.


%cmake -DBUILD_SERVER=0 -DRUN_IN_PLACE=0 -DCMAKE_INSTALL_PREFIX=/usr

$ rpm -E %cmake

  CFLAGS=${CFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic} ; export
CFLAGS ; 
  CXXFLAGS=${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic} ; export
CXXFLAGS ; 
  FFLAGS=${FFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic
-I/usr/lib64/gfortran/modules} ; export FFLAGS ; 
  FCFLAGS=${FCFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic
-I/usr/lib64/gfortran/modules} ; export FCFLAGS ; 
  LDFLAGS=${LDFLAGS:--Wl,-z,relro } ; export LDFLAGS ; 
  /usr/bin/cmake \
-DCMAKE_C_FLAGS_RELEASE:STRING=-DNDEBUG \
-DCMAKE_CXX_FLAGS_RELEASE:STRING=-DNDEBUG \
-DCMAKE_Fortran_FLAGS_RELEASE:STRING=-DNDEBUG \
-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
-DCMAKE_INSTALL_PREFIX:PATH=/usr \
-DINCLUDE_INSTALL_DIR:PATH=/usr/include \
-DLIB_INSTALL_DIR:PATH=/usr/lib64 \
-DSYSCONF_INSTALL_DIR:PATH=/etc \
-DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if lib64 == lib64 
-DLIB_SUFFIX=64 \
%endif 
-DBUILD_SHARED_LIBS:BOOL=ON

ALready defined in the macro:

-DCMAKE_INSTALL_PREFIX=/usr

And, it'd be better to have a server -DBUILD_SERVER=0, or other explanations?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #11 from Christopher Meng i...@cicku.me ---
* Thu Sep 11 2014 Ye Myat Kaung mavj...@gmail.com - 1408.00

The version in the end is not correct, you can use rpmdev-bumpspec to bump it
and see the standard.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612



--- Comment #6 from Ye Myat Kaung mavj...@gmail.com ---
Spec URL: https://mavjs.fedorapeople.org/voxelands/voxelands.spec
SRPM URL:
https://mavjs.fedorapeople.org/voxelands/voxelands-1408.00-1.fc20.src.rpm

Copr URL: http://copr.fedoraproject.org/coprs/mavjs/voxelands/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Mihkel Vain tura...@gmail.com changed:

   What|Removed |Added

 CC||tura...@gmail.com



--- Comment #7 from Mihkel Vain tura...@gmail.com ---
Hi. This is not a formal review... just some remarks.

1. voxelands.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab:
line 3)

Use on only tabs or spaces in spec file.


2. Group:Amusements/Games

You don't need that, unless to plan to target EPEL 5

3. URL:http://.voxelands.com

Loose one w

4. cmake -DBUILD_SERVER=0 -DRUN_IN_PLACE=0 -DCMAKE_INSTALL_PREFIX=/usr

Use %cmake macro eg:
%cmake -DBUILD_SERVER=0 -DRUN_IN_PLACE=0 -DCMAKE_INSTALL_PREFIX=/usr

5. %clean
rm -rf %{buildroot}

You don't need that, unless to plan to target EPEL 5 

5. %defattr(-,root,root)

You don't need that.


Note. This list may not be complete and I don't intend to do formal review,
because I think I don't have enough right for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085612] Review Request: voxelands - The Fun-Focused Free Software Voxel World Game (was: minetest-classic)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1085612

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 CC||i...@cicku.me



--- Comment #8 from Christopher Meng i...@cicku.me ---
%{_prefix}/local/


This is NOT allowed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review