[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-SDL2_mixer-2.0.0-3.fc ||20 Resolution|--- |ERRATA Last Closed||2014-10-10 12:01:16 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2_mixer-2.0.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-SDL2_mixer-2.0.0-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Marcel Wysocki m...@satgnu.net changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Marcel Wysocki m...@satgnu.net --- New Package SCM Request === Package Name: mingw-SDL2_mixer Short Description: MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library Upstream URL: http://www.libSDL.org/projects/SDL_mixer/ Owners: maci epienbro Branches: f19 f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #4 from Marcel Wysocki m...@satgnu.net --- Update: * Mon Jul 21 2014 maci m...@satgnu.net - 2.0.0-3 - Fix homepage URL Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 David King amigad...@amigadave.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from David King amigad...@amigadave.com --- The updated spec seems fine to me. The SRPM has not been updated, however (it is still the -2), but that seems like a typo, as using a -3 in the URL instead works fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #6 from Marcel Wysocki m...@satgnu.net --- yeah, sorry was a typo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Marcel Wysocki m...@satgnu.net changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Marcel Wysocki m...@satgnu.net --- New Package SCM Request === Package Name: mingw-SDL2_mixer Short Description: MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library Upstream URL: http://www.libSDL.org/projects/SDL_mixer/ Owners: maci epienbrock Branches: f19 f20 f21 el6 epel7 InitialCC: fedora-mi...@lists.fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- WARNING: epienbrock is not a valid FAS account. WARNING: fedora-mi...@lists.fedoraproject.org is not a valid FAS account. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809
David King amigad...@amigadave.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||amigad...@amigadave.com
Assignee|nob...@fedoraproject.org|amigad...@amigadave.com
Flags||fedora-review?
--- Comment #3 from David King amigad...@amigadave.com ---
Generally, it looks pretty good, just the homepage location needs fixing.
* the homepage (URL and Source0) has a typo, it should be:
http://www.libsdl.org/projects/SDL_mixer/
Would you be able to do a review swap with bug 1076456?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Header files in -devel subpackage, if present.
Note: mingw32-SDL2_mixer : /usr/i686-w64-mingw32/sys-
root/mingw/include/SDL2/SDL_mixer.h mingw64-SDL2_mixer :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
Not a problem for mingw packages.
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Illegal
package name: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Does not provide
-static: mingw32-SDL2_mixer, mingw64-SDL2_mixer.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
Also not a problem for mingw packages.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
*No copyright* GPL (v2 or later) (with incorrect FSF address), LGPL
(v2.1 or later) (with incorrect FSF address), GPL (v2 or later),
Unknown or generated, LGPL (v2 or later) (with incorrect FSF
address), ISC, zlib/libpng, GPL (v2 or later) (with incorrect FSF
address), BSD (3 clause), LGPL (with incorrect FSF address), LGPL
(v2.1 or later), *No copyright* Public domain. 313 files have unknown
license. Detailed output of licensecheck in
/home/david/checkout/rpms/1096809-mingw-SDL2_mixer/licensecheck.txt
All the licenses other than zlib are in third-party libraries, which are not
built, so the license tag is fine.
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/x86_64-w64-mingw32/sys-
root/mingw/include/SDL2(mingw64-SDL2), /usr/i686-w64-mingw32/sys-
root/mingw/include/SDL2(mingw32-SDL2)
As the binary packages generated from this package require SDL2, not owning
those directories is fine.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Bug 1096809 depends on bug 1096796, which changed state. Bug 1096796 Summary: Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library https://bugzilla.redhat.com/show_bug.cgi?id=1096796 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 --- Comment #2 from Marcel Wysocki m...@satgnu.net --- Fixed Links: Spec URL: https://rawgit.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://rawgit.com/maci0/rpmbuild/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Marcel Wysocki m...@satgnu.net changed: What|Removed |Added Flags|fedora-review? | --- Comment #1 from Marcel Wysocki m...@satgnu.net --- Update: * Tue May 13 2014 Marcel Wysocki m...@satgnu.net - 2.0.0-2 - Removed redundant BuildRequires Spec URL: https://raw.githubusercontent.com/maci0/rpmbuild/master/SPECS/mingw-SDL2_mixer.spec SRPM URL: https://github.com/maci0/rpmbuild/raw/master/SRPMS/mingw-SDL2_mixer-2.0.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Marcel Wysocki m...@satgnu.net changed: What|Removed |Added CC||fedora-mingw@lists.fedorapr ||oject.org Depends On||1096796 Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1096796 [Bug 1096796] Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
