[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||zbys...@in.waw.pl
 Resolution|--- |DUPLICATE
Last Closed||2016-12-05 10:44:55



--- Comment #14 from Zbigniew Jędrzejewski-Szmek  ---


*** This bug has been marked as a duplicate of bug 1398433 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #13 from Upstream Release Monitoring 
 ---
pbrobinson's scratch build of
gtk-murrine-engine?#b4bddbf235c281d671c99e8008f609b6d4e314d0 for
epel7-archbootstrap and
git://pkgs.fedoraproject.org/gtk-murrine-engine?#b4bddbf235c281d671c99e8008f609b6d4e314d0
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12037955

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #12 from Upstream Release Monitoring 
 ---
pbrobinson's scratch build of
gtk-sharp-beans?#bbba0aef7a4bd673006df5b9a85a5763d9c026bc for
epel7-archbootstrap and
git://pkgs.fedoraproject.org/gtk-sharp-beans?#bbba0aef7a4bd673006df5b9a85a5763d9c026bc
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12037959

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Christopher Meng  changed:

   What|Removed |Added

   Assignee|admil...@redhat.com |i...@cicku.me



--- Comment #11 from Christopher Meng  ---
Taking back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Adam Miller admil...@redhat.com changed:

   What|Removed |Added

 CC||admil...@redhat.com
   Assignee|nob...@fedoraproject.org|admil...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #10 from Adam Miller admil...@redhat.com ---
Created attachment 1019425
  -- https://bugzilla.redhat.com/attachment.cgi?id=1019425action=edit
FTBFS - mock rawhide build logs 2015-04-27

Fails to build on rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #9 from James Wilson Harshaw IV jwhars...@gmail.com ---
Reviewer went AWHOL, looking for a new reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

James Wilson Harshaw IV jwhars...@gmail.com changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #8 from Wesley Hearn whe...@redhat.com ---
pinging reviewer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #7 from Wesley Hearn whe...@redhat.com ---
Hey,
Sorry for the delay but 0.3.0 needed a newer version of vala then what is
sipped with Fedora 20, so here is the updated spec and srpm.

https://jknife.fedorapeople.org/review/granite/granite.spec
https://jknife.fedorapeople.org/review/granite/granite-0.3.0-2.fc21.src.rpm

You can find a copr build here:
http://copr.fedoraproject.org/coprs/jknife/pantheon/build/57562/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #6 from Christopher Meng i...@cicku.me ---
Hmm...Looks like 0.3 is available...

Please build again(sorry I forgot to mention this previously).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #5 from Wesley Hearn whe...@redhat.com ---
So looking at it, it is a partial translation. To get the language into Fedora
it would require putting in a translation request, which I do not know Rusyn so
I would not be able to help in any way with it and on that it is not a widely
used language. I think for the time being it is ok to remove it. At a later
date if someone wants Fedora fully translated into rue it is a simple one line
change to readd it back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #2 from Christopher Meng i...@cicku.me ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated




= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 LGPL (v3 or later), LGPL (v2 or later) (with incorrect FSF address),
 Unknown or generated. 2 files have unknown license. Detailed output of
 licensecheck:

LGPL (v2 or later) (with incorrect FSF address)
---
granite-0.2.3.1/lib/Widgets/widgets-utils.c

LGPL (v3 or later)
--
granite-0.2.3.1/demo/GraniteDemo.vala
granite-0.2.3.1/lib/Application.vala
granite-0.2.3.1/lib/Drawing/BufferSurface.vala
granite-0.2.3.1/lib/Drawing/Color.vala
granite-0.2.3.1/lib/Drawing/Utilities.vala
granite-0.2.3.1/lib/GtkPatch/AboutDialog.vala
granite-0.2.3.1/lib/Services/Contractor.vala
granite-0.2.3.1/lib/Services/ContractorProxy.vala
granite-0.2.3.1/lib/Services/IconFactory.vala
granite-0.2.3.1/lib/Services/Logger.vala
granite-0.2.3.1/lib/Services/Paths.vala
granite-0.2.3.1/lib/Services/Settings.vala
granite-0.2.3.1/lib/Services/SimpleCommand.vala
granite-0.2.3.1/lib/Services/System.vala
granite-0.2.3.1/lib/Widgets/AboutDialog.vala
granite-0.2.3.1/lib/Widgets/AppMenu.vala
granite-0.2.3.1/lib/Widgets/CellRendererBadge.vala
granite-0.2.3.1/lib/Widgets/CellRendererExpander.vala
granite-0.2.3.1/lib/Widgets/CollapsiblePaned.vala
granite-0.2.3.1/lib/Widgets/CompositedWindow.vala
granite-0.2.3.1/lib/Widgets/ContractorMenu.vala
granite-0.2.3.1/lib/Widgets/ContractorView.vala
granite-0.2.3.1/lib/Widgets/DatePicker.vala
granite-0.2.3.1/lib/Widgets/DecoratedWindow.vala
granite-0.2.3.1/lib/Widgets/DynamicNotebook.vala
granite-0.2.3.1/lib/Widgets/Entries.vala
granite-0.2.3.1/lib/Widgets/LightWindow.vala
granite-0.2.3.1/lib/Widgets/ModeButton.vala
granite-0.2.3.1/lib/Widgets/OverlayBar.vala
granite-0.2.3.1/lib/Widgets/PopOver.vala
granite-0.2.3.1/lib/Widgets/SidebarPaned.vala
granite-0.2.3.1/lib/Widgets/SourceList.vala
granite-0.2.3.1/lib/Widgets/StaticNotebook.vala
granite-0.2.3.1/lib/Widgets/StatusBar.vala
granite-0.2.3.1/lib/Widgets/ThinPaned.vala
granite-0.2.3.1/lib/Widgets/TimePicker.vala
granite-0.2.3.1/lib/Widgets/ToolButtonWithMenu.vala
granite-0.2.3.1/lib/Widgets/Utils.vala
granite-0.2.3.1/lib/Widgets/Welcome.vala
granite-0.2.3.1/lib/Widgets/WrapLabel.vala
granite-0.2.3.1/lib/style-classes.vala

Unknown or generated

granite-0.2.3.1/lib/Widgets/close-button.c
granite-0.2.3.1/lib/Widgets/widgets-utils.h

[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/rue,
 /usr/share/locale/rue/LC_MESSAGES
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in granite
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #3 from Wesley Hearn whe...@redhat.com ---
Updated Spec: http://jknife.fedorapeople.org/review/granite/granite.spec
Updated SRPM:
http://jknife.fedorapeople.org/review/granite/granite-0.2.3.1-2.fc20.src.rpm

I removed the rue locale, it seems it is a valid locale but not one Fedora
supports. It is the Rusyn language

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545



--- Comment #4 from Christopher Meng i...@cicku.me ---
(In reply to Wesley Hearn from comment #3)
 Updated Spec: http://jknife.fedorapeople.org/review/granite/granite.spec
 Updated SRPM:
 http://jknife.fedorapeople.org/review/granite/granite-0.2.3.1-2.fc20.src.rpm
 
 I removed the rue locale, it seems it is a valid locale but not one Fedora
 supports. It is the Rusyn language

If it really is, I think you should file a bug against filesystem package. We
should comform to the guideline, but we also need to think about the user
experience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@cicku.me
   Assignee|nob...@fedoraproject.org|i...@cicku.me
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1103545] Review Request: granite - GTK extensions for the elementary desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1103545

Wesley Hearn whe...@redhat.com changed:

   What|Removed |Added

 Blocks||1068850 (Pantheon)
 CC||tingp...@tingping.se



--- Comment #1 from Wesley Hearn whe...@redhat.com ---
*** Bug 998483 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1068850
[Bug 1068850] Fedora 22 Change Pantheon Desktop tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review