[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2015-01-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|alglib-3.8.2-5.fc20 |alglib-3.9.0-1.el7



--- Comment #24 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.9.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2015-01-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|alglib-3.9.0-1.el7  |alglib-3.9.0-1.el6



--- Comment #25 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.9.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2015-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #23 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.9.0-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/alglib-3.9.0-1.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2015-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #22 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.9.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/alglib-3.9.0-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||alglib-3.8.2-5.fc20
 Resolution|--- |ERRATA
Last Closed||2014-07-19 02:04:19



--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.8.2-5.fc20 has been pushed to the Fedora 20 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Jakub Čajka jca...@redhat.com changed:

   What|Removed |Added

 CC||jca...@redhat.com



--- Comment #18 from Jakub Čajka jca...@redhat.com ---
Created attachment 916691
  -- https://bugzilla.redhat.com/attachment.cgi?id=916691action=edit
Exclusive for primary archs

Hello, 

package fails to build on secondary archs due to test failure. As upstream is
not supporting any other archs then x86 and arm. I am suggesting to make this
package exclusive for them. In attachment is patch doing so.

Best regards 
Jakub 

Links to failing builds:
http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1437085
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1938973
http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=2482472

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #19 from Sandro Mani manisan...@gmail.com ---
Applied, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #20 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.8.2-5.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/alglib-3.8.2-5.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.8.2-4.fc20 has been pushed to the Fedora 20 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-07-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #16 from Fedora Update System upda...@fedoraproject.org ---
alglib-3.8.2-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/alglib-3.8.2-4.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #15 from Kevin Fenzi ke...@scrye.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Kevin Fenzi ke...@scrye.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #12 from Kevin Fenzi ke...@scrye.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Dave Love d.l...@liverpool.ac.uk changed:

   What|Removed |Added

 CC||d.l...@liverpool.ac.uk



--- Comment #13 from Dave Love d.l...@liverpool.ac.uk ---
Could you use %setup instead of %autosetup in the spec and get it into EPEL?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Sandro Mani manisan...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #14 from Sandro Mani manisan...@gmail.com ---
Package Change Request
==
Package Name: alglib
New Branches: el6 epel7
Owners: smani
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Sandro Mani manisan...@gmail.com changed:

   What|Removed |Added

 Blocks||388




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=388
[Bug 388] Review Request: gmsh - A three-dimensional finite element
mesh generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #5 from Sandro Mani manisan...@gmail.com ---
Spec URL: http://smani.fedorapeople.org/review/alglib.spec
SRPM URL: http://smani.fedorapeople.org/review/alglib-3.8.2-2.fc21.src.rpm

%changelog
* Wed Jun 18 2014 Sandro Mani manisan...@gmail.com - 3.8.2-2
- Add doc subpackage with correct license
- Run tests
- Fix unversioned so included in main package
- Fix manual.cpp.html permissions, line endings

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #6 from Antonio Trande anto.tra...@gmail.com ---
License file (BSD) is missing and not tagged for -doc package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #7 from Sandro Mani manisan...@gmail.com ---
Spec URL: http://smani.fedorapeople.org/review/alglib.spec
SRPM URL: http://smani.fedorapeople.org/review/alglib-3.8.2-3.fc21.src.rpm

%changelog
* Wed Jun 18 2014 Sandro Mani manisan...@gmail.com - 3.8.2-3
- Add bsd.txt to doc subpackage (license text extracted from manual.cpp.html)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #8 from Antonio Trande anto.tra...@gmail.com ---
-doc needs an own License tag:

%packagedoc
Summary:API documentation for %{name}
BuildArch:  noarch
License:BSD
%descriptiondoc
The %{name}-doc package contains the %{name} API documentation.

http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License:_field

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 GPL (v2 or later), Unknown or generated. 4 files have unknown
 license. Detailed output of licensecheck in
 /home/sagitter/1109490-alglib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in alglib-doc
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the 

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #9 from Sandro Mani manisan...@gmail.com ---
Ups sorry, somehow misread the remark about the -doc License...

Spec URL: http://smani.fedorapeople.org/review/alglib.spec
SRPM URL: http://smani.fedorapeople.org/review/alglib-3.8.2-4.fc21.src.rpm

* Wed Jun 18 2014 Sandro Mani manisan...@gmail.com - 3.8.2-4
- Add missing license tag

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Antonio Trande anto.tra...@gmail.com ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Sandro Mani manisan...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #11 from Sandro Mani manisan...@gmail.com ---
Thanks a lot!

New Package SCM Request
===
Package Name: alglib
Short Description: A numerical analysis and data processing library
Owners: smani
Branches: f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #4 from Antonio Trande anto.tra...@gmail.com ---
- Documentation html file is released under BSD license (its License text file
is missing).
  Better if packaged as -doc sub-package.

- Please, fix all warnings/errors from rpmlint.

- alglib seems to provide two tests too.
  See http://www.alglib.net/translator/man/manual.cpp.html#gs_testing

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
  or number of files.
  Note: Documentation size is 1761280 bytes in 2 files.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 GPL (v2 or later), Unknown or generated. 4 files have unknown
 license. Detailed output of licensecheck in
 /home/sagitter/1109490-alglib/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be 

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Sandro Mani manisan...@gmail.com changed:

   What|Removed |Added

 Blocks||753577




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=753577
[Bug 753577] Review Request: gmsh - finite element grid generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #1 from Antonio Trande anto.tra...@gmail.com ---
Hi Sandro.

Review swap with https://bugzilla.redhat.com/show_bug.cgi?id=1105730?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490



--- Comment #2 from Sandro Mani manisan...@gmail.com ---
Sure. Maybe hold off the posting the review for a day or so until Alexey
Vasyukov has had a chance to do an informal review, so that he has some reviews
to show off for him to get sponsored, see [1].

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1065541#c10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1109490] Review Request: alglib - A numerical analysis and data processing library

2014-06-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1109490

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Sandro Mani from comment #2)
 Sure. Maybe hold off the posting the review for a day or so until Alexey
 Vasyukov has had a chance to do an informal review, so that he has some
 reviews to show off for him to get sponsored, see [1].
 
 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1065541#c10

Okay, wait for a review by Alexey then I will do mine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review