[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Sergio Monteiro Basto  changed:

   What|Removed |Added

 Resolution|NOTABUG |DUPLICATE



--- Comment #34 from Sergio Monteiro Basto  ---


*** This bug has been marked as a duplicate of bug 1399833 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Erik Johnson  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-09-06 15:29:10



--- Comment #33 from Erik Johnson  ---
This is no longer a priority to get packaged, I will close it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #32 from Sergio Pascual  ---
As per

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

a response is needed in one week or the review will be closed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #31 from Sergio Pascual  ---
(In reply to Sergio Monteiro Basto from comment #30)

> and we just need change ? 
> Name:   python-%{srcname}
> to 
> Name:   python2-%{srcname}

I like the suggestion in the guidelines of one empty toplevel package
(python-%{srcname}) and a  python2-%{srcname} subpackage. The top level has a
Provides pointing to the package corresponding to the default interpreter in
the release (python2 vs python3)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Sergio Monteiro Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #30 from Sergio Monteiro Basto  ---
2.4.4 is released 

also notice that upstream have one python-libnacl.spec 

https://github.com/saltstack/libnacl/blob/master/pkg/rpm/python-libnacl.spec

and we just need change ? 
Name:   python-%{srcname}
to 
Name:   python2-%{srcname}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

M. Scherer  changed:

   What|Removed |Added

 CC||msche...@redhat.com
  Flags||needinfo?(sergio.pasra@gmai
   ||l.com)



--- Comment #28 from M. Scherer  ---
Sergio, anything missing ? This is blocking new version of salt, afaik.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Sergio Pascual  changed:

   What|Removed |Added

  Flags|needinfo?(sergio.pasra@gmai |
   |l.com)  |



--- Comment #29 from Sergio Pascual  ---
Sorry I missed this update. Since may there have been a few changes in Python
packaging guidelines, for example, you need a Provides: python2-libnacl for
Fedora 22+ in the Python2 subpackage 

Could you review the guidelines and check if you need more changes?

https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #27 from Upstream Release Monitoring 
 ---
jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
for f22-candidate and
git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #26 from Erik Johnson e...@saltstack.com ---
Sorry for the extended delay on this. Updated SPEC and SRPM with license file
added. See below links:

SRPM:
https://terminalmage.fedorapeople.org/pkg_review/python-libnacl-1.4.2-1.fc22.src.rpm
SPEC: https://terminalmage.fedorapeople.org/pkg_review/python-libnacl.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Erik Johnson e...@saltstack.com changed:

   What|Removed |Added

  Flags|needinfo?(e...@saltstack.co |
   |m)  |



--- Comment #25 from Erik Johnson e...@saltstack.com ---
I wear a lot of hats at work, so I've been a little sidetracked. I will try to
get to this and the ioflo review today or later this week. Thanks for checking
in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

 CC||e...@saltstack.com
  Flags||needinfo?(e...@saltstack.co
   ||m)



--- Comment #24 from Sergio Pascual sergio.pa...@gmail.com ---
Any progress with this? You only need to add the license file to finish...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #23 from Sergio Pascual sergio.pa...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[-]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[-]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm  4.4
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: Buildroot is not present
[-]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[!]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items 

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #22 from Erik Johnson e...@saltstack.com ---
OK, the upstream issues I referenced in my earlier email have been resolved.
The SRPM linked below successfully built for me on rawhide and EL6.

SRPM:
http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.3.5-1.el6.src.rpm
SPEC: http://terminalmage.net/redhat/python-libnacl/python-libnacl.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #20 from Sergio Pascual sergio.pa...@gmail.com ---
I'm sorry, but it is still broken for me.

I'm doing 

$ mock -r fedora-rawhide-x86_64 python-libnacl-1.3.2-1.el6.src.rpm

And the build log says:

Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.fFTP2g
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf libnacl-1.3.2
+ /usr/bin/gzip -dc /builddir/build/SOURCES/libnacl-1.3.2.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd libnacl-1.3.2
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ rm -rf /builddir/build/BUILD/python3-python-libnacl-1.3.2-1.fc22
+ cp -a . /builddir/build/BUILD/python3-python-libnacl-1.3.2-1.fc22
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.EkCgN0
+ umask 022
+ cd /builddir/build/BUILD
RPM build errors:
+ cd libnacl-1.3.2
+ '%{__python2}' setup.py build
/var/tmp/rpm-tmp.EkCgN0: line 31: fg: no job control
error: Bad exit status from /var/tmp/rpm-tmp.EkCgN0 (%build)
Bad exit status from /var/tmp/rpm-tmp.EkCgN0 (%build)



Could you check that the same command works for you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #21 from Erik Johnson e...@saltstack.com ---
OK, I must have put the wrong file up there, because when I dowloaded the one
from that link I can reproduce the failure.

However, right now, with a proper SRPM, the current python-libnacl release
still will not build due to a soname bump in the newest version of libsodium
(which was added to Rawhide this past week). I've contacted the libnacl
developer and a new libnacl will be released this weekend. I'll make a new SRPM
and update this issue at that time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #18 from Sergio Pascual sergio.pa...@gmail.com ---
This link is broken

http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.3.2-1.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #19 from Erik Johnson e...@saltstack.com ---
Sorry, it is now fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #15 from Sergio Pascual sergio.pa...@gmail.com ---
Ok, I'm trying again,

$ wget
http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.3.2-1.el6.src.rpm
$ koji build --scratch rawhide python-libnacl-1.3.2-1.el6.src.rpm


The task is here,

http://koji.fedoraproject.org/koji/taskinfo?taskID=7301967

It fails, you can have a look here in the build log

https://kojipkgs.fedoraproject.org//work/tasks/1968/7301968/build.log

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.ao2sKG
+ umask 022
+ cd /builddir/build/BUILD
+ cd libnacl-1.3.2
+ '%{__python2}' setup.py build
/var/tmp/rpm-tmp.ao2sKG: line 31: fg: no job control
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.ao2sKG (%build)
Bad exit status from /var/tmp/rpm-tmp.ao2sKG (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps 
builddir/build/SPECS/python-libnacl.spec']
Traceback (most recent call last):
  File /usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py, line
70, in trace
result = func(*args, **kw)
  File /usr/lib/python2.7/site-packages/mockbuild/util.py, line 378, in do
raise mockbuild.exception.Error, (Command failed. See logs for output.\n #
%s % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps 
builddir/build/SPECS/python-libnacl.spec']
LEAVE do -- EXCEPTION RAISED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #16 from Sergio Pascual sergio.pa...@gmail.com ---
Of course, this could be because rawhide is broken, I have launched a scratch
build in f21 just in case:

http://koji.fedoraproject.org/koji/taskinfo?taskID=7302051

But I think that the cause are the redefitions of python2 macros you do in the
spec. I'm not sure if this is allowed by the guidelines, but I do not recommend
it. It makes the spec more difficult to understand. Remember that you can have
a different spec for each branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #17 from Erik Johnson e...@saltstack.com ---
I see what the problem is. It looks like the SRPM that I uploaded was an
earlier version, when I was still dealing with the same build failures you
found initially. The one that I was building on my laptop (as well as some
scratch builds I just ran) was working just fine, so I checked the sha256
checksum and realized that they were different.

I've updated the SRPM at the URL referenced in my earlier message. Sorry for
the confusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #10 from Erik Johnson e...@saltstack.com ---
That build failure was an upstream bug, which is fixed in 1.3.2. I've updated
the spec, here are the new files:

New SPEC: http://terminalmage.net/redhat/python-libnacl/python-libnacl.spec
New SRPM:
http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.3.2-1.el6.src.rpm

It builds now on rawhide, as well as EPEL5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #11 from Sergio Pascual sergio.pa...@gmail.com ---
I'm currently on vacation, I will try to do the review as time permits

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #12 from Sergio Pascual sergio.pa...@gmail.com ---
I have launched this scratch build in rawhide

http://koji.fedoraproject.org/koji/taskinfo?taskID=7291922

I will check it later

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #13 from Sergio Pascual sergio.pa...@gmail.com ---
Well, it fails.

https://kojipkgs.fedoraproject.org//work/tasks/1923/7291923/build.log

It seems that the __python2 macro is undefined. It maybe related with the
redefinitions you do on the first lines of the spec file. It's a little bit
difficult to understand how the macros are substituted with all the %ifs and
%elses.

A suggestion, create a simple spec that builds in rawhide and add the
conditionals for epel later. Or put them in the specfiles in their own branches

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #14 from Erik Johnson e...@saltstack.com ---
There aren't any elses in the top of the spec anymore. How are you building
this? Maybe you have a cached version of the SPEC file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #9 from Sergio Pascual sergio.pa...@gmail.com ---
The package does not build in rawhide, look

https://kojipkgs.fedoraproject.org//work/tasks/9648/7199648/build.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #7 from Christopher Meng i...@cicku.me ---
I just wonder wht it has libnacl instead of libsodium in its name? ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #8 from Erik Johnson e...@saltstack.com ---
Not sure, I didn't write it :)

I think it was named libnacl partly because it was written as an alternative to
PyNaCl.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Sergio Pascual sergio.pa...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sergio.pa...@gmail.com
   Assignee|nob...@fedoraproject.org|sergio.pa...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #6 from Erik Johnson e...@saltstack.com ---
New SPEC: http://terminalmage.net/redhat/python-libnacl/python-libnacl.spec
New SRPM:
http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.1.0-1.el6.src.rpm


Thanks for the recommendations. rpmlint is clean (no warnings/errors) now, and
the SPEC should now work for EL5 as well. There are a few INFO-level lines in
the rpmlint output, but they appear to be falsely reporting, as you can see
below.


[16:37:50] erik@rpmbuild ~/rpmbuild/SRPMS
% rpmlint -v python-libnacl-1.1.0-1.el6.src.rpm
python-libnacl.src: I: checking
python-libnacl.src: I: enchant-dictionary-not-found en_US
python-libnacl.src: I: checking-url https://github.com/saltstack/libnacl
(timeout 10 seconds)
python-libnacl.src: I: checking-url
https://pypi.python.org/packages/source/l/libnacl/libnacl-1.1.0.tar.gz (timeout
10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[16:37:54]  erik@rpmbuild ~/rpmbuild/SRPMS
% curl --silent
https://pypi.python.org/packages/source/l/libnacl/libnacl-1.1.0.tar.gz | file -
/dev/stdin: gzip compressed data, was dist/libnacl-1.1.0.tar, last modified:
Wed Jun 25 13:31:50 2014, max compression
[16:38:04]  erik@rpmbuild ~/rpmbuild/SRPMS
% curl --silent -IL https://github.com/saltstack/libnacl | grep Status
Status: 200 OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310

Fabian Affolter m...@fabian-affolter.ch changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch



--- Comment #5 from Fabian Affolter m...@fabian-affolter.ch ---
Just some comments:

- At least some BRs (python2-devel and python-setuptools) are missing
- Python macros must be versioned
  More details: https://fedoraproject.org/wiki/Packaging:Python
- el5 needs additional stuff, see your rpmlint output.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #1 from Erik Johnson e...@saltstack.com ---
Branch-and-build ticket for libsodium on EL5 is:
https://bugzilla.redhat.com/show_bug.cgi?id=1113311

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #2 from Erik Johnson e...@saltstack.com ---
I will need branches for: el5, el6, epel7, f20, f19, and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #3 from Erik Johnson e...@saltstack.com ---
The referenced SPEC should build for all but el5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1113310



--- Comment #4 from Erik Johnson e...@saltstack.com ---
I just realized that I posted a link to the actual RPM, not the SRPM. Corrected
url for the SRPM is:
http://terminalmage.net/redhat/python-libnacl/python-libnacl-1.0.0-1.el6.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review