[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-horde-Horde-CssMinify-1 |php-horde-Horde-CssMinify-1 |.0.1-1.fc20 |.0.1-1.el6 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-CssMinify-1.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-horde-Horde-CssMinify-1 ||.0.1-1.fc20 Resolution|--- |ERRATA Last Closed||2014-08-01 02:01:49 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-CssMinify-1.0.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-CssMinify-1.0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-horde-Horde-CssMinify-1.0.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-CssMinify-1.0.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-CssMinify-1.0.1-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- php-horde-Horde-CssMinify-1.0.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||karlthe...@gmail.com
Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
Flags||fedora-review+
--- Comment #3 from Haïkel Guémar karlthe...@gmail.com ---
Since this package complies with Fedora general and PHP specific guidelines, I
hereby approve it into Fedora Packages Collection. Please go forward with the
scm request.
I took packager comments into account, I have full confidence that Remi will
cleanup thel EL-5 after import
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 3 files have unknown license. Detailed output of
licensecheck in /home/haikel/1117438-php-horde-Horde-
CssMinify/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Remi Collet fed...@famillecollet.com --- Thanks for the review ! New Package SCM Request === Package Name: php-horde-Horde-CssMinify Short Description: CSS Minification Upstream URL: http://www.horde.org/ Owners: remi Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438
--- Comment #5 from Haïkel Guémar karlthe...@gmail.com ---
My apologies, I didn't paste the right file.
Here's the completed review summary.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 3 files have unknown license. Detailed output of
licensecheck in /home/haikel/1117438-php-horde-Horde-
CssMinify/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: Buildroot is not present
Note: Buildroot: present but not needed
[-]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]:
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 --- Comment #2 from Remi Collet fed...@famillecollet.com --- Update to 1.0.1 https://github.com/remicollet/remirepo/commit/09ea05b920c537459f9c6acbcc1dad9df482d0ef Spec: https://raw.githubusercontent.com/remicollet/remirepo/09ea05b920c537459f9c6acbcc1dad9df482d0ef/php/horde/php-horde-Horde-CssMinify/php-horde-Horde-CssMinify.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-CssMinify-1.0.1-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117438] Review Request: php-horde-Horde-CssMinify - CSS Minification
https://bugzilla.redhat.com/show_bug.cgi?id=1117438 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Alias||Horde_CssMinify --- Comment #1 from Remi Collet fed...@famillecollet.com --- I will clean EL-5 stuff after import. This is a new dependency of Horde_Core 2.12.0 (for Horde 6.2) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
