[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2014-08-15 20:29:09 |2017-05-07 01:52:41 --- Comment #12 from Fedora Update System --- rapidjson-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords||Reopened --- Comment #11 from Fedora Update System --- rapidjson-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7e87825459 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 --- Comment #10 from Fedora Update System --- rapidjson-1.1.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-7e87825459 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Fixed In Version|rapidjson-0.12-0.1.git20140 |rapidjson-0.12-0.1.git20140 |801.67143c2.fc19|801.67143c2.fc20 --- Comment #9 from Fedora Update System --- rapidjson-0.12-0.1.git20140801.67143c2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rapidjson-0.12-0.1.git20140 ||801.67143c2.fc19 Resolution|--- |ERRATA Last Closed||2014-08-15 20:29:09 --- Comment #8 from Fedora Update System --- rapidjson-0.12-0.1.git20140801.67143c2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 --- Comment #7 from Michael Schwendt --- > rapidjson-0.12-0.1.git20140801.67143c2.fc20 That's a slightly abnormal release tag, since if following the guidelines the snapshot date would be put before the RCS id (since it may be more significant in versioned dependencies and during snapshot updates): rapidjson-0.12-0.1.20140801git67143c2.fc20 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages [Of course, for basic updates the 0.X at the very left of %release would be most-significant and sufficient if increased properly for all updates.] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- rapidjson-0.12-0.1.git20140801.67143c2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 --- Comment #4 from Fedora Update System --- rapidjson-0.12-0.1.git20140801.67143c2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rapidjson-0.12-0.1.git20140801.67143c2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 --- Comment #5 from Fedora Update System --- rapidjson-0.12-0.1.git20140801.67143c2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rapidjson-0.12-0.1.git20140801.67143c2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Björn "besser82" Esser changed: What|Removed |Added Status|NEW |POST Flags||fedora-cvs? --- Comment #2 from Björn "besser82" Esser --- Thanks for the quick review, Christian! # New Package SCM Request === Package Name: rapidjson Short Description: Fast JSON parser and generator for C++ Upstream URL: http://miloyip.github.io/rapidjson Owners: besser82 Branches: f19 f20 f21 el5 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380
Christian Dersch changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #1 from Christian Dersch ---
Review done, looks fine :)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (3 clause)", "BSD (2 clause)", "ISC", "Unknown or generated", "BSD
(4 clause)". 88 files have unknown license. Detailed output of
licensecheck in /home/review/1127380-rapidjson/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rapidjson-
devel , rapidjson-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Christian Dersch changed: What|Removed |Added CC||chrisder...@gmail.com Assignee|nob...@fedoraproject.org|chrisder...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127380] Review Request: rapidjson - Fast JSON parser and generator for C++
https://bugzilla.redhat.com/show_bug.cgi?id=1127380 Björn "besser82" Esser changed: What|Removed |Added Blocks||1126983 Alias||rapidjson Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1126983 [Bug 1126983] Review Request: cereal - Header-only C++11 serialization library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
