[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-11-22 01:24:56



--- Comment #12 from Fedora Update System  ---
FEDORA-2020-69e1016486 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
FEDORA-2020-69e1016486 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-69e1016486 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-69e1016486

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #10 from Fedora Update System  ---
FEDORA-2020-69e1016486 has been submitted as an update to Fedora 33.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-69e1016486


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162



--- Comment #9 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/badvpn


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162



--- Comment #8 from Pete Walter  ---
Nice, thanks, Robert-André! Requested the repo now. (I don't need a sponsor: I
got sponsored years ago.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Robert-André Mauchin   changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Robert-André Mauchin   ---
Package approved, you still need to find a sponsor.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162



--- Comment #6 from Pete Walter  ---
Thanks for taking this review, Robert-André! I've hopefully fixed up all the
issues you pointed out. "mycmake" define is a define, not a global because it's
supposed to be local to the %build section.

Spec URL: https://pwalter.fedorapeople.org/badvpn.spec
SRPM URL: https://pwalter.fedorapeople.org/badvpn-1.999.130-1.fc33.src.rpm

* Sat Aug 29 2020 Pete Walter  - 1.999.130-1
- Update to 1.999.130
- Switch to new cmake macros
- Switch to autosetup
- Add gcc BuildRequires
- Remove no longer needed buildroot cleaning in install section

koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=50440205


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com



--- Comment #5 from Robert-André Mauchin   ---
 - make %{?_smp_mflags} → %cmake_build

 - Not needed

rm -rf $RPM_BUILD_ROOT

 - %make_install → %cmake_install

See https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds for
the out of source builds.

 - Bump to 1.999.130

 - Add a BR against gcc

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
 License", "*No copyright* BSD 3-clause "New" or "Revised" License",
 "*No copyright* [generated file]", "GNU General Public License v3.0 or
 later", "*No copyright* GNU General Public License v2.0 or later",
 "*No copyright* Public domain", "BSD 4-clause "Original" or "Old"
 License", "NTP License". 360 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/badvpn/review-
 badvpn/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, 

needinfo canceled: [Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Pete Walter  has canceled Package Review
's request for Pete Walter
's needinfo:
Bug 1157162: Review Request: badvpn - Peer-to-peer VPN solution
https://bugzilla.redhat.com/show_bug.cgi?id=1157162
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Pete Walter  changed:

   What|Removed |Added

  Flags|needinfo?(walter.pete@yande |
   |x.com)  |




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Pete Walter  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #3 from Pete Walter  ---
Removing FE-NEEDSPONSOR tracker as I just got sponsored.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162



--- Comment #2 from Pete Walter  ---
(In reply to Eduardo Mayorga from comment #1)
> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>  beginning of %install.
> 
> Please remove that line.

Agreed; thanks for pointing this out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Eduardo Mayorga  changed:

   What|Removed |Added

 CC||e...@mayorgalinux.com



--- Comment #1 from Eduardo Mayorga  ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.

Please remove that line.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157162] Review Request: badvpn - Peer-to-peer VPN solution

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157162

Pete Walter walter.p...@ymail.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review