[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|needinfo?(pyn...@gmail.com) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2015-07-24 00:39:30 --- Comment #10 from Eduardo Echeverria echevemas...@gmail.com --- I don't think so, this potential contributor has not responded for seven months, so it is unlikely that him could follow with this package. i will close for now, feel free to open a new review request if you still are interested to work in this -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||pyn...@gmail.com Flags||needinfo?(pyn...@gmail.com) --- Comment #9 from Parag AN(पराग) panem...@gmail.com --- Any progress here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #7 from Eduardo Echeverria echevemas...@gmail.com --- Walter, any update here? that week was very long :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #8 from Walter D. Vargas pyn...@gmail.com --- Hi Eduardo. ok, I'm ready to go with the package. only for now I must finish setting up my computer because I have recently installed fedora-workstation, I must prepare the environment while doing some maintenance on some machines, but this week and I'll be more active, and yes, it was definitely very long week :( best said the project. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #6 from Walter D. Vargas pyn...@gmail.com --- hello guys, I want to thank you for all the support and suggestions. I must inform you that at this moment I'm working on a project that ends this week, and for that reason I could not do any upgrade. next week and will be with more time and we will do everything possible to advance. Greetings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #5 from Eduardo Echeverria echevemas...@gmail.com --- Any update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201
William Moreno williamjmore...@gmail.com changed:
What|Removed |Added
CC||williamjmore...@gmail.com
--- Comment #2 from William Moreno williamjmore...@gmail.com ---
Hello Walter:
I am not a new packagers sponsonr but I can help in the review procces of your
package with a informal review, please remember than you will need to look for
a sponsor to aprove your request:
I am only comments some points than require atention:
[!]: Package consistently uses macros (instead of hard-coded directory names).
We have defined this macros than you can use in the %%files sección
%{python2_sitelib}/%{pypi_name}
%{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
If you are not going to Epel can remove firts lines of the .spec, this macros
are allready defined in Fedora
Here is a example of a .spec you can check:
https://williamjmorenor.fedorapeople.org/rpmdev/python-slugify.spec
Rpmlint
---
Checking: python-flask-imgur-0.1-1.fc20.noarch.rpm
python-flask-imgur-0.1-1.fc20.src.rpm
python-flask-imgur.noarch: E: description-line-too-long C This is simple flask
extension allowing uploading images straight to Imgur image hosting service.
python-flask-imgur.noarch: W: no-documentation
python-flask-imgur.src: E: description-line-too-long C This is simple flask
extension allowing uploading images straight to Imgur image hosting service.
python-flask-imgur.src:31: W: macro-in-comment %{__python2}
python-flask-imgur.src:45: W: macro-in-comment %{python_sitearch}
2 packages and 0 specfiles checked; 2 errors, 3 warnings.
Error:
Remember than spec file must fill in 80 characteres per line,
Warning:
You have this line in your %%files section
# For arch-specific packages: sitearch
#%{python_sitearch}/*
If this is not needed remove it for the .spec
Also upstream is not providing a License file in the tarball, you can patch it,
and request upstream to add the License file in futures releases.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201
Eduardo Echeverria echevemas...@gmail.com changed:
What|Removed |Added
CC||echevemas...@gmail.com
--- Comment #3 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Parag, I'm serving as mentor of walter since the latest fudcon. (along with
other guys) they are trying to package some flask libraries that yet not are in
fedora.
Walter, will be very appreciated that you could do some informal reviews to
other packagers, or take some packages of the discussed list in fudcon.
I'm able to sponsor to you, if one of these conditions are accomplished.
So, we can pass to the comments.
It is good habit, (in the case of python packages) see the setup.py, the
requirements files, or the imports of the files for looking for the requires
of the package.
if you see the setup.py
install_requires=[Flask, six = 1.7.3],
and in the flask-imgur.py you can see
from six.moves import urllib
As you can see, you need the requires, Flask and python-six
- Take into account the William's comments.
- Remove the flags of the %build section. it is only needed if the package
contains arched contents
- Clean manually the buildroot it is not necessary in newer versions of fedora
(this applies only in epel5) - see %install section = rm -rf $RPM_BUILD_ROOT
- BTW, remove the unneded comments
# For noarch packages: sitelib
And please, list the files one per one, this is not mandatory, but if in the
future there are content that not accomplish with fedora guidelines, you can
see of the quick way.
= %{python_sitelib}/*
Do you want package this for epel, if so, take into account that the macro
%{_python2} does not exists there
Use this workaround
%{!?__python2: %global __python2 %{__python}}
Also, will be good see the epel guidelines.
Hoping your revisions.
Thanks :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #4 from Parag AN(पराग) panem...@gmail.com --- Edurado, Sure go ahead and sponsor this person :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app. this is my first package, i need a Sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Walter D. Vargas pyn...@gmail.com changed: What|Removed |Added Summary|Review Request: |Review Request: |python-flask-imgur - |python-flask-imgur - Upload |Upload images straight to |images straight to Imgur in |Imgur in your Flask app.|your Flask app. this is my |this is my first package, i |first package, i need a |need a Sponsor.|Sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Summary|Review Request: |Review Request: |python-flask-imgur - Upload |python-flask-imgur - Upload |images straight to Imgur in |images straight to Imgur in |your Flask app. this is my |your Flask app. |first package, i need a | |Sponsor.| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.
https://bugzilla.redhat.com/show_bug.cgi?id=1157201 --- Comment #1 from Parag AN(पराग) panem...@gmail.com --- Hi Walter, We have this process http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group to get sponsored in packager group. Can you either submit few more packages and/or some (3-5) package reviews? This is needed to make sure package submitter understands packaging well and follows as per fedora packaging guidelines. Please go through links 1) http://fedoraproject.org/wiki/Package_Review_Process 2) https://fedoraproject.org/wiki/PackagingGuidelines 3) To find package already submitted for review check http://fedoraproject.org/PackageReviewStatus/ 4) http://fedoraproject.org/wiki/Packaging:ReviewGuidelines 5) https://fedorahosted.org/FedoraReview/ this is fedora-review tool to help review packages in fedora. If you got any questions please ask :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
