[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #30 from Package Review  ---
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #29 from Ben Rosser  ---
Actually, on further thought, I do not believe it makes sense for ufoai and
ufoai-data to be separate source packages. This makes the directory ownership
logic simpler-- if all the packages (data and data-server) included can depend
on ufoai-common, ufoai-common can own /usr/share/ufoai and
/usr/share/ufoai/base.

I'm guessing this separation predated noarch subpackages?

The licensing needs to be checked carefully, and I have not done that (I don't
know if the License: tag breakdown that was in the spec is accurate). And a
decision needs to be reached on unbundling. So I'm not proposing this for
review. But you can grab my revised spec here:

https://tc01.fedorapeople.org/ufoai/ufoai.spec

A patch from Osipov is mirrored here, along with my configure script patch:

https://tc01.fedorapeople.org/ufoai/ufoai-2.5-desktop-files.patch
https://tc01.fedorapeople.org/ufoai/ufoai-configure-invalid-option.patch

And a SRPM of ufoai 2.5 is here:

https://tc01.fedorapeople.org/ufoai/ufoai-2.5-3.fc28.src.rpm

If I feel sufficiently motivated to double-check all the licensing and look at
the bundling over the next few days, I might even submit a new review request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/KM2K6AFM7LGU2PLLQGYFV5BSHZUV5QWH/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #28 from Ben Rosser  ---
Well... I have gone through ufoai.spec and cleaned it up, modernizing and
fixing some things.

In particular I patched the configure script so that it does not fail when it
receives unrecognized options, meaning that the %configure macro can be used.

I then had to do some work to get the package to build at all; the biggest
thing that worries me is that I had to add -Wno-narrowing to CFLAGS to get
things to compile, which maybe isn't okay.

I have yet to take a detailed look at the ufoai-data package, but I am assuming
the issue with unbundling things is that all the data files are compressed into
.pk3 archives, so the pk3s would need to be extracted, content unbundled, and
then re-packed.

I am not sure if this is worth it, honestly, especially given the more lenient
bundling guidelines of the present day. Since we know that horai-ume-fonts has
been approved by Fedora Legal, I don't know if there's really a problem with
keeping it in this package anymore. I don't particularly feel motivated to do
it, anyway.

But I will post the updated specs somewhere.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2IBT74RB5JY5SGSRYM5ZHUO5REYJMDAL/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #27 from Sergio Monteiro Basto  ---
Meanwhile somebody unbundled fonts properly (and I think I read that is more
stuff), I could update it in RPMFusion .
Unfortunately infrastructure of RPMFusion can't handle with 1 GByte of data, we
need to think in one solution for end user download data from other place , for
example using lpf.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IEV34XIH2YHUYSS5ZKIPYZYQR55R26RC/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #26 from Ben Rosser  ---
@Karel: okay, understood. 

Since the submitter has not responded to a couple pings, I propose that this
ticket be closed in accordance with the stalled review policy.

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

@Sergio: I thought the RPM Fusion ufoai package was orphaned/retired, actually.
I was surprised to see it in your list of FTFBS packages. :(

Probably it should be retired from RPM Fusion, and someone should write a new,
clean 2.5 spec written for Fedora, with the fonts properly unbundled?

I'd be happy to review. (I would submit the package myself, but I've been
pretty busy lately and I'm not sure I will have the time in the near future).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HEBRMMAYN2T4T4I2XXHA2DLLXJU7WEWL/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #25 from Marcin Zajaczkowski  ---
@Sergio, I packaged 2.5 (then "DEV") for Fedora -
https://ufoai.org/forum/index.php/topic,8508.0.html . It might be somehow
useful for you to update the rpmfusion version (nevertheless it was almost 5
years ago, in the moment when I wanted to play UFOAI once again after a few
years of break, there could have benn many changes in since then).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/YP3VZRIZ5TUD7RXW5DK5RAVWG7EWFSSU/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #24 from Sergio Monteiro Basto  ---
So without modification, ufoai still not free ? 

Meanwhile we may update ufoai to 2.5 in Rpmfusion , in last mass rebuild I
notice that ufoai was never built successfully in new infrastructure [1] and
still in version 2.4 ! 

[1]
http://koji.rpmfusion.org/koji/packageinfo?packageID=417

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HAYUBNCFNTEDOU3EARSSPNOJGVCYQJ7Z/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Karel Volný  changed:

   What|Removed |Added

 CC|kvo...@redhat.com   |
  Flags|needinfo?(kvo...@redhat.com |
   |)   |



--- Comment #23 from Karel Volný  ---
(In reply to Ben Rosser from comment #22)
> I have some spare time; what is it that needs to be done to continue this? I
> would be happy to review, but it sounds like the submission itself needs to
> be modified first to depend on the system copy of horai-ume-fonts?

oops, sorry for missing this

please get back to comment #7, it's not just horai-ume-fonts

also please review comment #2 if everything had been resolved

and most important, find someone really interested in this to cooperate with
you, either taking the packager or reviewer roles

I'm not going to touch this anymore -

https://ufoai.org/forum/index.php/topic,9156.0.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/CNLB6VWNLVO5HASZ5ALDOGGYUT7X6374/

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Ben Rosser  changed:

   What|Removed |Added

 CC||legol...@yandex.ru
  Flags||needinfo?(legolegs@yandex.r
   ||u)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Ben Rosser  changed:

   What|Removed |Added

  Flags||needinfo?(kvo...@redhat.com
   ||)



--- Comment #22 from Ben Rosser  ---
I have some spare time; what is it that needs to be done to continue this? I
would be happy to review, but it sounds like the submission itself needs to be
modified first to depend on the system copy of horai-ume-fonts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #21 from Tom "spot" Callaway  ---
Removing FE-Legal block here. Font is "mplus" licensed.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #20 from Karel Volný  ---
(In reply to Sergio Monteiro Basto from comment #19)
> (In reply to Karel Volný from comment #10) 
> > meanwhile, the license got simplified, however still I'm unsure how is it
> > treated in Fedora, so I've resent a question to
> > le...@lists.fedoraproject.org today
> 
> first it accepted by Fedora legal or not ?

yep, the fonts are in Fedora already

ping, is there anyone having some spare time to continue with this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Sergio Monteiro Basto  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #19 from Sergio Monteiro Basto  ---
Hi,

(In reply to Karel Volný from comment #10) 
> meanwhile, the license got simplified, however still I'm unsure how is it
> treated in Fedora, so I've resent a question to
> le...@lists.fedoraproject.org today

first it accepted by Fedora legal or not ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1364745




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] (FE-GAMESIG) Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #18 from Osipov Oleg  ---
Yes I do need a reviewer and/or a sponsor. I need to cut out Umefont from the
package though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com



--- Comment #17 from Ben Rosser  ---
It looks like the font issue has been resolved-- does that mean this review can
proceed? Are you in need of a reviewer?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Karel Volný  changed:

   What|Removed |Added

  Flags|needinfo?(kvo...@redhat.com |
   |)   |



--- Comment #14 from Karel Volný  ---
(In reply to Neal Gompa from comment #13)
> I just saw your email thread in Fedora Legal about the Umefont license[0].
> Have you received a sufficient answer for packaging it yet?
> 
> [0]:
> https://lists.fedoraproject.org/archives/list/legal%40lists.fedoraproject.
> org/thread/VEPUXYCFJG6XSLPJHDBDH5NUXSWAEH2I/

I'm not sure ... I can try go with that and sort it out with the reviewer

I'll try to submit the review request ASAP (feel free to ping me if it feels
too long :-))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #15 from Marcin Zajaczkowski  ---
Btw, as a additional encouragement to make it a part of the official Fedora
repository there is already an offer to donate $30 as a thank you :)
http://ufoai.org/forum/index.php/topic,8932.0.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #16 from Karel Volný  ---
(In reply to Karel Volný from comment #14)
> I'll try to submit the review request ASAP (feel free to ping me if it feels
> too long :-))

ok, I've found some time today ... bug #1301144

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #13 from Neal Gompa  ---
(In reply to Karel Volný from comment #12)
> (In reply to Neal Gompa from comment #11)
> > Your ufoai-data package spec is missing the %{?dist} tag in the Release
> > field (like how the ufoai package spec has it).
> 
> originally that was done on purpose, not to duplicate the same data in
> buildsys and on mirrors
> 
> > @Karel, it seems your email got moderated out of Fedora Legal, as I don't
> > see it in the archives[0].
> 
> it seems that the archives are broken (or just late?) as I don't see
> anything for this January while I've already received my e-mail back from
> the list and also an answer from Dmitry Alexandrov
> 
> note that I also do not see any 2016's messages on e.g. test-list:
> https://lists.fedoraproject.org/pipermail/test/
> 
> the archive for December suggests that it stopped on Christmas:
> 
> Starting: Sun Nov 1 03:04:30 UTC 2015
> Ending: Mon Nov 23 01:00:31 UTC 2015
> 
> 
> > The Umefont license[1] appears to be an extremely permissive license, so I
> > don't expect it to be a problem, but that said, this font license question
> > does need to be answered, so I'm setting FE-Legal to block it.
> 
> well, the only problem now is that I cannot find *that much* permissive
> licence on the list of approved
> 
> Dmitry suggested that it might be substituted with CopyrightOnly
> [https://fedoraproject.org/wiki/Licensing:CopyrightOnly]
> 
> The page says "You don't have to list this if you don't want to." which
> would probably apply here too, but not listing any license in the spec is
> considered blocker these days if I recall correctly ...

I just saw your email thread in Fedora Legal about the Umefont license[0]. Have
you received a sufficient answer for packaging it yet?

[0]:
https://lists.fedoraproject.org/archives/list/legal%40lists.fedoraproject.org/thread/VEPUXYCFJG6XSLPJHDBDH5NUXSWAEH2I/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Neal Gompa  changed:

   What|Removed |Added

  Flags||needinfo?(kvo...@redhat.com
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #12 from Karel Volný  ---
(In reply to Neal Gompa from comment #11)
> Your ufoai-data package spec is missing the %{?dist} tag in the Release
> field (like how the ufoai package spec has it).

originally that was done on purpose, not to duplicate the same data in buildsys
and on mirrors

> @Karel, it seems your email got moderated out of Fedora Legal, as I don't
> see it in the archives[0].

it seems that the archives are broken (or just late?) as I don't see anything
for this January while I've already received my e-mail back from the list and
also an answer from Dmitry Alexandrov

note that I also do not see any 2016's messages on e.g. test-list:
https://lists.fedoraproject.org/pipermail/test/

the archive for December suggests that it stopped on Christmas:

Starting: Sun Nov 1 03:04:30 UTC 2015
Ending: Mon Nov 23 01:00:31 UTC 2015


> The Umefont license[1] appears to be an extremely permissive license, so I
> don't expect it to be a problem, but that said, this font license question
> does need to be answered, so I'm setting FE-Legal to block it.

well, the only problem now is that I cannot find *that much* permissive licence
on the list of approved

Dmitry suggested that it might be substituted with CopyrightOnly
[https://fedoraproject.org/wiki/Licensing:CopyrightOnly]

The page says "You don't have to list this if you don't want to." which would
probably apply here too, but not listing any license in the spec is considered
blocker these days if I recall correctly ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
 Blocks||182235 (FE-Legal)



--- Comment #11 from Neal Gompa  ---
Your ufoai-data package spec is missing the %{?dist} tag in the Release field
(like how the ufoai package spec has it).

@Karel, it seems your email got moderated out of Fedora Legal, as I don't see
it in the archives[0].

The Umefont license[1] appears to be an extremely permissive license, so I
don't expect it to be a problem, but that said, this font license question does
need to be answered, so I'm setting FE-Legal to block it.

[0]: https://lists.fedoraproject.org/pipermail/legal/
[1]: https://osdn.jp/projects/ume-font/wiki/FrontPage#h2-Licence


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #10 from Karel Volný  ---
(In reply to Ali Akcaagac from comment #9)
> So how about properl packaging the game as well ? Under Fedora 22 I only
> find the data files for client and server but no game files. Am I missing
> something ?

well, what is missing is the manpower :-/

I got stuck with the font package because it needs the license approved, and my
email to legal@ got somehow moderated out and I hadn't find the time to resolve
the issue ...

meanwhile, the license got simplified, however still I'm unsure how is it
treated in Fedora, so I've resent a question to le...@lists.fedoraproject.org
today

also, more tweaks are needed, see the above discussion, helping hands welcome
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Ali Akcaagac  changed:

   What|Removed |Added

 CC||ali...@web.de



--- Comment #9 from Ali Akcaagac  ---
So how about properl packaging the game as well ? Under Fedora 22 I only find
the data files for client and server but no game files. Am I missing something
?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #8 from Karel Volný kvo...@redhat.com ---
so, I'll try to get the font packaged properly:

https://fedoraproject.org/wiki/Ume_fonts
https://lists.fedoraproject.org/pipermail/fonts/2014-November/001764.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #3 from Osipov Oleg legol...@yandex.ru ---
how about %configure --enable-ufoded --enable-release. ?
Does not work, build.log:
+ ./configure --build=x86_64-redhat-linux-gnu long blahblah skipped
invalid option --build=x86_64-redhat-linux-gnu

UFO:AI does not use autotools.

not needed
don't own this dirs
If game works ok - then you can remove it
Done.

%dir %{_docdir}/%{name}-%{version}
%doc %{_docdir}/%{name}-%{version}/README
%doc %{_docdir}/%{name}-%{version}/COPYING
use %doc instead.
Do you mean I should replace %{_docdir}/%{name}-%{version} to
%{_docdir}/%{name} all over specfile?

documentation
I'd enable it. PDF is cool =)
Just checked it out. It is outdated. What a surprise ;) Better to not include
it today, because not only UI has changed since the doc was written but the
game mechanics itself evolved including important stuff like reaction fire.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Osipov Oleg legol...@yandex.ru changed:

   What|Removed |Added

URL||https://github.com/legolegs
   ||/ufoai-rpms-fedora



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Marcin Zajaczkowski msz...@wp.pl changed:

   What|Removed |Added

 CC||msz...@wp.pl



--- Comment #4 from Marcin Zajaczkowski msz...@wp.pl ---
 Also building of documentation is disabling because (I think) making pdf 
 leads to hge build dependencies. And nobody ever reads manuals anyway :)

Exactly. I disabled it when was updating Fedora build to 2.5-dev [1]. For that
unofficial version documentation was optional and tetex-latex needed hundreds
of sub packages (which as I experienced in the past like to be updated a few
times a year).

[1] - http://ufoai.org/forum/index.php/topic,8508.0.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Karel Volný kvo...@redhat.com changed:

   What|Removed |Added

 CC||kvo...@redhat.com



--- Comment #5 from Karel Volný kvo...@redhat.com ---
(In reply to Osipov Oleg from comment #0)
 Copyright status:
 Today UFO:AI is a free software. Licenses: CC-A, CC-A-SA, GPL, GNU FDL, MIT,
 Public Domain (see
 http://sourceforge.net/p/ufoai/code/ci/ufoai_2.5.0/tree/LICENSES )

you have to update the License field in spec too, I think it should be like
this:

License:  CC-BY and CC-BY-SA and GFDL and GPLv2 and GPLv2+ and GPLv3+ and
MIT and Public Domain


*BUT* this list is missing the umefont license which has to be approved by
Fedora legal at first

and while at it, the font should be unbundled (as well as others - the whole
media pack in -data)


also, please change URL from http://ufoai.sourceforge.net/ to http://ufoai.org/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #6 from Osipov Oleg legol...@yandex.ru ---
umefont license which has to be approved by Fedora legal at first

Okay, here goes the text:
http://sourceforge.net/p/ufoai/code/ci/ufoai_2.5.0/tree/base/media/umefont-readme_license.html

the font should be unbundled
Not sure if I understood you right. Do you meant I need to made separate
package with fonts or to make the game use system fonts?

update the License field
change URL
Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #7 from Karel Volný kvo...@redhat.com ---
(In reply to Osipov Oleg from comment #6)
 the font should be unbundled
 Not sure if I understood you right. Do you meant I need to made separate
 package with fonts or to make the game use system fonts?

the game should use system fonts and depend on those packages; some are already
available (dejavu), those that aren't should be packaged in new font packages
(which is the case of umefont)

I refer to this rule in the packaging guidelines:

https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Osipov Oleg legol...@yandex.ru changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255



--- Comment #1 from Osipov Oleg legol...@yandex.ru ---
I must admit flaws in package. Firstly the opengl wrapper was disabled when I
adopted the package. I am not sure why it was done and how important wrapper
is.
Also building of documentation is disabling because (I think) making pdf leads
to hge build dependencies. And nobody ever reads manuals anyway :)

Please excuse me for multiposting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157255] Review Request: ufoai - UFO: Alien Invasion strategy game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1157255

Igor Gnatenko i.gnatenko.br...@gmail.com changed:

   What|Removed |Added

 CC||i.gnatenko.br...@gmail.com



--- Comment #2 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
# don't use %%configure, UFOAI doesn't like default configure options
./configure \
   --disable-dependency-tracking \
   --prefix=%{_prefix} \
   --bindir=%{_bindir} \
   --datadir=%{_datadir}/%{name} \
   --libdir=%{_libdir}/%{name} \
   --localedir=%{_datarootdir}/locale \
   --disable-testall \
   --enable-ufoded \
   --enable-uforadiant \
   --enable-ufo2map \
   --enable-ufomodel \
   --enable-release
how about %configure --enable-ufoded --enable-release. ?

%clean
rm -rf %{buildroot}
and
%defattr(-,root,root,-)
not needed

%dir %{_datadir}/icons/hicolor/
%dir %{_datadir}/icons/hicolor/32x32/
%dir %{_datadir}/icons/hicolor/32x32/apps/
No, don't own this dirs. 
$ rpm -qf /usr/share/icons/hicolor/
hicolor-icon-theme-0.13-2.fc21.noarch

Firstly the opengl wrapper was disabled when I adopted the package. I am not 
sure why it was done and how important wrapper is.
If game works ok - then you can remove it. For example, teeworlds buggy without
it.

# we need to use full path so %%doc does not the cleanup
%dir %{_docdir}/%{name}-%{version}
%doc %{_docdir}/%{name}-%{version}/README
%doc %{_docdir}/%{name}-%{version}/COPYING
use %doc instead. for f20+ or f21+ we're using non-versioned doc dirs.

Also building of documentation is disabling because (I think) making pdf leads 
to hge build dependencies. And nobody ever reads manuals anyway :)
I'd enable it. PDF is cool =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review