https://bugzilla.redhat.com/show_bug.cgi?id=1158188
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mizde...@redhat.com
Assignee|nob...@fedoraproject.org|mizde...@redhat.com
Flags||fedora-review+
--- Comment #1 from Mikolaj Izdebski mizde...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Check
[x] rpmlint must be run on the source rpm and all binary rpms the
build produces. The output should be posted in the review.
[x] The package must be named according to the Package Naming
Guidelines.
[x] The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[x] The package must meet the Packaging Guidelines.
[x] The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[x] The License field in the package spec file must match the actual
license.
[x] If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc.
[x] The spec file must be written in American English.
[x] The spec file for the package MUST be legible.
[x] The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use
sha256sum for this task as it is used by the sources file once
imported into git. If no upstream URL can be specified for this
package, please see the Source URL Guidelines for how to deal with
this.
[x] The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[x] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the
spec in ExcludeArch. Each architecture listed in ExcludeArch MUST
have a bug filed in bugzilla, describing the reason that the
package does not compile/build/work on that architecture. The bug
number MUST be placed in a comment, next to the corresponding
ExcludeArch line.
[x] All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging
Guidelines; inclusion of those as BuildRequires is optional.
Apply common sense.
[x] The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly
forbidden.
[x] Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[x] Packages must NOT bundle copies of system libraries.
[x] If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the
rationalization for relocation of that specific package. Without
this, use of Prefix: /usr is considered a blocker.
[x] A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a
package which does create that directory.
[x] A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in
specific situations.)
[x] Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
[x] Each package must consistently use macros.
[x] The package must contain code, or permissible content.
[x] Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement,
but is not restricted to size. Large can refer to either size or
quantity).
[x] If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the
program must run properly if it is not present.
[x] Static libraries must be in a -static package.
[x] Development files must be in a -devel package.
[x] In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires:
%{name}%{?_isa} = %{version}-%{release}
[x] Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[x] Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed
with desktop-file-install in the %install section. If you feel
that your packaged GUI application does not need a .desktop file,
you must put a comment in the spec file with your explanation.
[x] Packages
