[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Bug 1163739 depends on bug 1163814, which changed state. Bug 1163814 Summary: Review Request: sonar - An open platform to manage code quality https://bugzilla.redhat.com/show_bug.cgi?id=1163814 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Bug 1163739 depends on bug 1163816, which changed state. Bug 1163816 Summary: Review Request: sonar-runner - Default launcher to analyze a project with SonarQube https://bugzilla.redhat.com/show_bug.cgi?id=1163816 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Bug 1163739 depends on bug 843417, which changed state. Bug 843417 Summary: groovy-2.3.7 is available https://bugzilla.redhat.com/show_bug.cgi?id=843417 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-11-19 09:42:56 --- Comment #11 from Mikolaj Izdebski mizde...@redhat.com --- Built for rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=8186205 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739
--- Comment #4 from Michael Simacek msima...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- There is bundled jar gradle/wrapper/gradle-wrapper.jar, I'd like to
have it removed in %prep
- Bundled
subprojects/diagnostics/src/main/resources/org/gradle/api/tasks/diagnostics/htmldependencyreport/jquery.jstree.js
has different license so the license tag should reflect it (the
bundling itself is probably ok, because of the javascript FPC
exception)
f-r generated:
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/share/java/gradle/gradle-base-
services-groovy.jar
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- Sources used to build the package match the upstream source, as provided in
the spec URL.
Note: Upstream MD5sum check error, diff is in
/home/msimacek/reviews/1163739-gradle/diff.txt
See: http://fedoraproject.org/wiki/Packaging/SourceURL
- That's the all-released-versions.json file, I don't think it's a problem
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), BSL (v1.0), MIT/X11 (BSD like), LGPL (v2 or later)
(with incorrect FSF address), Unknown or generated. 382 files have
unknown license. Detailed output of licensecheck in
/home/msimacek/reviews/1163739-gradle/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-poms/gradle, /usr/share/maven-
metadata
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/java/xmvn, /usr/share
/maven-poms/gradle, /usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in gradle
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Java:
[!]: Bundled jar/class files should be removed before build
Note: Test run failed
[x]: Packages have
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Michael Simacek msima...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||msima...@redhat.com Assignee|nob...@fedoraproject.org|msima...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 --- Comment #3 from Mikolaj Izdebski mizde...@redhat.com --- Updated package (updated to sonar from F22, added a few spec comments): Spec URL: https://raw.githubusercontent.com/mizdebsk/gradle-packaging/20c6c6a5aa7e53aac06f1c8c6faae6ab7ac764a9/gradle.spec SRPM URL: http://kojipkgs.fedoraproject.org/work/cli-build/1416299532.412575.EXdDDPeo/gradle-2.2-0.45.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 --- Comment #5 from Mikolaj Izdebski mizde...@redhat.com --- Updated package: %changelog * Tue Nov 18 2014 Mikolaj Izdebski mizde...@redhat.com - 2.2-0.46 - Remove bundled wrapper JAR - Remove bundled JavaScript - Refresh all-released-versions.json from upstream Spec URL: https://raw.githubusercontent.com/mizdebsk/gradle-packaging/c921cda14e405edd777c19e09d5640b83dd7d44d/gradle.spec SRPM URL: http://kojipkgs.fedoraproject.org/work/cli-build/1416317239.424539.TBtnmeGT/gradle-2.2-0.46.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Michael Simacek msima...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Michael Simacek msima...@redhat.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Mikolaj Izdebski mizde...@redhat.com --- Package Change Request == Package Name: gradle New Branches: f21 devel Owners: mizdebsk goldmann gil madsa msimacek msrb InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Mikolaj Izdebski mizde...@redhat.com --- Devel branch has not been unretired. Please unretire this branch too, as requested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Complete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Whiteboard|NotReady| --- Comment #2 from Mikolaj Izdebski mizde...@redhat.com --- (In reply to Mikolaj Izdebski from comment #1) Since Gradle depends on itself, I've requested bootstrap exception from FPC: https://fedorahosted.org/fpc/ticket/471 Bootstrap exception has been granted by FPC. New updated package: Spec URL: https://raw.githubusercontent.com/mizdebsk/gradle-packaging/21c03149fd8b4f49f07b712c3f7a01071e22ad56/gradle.spec SRPM URL: http://copr-be.cloud.fedoraproject.org/results/mizdebsk/gradle/fedora-rawhide-x86_64/gradle-2.2-0.42.fc22/gradle-2.2-0.42.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Depends On||843417 Whiteboard||NotReady Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug https://bugzilla.redhat.com/show_bug.cgi?id=843417 [Bug 843417] groovy-2.3.7 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 --- Comment #1 from Mikolaj Izdebski mizde...@redhat.com --- Since Gradle depends on itself, I've requested bootstrap exception from FPC: https://fedorahosted.org/fpc/ticket/471 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163739] Review Request: gradle - Build automation tool
https://bugzilla.redhat.com/show_bug.cgi?id=1163739 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Depends On||1163814, 1163816 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1163814 [Bug 1163814] Review Request: sonar - An open platform to manage code quality https://bugzilla.redhat.com/show_bug.cgi?id=1163816 [Bug 1163816] Review Request: sonar-runner - Default launcher to analyze a project with SonarQube -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
