[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Bug 1167136 depends on bug 1166851, which changed state. Bug 1166851 Summary: Review Request: python-husl - A Python implementation of HUSL https://bugzilla.redhat.com/show_bug.cgi?id=1166851 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-seaborn-0.5.1-4.fc21 Resolution|--- |ERRATA Last Closed||2014-12-11 23:32:22 --- Comment #13 from Fedora Update System --- python-seaborn-0.5.1-4.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- python-seaborn-0.5.1-4.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #11 from Fedora Update System --- python-seaborn-0.5.1-4.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-seaborn-0.5.1-4.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Sergio Pascual changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Sergio Pascual --- New Package SCM Request === Package Name: python-seaborn Short Description: Statistical data visualization in Python Upstream URL: http://stanford.edu/~mwaskom/software/seaborn/ Owners: sergiopr Branches: f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Florian "der-flo" Lehner changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Florian "der-flo" Lehner --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ---> https://github.com/mwaskom/seaborn/pull/379 [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-seaborn [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. ---> upstream does not include an license text file packager informed upstream and included the license text file as patch https://github.com/mwaskom/seaborn/pull/379 ---> so
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #7 from Sergio Pascual --- Done! Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn-0.5.1-4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #6 from Florian "der-flo" Lehner --- Hi Sergio! Please add an file containing the license text as an patch and mention that you reported the issue upstream in the comment to this patch. Cheers, Flo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #5 from Sergio Pascual --- (In reply to Florian "der-flo" Lehner from comment #4) > hi Sergio! > > there are some points: > > [ ] I miss the license text The tarball from pypi doesn't have a LICENSE file. I have opened a tiket upstream https://github.com/mwaskom/seaborn/issues/378 > [ ] Please add an comment for the patches you have made Done > [ ] from rpmlint: Error: explicit-lib-dependency python3-matplotlib As far as I can see, this is because python-matplotlib contains the string "lib" It's a false positive, see i.e. here https://bugzilla.redhat.com/show_bug.cgi?id=790869#c2 > > Cheers, > Flo Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn-0.5.1-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #4 from Florian "der-flo" Lehner --- hi Sergio! there are some points: [ ] I miss the license text [ ] Please add an comment for the patches you have made [ ] from rpmlint: Error: explicit-lib-dependency python3-matplotlib Cheers, Flo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #3 from Sergio Pascual --- I forgot to add the BR on python-husl... New SPEC & SRPM Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-seaborn-0.5.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 --- Comment #2 from Sergio Pascual --- Yes, I know, it's becasue python-husl is not yet in buildroot. Perhaps tomorrow. Thanks for the review, BTW! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Florian "der-flo" Lehner changed: What|Removed |Added Status|NEW |ASSIGNED CC||d...@der-flo.net Assignee|nob...@fedoraproject.org|d...@der-flo.net Flags||fedora-review? --- Comment #1 from Florian "der-flo" Lehner --- hi Sergio! Your SRPM fails to build. For more take a look at the logs at http://koji.fedoraproject.org/koji/taskinfo?taskID=8220790 Cheers, Florian -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1167136 Sergio Pascual changed: What|Removed |Added Depends On||1166851 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1166851 [Bug 1166851] Review Request: python-husl - A Python implementation of HUSL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review