[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Jerry James  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review?  |
Last Closed||2016-04-03 11:53:12



--- Comment #22 from Jerry James  ---
I waited much longer than a week with no response.  I am closing this review
due to an unresponsive submitter.  For those concerned about js-of-ocaml and
opam, note that the missing dependency is now not even proposed for review.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #21 from Jerry James  ---
This review is stalled.  Jon, please respond within one week if you intend to
continue with this review.

See https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #20 from Jerry James  ---
Jon, are you still interested in pursuing this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #19 from Jerry James  ---
I can take this review.  Jon, do you still need a sponsor?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- SHOULD issue: has upstream been approached about including a separate license
  file in the distribution?
- SHOULD issue: A short note about the patch (e.g., "# Enable building with
  debuginfo") would help others who look at the spec file
- SHOULD issue: the source distribution includes a test directory.  Is a %check
  script possible?
- SHOULD issue: Pass the -p flag (or -a) to cp when copying source files to
  preserve timestamps; this is the case with the first cp command in %install.
- Very minor issue: The comment in %files about the "following line" doesn't
  really refer to the following line.  I found that confusing for a second or
  two.
- Consider adding this to avoid producing an empty -debuginfo rpm on
  architectures with no native compiler:

%ifnarch %{ocaml_native_compiler}
%global debug_package %{nil}
%endif


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 21 files have unknown
 license. Detailed output of licensecheck in /home/jamesjer/1172771
 -ocaml-cmdliner/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already 

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #18 from Jon Ludlam  ---
Ack, I know that feeling :-( Good luck with them!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #17 from Andrew Beekhof  ---
Its probably best if someone else takes this.  
Too many daily "emergencies" on my end.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #16 from Jon Ludlam  ---
Hi Andrew, any update on this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Andrew Beekhof  changed:

   What|Removed |Added

  Flags|needinfo?(abeekhof@redhat.c |
   |om) |



--- Comment #15 from Andrew Beekhof  ---
Rich, absolutely.
Unless it cant wait until after the openstack summit.  
I wont get a lot done while I'm there :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #12 from Jon Ludlam  ---
Two new versions have been released since I made this - let me update it to the
latest version before anyone has a look.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #13 from Upstream Release Monitoring 
 ---
jonludlam's scratch build of ocaml-cmdliner-0.9.8-1.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11536701

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #14 from Jon Ludlam  ---
OK, updated.

Spec URL: http://www.recoil.org/~jon/ocaml-cmdliner.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-cmdliner-0.9.8-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #10 from Michel Alexandre Salim  ---
ps apologies for the delay - am guessing it's partly because the NEEDSPONSOR
tracker wasn't depended on, so potential sponsors didn't see this.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Michel Alexandre Salim  changed:

   What|Removed |Added

 CC||mic...@michel-slm.name
  Flags||needinfo?



--- Comment #9 from Michel Alexandre Salim  ---
Hi everyone,

What's the status on this?

Richard, your update to js-of-ocaml is actually breaking because of a
dependency on ocaml-cmdliner.

Jon - would be happy to sponsor if you're still interested in packaging this.
Let me know and I'll then proceed with a formal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Richard W.M. Jones  changed:

   What|Removed |Added

 CC||abeek...@redhat.com
  Flags|needinfo?   |needinfo?(abeekhof@redhat.c
   ||om)



--- Comment #11 from Richard W.M. Jones  ---
Andrew, do you want to review this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #8 from Jon Ludlam j...@recoil.org ---
As for uutf and jsonm, I've now included a license file explicitly in the SRPM.

Spec URL: http://www.recoil.org/~jon/ocaml-cmdliner.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-cmdliner-0.9.6-3.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 Blocks||1185099




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1185099
[Bug 1185099] Review Request: opam - A source-based package manager for
OCaml
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

 CC||rjo...@redhat.com



--- Comment #7 from Richard W.M. Jones rjo...@redhat.com ---
In general, the spec file looks OK.  I can't find any specific
problem to point out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771

Vasiliy Glazov vasc...@gmail.com changed:

   What|Removed |Added

 CC||vasc...@gmail.com



--- Comment #2 from Vasiliy Glazov vasc...@gmail.com ---
Please correct debuginfo package rpmlint error:

ocaml-cmdliner-debuginfo.x86_64: E: debuginfo-without-sources

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #3 from Jon Ludlam j...@recoil.org ---
Thanks Vasiliy. Should I bump the release number when I do?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #4 from Vasiliy Glazov vasc...@gmail.com ---
Yes. And create new post with updated Spec URL and SRPM URL. It must contain
changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #5 from Jon Ludlam j...@recoil.org ---
Fixed, thanks.

Spec URL: http://www.recoil.org/~jon/ocaml-cmdliner.spec
SRPM URL: http://www.recoil.org/~jon/ocaml-cmdliner-0.9.6-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #6 from Jon Ludlam j...@recoil.org ---
Also, koji link: http://koji.fedoraproject.org/koji/taskinfo?taskID=8348613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1172771] Review Request: ocaml-cmdliner - OCaml library for dealing with command line arguments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1172771



--- Comment #1 from Jon Ludlam j...@recoil.org ---
The guide for submitting these review requests suggests that I point out this
is my first submission and that I need a sponsor. I'm hoping Richard W.M. Jones
will help me out here!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review