[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Fedora Update System changed: What|Removed |Added Fixed In Version||python-pytest-multihost-0.6 ||-2.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System --- python-pytest-multihost-0.6-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Petr Viktorin changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-01-28 11:48:34 --- Comment #8 from Petr Viktorin --- Thanks for the review, and for the repo creation! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 --- Comment #7 from Fedora Update System --- python-pytest-multihost-0.6-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-pytest-multihost-0.6-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Petr Viktorin changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Petr Viktorin --- New Package SCM Request === Package Name: python-pytest-multihost Short Description: Utility for writing multi-host tests for pytest Upstream URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git Owners: pviktori Branches: f22 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Stephen Gallagher changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Stephen Gallagher --- Review approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 --- Comment #3 from Petr Viktorin --- Oops, forgot to change the license for both Pythons SRPM URL: https://fedorapeople.org/~pviktori/srpms/python-pytest-multihost-0.6-2.fc21.src.rpm Spec URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git/plain/python-pytest-multihost.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Petr Viktorin changed: What|Removed |Added Flags|needinfo?(pviktori@redhat.c | |om) | --- Comment #2 from Petr Viktorin --- Thanks for the review! SRPM URL: https://fedorapeople.org/~pviktori/srpms/python-pytest-multihost-0.6-1.fc21.src.rpm And these are just updated (same URL): Spec URL: https://git.fedorahosted.org/cgit/python-pytest-multihost.git/plain/python-pytest-multihost.spec COPR: https://copr.fedoraproject.org/coprs/pviktori/pytest-plugins/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Stephen Gallagher changed: What|Removed |Added CC||pvikt...@redhat.com Flags||needinfo?(pviktori@redhat.c ||om) --- Comment #1 from Stephen Gallagher --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = Issues - Use %license instead of %doc for COPYING. This will ensure that it's still installed, even if someone uses --nodocs with RPM (to maintain legal requirements. Also, in the future, RPM will treat %license as a hardlink opportunity to avoid duplicating licenses on the disk. - Upstream tarball contains tests but they are not run in %check If they cannot be run in %check, a comment to that effect should be provided. = MUST items = Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 20 files have unknown license. Detailed output of licensecheck in /dev/shm/reviews/1179336-python-pytest- multihost/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 102400 bytes in 4 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applica
[Bug 1179336] Review Request: python-pytest-multihost - Utility for writing multi-host tests for pytest
https://bugzilla.redhat.com/show_bug.cgi?id=1179336 Stephen Gallagher changed: What|Removed |Added CC||sgall...@redhat.com Assignee|nob...@fedoraproject.org|sgall...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review