[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sflphone-1.4.1-6.fc21 Resolution|--- |ERRATA Last Closed||2015-03-26 17:51:16 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- sflphone-1.4.1-6.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|sflphone-1.4.1-6.fc21 |sflphone-1.4.1-6.fc20 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- sflphone-1.4.1-6.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- sflphone-1.4.1-6.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- sflphone-1.4.1-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/sflphone-1.4.1-6.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- sflphone-1.4.1-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/sflphone-1.4.1-6.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added Alias||sflphone -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Sandro Mani manisan...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Sandro Mani manisan...@gmail.com --- Oh, never noticed that before, will need to fix it in a number of other packages as well! Thanks for the review! New Package SCM Request === Package Name: sflphone Short Description: SIP/IAX2 compatible enterprise-class software phone Owners: smani Branches: f20 f21 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Jerry James loganje...@gmail.com --- Hmmm, the -Wl,--as-needed addition stomped on Fedora's relro flags. How about doing this instead? LDFLAGS=$RPM_LD_FLAGS -Wl,--as-needed %configure No need to delay the review for that change, though. Please do that when you import the package into git. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698
--- Comment #4 from Jerry James loganje...@gmail.com ---
Issues, in no particular order.
1. Please use the %license macro instead of %doc for COPYING.
2. sflphone-common installs a file into /usr/share/dbus-1/services, which is
owned by the dbus package. Meanwhile, sflphone-libs has a dependency on
dbus-libs, but I don't see a dependency on dbus itself anywhere. Should
either -common or -libs Requires: dbus?
3. sflphone-kde owns /usr/share/icons/hicolor, as well as specific directories
under it (22x22, 32x32, etc.). However, hicolor-icon-theme is the proper
owner of those directories. The package should not own those directories,
but rather the files in them, and depend on hicolor-icon-theme.
4. Also, sflphone-kde owns /usr/share/applications/kde4, which is already
owned by kde-filesystem, which the package already Requires.
5. I wonder whether the -gnome and -kde subpackages should do this:
Requires: %{name}-libs%{?_isa} = %{version}-%{release}
instead of depending on sflphone-common. That way, you can get the
%{?_isa} in there to be sure there are no architecture mismatches, and
since -libs and -common depend on each other, the set of packages to be
installed doesn't change from its current state.
6. Rpmlint says:
sflphone-kde.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/sflphone-client-kde.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz). Install the icon as plain uncompressed SVG.
7. Rpmlint says:
sflphone-kde.x86_64: E: invalid-desktopfile
/usr/share/applications/kde4/sflphone-client-kde.desktop file contains group
Protocol, but groups extending the format should start with X-
8. Rpmlint also complains about unused direct shlib dependencies. Perhaps
linking should be done with -Wl,--as-needed?
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2), GPL (v2 or later), GPL (v3 or later), Unknown or
generated, GPL (v3 or later) (with incorrect FSF address), LGPL (v3
or later), GPL (v2 or later) (with incorrect FSF address), LGPL (v2.1
or later). 24 files have unknown license. Detailed output of
licensecheck in /home/jamesjer/1180698-sflphone/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/dbus-1,
/usr/lib64/sflphone, /usr/share/dbus-1/services
/usr/lib64/sflphone is a false positive; it is owned by the -libs
subpackage. The other 2 directories are owned by dbus. See issue 2
above.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora-logos,
pdfmod, imagination, gnome-activity-journal, poedit, xsane, gweled),
/usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme, gweled),
/usr/share/icons/hicolor/22x22(pdfmod, gweled, hicolor-icon-theme,
fedora-logos), /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme,
fedora-logos, imagination, gnome-activity-journal, poedit, xsane,
gweled), /usr/share/icons/hicolor/22x22/apps(pdfmod, gweled, hicolor-
icon-theme, fedora-logos, poedit), /usr/share/icons/hicolor/32x32/apps
(hicolor-icon-theme, fedora-logos, pdfmod, gnome-activity-journal,
poedit, xsane), /usr/share/applications/kde4(kde-filesystem),
/usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, fedora-logos,
pdfmod, imagination, gnome-activity-journal, poedit, gweled),
/usr/share/icons/hicolor/16x16(hicolor-icon-theme, fedora-logos, pdfmod,
imagination, xsane, gweled), /usr/share/icons/hicolor/128x128/apps
(hicolor-icon-theme), /usr/share/icons/hicolor/128x128(hicolor-icon-
theme), /usr/share/icons/hicolor/64x64(hicolor-icon-theme, gweled),
/usr/share/icons/hicolor/48x48(gweled, hicolor-icon-theme, fedora-logos,
xsane, imagination), /usr/share/icons/hicolor/32x32(pdfmod, hicolor-icon-
theme, fedora-logos, xsane),
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698
--- Comment #5 from Sandro Mani manisan...@gmail.com ---
Spec URL: https://smani.fedorapeople.org/review/sflphone.spec
SRPM URL: https://smani.fedorapeople.org/review/sflphone-1.4.1-2.fc22.src.rpm
%changelog
* Thu Jan 22 2015 Sandro Mani manisan...@gmail.com - 1.4.1-2
- Use %%license
- Add Requires: dbus to sflphone-common
- Fixed ownership of %%{_datadir}/icons/hicolor, added Requires:
hicolor-icon-theme
- Fixed ownership of %%{_datadir}/applications/kde4/
- Require sflphone-libs in sflphone-kde, sflphone-gnome, not sflphone-common
- Fix desktop file
- Add LDFLAGS=-Wl,--as-needed
- Fix FSF addresses
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #3 from Jerry James loganje...@gmail.com --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 --- Comment #2 from Sandro Mani manisan...@gmail.com --- Bunding request for F20, F21 was approved: https://fedorahosted.org/fpc/ticket/491#comment:2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180698] Review Request: sflphone - SIP/IAX2 compatible enterprise-class software phone
https://bugzilla.redhat.com/show_bug.cgi?id=1180698 Sandro Mani manisan...@gmail.com changed: What|Removed |Added Blocks||656997 (kde-reviews) CC||linux.n@gmail.com --- Comment #1 from Sandro Mani manisan...@gmail.com --- *** Bug 692131 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
