[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-XStatic-smart-table- |python-XStatic-smart-table- |1.4.5.3-1.fc21 |1.4.5.3-1.el7 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-smart-table-1.4.5.3-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-XStatic-smart-table- ||1.4.5.3-1.fc21 Resolution|--- |ERRATA Last Closed||2015-02-04 03:01:31 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-smart-table-1.4.5.3-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-smart-table-1.4.5.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-XStatic-smart-table-1.4.5.3-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-smart-table-1.4.5.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-XStatic-smart-table-1.4.5.3-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-smart-table-1.4.5.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Matthias Runge mru...@redhat.com changed: What|Removed |Added Status|ASSIGNED|POST Flags||fedora-cvs? --- Comment #2 from Matthias Runge mru...@redhat.com --- Thanks again, Haikel and thank you for your kind offer. It's nothing urgent, and I'm not trying to put additional work on an already overloaded person! New Package SCM Request === Package Name: python-XStatic-smart-table Short Description: smart-table (XStatic packaging standard) Upstream URL: https://github.com/lorenzofox3/Smart-Table Owners: mrunge Branches: epel7 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1181050] Review Request: python-XStatic-smart-table - smart-table (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1181050
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||karlthe...@gmail.com
Assignee|nob...@fedoraproject.org|karlthe...@gmail.com
Flags||fedora-review+
--- Comment #1 from Haïkel Guémar karlthe...@gmail.com ---
As usual with XStatic upstream, license file is not provided, please ask them
to ship it.
I hereby approve this package into Fedora Packages Collection as it complies
with Fedora guidelines.
Please submit a SCM request.
btw, Matthias, you're more than welcome to CC or ping me for packages reviews.
:)
I usually check every sunday reviewing requests but I missed this one.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[-] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 5 files have unknown license. Detailed output of
licensecheck in /home/haikel/1181050-python-XStatic-smart-
table/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/xstatic/pkg
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
