[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235



--- Comment #7 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-25 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-01-25 18:45:44



--- Comment #8 from Rex Dieter rdie...@math.unl.edu ---
Thanks, imported

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8710097

$ rpmlint -i -v *
kdeedu-data.src: I: checking
kdeedu-data.src: I: checking-url
https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds)
kdeedu-data.src: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz
(timeout 10 seconds)
kdeedu-data.noarch: I: checking
kdeedu-data.noarch: I: checking-url
https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds)
kdeedu-data.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/integral_func.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: dangling-relative-symlink /usr/share/apps/kvtml
../../kde4/apps/kvtml
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/editplots.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/maximum.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/minimum.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newpolar.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newfunction.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/deriv_func.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newparametric.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/functionhelp.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/resetview.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/editconstants.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.spec: I: checking
kdeedu-data.spec: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 13 warnings.


Most warnings refer to the svgz icons. I've thought about again. The installed
icons are intended to be used in kdeedu apps. All of them are in the actions
folders, so they don't affect the display in simple window manager menus. This
would be the only usecase which I can imagine as a problem. Leave the
compressed icons untouched.


-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Rex Dieter rdie...@math.unl.edu ---
New Package SCM Request
===
Package Name: kdeedu-data
Short Description: Shared icons, artwork and data files for educational
applications
Upstream URL: https://projects.kde.org/projects/kde/kdeedu/kdeedu-data
Owners: group::kde-sig
Branches: f20 f21
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mario.blaetterm...@gmail.co
   ||m
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?



--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
Rpmlint complains about some things:

$ rpmlint -i -v *
kdeedu-data.src: I: checking
kdeedu-data.src: I: checking-url
https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds)
kdeedu-data.src: W: invalid-url URL:
https://projects.kde.org/projects/kde/kdeedu/kdeedu-data The read operation
timed out
The value should be a valid, public HTTP, HTTPS, or FTP URL.

kdeedu-data.src:29: W: setup-not-quiet
Use the -q option to the %setup macro to avoid useless build output from
unpacking the sources.

kdeedu-data.src: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz
(timeout 10 seconds)
kdeedu-data.noarch: I: checking
kdeedu-data.noarch: I: checking-url
https://projects.kde.org/projects/kde/kdeedu/kdeedu-data (timeout 10 seconds)
kdeedu-data.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/integral_func.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: dangling-relative-symlink /usr/share/apps/kvtml
../../kde4/apps/kvtml
The target of the symbolic link does not exist within this package or its file
based dependencies.  Verify spelling of the link target and that the target is
included in a package in this package's dependency chain.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/editplots.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/maximum.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/minimum.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newpolar.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newfunction.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/deriv_func.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/newparametric.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/functionhelp.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/resetview.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.noarch: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/editconstants.svgz
Not all desktop environments that support SVG icons support them gzipped
(.svgz).  Install the icon as plain uncompressed SVG.

kdeedu-data.spec: I: checking
kdeedu-data.spec:29: W: setup-not-quiet
Use the -q option to the %setup macro to avoid useless build output from
unpacking the sources.

kdeedu-data.spec: I: checking-url
http://download.kde.org/stable/applications/14.12.1/src/kdeedu-data-14.12.1.tar.xz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 16 warnings.



The warning about the not downloadable tarball is false positive. I can
download it using wget.

Regarding the svgz icons, you should install them uncompressed. I don't know
about the problems

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235



--- Comment #3 from Rex Dieter rdie...@math.unl.edu ---
This package is common to several kde4 *and* kf5 applications, that's why it
references both, but you're right, adding a dep on hicolor-icon-theme is
strictly needed here (even though all of it's consumers will pull it too via
kde libraries).

Update on the way...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-23 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235



--- Comment #4 from Rex Dieter rdie...@math.unl.edu ---
Spec URL: https://rdieter.fedorapeople.org/rpms/kdeedu-data/kdeedu-data.spec
SRPM URL:
https://rdieter.fedorapeople.org/rpms/kdeedu-data/kdeedu-data-14.12.1-2.fc20.src.rpm

%changelog
* Fri Jan 23 2015 Rex Dieter rdie...@fedoraproject.org 14.12.1-2
- Requires: hicolor-icon-theme
- use %%setup -q

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-19 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235



--- Comment #1 from Rex Dieter rdie...@math.unl.edu ---
From included README_packagers:

  At the attention of packagers  *

KHangMan, Kanagram, Parley and KWordQuiz depend on /kdeedu/data/kvtml!

Please do not ship Kanagram and KHangMan without those files, thanks!

KHangMan and Kanagram depend on those files, Parley and KWordQuiz can use them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-19 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

  Alias||kdeedu-data



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1183235] Review Request: kdeedu-data - Shared icons, artwork and data files for educational applications

2015-01-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=1183235

Rex Dieter rdie...@math.unl.edu changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review