[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Richard W.M. Jones changed: What|Removed |Added Flags|needinfo?(rjo...@redhat.com |needinfo?(j...@recoil.org) |) | --- Comment #7 from Richard W.M. Jones --- Jon, do you wish to continue with this review or shall we abandon it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
Product: Fedora Version: rawhide Component: Package Review Richard W.M. Jones has canceled Package Review 's request for Richard W.M. Jones 's needinfo: Bug 1183825: Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml https://bugzilla.redhat.com/show_bug.cgi?id=1183825 --- Comment #7 from Richard W.M. Jones --- Jon, do you wish to continue with this review or shall we abandon it? ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Bug 1183825 depends on bug 1790146, which changed state. Bug 1790146 Summary: Review Request: ocaml-uutf - Non-blocking streaming Unicode codec for OCaml https://bugzilla.redhat.com/show_bug.cgi?id=1790146 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Jerry James changed: What|Removed |Added Depends On||1790146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1790146 [Bug 1790146] Review Request: ocaml-uutf - Non-blocking streaming Unicode codec for OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Bug 1183825 depends on bug 1183195, which changed state. Bug 1183195 Summary: Review Request: ocaml-uutf - Non-blocking streaming codec for UTF-8, UTF-16, UTF-16LE and UTF-16BE https://bugzilla.redhat.com/show_bug.cgi?id=1183195 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 --- Comment #5 from Jon Ludlam --- License now included and isa macro now sorted out. Spec URL: http://www.recoil.org/~jon/ocaml-jsonm.spec SRPM URL: http://www.recoil.org/~jon/ocaml-jsonm-0.9.1-4.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825
--- Comment #4 from Richard W.M. Jones ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[-]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
This package has the same mystery "BSD3" license. It needs to be
clarified with upstream as to precisely what wording is in the
license.
[-]: %build honors applicable compiler flags or justifies otherwise.
The build system is sufficiently wierd that it's probably impossible
to use %{configure}, %{_smp_mflags} etc.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[-]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Ocaml:
[x]: This should never happen
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
See comment above.
[x]: Final provides and requires are sane (see attachments).
[?]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml-
jsonm-devel
May need to use %{?_isa}.
[x]: Package functions as described.
[x]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package sh
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Richard W.M. Jones changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rjo...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 --- Comment #3 from Jon Ludlam --- Fixed thanks. Spec URL: http://www.recoil.org/~jon/ocaml-jsonm.spec SRPM URL: http://www.recoil.org/~jon/ocaml-jsonm-0.9.1-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Richard W.M. Jones changed: What|Removed |Added Blocks||1185099 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1185099 [Bug 1185099] Review Request: opam - A source-based package manager for OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 --- Comment #2 from Richard W.M. Jones --- Defining 'native_compiler' symbol but not using it. [Uutf] .. [] doesn't mean anything to rpm - this is not ocamldoc! It's probably better just to remove the square brackets. The rest looks good to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 Richard W.M. Jones changed: What|Removed |Added CC||rjo...@redhat.com Depends On||1183195 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1183195 [Bug 1183195] Review Request: ocaml-uutf - Non-blocking streaming codec for UTF-8, UTF-16, UTF-16LE and UTF-16BE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1183825] Review Request: ocaml-jsonm - Non-blocking streaming JSON codec for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1183825 --- Comment #1 from Jon Ludlam --- This package depends upon ocaml-uutf, for which I have a review request pending here: https://bugzilla.redhat.com/show_bug.cgi?id=1183195 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
