[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920



--- Comment #4 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||rubygem-rails-dom-testing-1
   ||.0.5-1.fc22
 Resolution|--- |RAWHIDE
Last Closed||2015-01-26 10:16:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Josef Stribny jstri...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jstri...@redhat.com
   Assignee|nob...@fedoraproject.org|jstri...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Josef Stribny jstri...@redhat.com ---
I will take it for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Josef Stribny jstri...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Josef Stribny jstri...@redhat.com ---
* Extra space before a dot: 

Dom and Selector assertions for Rails applications .

* Wrong upstream URL:

https://github.com/rails/rails-dom-testing is the new official URL from which
the latest release comes from. Upstream should probably fix that in .gemspec.

Otherwise everything looks sane, package builds and runs, rpmlint does not
complain about anything meaningful. == APPROVED. Please fix the above before
pushing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Vít Ondruch vondr...@redhat.com ---
(In reply to Josef Stribny from comment #2)
 * Extra space before a dot: 
 
 Dom and Selector assertions for Rails applications .

I already fixed this locally.

 * Wrong upstream URL:
 
 https://github.com/rails/rails-dom-testing is the new official URL from
 which the latest release comes from. Upstream should probably fix that in
 .gemspec.

Hmm, not sure about this. I checked the former URL and the URL you are
referencing and both are valid/the same ATM, where the one in .gemspec is fork
of the one you are referencing. I prefer to keep the .gemspec one ATM and will
see what will future bring.

 Otherwise everything looks sane, package builds and runs, rpmlint does not
 complain about anything meaningful. == APPROVED. Please fix the above
 before pushing.

Thanks for the review.


New Package SCM Request
===
Package Name: rubygem-rails-dom-testing
Short Description: Compares doms and assert certain elements exists in doms
using Nokogiri
Upstream URL: https://github.com/kaspth/rails-dom-testing
Owners: vondruch jstribny
Branches: 
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920
Bug 1184920 depends on bug 1184130, which changed state.

Bug 1184130 Summary: Review Request: rubygem-rails-deprecated_sanitizer - 
Deprecated sanitizer API extracted from Action View
https://bugzilla.redhat.com/show_bug.cgi?id=1184130

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Blocks||1184910




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1184910
[Bug 1184910] Ruby on Rails 4.2
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Depends On||1184130




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1184130
[Bug 1184130] Review Request: rubygem-rails-deprecated_sanitizer -
Deprecated sanitizer API extracted from Action View
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1184920] Review Request: rubygem-rails-dom-testing - Compares doms and assert certain elements exists in doms using Nokogiri

2015-01-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1184920

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Blocks||1184996




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1184996
[Bug 1184996] Review Request: rubygem-rails-html-sanitizer - This gem is
responsible to sanitize HTML fragments in Rails applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review