[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-django-rest-framewor ||k-3.1.1-3.fc22 Resolution|--- |ERRATA Last Closed||2015-05-25 23:20:58 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-django-rest-framework-3.1.1-3.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-django-rest-framework-3.1.1-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-django-rest-framework-3.1.1-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-django-rest-framework-3.1.1-3.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #5 from Julien Enselme juj...@jujens.eu --- I think you forgot to upload the new SRPM. At the URL you gave, I get a 404 error. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605
--- Comment #7 from Julien Enselme juj...@jujens.eu ---
I have some errors with fedora-review:
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.4/site-
packages/rest_framework/locale/en_US/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/en_US, /usr/lib/python3.4/site-
packages/rest_framework/locale/zh_CN, /usr/lib/python3.4/site-
packages/rest_framework/locale/zh_CN/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/pt_PT/LC_MESSAGES,
/usr/lib/python2.7/site-
packages/rest_framework/locale/zh_CN/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/pt_BR/LC_MESSAGES,
/usr/lib/python3.4/site-
packages/rest_framework/locale/ko_KR/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/ko_KR, /usr/lib/python3.4/site-
packages/rest_framework/locale/pt_PT, /usr/lib/python3.4/site-
packages/rest_framework/locale/ko_KR, /usr/lib/python2.7/site-
packages/rest_framework/locale/pt_BR, /usr/lib/python3.4/site-
packages/rest_framework/locale/pt_BR/LC_MESSAGES, /usr/lib/python3.4
/site-packages/rest_framework/locale/pt_PT/LC_MESSAGES,
/usr/lib/python3.4/site-packages/rest_framework/locale/en_US,
/usr/lib/python3.4/site-packages/rest_framework/locale/pt_BR,
/usr/lib/python2.7/site-packages/rest_framework/locale/pt_PT,
/usr/lib/python2.7/site-packages/rest_framework/locale/zh_CN,
/usr/lib/python2.7/site-
packages/rest_framework/locale/ko_KR/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/en_US/LC_MESSAGES
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.4/site-
packages/rest_framework/locale/zh_CN/LC_MESSAGES, /usr/lib/python3.4
/site-packages/rest_framework/locale/pt_PT/LC_MESSAGES,
/usr/lib/python3.4/site-packages/rest_framework/locale/pt_PT,
/usr/lib/python2.7/site-packages/rest_framework/locale/ko_KR,
/usr/lib/python3.4/site-
packages/rest_framework/locale/en_US/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/pt_PT/LC_MESSAGES,
/usr/lib/python3.4/site-packages/rest_framework/locale/pt_BR,
/usr/lib/python2.7/site-packages/rest_framework/locale/pt_PT,
/usr/lib/python2.7/site-
packages/rest_framework/locale/zh_CN/LC_MESSAGES, /usr/lib/python3.4
/site-packages/rest_framework/locale/zh_CN, /usr/lib/python2.7/site-
packages/rest_framework/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/ko_KR/LC_MESSAGES,
/usr/lib/python3.4/site-packages/rest_framework/locale/ko_KR,
/usr/lib/python2.7/site-packages/rest_framework/locale/pt_BR,
/usr/lib/python3.4/site-
packages/rest_framework/locale/pt_BR/LC_MESSAGES, /usr/lib/python2.7
/site-packages/rest_framework/locale/en_US, /usr/lib/python2.7/site-
packages/rest_framework/locale/en_US/LC_MESSAGES, /usr/lib/python3.4
/site-packages/rest_framework/locale/ko_KR/LC_MESSAGES,
/usr/lib/python3.4/site-packages/rest_framework/locale/en_US,
/usr/lib/python2.7/site-packages/rest_framework/locale/zh_CN
I think that %{python3_sitelib}/rest_framework/locale/??/ in your %files
section is too restrictive. Maybe use a *? Or include the whole directory?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #6 from Matthias Runge mru...@redhat.com --- shame on me. SPEC: http://www.matthias-runge.de/fedora/python-django-rest-framework.spec SRPM: http://www.matthias-runge.de/fedora/python-django-rest-framework-3.1.1-2.fc22.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9660875 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #8 from Matthias Runge mru...@redhat.com --- Sigh, that wasn't caught by rpmlint and during build as well. Handling locale files is a bit tricky here. I don't want those files included twice SPEC: http://www.matthias-runge.de/fedora/python-django-rest-framework.spec SRPM: http://www.matthias-runge.de/fedora/python-django-rest-framework-3.1.1-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Julien Enselme juj...@jujens.eu changed: What|Removed |Added Flags||fedora-review+ --- Comment #9 from Julien Enselme juj...@jujens.eu --- This time, it looks good. Approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Matthias Runge mru...@redhat.com --- Thanks much, greatly appreciated! New Package SCM Request === Package Name: python-django-rest-framework Short Description: Web APIs for Django, made easy Upstream URL: http://www.django-rest-framework.org/ Owners: mrunge Branches: f22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #2 from Matthias Runge mru...@redhat.com --- Thank you for the review Upstream does not distribute a license file https://github.com/tomchristie/django-rest-framework/issues/2906 python3 package added SPEC: http://www.matthias-runge.de/fedora/python-django-rest-framework.spec SRPM: http://www.matthias-runge.de/fedora/python-django-rest-framework-3.1.1-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #3 from Julien Enselme juj...@jujens.eu --- Mock build fails due to: ImportError: No module named setuptools Please update the BR -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605 --- Comment #4 from Matthias Runge mru...@redhat.com --- Done. I just verified, it really builds in mock. SPEC: http://www.matthias-runge.de/fedora/python-django-rest-framework.spec SRPM: http://www.matthias-runge.de/fedora/python-django-rest-framework-3.1.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197605] Review Request: python-django-rest-framework - Web APIs for Django, made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1197605
Julien Enselme juj...@jujens.eu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||juj...@jujens.eu
Assignee|nob...@fedoraproject.org|juj...@jujens.eu
--- Comment #1 from Julien Enselme juj...@jujens.eu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 53 files have unknown license. Detailed
output of licensecheck in /tmp/1197605-python-django-rest-
framework/licensecheck.txt
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[ X: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[X]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[!]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[X]: Packages should try
