[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-12-09 15:50:27



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #38 from Fedora Update System  ---
python-pyopencl-2015.2-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #37 from Fedora Update System  ---
python-pyopencl-2015.2-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-pyopencl'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-ad9050aa1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #36 from Fedora Update System  ---
python-pyopencl-2015.2-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-ad9050aa1b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #35 from Igor Gnatenko  ---
(In reply to Jonathan Underwood from comment #34)
> Any progress on pushing for F23?

Yes, I'm slowly pushing stuff into f23 (there was problem with bodhi itself)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #34 from Jonathan Underwood  ---
Any progress on pushing for F23?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819
Bug 1219819 depends on bug 1250651, which changed state.

Bug 1250651 Summary: Review Request: python-compyte - A common set of compute 
primitives for PyCUDA and PyOpenCL
https://bugzilla.redhat.com/show_bug.cgi?id=1250651

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #32 from Igor Gnatenko  ---
(In reply to Jonathan Underwood from comment #31)
> Igor: I see you've pushedd a build to rawhide. Please can you psuh for F23
> as well. And please do close this bug.

not possible right now, bodhi don't allow me to push other stack (pytools,
etc.) just because bugs in bodhi. I will do it ASAP

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #33 from Jonathan Underwood  ---
(In reply to Igor Gnatenko from comment #32)
> (In reply to Jonathan Underwood from comment #31)
> > Igor: I see you've pushedd a build to rawhide. Please can you psuh for F23
> > as well. And please do close this bug.
> 
> not possible right now, bodhi don't allow me to push other stack (pytools,
> etc.) just because bugs in bodhi. I will do it ASAP

Oh dear, that doesn't sound good. Are the bodhi problems reported somewhere?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #31 from Jonathan Underwood  ---
Igor: I see you've pushedd a build to rawhide. Please can you psuh for F23 as
well. And please do close this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #28 from Igor Gnatenko  ---
New SPEC:
https://ignatenkobrain.fedorapeople.org/for-review/python-pyopencl.spec
New SRPM:
https://ignatenkobrain.fedorapeople.org/for-review/python-pyopencl-2015.2-1.fc22.src.rpm

- Update to 2015.2
- Add some description to bundled libs providing
- Provide exact version of bundled cephes
- Force tests passed
- Fixed dependencies list


Jonathan, I think now it should be okay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #18 from Jonathan Underwood  ---
Any progress here, Igor?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #21 from Igor Gnatenko  ---
OK, I will fix all issues in a 30 mins :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #22 from Igor Gnatenko  ---
Upstream bug for LICENSE: https://github.com/pyopencl/pyopencl/issues/93
New SPEC:
https://github.com/ignatenkobrain/python-pyopencl/raw/master/python-pyopencl.spec
New SRPM:
https://github.com/ignatenkobrain/python-pyopencl/raw/master/python-pyopencl-2015.1-4.fc22.src.rpm

Regarding patches.
1 and 2 just disables downloading and using external python-compyte (and
upstream don't want to change this. it was discussed in upstream
python-compyte). Third is just to fix CFLAGS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Igor Gnatenko  changed:

   What|Removed |Added

 CC||hgkam...@hotmail.com



--- Comment #23 from Igor Gnatenko  ---
*** Bug 1174959 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #20 from Jonathan Underwood  ---
(In reply to Igor Gnatenko from comment #19)
> I asked upstream of cephes in past week, still no response. I do not
> understand part from spot about changing license to GPLv2.

Debian has obtained permission from the Cephes author to distribute the Cephes
code under GPLv2 licensing. Tom is saying we can therefore assume that the code
from Cephes is available under GPLv2. As such, the license tag should be what I
posted in Comment #17, and the legal question no longer blocks this package.
So, you can go ahead and deal with the issues I pointed out during review, and
then we can approve the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(i.gnatenko.brain@ |
   |gmail.com)  |



--- Comment #19 from Igor Gnatenko  ---
I asked upstream of cephes in past week, still no response. I do not understand
part from spot about changing license to GPLv2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #24 from Jonathan Underwood  ---
(In reply to Igor Gnatenko from comment #22)
> Regarding patches.
> 1 and 2 just disables downloading and using external python-compyte (and
> upstream don't want to change this. it was discussed in upstream
> python-compyte). Third is just to fix CFLAGS.

As I stated in the review comment, comments need adding to the spec file
explaining this.

You should also add a comment with the license bug url above the license tag.

You haven't added any of the bundled Provides that I helpfully worked out for
you in the review comment.

You haven't added a %check section and added the tests during build that I
pointed out.

At this point I stopped checking the rest of the issues.

Basically, it seems like you've totally ignored the issues I raised during
review :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #25 from Igor Gnatenko  ---
I was totally sure that I added Provides =( Give me a some time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #27 from Jonathan Underwood  ---
For the bundled Provides please also include the comments that I wrote for you
- they will help a future maintainer of the package understand what's bundled
and where (and perhaps help in any future efforts at unbundling). 

The bundled version  of cephes is 2.8 as clearly stated in the headers of the
files bundling it, so that needs adding to the bundled Provide. The version of
boost is entirely unclear, though.

Also, your %changelog entries are too sparse - they don't include all changes
you've made at each stage. That information is very useful for other
maintainers, so please get in the habit of writing changelog entries which
reflect the changes you make.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819
Bug 1219819 depends on bug 1250651, which changed state.

Bug 1250651 Summary: Review Request: python-compyte - A common set of compute 
primitives for PyCUDA and PyOpenCL
https://bugzilla.redhat.com/show_bug.cgi?id=1250651

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood  changed:

   What|Removed |Added

 CC||i.gnatenko.br...@gmail.com
  Flags||needinfo?(i.gnatenko.brain@
   ||gmail.com)



--- Comment #17 from Jonathan Underwood  ---
Thanks Tom. 

Ignor - are you going to contact Cephes upstream as Tom suggests and ask them
to permit the use of the cephes code in pyopencl under the same license as the
rest of pyopencl (MIT)?

In the short term, the license field should then be

MIT and Boost and ASL 2.0 and GPLv2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com



--- Comment #16 from Tom "spot" Callaway  ---
I think it is safe to inherit the GPLv2 permission that Debian has secured for
Cephes. However, you may not wish to do so because it would change the overall
license for pyopencl from MIT (permissive) to GPLv2 (copyleft).

I'd encourage you to reach out to the cephes upstream, explain the issue, and
ask if they would permit the use of the cephes code in pyopencl under the same
license as the rest of pyopencl (MIT).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #12 from Igor Gnatenko  ---
New SPEC:
https://ignatenkobrain.fedorapeople.org/for-review/python-pyopencl.spec
New SRPM:
https://ignatenkobrain.fedorapeople.org/for-review/python-pyopencl-2015.1-3.fc24.src.rpm

I fixed:
* non-standard-executable-perm
* version-control-internal-file
* non-expandable-macro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #15 from Jonathan Underwood  ---
The Cephes issue has previously come up during the grace package review, and
these comments seem relevant:

https://bugzilla.redhat.com/show_bug.cgi?id=166414#c9
https://bugzilla.redhat.com/show_bug.cgi?id=166414#c10

It seems like at some point the cephes license header was changed, and also
that email sent. The snippets included with pyopencl perhaps have an out of
date cephes license? Unclear to me what the situation is. Suggestion for Igor:
while we wait for FE Legal, ask upstream pyopencl for some clarification on
when they took the code from cephes, and what they regard the license situation
to be.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819
Bug 1219819 depends on bug 1250651, which changed state.

Bug 1250651 Summary: Review Request: python-compyte - A common set of compute 
primitives for PyCUDA and PyOpenCL
https://bugzilla.redhat.com/show_bug.cgi?id=1250651

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood  changed:

   What|Removed |Added

  Flags|needinfo?(jonathan.underwoo |
   |d...@gmail.com)|



--- Comment #10 from Jonathan Underwood  ---
PLease *always* use the prescribed format for the spec and srpm url - otherwise
the fedora-review tool doesn't find the latest package version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #13 from Jonathan Underwood  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
See all issues below, quick summary:

1) Some bundled libraries need appropriate Provides.
2) License issue with cephes code.
3) Some files have wrong perms.
4) No license files included with tarball.
5) License tag incorrect
6) Missing %check section


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

No LICENSE or COPYING file is included with upstream release - please
file a bug asking them to add relevant license files to their packaged
releases.

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSL (v1.0)", "Apache (v2.0)", "Unknown
 or generated". 63 files have unknown license. Detailed output of
 licensecheck in /home/jgu/Fedora/1219819-python-
 pyopencl/licensecheck.txt

License field should be MIT and Boost and ASL 2.0.

However, far more worrying is the following. For these files:

pyopencl-2015.1/pyopencl/cl/pyopencl-bessel-j.cl
pyopencl-2015.1/pyopencl/cl/pyopencl-bessel-y.cl
pyopencl-2015.1/pyopencl/cl/pyopencl-eval-tbl.cl

the header at the top says this:

//  Pieced together from Boost C++ and Cephes by
//  Andreas Kloeckner (C) 2012
//
//  Pieces from:
//
//  Copyright (c) 2006 Xiaogang Zhang, John Maddock
//  Use, modification and distribution are subject to the
//  Boost Software License, Version 1.0. (See
//  http://www.boost.org/LICENSE_1_0.txt)
//
// Cephes Math Library Release 2.8:  June, 2000
// Copyright 1984, 1987, 1989, 1992, 2000 by Stephen L. Moshier
// What you see here may be used freely, but it comes with no support or
// guarantee.


It's the Cephes part that's concerning - it's not clear to me that
this is compatible with Fedora's licensing requirements. I'll flag Legal.

In addition pyopencl/cl/pyopencl-airy.cl seems to be also taken from
cephes and has the cephes part of the above header at the top.


[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.

As stated above these three files seem to be bundled bits of Boost and
Cephes:

pyopencl-2015.1/pyopencl/cl/pyopencl-bessel-j.cl
pyopencl-2015.1/pyopencl/cl/pyopencl-bessel-y.cl
pyopencl-2015.1/pyopencl/cl/pyopencl-eval-tbl.cl

They seem to be fairly small fragments of the much larger libraries,
and the new bundling guidelines allow bundling, but I wonder if you've
given any thought as to whether it would be possible to somehow
unbundle these bits? This isn't a blocker, but you should add
something to the effect of

# pyopencl/cl/pyopencl-bessel-[j,y].cl and
# pyopencl/cl/pyopencl-eval-tbl.cl contain snippets taken from boost
# and cephes. pyopencl/cl/pyopencl-airy.cl contains code taken from
# cephes.
Provides: bundled(boost-math) = 
Provides: bundled(cephes) = 

You'll need to work out what version they've pulled the snippets from.

The file pyopencl/cl/pyopencl-ranluxcl.cl contains a modified and
bundled version of the ranluxcl library, so this is needed:

# pyopencl/cl/pyopencl-ranluxcl.cl contains a modified version of the
# ranluxcl library
Provides: bundled(ranluxcl) = 1.3.1


[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python2-pyopencl (description), python3-pyopencl
 (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #14 from Jonathan Underwood  ---
Now blocking FE-Legal.

Legal folks, the issue here is that this package bundles some code taken from
the Cephes library which is licensed simply as:

// Cephes Math Library Release 2.8:  June, 2000
// Copyright 1984, 1987, 1989, 1992, 2000 by Stephen L. Moshier
// What you see here may be used freely, but it comes with no support or
// guarantee.


... is this compatible with Fedora licensing requirements?

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #11 from Jonathan Underwood  ---
OK, fedora-review did in fact detect the new package, great. I'll kick off a
build and review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #8 from Jonathan Underwood  ---
Any progress here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood jonathan.underw...@gmail.com changed:

   What|Removed |Added

 Blocks||1205648




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1205648
[Bug 1205648] RFE: csc_opencl support in xpra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood jonathan.underw...@gmail.com changed:

   What|Removed |Added

 CC||jonathan.underw...@gmail.co
   ||m



--- Comment #1 from Jonathan Underwood jonathan.underw...@gmail.com ---
I'll happily review this once the pytools issue is resolved - I think the
maintainer can be considered non-responsive at this point - I suggest you start
the non-responsive maintainer process and apply for commit access to pytools so
you can update that package, if you're willing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819
Bug 1219819 depends on bug 1219815, which changed state.

Bug 1219815 Summary: 2014.3.5 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1219815

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Jonathan Underwood jonathan.underw...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jonathan.underw...@gmail.co
   ||m
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #2 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
(In reply to Jonathan Underwood from comment #1)
 I'll happily review this once the pytools issue is resolved - I think the
 maintainer can be considered non-responsive at this point - I suggest you
 start the non-responsive maintainer process and apply for commit access to
 pytools so you can update that package, if you're willing.

I just realized that pyopencl depends on python-compyte which is not packaged.
I will package it after 2 hours, so please review it first.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #3 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
I mean this package works, but not in all cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #4 from Jonathan Underwood jonathan.underw...@gmail.com ---
OK, will wait for compyte. Please note the python packaging guidelines were
updated yesterday, and quite a lot has changed:

https://fedoraproject.org/wiki/Packaging:Python

https://fedoraproject.org/wiki/Packaging:Python_Appendix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #5 from Jonathan Underwood jonathan.underw...@gmail.com ---
In the meantime, some rpmlint issues:

Checking: python-pyopencl-2015.1-1.fc22.x86_64.rpm
  python3-pyopencl-2015.1-1.fc22.x86_64.rpm
  python-pyopencl-2015.1-1.fc22.src.rpm
python-pyopencl.x86_64: E: version-control-internal-file
/usr/share/doc/python-pyopencl/examples/.gitignore
python-pyopencl.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/si$e-packages/pyopencl/_pvt_struct.so 775
python-pyopencl.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/sit
e-packages/pyopencl/_cl.so 775
python-pyopencl.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/
site-packages/pyopencl/cl/pyopencl-complex.h
python-pyopencl.x86_64: W: doc-file-dependency
/usr/share/doc/python-pyopencl/ex
amples/download-examples-from-wiki.py /usr/bin/env
python3-pyopencl.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.4
/site-packages/pyopencl/cl/pyopencl-complex.h
python3-pyopencl.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.4/si
te-packages/pyopencl/_cl.cpython-34m.so 775
python3-pyopencl.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.4/si
te-packages/pyopencl/_pvt_struct.cpython-34m.so 775
python3-pyopencl.x86_64: E: version-control-internal-file
/usr/share/doc/python3
-pyopencl/examples/.gitignore
python3-pyopencl.x86_64: W: doc-file-dependency
/usr/share/doc/python3-pyopencl/
examples/download-examples-from-wiki.py /usr/bin/env
3 packages and 0 specfiles checked; 6 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #6 from Jonathan Underwood jonathan.underw...@gmail.com ---
Also, I note that upstream has released 2015.1.2. In addition, fedora-review
reports installation problems with the built packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819



--- Comment #7 from Jonathan Underwood jonathan.underw...@gmail.com ---
Oh, ignore the comment about 2015.1.2  - I must have imagined that, as I can't
see it now! Sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Igor Gnatenko i.gnatenko.br...@gmail.com changed:

   What|Removed |Added

 Depends On||1250651




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1250651
[Bug 1250651] Review Request: python-compyte - A common set of compute
primitives for PyCUDA and PyOpenCL
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219819] Review Request: python-pyopencl - Python wrapper for OpenCL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219819

Igor Gnatenko i.gnatenko.br...@gmail.com changed:

   What|Removed |Added

 Depends On||1219815




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1219815
[Bug 1219815] 2014.3.5 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review