[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-19 04:58:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #34 from Fedora Update System  ---
libASL-0.1.6-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #35 from Fedora Update System  ---
libASL-0.1.6-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System  ---
libASL-0.1.6-1.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libASL'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-eb911d4af4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #33 from Fedora Update System  ---
libASL-0.1.6-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libASL'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-d8e74569ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #20 from Christian Dersch  ---
Yes, running mock with yum instead of dnf solves the FTBS. Other possibilty
would be teh usage of provided koji builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #21 from Christian Dersch  ---
Following line should do it:

mock --clean --init --yum -r fedora-rawhide-x86_64 && fedora-review -v -m
fedora-rawhide-x86_64 -o "--yum " -b 1244797

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #25 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.5.fc22.src.rpm

Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11758115

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #23 from Raphael Groner  ---
Created attachment 1091874
  --> https://bugzilla.redhat.com/attachment.cgi?id=1091874=edit
licensecheck.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #28 from Christian Dersch  ---
Thank you again :) Well this depends on use case, maybe a user just wants to
run the provides examples as binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #24 from Christian Dersch  ---
Thank you very much for your review :)

About the issues:
Issues:
- License: AGPLv3 and BSD and MIT
==> Will fix it

- Please validate source files without proper license header.
==> These files (mostly pics in doc) are AGPL too 


- Include license text(s) into every subpackage.
==> Well, license is installed in every case because of dependency to libASL,
but I can add them there too.

- Use Require: libASL where appropriate for subpackages.
==> dep will be recognized automatically, but as there won't be a negative
effect by adding them I'll do it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #26 from Upstream Release Monitoring 
 ---
lupinix's scratch build of libASL-0.1.6-0.5.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11758115

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #27 from Raphael Groner  ---
Fine now.

(SHOULD)
Notice that an user of the examples may want to install the devel subpackage
instead of just the main package only. Maybe you want to modify that Require
there again? You could also additionally add Suggests: libASL-examples to both
doc and devel subpackages, but that's up to you and only a personal preference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review?



--- Comment #22 from Raphael Groner  ---
Issues:
- License: AGPLv3 and BSD and MIT
- Please validate source files without proper license header.
- Include license text(s) into every subpackage.
- Use Require: libASL where appropriate for subpackages.
-


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (3 clause)", "AGPL (v3)", "Unknown
 or generated". 38 files have unknown license. Detailed output of
 licensecheck in /home/builder/fedora-
 review/1244797-libASL/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 184320 bytes in 28 files.
=> False positive IMHO, maybe f-r thinks doc or examples is main package.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[?]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query 

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #29 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/libASL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #30 from Fedora Update System  ---
libASL-0.1.6-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-d8e74569ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #19 from Raphael Groner  ---
fedora-review gives me FTBFS in mock -r rawhide, while running it on a F23
system. We guess it's a bug/problem with dnf. Maybe f-r could be reconfigured
to run the failing part with yum.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|projects...@smart.ms|nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #17 from Upstream Release Monitoring 
 ---
lupinix's scratch build of libASL-0.1.6-0.4.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11751101

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #14 from Raphael Groner  ---
A quick look into your spec file shows some hints and advices. Later, I could
do the official review run. Currently, I do not find any blockers, so I hope
the review can pass quickly.

. (SHOULD/) Please use %{upstream} consistently or not at all. Well, it
seems to me somehow to be ridiculous to use a macro with a longer name than the
shorter text by itself, therefore you maybe want to replace it in %description
as well?
- Name: libASL
+ Name: lib%{upstream}

. (SHOULD) Again, please use consistently the macros. Either decide to use
"mkdir -p", %{__mkdir_p}, or "%{__mkdir} -p". I guess you want to keep with
%{__mkdir_p} as you do in %install.
  %prep
  %setup -q -n %{upstream}-%{version}
- %{__mkdir} -p %{_cmake_build_subdir}
+ %{__mkdir_p} %{_cmake_build_subdir}

. (SHOULD) examples could be merged into doc subpackage to avoid just another
subpackage without any additional benefit but that's somehow related to any
personal preference.

. (SHOULD) pushd/popd is not needed in %install
- pushd %{_cmake_build_subdir}
- %make_install
- popd
+ %make_install -C %{_cmake_build_subdir}

. (SHOULD) You could use delete parameter of find command, this makes it easier
to read and execution may be faster.
- find %{buildroot} -name '*.la' -exec rm -f {} ';'
+ find %{buildroot} -name '*.la' -delete

. (SHOULD) Please consider to use %check for execution of some files from the
tests folder. You mentioned somehow OpenCL as a possible fail reason, can you
disable individually those dedicated tests to have at least a basic QA inside
the build?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #15 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.4.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #16 from Christian Dersch  ---
Thank you for your remarks Raphael! I fixed the spec file, except:
* I'll stick with examples package (it's arched, -doc will be noarch again
hopefully in next releases)
* checks do not work on Koji due to heavy OpenCL usage by ASL. Maybe I find a
way using POCL later, but there are upstream bugs avoiding it right now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #18 from Christian Dersch  ---
Also builds fine for F22 and F23

F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=11751151
F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=11751147

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||projects...@smart.ms
   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #11 from Christian Dersch  ---
I don't understand the failure, package building fine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #9 from Upstream Release Monitoring 
 ---
lupinix's scratch build of libASL-0.1.6-0.2.fc21.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11237273

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #10 from Upstream Release Monitoring 
 ---
lupinix's scratch build of libASL-0.1.6-0.2.fc21.src.rpm for rawhide failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11237671

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #13 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.3.fc21.src.rpm

noarch for -doc supbackage was the reason, builds fine now :) 

Koji builds:
Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238219
F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238239
F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238232
F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=11238228

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #8 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.6-0.2.fc21.src.rpm

Koji Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=11237273

Thank you very much for your comments Christopher! Should be fixed now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #12 from Upstream Release Monitoring 
 ---
lupinix's scratch build of libASL-0.1.6-0.3.fc21.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11238219

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #4 from Michael Schwendt (Fedora Packager Sponsors Group) 
bugs.mich...@gmx.net ---
Just a drive-by comment:


 %packagedevel
 Requires: cmake

Clearly overhead for a -devel package that also provides a pkg-config file.

If you only want cmake for directory ownership, it is permissible to include
also %{_libdir}/cmake in your package:

 
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function


 Requires:   pkgconfig

Nowadays there's an automatic dependency on /usr/bin/pkgconfig and automatic
dependencies for .pc file inter-dependencies, too. Even on RHEL6.


 %{_libdir}/cmake/%{upstream}/*.cmake

Directory %{_libdir}/cmake/%{upstream} is not included in the package.


 %exclude %{_pkgdocdir}/html

%exclude without a corresponding include of the same path name is dangerous.
%exclude hides the file(s) from all %files sections and can lead to missing
files in the built packages. Your spec file is not clear with regard to
movement/removal of some doc files, such as %{_docdir}/%{upstream}/html, and
how %_pkgdocdir/html fits into that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #2 from Christian Dersch lupi...@mailbox.org ---
Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec
SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.4-0.1.fc22.src.rpm

Package will be named libASL to be conform with Naming Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797

Christian Dersch lupi...@mailbox.org changed:

   What|Removed |Added

Summary|Review Request: ASL -   |Review Request: libASL -
   |Advanced Simulation Library |Advanced Simulation Library



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244797] Review Request: libASL - Advanced Simulation Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244797



--- Comment #3 from Christian Dersch lupi...@mailbox.org ---
OK, there are more conflicts to be resolved... I have to contact upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review